From patchwork Tue May 30 10:26:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Karlman X-Patchwork-Id: 1787389 X-Patchwork-Delegate: ykai007@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.a=rsa-sha256 header.s=s1 header.b=hRx8orCU; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QVpV05dDHz20Q4 for ; Tue, 30 May 2023 20:26:48 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4482284711; Tue, 30 May 2023 12:26:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.b="hRx8orCU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B44A28215F; Tue, 30 May 2023 12:26:27 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2 Received: from s.wrqvtzvf.outbound-mail.sendgrid.net (s.wrqvtzvf.outbound-mail.sendgrid.net [149.72.126.143]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 50A41857BF for ; Tue, 30 May 2023 12:26:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bounces+31435339-7456-u-boot=lists.denx.de@em2124.kwiboo.se DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:from:subject:to; s=s1; bh=29UJgZ+/vwfnwUD2hkgLKq+vih3JX97IWTuT4GOqUvU=; b=hRx8orCUPiLLm6YAVRbW0evWE7Wi0+R+Y19+jZeCGjO3XJ2CZN6yWXiv61mGYhQgtYnv yG8nEwI4kckqCZufFD1RDBQrVcxzPeMjvW17sSdl/jtv71YxjILsWagigTxMo+NsBRlucz UMEZ/LKDh/LXOFLN6jax+7WIxDG75zmVgiMS8KI1XJ81R855vBNBmACL+ge+mUgNIwpMrt ofwTxTQSYQT7L6C459tNlJ7EyyuDoGBcwQ6lmRl9xGSz+ZVca7dPHwOH9UN2r4+UHfKnnd omd2T6DDetGCuISDGsHm+hvJbB6rnHixBewDAS4J5UXAvvPtNt/lVxQ3mqTdcaXg== Received: by filterdrecv-77869f68cc-s89tm with SMTP id filterdrecv-77869f68cc-s89tm-1-6475CF4D-15 2023-05-30 10:26:21.529753656 +0000 UTC m=+1680611.646362940 Received: from bionic.localdomain (unknown) by geopod-ismtpd-4 (SG) with ESMTP id SgHI7zozS8KTBopS0yckBQ Tue, 30 May 2023 10:26:21.333 +0000 (UTC) From: Jonas Karlman Subject: [PATCH 1/5] Revert "arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb" Date: Tue, 30 May 2023 10:26:21 +0000 (UTC) Message-Id: <20230530102617.3413183-2-jonas@kwiboo.se> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230530102617.3413183-1-jonas@kwiboo.se> References: <20230530102617.3413183-1-jonas@kwiboo.se> MIME-Version: 1.0 X-SG-EID: TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxAfZekEeQsTe+RrMu3cja6a0h3rFkaJ8C/Ja/AltQJhd7wuS14nfc6UTj/JUzhnQZlqQ88SIbhW6XDPeG6jQOQnGinUSc66SydQcMGpRkuqJo8A5XDTVIPomOWyQhEP7qUo75U/4bh6wyC9oZbNsKW2f/I6cGM9Y7uprgLNdG6xuwcITSabbVi7MAFjqATGFHvqa To: Kever Yang , Simon Glass , Philipp Tomsich , Marek Vasut , Akash Gajjar Cc: Jonas Karlman , Jagan Teki , FUKAUMI Naoki , u-boot@lists.denx.de X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Remove regulator-boot-on prop from regulators now that the phy core has support for phy-supply after commit c57e0dcd9384 "phy: add support for phy-supply". This reverts commit 7911f409ff20dce5995cc1b703a6e30c94022f6b. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ---- arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 -------- 2 files changed, 12 deletions(-) diff --git a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi index f91740c1c0c8..57b77151c57c 100644 --- a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi +++ b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi @@ -77,7 +77,3 @@ bootph-all; status = "okay"; }; - -&vcc5v0_usb30 { - regulator-boot-on; -}; diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi index bbf54f888fa0..ecbbdeee32f8 100644 --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi @@ -110,11 +110,3 @@ bootph-all; status = "okay"; }; - -&vcc5v0_usb_host { - regulator-boot-on; -}; - -&vcc5v0_usb_hub { - regulator-boot-on; -}; From patchwork Tue May 30 10:26:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Karlman X-Patchwork-Id: 1787390 X-Patchwork-Delegate: ykai007@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.a=rsa-sha256 header.s=s1 header.b=l5UxKLna; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QVpVN2Pttz20Q4 for ; Tue, 30 May 2023 20:27:08 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1FC2F85E7B; Tue, 30 May 2023 12:26:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.b="l5UxKLna"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1DE4284711; Tue, 30 May 2023 12:26:28 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2 Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2C7E385EEB for ; Tue, 30 May 2023 12:26:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bounces+31435339-7456-u-boot=lists.denx.de@em2124.kwiboo.se DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:from:subject:to; s=s1; bh=PBTc9yNMJLYXWSnDsfpujx4B/+QfVT+KnuWdpwKVu70=; b=l5UxKLnaO9Yvl7T7n9g8Lmh97p8yWpVR4fND/ynSZV4+IC1aRawhpCLTDHv496U88poB kXKjEuebkI14zNlpe7GgxBWX+XKGYLlnYWP+uIxRh+W6OoHQylcLy3rPoT0X9myAwbZDfR abKHJl8R+b1YQwoYKlH1Q8N6ZrIzxJx1vVNFRm6niKReiTnGRtsdrNYjGiEpb9z6DjKxCP IxrSkRXjdLg4dEBJU4Zj12MObFbDz4YzI/kEYxxVaqK3gJlYqnK8EuDjZ/XsMyxT6mWq29 jSyql3nQAQvkVm4ejTO6eXYrAQF8LQT4SGTwJ49F42x65n/bHz1vh9lqZHvpeNRg== Received: by filterdrecv-66949dbc98-s5rnx with SMTP id filterdrecv-66949dbc98-s5rnx-1-6475CF4E-15 2023-05-30 10:26:22.50800113 +0000 UTC m=+1680405.585398628 Received: from bionic.localdomain (unknown) by geopod-ismtpd-4 (SG) with ESMTP id SCfnttrCQuOI6YnElj1Xvg Tue, 30 May 2023 10:26:22.265 +0000 (UTC) From: Jonas Karlman Subject: [PATCH 2/5] usb: dwc3-generic: Return early when there is no child node Date: Tue, 30 May 2023 10:26:22 +0000 (UTC) Message-Id: <20230530102617.3413183-3-jonas@kwiboo.se> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230530102617.3413183-1-jonas@kwiboo.se> References: <20230530102617.3413183-1-jonas@kwiboo.se> MIME-Version: 1.0 X-SG-EID: TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxAfZekEeQsTe+RrMu3cja6a0h8bOpAsVVh+WCbBXcT4KNviFZ7Tm3UB84/erFLbXF0QJAVYaQd+l38SEVxGW5VRHKyJnMUQcyHMRt4QsT3H8Ju38usSA18Q7/kd19+SOiJgqZM60ONRLOBbfqoqT+T9XcD07CHFLaq7RSri42EsG6MaGYTeZc+Ocq3FDcU/ub3nS To: Kever Yang , Simon Glass , Philipp Tomsich , Marek Vasut Cc: Jonas Karlman , Akash Gajjar , Jagan Teki , FUKAUMI Naoki , u-boot@lists.denx.de X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The call to device_find_first_child always return 0, change to return early when there is no child node. Signed-off-by: Jonas Karlman --- drivers/usb/dwc3/dwc3-generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 66da5a8d6f8c..c28ad47bddd8 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -558,9 +558,9 @@ int dwc3_glue_probe(struct udevice *dev) return ret; } - ret = device_find_first_child(dev, &child); - if (ret) - return ret; + device_find_first_child(dev, &child); + if (!child) + return 0; if (glue->clks.count == 0) { ret = dwc3_glue_clk_init(child, glue); From patchwork Tue May 30 10:26:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Karlman X-Patchwork-Id: 1787391 X-Patchwork-Delegate: ykai007@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.a=rsa-sha256 header.s=s1 header.b=EN0zFHn9; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QVpVZ2QL7z20Q4 for ; Tue, 30 May 2023 20:27:18 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B22A85F01; Tue, 30 May 2023 12:26:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.b="EN0zFHn9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 732888215F; Tue, 30 May 2023 12:26:30 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2 Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 43B5C85F22 for ; Tue, 30 May 2023 12:26:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bounces+31435339-7456-u-boot=lists.denx.de@em2124.kwiboo.se DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:from:subject:to; s=s1; bh=yMz3bduzWZb13QF3zmEeYawnGwkyzbs5S0iQXKHe5t4=; b=EN0zFHn9k31u9KYm7MJJ32yzmRioBGTKPdeo22w9UHf9xImwSjtZbl39SUDTdOuBWHr2 SFSw6tKSIMXXMxWg59QAjMX6hvkvf6gvwlozXwVlMX160T+K+JQCzV37V3/nryS26nXyMH 6Sxtn8guz6EqjMozZ7+lPFNMn4RkMc/2w3CK6vg9LZJND+CRRUet0BCpOYdnD0dJ+UVc6A 41DtL8RLcHQjSQJOO60ZSjyR62ZcYI7FrULVW4DRLtcGqGY27Yz7Bn/2ar0jdLe4Y2YdWu MsIiR1YvYR0gs3rEbQuadsymnM1cbebVKrb9DHA/YAc5M85RkojxYopPkTbfZqNQ== Received: by filterdrecv-d7bbbc8bf-zf9x9 with SMTP id filterdrecv-d7bbbc8bf-zf9x9-1-6475CF4F-17 2023-05-30 10:26:23.614353893 +0000 UTC m=+1680391.412183606 Received: from bionic.localdomain (unknown) by geopod-ismtpd-4 (SG) with ESMTP id -9zDdwXmTcyQ6l65vAHNfQ Tue, 30 May 2023 10:26:23.376 +0000 (UTC) From: Jonas Karlman Subject: [PATCH 3/5] usb: dwc3-generic: Relax unsupported dr_mode check Date: Tue, 30 May 2023 10:26:23 +0000 (UTC) Message-Id: <20230530102617.3413183-4-jonas@kwiboo.se> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230530102617.3413183-1-jonas@kwiboo.se> References: <20230530102617.3413183-1-jonas@kwiboo.se> MIME-Version: 1.0 X-SG-EID: TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxAfZekEeQsTe+RrMu3cja6a0h6t/GTn5umONNXK7boNtGkQMWS4GB4N33Nz6oCTbOg9D+1WaEFoOj8QNWGAxWiBurlD31IMb0WtyPw4nhs73lOXfvJJL3bQCPRJFcGpn2KWih5jDZYGzXy2o6dNN0XXxQtrxhpZrMDXtRxkPfo8OOlwnschgxh9tSA4Py7Cd51i+ To: Kever Yang , Simon Glass , Philipp Tomsich , Marek Vasut Cc: Jonas Karlman , Akash Gajjar , Jagan Teki , FUKAUMI Naoki , u-boot@lists.denx.de X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean When dr_mode is peripheral or otg and U-Boot has not been built with DM_USB_GADGET support, booting such device may end up with: dwc3_glue_bind_common: subnode name: usb@fcc00000 Error binding driver 'dwc3-generic-wrapper': -6 Some drivers failed to bind initcall sequence 00000000effbca08 failed at call 0000000000a217c8 (err=-6) ### ERROR ### Please RESET the board ### Instead fail gracfully with ENODEV to allow board continue booting. dwc3_glue_bind_common: subnode name: usb@fcc00000 dwc3_glue_bind_common: unsupported dr_mode Signed-off-by: Jonas Karlman --- drivers/usb/dwc3/dwc3-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index c28ad47bddd8..f7859a530280 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -422,13 +422,13 @@ static int dwc3_glue_bind_common(struct udevice *parent, ofnode node) dr_mode = usb_get_dr_mode(node); switch (dr_mode) { +#if CONFIG_IS_ENABLED(DM_USB_GADGET) case USB_DR_MODE_PERIPHERAL: case USB_DR_MODE_OTG: -#if CONFIG_IS_ENABLED(DM_USB_GADGET) debug("%s: dr_mode: OTG or Peripheral\n", __func__); driver = "dwc3-generic-peripheral"; -#endif break; +#endif #if defined(CONFIG_SPL_USB_HOST) || !defined(CONFIG_SPL_BUILD) case USB_DR_MODE_HOST: debug("%s: dr_mode: HOST\n", __func__); From patchwork Tue May 30 10:26:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Karlman X-Patchwork-Id: 1787392 X-Patchwork-Delegate: ykai007@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.a=rsa-sha256 header.s=s1 header.b=a4dhg9EI; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QVpVq074Zz20Q4 for ; Tue, 30 May 2023 20:27:31 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 35C2185F0D; Tue, 30 May 2023 12:26:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.b="a4dhg9EI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F7D88215F; Tue, 30 May 2023 12:26:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2 Received: from s.wrqvwxzv.outbound-mail.sendgrid.net (s.wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3A31485F01 for ; Tue, 30 May 2023 12:26:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bounces+31435339-7456-u-boot=lists.denx.de@em2124.kwiboo.se DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:from:subject:to; s=s1; bh=00fL9VJfaE7UNgY/1AeW2ZBdZxX3V+1rVfNRRtpNLZg=; b=a4dhg9EIhd8YiNSbhsRi512QUpOqMVCv2A7iQNAy7mWhdx2GvYy0v/BpulV+Bwqj3FKI 7PKHD6UUnnCPETbSxCJzyHCpsSbGjRLCN6LQXv/9OhVzp9bT5Gj/H9xY3Rah5oNAxhK6+j jMyQTLU6PUOXuRecCDOaRmu58wcOWyac8PyfCF6CFw0ouAuQ3ntPhxgYgu1R5uu5QAvMR8 kG6xZQ7hWB5NanbXExxr44OAVmGScmwNX+M+tLr7AYSeJ8ikYErAz/sR6ydRt4wNF9IAyR kdoyPHq5QnbL1141xPruwTyD3is8FrvRxEeHwNKxW8WbjoiMPOJXnuVQ6J0o1i6A== Received: by filterdrecv-65f68489c8-rwlcm with SMTP id filterdrecv-65f68489c8-rwlcm-1-6475CF50-19 2023-05-30 10:26:24.568523678 +0000 UTC m=+1680626.327296811 Received: from bionic.localdomain (unknown) by geopod-ismtpd-4 (SG) with ESMTP id 2l_XLuUPRJWmLjLGTId3jw Tue, 30 May 2023 10:26:24.307 +0000 (UTC) From: Jonas Karlman Subject: [PATCH 4/5] usb: dwc3-generic: Add rk3568 support Date: Tue, 30 May 2023 10:26:24 +0000 (UTC) Message-Id: <20230530102617.3413183-5-jonas@kwiboo.se> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230530102617.3413183-1-jonas@kwiboo.se> References: <20230530102617.3413183-1-jonas@kwiboo.se> MIME-Version: 1.0 X-SG-EID: TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxAfZekEeQsTe+RrMu3cja6a0h4kUIHw8AVVpQn6uciC2TnX8W7USSBq2+Cb1zq7dZHniAkbzfOlVHoZjQiFR7CsiBmyn20YrZ0JxEqnqIch7sMnzahoOiiZ3FObF5utwseRYNVUEoYJ4d5VB/9XExOHpEiRME41r9fSdT1IYvTs0E+UUxhGeLIMLGUjoZGGrfTgT To: Kever Yang , Simon Glass , Philipp Tomsich , Marek Vasut Cc: Jonas Karlman , Akash Gajjar , Jagan Teki , FUKAUMI Naoki , u-boot@lists.denx.de X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean RK3568 share glue and ctrl in a single node. Use glue_get_ctrl_dev to return the the glue node as the ctrl node. Signed-off-by: Jonas Karlman Reviewed-by: Jagan Teki --- drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index f7859a530280..0d30657da319 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -406,6 +406,22 @@ struct dwc3_glue_ops ti_ops = { .glue_configure = dwc3_ti_glue_configure, }; +static int dwc3_rk_glue_get_ctrl_dev(struct udevice *dev, ofnode *node) +{ + if (!device_is_compatible(dev, "snps,dwc3")) + return -EINVAL; + + *node = dev_ofnode(dev); + if (!ofnode_valid(*node)) + return -EINVAL; + + return 0; +} + +struct dwc3_glue_ops rk_ops = { + .glue_get_ctrl_dev = dwc3_rk_glue_get_ctrl_dev, +}; + static int dwc3_glue_bind_common(struct udevice *parent, ofnode node) { const char *name = ofnode_get_name(node); @@ -607,6 +623,7 @@ static const struct udevice_id dwc3_glue_ids[] = { { .compatible = "ti,am654-dwc3" }, { .compatible = "rockchip,rk3328-dwc3" }, { .compatible = "rockchip,rk3399-dwc3" }, + { .compatible = "rockchip,rk3568-dwc3", .data = (ulong)&rk_ops }, { .compatible = "qcom,dwc3" }, { .compatible = "fsl,imx8mp-dwc3", .data = (ulong)&imx8mp_ops }, { .compatible = "fsl,imx8mq-dwc3" }, From patchwork Tue May 30 10:26:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Karlman X-Patchwork-Id: 1787393 X-Patchwork-Delegate: ykai007@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.a=rsa-sha256 header.s=s1 header.b=rTzGQqDs; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QVpW42nJ5z20Q4 for ; Tue, 30 May 2023 20:27:44 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 35B5E85F74; Tue, 30 May 2023 12:26:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.b="rTzGQqDs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C6E0384711; Tue, 30 May 2023 12:26:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2 Received: from s.wrqvwxzv.outbound-mail.sendgrid.net (s.wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E6CD85F4F for ; Tue, 30 May 2023 12:26:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bounces+31435339-7456-u-boot=lists.denx.de@em2124.kwiboo.se DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:from:subject:to; s=s1; bh=acZYX0iPZ0/1y+XvHliggvus1YtiF+ksVK/L9MHoKtc=; b=rTzGQqDssdmv5R88i/OBrpg4jpaRgabHB3ArH5MBHSoLOJKT+T/AfjO4+kC36s2WfNoC foeLmchC691InK5SEelj5iLLDf5wIXEX4fekusDxoZ6POp6/3tHrCq7RhLAfwsBpEHp9wv c2kdkD1ZYaWKFo2hOolL+QvnHswX+GA2/2g1i1Mjv/9x5guQJ1xKxOYFRG4ciL00w/rTQj 8A2UrwFHIRUse+ZxWDc6JGWm5wKwvE2zkGvezC7mWv6GdTx+QfABXW0ZtEe7UIdWpEZFjQ GcUzZVOZ076J8tRjQ5Q8IJ6Nv4QCLFoZtB6toyte3BX4U1wXCPVui3ncz3ilRqmg== Received: by filterdrecv-d7bbbc8bf-nxr9l with SMTP id filterdrecv-d7bbbc8bf-nxr9l-1-6475CF51-18 2023-05-30 10:26:25.652189346 +0000 UTC m=+1680407.737922766 Received: from bionic.localdomain (unknown) by geopod-ismtpd-4 (SG) with ESMTP id wTlAtHMfR7eb8RsEaAptlA Tue, 30 May 2023 10:26:25.377 +0000 (UTC) From: Jonas Karlman Subject: [PATCH 5/5] rockchip: rk3568: Use dwc3-generic driver Date: Tue, 30 May 2023 10:26:25 +0000 (UTC) Message-Id: <20230530102617.3413183-6-jonas@kwiboo.se> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230530102617.3413183-1-jonas@kwiboo.se> References: <20230530102617.3413183-1-jonas@kwiboo.se> MIME-Version: 1.0 X-SG-EID: TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxAfZekEeQsTe+RrMu3cja6a0h/X8XLhoEwWzMtMEV0xO9DO7dC3ydXlW0vXpiZam8dMu67B6ZTJbTWYjGMM19oyKUTBITmU/c3u7LWHbexUdVAPpQBJFnbG0P4KhiRKvbtkZdQwSdjVagjjR5SF8QIj1O+Z2T52I5nZG1rZ7NSmxg0h1tLk1l2JSEPwlSfExI/Pg To: Kever Yang , Simon Glass , Philipp Tomsich , Marek Vasut , Jagan Teki , Akash Gajjar Cc: Jonas Karlman , FUKAUMI Naoki , u-boot@lists.denx.de X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Change RK3568 devices to use the newer dwc3-generic driver instead of the old xhci-dwc3 driver for USB 3.0 support. Signed-off-by: Jonas Karlman --- configs/radxa-cm3-io-rk3566_defconfig | 2 +- configs/rock-3a-rk3568_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/radxa-cm3-io-rk3566_defconfig b/configs/radxa-cm3-io-rk3566_defconfig index 56802d85cc25..e1b3602d24db 100644 --- a/configs/radxa-cm3-io-rk3566_defconfig +++ b/configs/radxa-cm3-io-rk3566_defconfig @@ -74,8 +74,8 @@ CONFIG_SYS_NS16550_MEM32=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y -CONFIG_USB_XHCI_DWC3=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_GENERIC=y CONFIG_USB_DWC3=y +CONFIG_USB_DWC3_GENERIC=y CONFIG_ERRNO_STR=y diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig index 616499f2f82b..ea72a8c9f6b3 100644 --- a/configs/rock-3a-rk3568_defconfig +++ b/configs/rock-3a-rk3568_defconfig @@ -84,10 +84,10 @@ CONFIG_ROCKCHIP_SFC=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y -CONFIG_USB_XHCI_DWC3=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_GENERIC=y CONFIG_USB_OHCI_HCD=y CONFIG_USB_OHCI_GENERIC=y CONFIG_USB_DWC3=y +CONFIG_USB_DWC3_GENERIC=y CONFIG_ERRNO_STR=y