From patchwork Fri Apr 28 19:52:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1775156 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=JP7U1D9Y; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q7NZG60Ynz23tZ for ; Sat, 29 Apr 2023 05:53:10 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 883B385DA9; Fri, 28 Apr 2023 21:53:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JP7U1D9Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5762885DA9; Fri, 28 Apr 2023 21:53:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 96A3685CBD for ; Fri, 28 Apr 2023 21:53:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1877eda6a1eso59003fac.1 for ; Fri, 28 Apr 2023 12:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682711580; x=1685303580; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7IAa4i2jMGn/1z+LxegCE6fjvEWexV2jNecFb3z+yxE=; b=JP7U1D9YGDD6L7fCSPVzsKgkfBnQjGV/mk/8687JYzsTZ+cZX/MZQr5zi0ZA1tHL7e 0PMzBJZWZFM/s+7eNJoLUKCpQmG/B4uPYuZt4N3oFIC4pShs3jKVxrkH2yeSs4lqZkNx 0TgppLoQeal23zr8E3RwJ9E/lDujpdMOzuekYcGIMDnzciBtK12/l+E5kNtyZrmuLdfm t7wFzi2AuybYsP8FYcg4IzIB9M9rm6ucxA5u2eAqo35tboaSWTAFLcwZTmG6Vfg7fqLv OugN9GLEaY0gTB10WIA5Nic2qd7exWP15pFmVvmAKoNh0ZemzKM0ulvsZm7zJOXW53O/ DXNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682711580; x=1685303580; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7IAa4i2jMGn/1z+LxegCE6fjvEWexV2jNecFb3z+yxE=; b=E3fXnpmJQ1je8KkvlHjcHbz1blmRieEp2dFRmRQlnEpq1bHLs87SqRFWbmySESv7xk hbKTOB2yqJs+yrXYL2+sPo/fSS01qx2wQTwhdtO7xLJHhH8RASsHQe+/YfHxKmRqEDTF VOP5u61437AlO6yif9SDB/wcZG+098IOn4pgcP5ZiXbCqv82wefYcqNCfQ2HeEGZNx9D CPWxTWRSD6NlyS7Czdnf/5FrjB0eL+ioVrOqJxJ6DEFWPqPiu4ZCcBkT69k8Qr/a29LF l+WZcXMm8JTHlV2iriyPoLKDu/TnyUfAqycnsMJwOpK9XS5GUTaPLYfJGEmg4gSv402/ wSvA== X-Gm-Message-State: AC+VfDwD7CG+mrAumS/3tLTz5keO7XVEevLZYC35tlTDXOUfUwqUY9vw wWo67Q1v91CbZmt5lbAlHok= X-Google-Smtp-Source: ACHHUZ6NNHca9++QurjGjOHFRbYmWzOqLcyzhaUfswwxYPXTEHgbga75ECqXsp+T4rmYyK6IvawYWA== X-Received: by 2002:a05:6870:15d6:b0:18e:99cf:6f7 with SMTP id k22-20020a05687015d600b0018e99cf06f7mr3718535oad.4.1682711580161; Fri, 28 Apr 2023 12:53:00 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b69:9ab1:eb3:146:2afe]) by smtp.gmail.com with ESMTPSA id n35-20020a056870822300b0018e96ef6e93sm5917587oae.54.2023.04.28.12.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 12:52:59 -0700 (PDT) From: Fabio Estevam To: h80.chung@samsung.com Cc: u-boot@lists.denx.de, tharvey@gateworks.com, aford173@gmail.com, marex@denx.de, ye.li@nxp.com, peng.fan@nxp.com, Fabio Estevam Subject: [RFC] power: imx8m-power-domain: Add delay to align with kernel driver Date: Fri, 28 Apr 2023 16:52:49 -0300 Message-Id: <20230428195249.756879-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Fabio Estevam In the imx8m power domain kernel driver, there is an extra udelay(5) prior to requesting the domain to power up: https://github.com/torvalds/linux/blob/v6.3/drivers/soc/imx/gpcv2.c#L347-L375 Haven't observed any issues due to the lack of this delay in U-Boot, but better to align it with the driver implementation. Signed-off-by: Fabio Estevam Reviewed-by: Marek Vasut --- Marking it as RFC for now, to try to get some feedback first. Thanks drivers/power/domain/imx8m-power-domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/domain/imx8m-power-domain.c b/drivers/power/domain/imx8m-power-domain.c index 145f6ec0cd32..df5d7d695621 100644 --- a/drivers/power/domain/imx8m-power-domain.c +++ b/drivers/power/domain/imx8m-power-domain.c @@ -338,6 +338,9 @@ static int imx8m_power_domain_on(struct power_domain *power_domain) } } + /* delay for reset to propagate */ + udelay(5); + if (domain->bits.pxx) { /* request the domain to power up */ setbits_le32(base + regs->pup, domain->bits.pxx);