From patchwork Thu Apr 27 13:30:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1774457 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=VZ/GVXhb; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q6c7Y2HTfz23tf for ; Thu, 27 Apr 2023 23:30:49 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E36DF3858C30 for ; Thu, 27 Apr 2023 13:30:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E36DF3858C30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1682602244; bh=GAJkTH4j4WV3vdWXIBYi6Sh0O9unsZ+Q79D3WwtrrkI=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=VZ/GVXhbDWLrOLjPDsRRdPWN9L8W0EX5Xh+4SlNSPVHQRDMH4y/ZHXacvtmgOD/Nm BQ2+s83p2WiubSXlCo6ViuAjNQgiAbKOOEecR0qCeueACl96hj9u04InMiUe+yKycW T/bcDeP3dsT10YR6jeqqwZde1Ct5s1FqJqYNITDU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5361D3858D33 for ; Thu, 27 Apr 2023 13:30:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5361D3858D33 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-197-sDuNbw7vOICWJALtT9swwQ-1; Thu, 27 Apr 2023 09:30:22 -0400 X-MC-Unique: sDuNbw7vOICWJALtT9swwQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C2ED32817230 for ; Thu, 27 Apr 2023 13:30:21 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86DE5492B03; Thu, 27 Apr 2023 13:30:21 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 33RDUIxf2760027 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Apr 2023 15:30:19 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 33RDUIS52760026; Thu, 27 Apr 2023 15:30:18 +0200 Date: Thu, 27 Apr 2023 15:30:17 +0200 To: Aldy Hernandez Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] gimple-range-op: Handle sqrt (basic bounds only) Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi! The following patch adds sqrt support (but similarly to sincos, only dumb basic ranges only). Ok for trunk if it passes bootstrap/regtest? Will improve this incrementally and sin/cos as well. 2023-04-27 Jakub Jelinek * gimple-range-op.cc (class cfn_sqrt): New type. (op_cfn_sqrt): New variable. (gimple_range_op_handler::maybe_builtin_call): Handle CASE_CFN_SQRT{,_FN}. * gcc.dg/tree-ssa/range-sqrt.c: New test. Jakub --- gcc/gimple-range-op.cc.jj 2023-04-27 11:57:09.865879982 +0200 +++ gcc/gimple-range-op.cc 2023-04-27 15:15:05.089787859 +0200 @@ -400,6 +400,83 @@ public: } } op_cfn_copysign; +class cfn_sqrt : public range_operator_float +{ +public: + using range_operator_float::fold_range; + using range_operator_float::op1_range; + virtual bool fold_range (frange &r, tree type, + const frange &lh, const frange &, + relation_trio) const final override + { + if (lh.undefined_p ()) + return false; + if (lh.known_isnan () || real_less (&lh.upper_bound (), &dconstm0)) + { + r.set_nan (type); + return true; + } + unsigned bulps + = targetm.libm_function_max_error (CFN_SQRT, TYPE_MODE (type), true); + if (bulps == ~0U) + r.set_varying (type); + else if (bulps == 0) + r.set (type, dconstm0, dconstinf); + else + { + REAL_VALUE_TYPE boundmin = dconstm0; + while (bulps--) + frange_nextafter (TYPE_MODE (type), boundmin, dconstninf); + r.set (type, boundmin, dconstinf); + } + if (!lh.maybe_isnan () && !real_less (&lh.lower_bound (), &dconst0)) + r.clear_nan (); + return true; + } + virtual bool op1_range (frange &r, tree type, + const frange &lhs, const frange &, + relation_trio) const final override + { + if (lhs.undefined_p ()) + return false; + + // A known NAN means the input is [-INF,-0.) U +-NAN. + if (lhs.known_isnan ()) + { + known_nan: + REAL_VALUE_TYPE ub = dconstm0; + frange_nextafter (TYPE_MODE (type), ub, dconstninf); + r.set (type, dconstninf, ub); + // No r.flush_denormals_to_zero (); here - it is a reverse op. + return true; + } + + // Results outside of [-0.0, +Inf] are impossible. + const REAL_VALUE_TYPE &ub = lhs.upper_bound (); + if (real_less (&ub, &dconstm0)) + { + if (!lhs.maybe_isnan ()) + r.set_undefined (); + else + // If lhs could be NAN and finite result is impossible, + // the range is like lhs.known_isnan () above. + goto known_nan; + return true; + } + + if (!lhs.maybe_isnan ()) + { + // If NAN is not valid result, the input cannot include either + // a NAN nor values smaller than -0. + r.set (type, dconstm0, dconstinf, nan_state (false, false)); + return true; + } + + r.set_varying (type); + return true; + } +} op_cfn_sqrt; + class cfn_sincos : public range_operator_float { public: @@ -961,6 +1038,13 @@ gimple_range_op_handler::maybe_builtin_c m_valid = true; break; + CASE_CFN_SQRT: + CASE_CFN_SQRT_FN: + m_op1 = gimple_call_arg (call, 0); + m_float = &op_cfn_sqrt; + m_valid = true; + break; + CASE_CFN_SIN: CASE_CFN_SIN_FN: m_op1 = gimple_call_arg (call, 0); --- gcc/testsuite/gcc.dg/tree-ssa/range-sqrt.c.jj 2023-04-27 15:10:09.285102144 +0200 +++ gcc/testsuite/gcc.dg/tree-ssa/range-sqrt.c 2023-04-27 15:12:01.478465821 +0200 @@ -0,0 +1,41 @@ +// { dg-do compile } +// { dg-options "-O2 -fdump-tree-evrp -fno-thread-jumps" } + +#include + +void use (double); +void link_error (); + +void +foo (double x) +{ + if (__builtin_isnan (x)) + __builtin_unreachable (); + x = sqrt (x); + if (x < -0.0) + link_error (); + use (x); +} + +void +bar (double x) +{ + if (!__builtin_isnan (sqrt (x))) + { + if (__builtin_isnan (x)) + link_error (); + if (x < -0.0) + link_error (); + } +} + +void +stool (double x) +{ + double res1 = sqrt (x); + double res2 = __builtin_sqrt (x); + if (res1 < -0.0 || res2 < -0.0) + link_error (); +} + +// { dg-final { scan-tree-dump-not "link_error" "evrp" { target { { *-*-linux* } && { glibc } } } } }