From patchwork Wed Mar 21 15:25:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 888918 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="ADcZ1XVc"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 405v8c2SlKz9s0n for ; Thu, 22 Mar 2018 02:38:24 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 4463EE36; Wed, 21 Mar 2018 15:25:23 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 5B0E7E31 for ; Wed, 21 Mar 2018 15:25:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 910C95DE for ; Wed, 21 Mar 2018 15:25:21 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180321152518euoutp02517a06003887b81c295adfccd5447e5b~d_Oax-Tgh1202712027euoutp02K; Wed, 21 Mar 2018 15:25:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180321152518euoutp02517a06003887b81c295adfccd5447e5b~d_Oax-Tgh1202712027euoutp02K DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1521645918; bh=xrGw73mwfFsKyEvfo8//rrz0P0EFYC5B5SQUWizmLPo=; h=From:To:Cc:Subject:Date:References:From; b=ADcZ1XVcgtfxVhZmB77THSKRkzyThz9LEUVLFXzBtBGVaMdb8EPgVHWSbB6GS/TtT kt/X0v/F4wuZg2WPBqS5zEsG7SGZfphZ2Jq1wKZJO08AKgtZzebSqu14zJSgOxffhg fuTZrfj5tHuc1gFB/S95YDxvbFCHIRGQMrzQhaHE= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180321152517eucas1p23df2c85ec5f2170e18c447672c052714~d_OZpfbst1254312543eucas1p2H; Wed, 21 Mar 2018 15:25:17 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 17.D2.05700.D5972BA5; Wed, 21 Mar 2018 15:25:17 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180321152516eucas1p2fa7ba6db0400c762a85f6855d870ec03~d_OY5V-o00788007880eucas1p2M; Wed, 21 Mar 2018 15:25:16 +0000 (GMT) X-AuditID: cbfec7f2-1c1ff70000011644-70-5ab2795d4582 Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 62.6B.04178.C5972BA5; Wed, 21 Mar 2018 15:25:16 +0000 (GMT) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P5Y00I6Y5I1HD40@eusync1.samsung.com>; Wed, 21 Mar 2018 15:25:16 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org, Ian Stokes Date: Wed, 21 Mar 2018 18:25:11 +0300 Message-id: <1521645911-13336-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsWy7djPc7qxlZuiDI5sFrL49eYBu8W0z7fZ La60/2S32PjwLKvF3E/PGR1YPRbvecnk8ezmf0aP9/uusnn0bVnFGMASxWWTkpqTWZZapG+X wJVxdmFWwRO+ilWfVzE1MD7n6mLk5JAQMJGYu3UWYxcjF4eQwApGie+vXjJDOJ8ZJS4c3sQC U7Vg0xKoqmWMEm8/3mAESQgJNDNJvHhlAmKzCehInFp9BCwuImAnMW1VExOIzSxQJnHz1xRW EFtYwEziwurVbCA2i4CqxP87T4AWcHDwCrhJXLkiD7FLTuLmuU6wIyQEbrJK3F+9jBEi4SIx 8/oENghbWOLV8S3sELaMRGfHQSaIhmZGiaXtm9kgnB5Gie6N25khquwlTt28CnURn8SkbdOZ QTZLCPBKdLQJQZR4SKxrvQb1saPEk00LWSGejJU4OrWLdQKj5AJGhlWM4qmlxbnpqcWGeanl esWJucWleel6yfm5mxiBEXb63/FPOxi/Xko6xCjAwajEw5uRsylKiDWxrLgy9xCjBAezkgjv ts8bo4R4UxIrq1KL8uOLSnNSiw8xSnOwKInzxmnURQkJpCeWpGanphakFsFkmTg4pRoY7e+U 9+e/qIpUfFt0Tm3q/wPtl66mSWf+qTf4FmmmyuknWcFqZP3zHXN/xbf+yqVOBxSiJZM6mMu2 8e+0kcg/X7XFe2XGDYsEzU8L0sRq4vmiwqo3b8wq6+ZdmX/kc4nHYjGhv/dZvAS39JUVrfjv zBR1YRVH5OVJifkdovdL9PW/T/uW/UOJpTgj0VCLuag4EQAvo/WVrAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHJMWRmVeSWpSXmKPExsVy+t/xy7oxlZuiDK7/07b49eYBu8W0z7fZ La60/2S32PjwLKvF3E/PGR1YPRbvecnk8ezmf0aP9/uusnn0bVnFGMASxWWTkpqTWZZapG+X wJVxdmFWwRO+ilWfVzE1MD7n6mLk5JAQMJFYsGkJYxcjF4eQwBJGiZld99hAEkICrUwSt5bk gdhsAjoSp1YfYQSxRQTsJKatamICsZkFyiTO/37HDGILC5hJXFi9GqyXRUBV4v+dJyxdjBwc vAJuEleuyEPskpO4ea6TeQIj1wJGhlWMIqmlxbnpucWGesWJucWleel6yfm5mxiBvt527Ofm HYyXNgYfYhTgYFTi4c3I2RQlxJpYVlyZe4hRgoNZSYR32+eNUUK8KYmVValF+fFFpTmpxYcY pTlYlMR5zxtURgkJpCeWpGanphakFsFkmTg4pRoYRUPXmXnXcBs/3Gd3xWtKf6PcxRMK65ev vqwx65vcgrW2KhrXVswyfO85LeD//6QZh0pXq5ua1m/6GZejzBHS76rfkLvo3c8DLw9k+ncJ Mv7hEpdgWn48RfW95Lm0Ym/d4xXhNlY/OZTS5GRy+dbnztytwsGg6XBCrK35fHzrmXquwI9B wfeVWIozEg21mIuKEwHaQNW58QEAAA== X-CMS-MailID: 20180321152516eucas1p2fa7ba6db0400c762a85f6855d870ec03 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180321152516eucas1p2fa7ba6db0400c762a85f6855d870ec03 X-RootMTR: 20180321152516eucas1p2fa7ba6db0400c762a85f6855d870ec03 References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , Heetae Ahn Subject: [ovs-dev] [PATCH] netdev-dpdk: Limit rate of DPDK logs. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org DPDK could produce huge amount of logs. For example, in case of exhausting of a mempool in vhost-user port, following message will be printed on each call to 'rte_vhost_dequeue_burst()': |ERR|VHOST_DATA: Failed to allocate memory for mbuf. These messages are increasing ovs-vswitchd.log size extremely fast making it unreadable and non-parsable by a common linux utils like grep, less etc. Moreover continuously growing log could exhaust the HDD space in a few hours breaking normal operation of the whole system. To avoid such issues, DPDK log rate limited to 600 messages per minute. This value is high, because we still want to see many big logs like vhost-user configuration sequence or debug messages, if debug enabled in DPDK. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- lib/dpdk.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/dpdk.c b/lib/dpdk.c index 3f5a55f..0a353f8 100644 --- a/lib/dpdk.c +++ b/lib/dpdk.c @@ -272,20 +272,21 @@ static ssize_t dpdk_log_write(void *c OVS_UNUSED, const char *buf, size_t size) { char *str = xmemdup0(buf, size); + static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(600, 600); switch (rte_log_cur_msg_loglevel()) { case RTE_LOG_DEBUG: - VLOG_DBG("%s", str); + VLOG_DBG_RL(&rl, "%s", str); break; case RTE_LOG_INFO: case RTE_LOG_NOTICE: - VLOG_INFO("%s", str); + VLOG_INFO_RL(&rl, "%s", str); break; case RTE_LOG_WARNING: - VLOG_WARN("%s", str); + VLOG_WARN_RL(&rl, "%s", str); break; case RTE_LOG_ERR: - VLOG_ERR("%s", str); + VLOG_ERR_RL(&rl, "%s", str); break; case RTE_LOG_CRIT: case RTE_LOG_ALERT: