From patchwork Mon Apr 10 01:13:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 1767041 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=jyCEFaSP; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PvrZm578Dz1yZP for ; Mon, 10 Apr 2023 11:13:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=CkMIYWogapPHsQnmsM1cc+2qbai80saRWNg8PDcBGlE=; b=jyCEFaSPPVqbUe 7IsJioR4F4rcAG7/kVha2ObDx8mkfwjfY8J+I9/9qLEn3rK7Blh+wsRWp2CYOnp/t9Ivxee9XyK/P dozK9ksRydcgLV0sEQT9t+JODTJzQkJWe7Vb72Epc4xbhVRC+HP3/gvb/IsMgfL50xTIDBR81mUcN QmczKIbM1xuknqq4EChnjAz/aZ9HwkTUbjvIfmItpPJx2UazNgP4FKWjMkpo96cWn0eNwhdLNlDP8 NlnRBj3gz484wlkq6FlrMy1dvqRdd0lIq1ZIcMHrr6F+smk0ehrr9p4+RiLRwf3hx9zhhHOt74GB/ xb6BHVgGI0M2UterlrIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plg64-00EPdU-1Y; Mon, 10 Apr 2023 01:13:28 +0000 Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1plg61-00EPd9-31; Mon, 10 Apr 2023 01:13:26 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Richard Weinberger , Anton Ivanov , Johannes Berg , Damien Le Moal , linux-ide@vger.kernel.org, linux-um@lists.infradead.org, Geert Uytterhoeven Subject: [PATCH v3] UML: pata_cs5536: fix build for X86_32 UML with TRACEPOINTS Date: Sun, 9 Apr 2023 18:13:25 -0700 Message-Id: <20230410011325.26850-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Current build of pata_cs5536 for i386 UML fails with: ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! Add the arch/x86/lib/msr.o binary to resolve these undefined symbols. Signed-off-by: Randy Dunlap Cc: Richard Weinberger Cc: Anton Ivanov Cc: Johannes Berg Cc: Damien Le Moal Cc: linux-ide@vger.kernel.org Cc: linux-um@lists.infradead.org Cc: Geert Uytterhoeven Reviewed-by: Damien Le Moal --- v2: change from not building on UML to fixing the build on UML v3: add Rev-by: Damien Le Moal arch/x86/um/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/arch/x86/um/Makefile b/arch/x86/um/Makefile --- a/arch/x86/um/Makefile +++ b/arch/x86/um/Makefile @@ -21,7 +21,7 @@ obj-y += checksum_32.o syscalls_32.o obj-$(CONFIG_ELF_CORE) += elfcore.o subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o -subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o +subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o ../lib/msr.o subarch-y += ../kernel/sys_ia32.o else