From patchwork Wed Mar 21 02:40:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 888516 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vgoRMd0J"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 405Yxv5Jdqz9rx7 for ; Wed, 21 Mar 2018 13:42:59 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 55FF1C21DC1; Wed, 21 Mar 2018 02:41:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B13CBC21E08; Wed, 21 Mar 2018 02:41:24 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 61266C21DD7; Wed, 21 Mar 2018 02:41:04 +0000 (UTC) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by lists.denx.de (Postfix) with ESMTPS id CCEF4C21E08 for ; Wed, 21 Mar 2018 02:41:00 +0000 (UTC) Received: by mail-pf0-f195.google.com with SMTP id d26so1460144pfn.5 for ; Tue, 20 Mar 2018 19:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=g7DDeK/2v4s5QngD29JMd/4Fzeea1Tlc9F7z/LX4v7o=; b=vgoRMd0J2N9LdSOE2HvraMalOexaiZmWgdZkeWZZSyYVoi8tfNWTH8U+hOoVz+Vy3j efi1CqrQbBqkMFtX0Lz4l/hVJjhkvg3edH6ecGDOGZSjtsisJnB7yYHTG7AVwfvfhCtc iPvFmeeOCFT/uWI+HLo5Z66mXi9dlnj3o6b/fIgRMtlKL1xBgscj9bq6W8GCXUYX955c Np2utLTTuW38cH48fNg/x8kIRNL9EO1Vpk4VGoMQhuFXiwYT/s0GtN+AkC2FAA6S1lwn yWaT7OldiIMTz3bkinwITV1XHFOgpDYytjI4npyivWf4gyFs38TO7c60yg+TaGt3OUMh zGYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g7DDeK/2v4s5QngD29JMd/4Fzeea1Tlc9F7z/LX4v7o=; b=K7RUzDIM8yhjSUPHiSpMkeQHjudW8axgLCGxcVedXwHS/g2TXW5E3obrizOdD3BmSN /R0IoVioI1SoaCNvUIZm6oD6R8W7/pp5MlUmBA5v1Mwx5rX1ozkZhztLwFnR5RRV3zlN RtqyrPiEBykKmnFrMd2Gt9GV8LoBqBC6pHsQ2sVq827hWh/8bElE0b8viqok0N/sTHcv SoTP9oTX7y0qNT+BBW9OrPd3YtxMFtwSDvp6CvGnvd507ugOtvN3a2Xgs+c/J85Ub66x bZFu9+yOoKGUHGySBoPa21QxuFJRiSidpFdGhT60qd0Wqx1GfhKcVLyJp6tsP2nyx+ll /2UA== X-Gm-Message-State: AElRT7GVZBgLKEO9W5Ib4D5M6IJ/evAP3QA9OLif34r8j9QhR5VEhvUY gIOzLWE/kuWFKgsS9ykomeRdg5G0 X-Google-Smtp-Source: AG47ELseA0B3uKuZb2GsRzcDQkyOLGROr0buPtsEKBb7tzPk38hfy/To0u/2rk92RtCRsLzseMARtQ== X-Received: by 10.99.164.74 with SMTP id c10mr10270644pgp.187.1521600059282; Tue, 20 Mar 2018 19:40:59 -0700 (PDT) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id h10sm5187829pgf.19.2018.03.20.19.40.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Mar 2018 19:40:58 -0700 (PDT) From: Chris Packham To: u-boot@lists.denx.de Date: Wed, 21 Mar 2018 15:40:33 +1300 Message-Id: <20180321024037.26393-2-judge.packham@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180321024037.26393-1-judge.packham@gmail.com> References: <20180321024037.26393-1-judge.packham@gmail.com> Cc: Marek Vasut , Chris Packham Subject: [U-Boot] [PATCH v1 1/5] rtc: ds1307: remove redundant code in rtc_reset X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As of commit 1a1fa2406689 ("rtc: Set valid date after reset") the command "date reset" will set the date/time to 2000-01-01 0:00:00 after calling rtc_reset(). This means that the ds1307 implementation of rtc_reset() doesn't need to call rtc_set(). Signed-off-by: Chris Packham Reviewed-by: Simon Glass --- drivers/rtc/ds1307.c | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/drivers/rtc/ds1307.c b/drivers/rtc/ds1307.c index 5df15c7fd6c6..5e74b93b72bc 100644 --- a/drivers/rtc/ds1307.c +++ b/drivers/rtc/ds1307.c @@ -184,25 +184,8 @@ int rtc_set (struct rtc_time *tmp) */ void rtc_reset (void) { - struct rtc_time tmp; - rtc_write (RTC_SEC_REG_ADDR, 0x00); /* clearing Clock Halt */ rtc_write (RTC_CTL_REG_ADDR, RTC_CTL_BIT_SQWE | RTC_CTL_BIT_RS1 | RTC_CTL_BIT_RS0); - - tmp.tm_year = 1970; - tmp.tm_mon = 1; - tmp.tm_mday= 1; - tmp.tm_hour = 0; - tmp.tm_min = 0; - tmp.tm_sec = 0; - - rtc_set(&tmp); - - printf ( "RTC: %4d-%02d-%02d %2d:%02d:%02d UTC\n", - tmp.tm_year, tmp.tm_mon, tmp.tm_mday, - tmp.tm_hour, tmp.tm_min, tmp.tm_sec); - - return; } @@ -321,14 +304,6 @@ read_rtc: static int ds1307_rtc_reset(struct udevice *dev) { int ret; - struct rtc_time tmp = { - .tm_year = 1970, - .tm_mon = 1, - .tm_mday = 1, - .tm_hour = 0, - .tm_min = 0, - .tm_sec = 0, - }; /* clear Clock Halt */ ret = dm_i2c_reg_write(dev, RTC_SEC_REG_ADDR, 0x00); @@ -340,14 +315,6 @@ static int ds1307_rtc_reset(struct udevice *dev) if (ret < 0) return ret; - ret = ds1307_rtc_set(dev, &tmp); - if (ret < 0) - return ret; - - debug("RTC: %4d-%02d-%02d %2d:%02d:%02d UTC\n", - tmp.tm_year, tmp.tm_mon, tmp.tm_mday, - tmp.tm_hour, tmp.tm_min, tmp.tm_sec); - return 0; } From patchwork Wed Mar 21 02:40:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 888510 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ncIklVXv"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 405Ywm2lGYz9rx7 for ; Wed, 21 Mar 2018 13:42:00 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id E20E6C21DD9; Wed, 21 Mar 2018 02:41:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id A28C4C21DEC; Wed, 21 Mar 2018 02:41:16 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 715EBC21E1B; Wed, 21 Mar 2018 02:41:09 +0000 (UTC) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by lists.denx.de (Postfix) with ESMTPS id F1F35C21E07 for ; Wed, 21 Mar 2018 02:41:05 +0000 (UTC) Received: by mail-pf0-f194.google.com with SMTP id z10so1454063pfh.13 for ; Tue, 20 Mar 2018 19:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UzSTWndZwIuVrTShMFavul07VR0/Xb2euppW+hIMUoo=; b=ncIklVXvGhAtkazd8SHQY43sXyWLkYb2aitXBdRM1lBN+MUHE2SH7JiHP4TFcPQu0K UJ0iOC0/ErWBZsKd/1OgcQW8SyKN7J44JXPVWB+15VgJxP0UP4NsR+8lryIoDSLSipjg Zomr5tnhN9NcFC7qlUaFPuCLWbfh+hHBUFDuJd1RlADGuYwcckjNKOZp1kev8C2sZnMo OwZiFSVswY1g9uVfud7wgcALjy2l/iY7I9pMmB4uqyC1hytGg8VVzxKrNqNARHfy9WyT k1/uD6/gqNlZ2LEtU5AFmqbNcayMRZ0a6W/aLHbyB5kZPnkjpsvdzNaaJAIDEqzvwLsf OcAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UzSTWndZwIuVrTShMFavul07VR0/Xb2euppW+hIMUoo=; b=Kr0ANIkLMF70Qf8B40jLJ4curb/F+PT3B0//a6E0lFPlgolofqZMieKq7ziCf4KNCC i2z2rgSIHkmF+N6RGyCXri+2+O7zB2+ntP8nTmjLPbKow8whXsmGc5pDvAzQvDGedDlH XRLmPLZj10+i7qMPuI2uL1/3vrTeKoAlGedUMZ9HIOXZyH8cz+/AnXWkqF6VEGw9Moat wkFWhBOH6rCZddt++mbYCkKsoC7pI+PziAHC28rdWxO0SWbjmFUf1KHguiNj8tUT/ng5 yHCzgsj6spL7YXZABRbkBRnbJ9qsisU2R3DAxmqKioZyDe8U1v3o3NbCcK9mdbKdKzNd xicQ== X-Gm-Message-State: AElRT7H1IuD8j7IP+uMMXDysS5+vEmQlVsgqa4+wsw2Sd1ApwYomDQv7 0wq3n4cnhsgb70w29IbG/uNtGH+Q X-Google-Smtp-Source: AG47ELvm7y6SfkRYUBOP7chIeZM/0TXHOTZXExABwspq3e3UBGfyIQnJF6TgJAodR01NXhTqtC2MHg== X-Received: by 10.98.111.65 with SMTP id k62mr14200591pfc.184.1521600064335; Tue, 20 Mar 2018 19:41:04 -0700 (PDT) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id h10sm5187829pgf.19.2018.03.20.19.40.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Mar 2018 19:41:03 -0700 (PDT) From: Chris Packham To: u-boot@lists.denx.de Date: Wed, 21 Mar 2018 15:40:34 +1300 Message-Id: <20180321024037.26393-3-judge.packham@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180321024037.26393-1-judge.packham@gmail.com> References: <20180321024037.26393-1-judge.packham@gmail.com> Cc: Marek Vasut , Chris Packham Subject: [U-Boot] [PATCH v1 2/5] rtc: ds1374: remove redundant code in rtc_reset X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As of commit 1a1fa2406689 ("rtc: Set valid date after reset") the command "date reset" will set the date/time to 2000-01-01 0:00:00 after calling rtc_reset(). This means that the ds1374 implementation of rtc_reset() doesn't need to call rtc_set(). Signed-off-by: Chris Packham --- drivers/rtc/ds1374.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/rtc/ds1374.c b/drivers/rtc/ds1374.c index 78473570b9df..9e440d845766 100644 --- a/drivers/rtc/ds1374.c +++ b/drivers/rtc/ds1374.c @@ -172,8 +172,6 @@ int rtc_set (struct rtc_time *tmp){ */ void rtc_reset (void){ - struct rtc_time tmp; - /* clear status flags */ rtc_write(RTC_SR_ADDR, (RTC_SR_BIT_AF|RTC_SR_BIT_OSF), false); /* clearing OSF and AF */ @@ -189,19 +187,6 @@ void rtc_reset (void){ |RTC_CTL_BIT_BBSQW), true);/* disable WD/ALM, WDSTR set to INT-pin, set BBSQW and SQW to 32k - set to 1 */ - tmp.tm_year = 1970; - tmp.tm_mon = 1; - tmp.tm_mday= 1; - tmp.tm_hour = 0; - tmp.tm_min = 0; - tmp.tm_sec = 0; - - rtc_set(&tmp); - - printf("RTC: %4d-%02d-%02d %2d:%02d:%02d UTC\n", - tmp.tm_year, tmp.tm_mon, tmp.tm_mday, - tmp.tm_hour, tmp.tm_min, tmp.tm_sec); - rtc_write(RTC_WD_ALM_CNT_BYTE2_ADDR, 0xAC, true); rtc_write(RTC_WD_ALM_CNT_BYTE1_ADDR, 0xDE, true); rtc_write(RTC_WD_ALM_CNT_BYTE2_ADDR, 0xAD, true); From patchwork Wed Mar 21 02:40:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 888518 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jfLM+A2e"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 405Yz95n69z9rxs for ; Wed, 21 Mar 2018 13:44:05 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 864EAC21DF9; Wed, 21 Mar 2018 02:42:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B6127C21E02; Wed, 21 Mar 2018 02:42:02 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E6EB5C21DEC; Wed, 21 Mar 2018 02:41:14 +0000 (UTC) Received: from mail-pl0-f67.google.com (mail-pl0-f67.google.com [209.85.160.67]) by lists.denx.de (Postfix) with ESMTPS id 0FB3CC21DD9 for ; Wed, 21 Mar 2018 02:41:11 +0000 (UTC) Received: by mail-pl0-f67.google.com with SMTP id k22-v6so2276220pls.6 for ; Tue, 20 Mar 2018 19:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=orBxCq3FdYDqIMQj+k5acPZ4FGuJrASX6TmKR+ROxbU=; b=jfLM+A2ed5YPz+scGJT+XCLopdy/M0c5kWhuKyC/dNvA0DZIQ0P45eyMEhudG5/TAA RzgnPGc0csSdTGZznDeZAZHxlJ+CM/V5hqdyVp0j4MEfHcNIKyk88yO3xcV81pYm/5yU 6TQONc0JYnqPma41XijouWdf7+sKIrnaQF4ZCeJqJehxKe52TMiMtjnG0jrvLJ9RPe4I cBt3tXL7N2C8mz5uO76V+nSi1Z3DvtvjykODLSEK55j3g414reTy960Ox2QDiI6eq91J hyHecB0DtrpyK40Gul4j22xo1gh4ZPeA2xBbX2985gCWBbVAD4DurcsoxOE9jT7cZvZ2 YfXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=orBxCq3FdYDqIMQj+k5acPZ4FGuJrASX6TmKR+ROxbU=; b=jRmLfmPhWphVHkImQWh8oc2z1qckIgev1j7DnEFx1TF1yBOYFBgNJhz8U7dHRc8/42 bzTLhOSjOK/z4rGy+ung7ukcwmDPeGbVRl+5bu/iWFfeYlodhrbxqnkgwHbYUP7aqkUb AyDFeTYTdUqxBn0AukfSt4jb8JeZZKB3lKqE8ltNH4Vn+8JBdsvbO9YM/aoZgt2zAlnd E2IYiff/GkVt+Fudas+GMF46aMXdOs1DxA3f1Rx5UJUYX8NM5iUj7SQWoAqlYgqoOzGZ FeeOTAc8I2pzJ3XEfkZACOX0fdqJQ6gdbzBTB8qJk3GKB0putCE2yjufWAEUqK/COVcs NygA== X-Gm-Message-State: AElRT7Elq30c3NfZ029jNib2YN5Nc24XId0L52fuLiZGRhZcB4SpAERZ fq5IsI77c/IIdKty7N+35S/j8jJ4 X-Google-Smtp-Source: AG47ELvUDOvH/01rrBA4bwnFXKQDhZ7LkazPEKSi6cBLNW9/6yA72j8NYEXeIqTVb0Ay3Oq9tfkfUQ== X-Received: by 2002:a17:902:7586:: with SMTP id j6-v6mr4312105pll.352.1521600069275; Tue, 20 Mar 2018 19:41:09 -0700 (PDT) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id h10sm5187829pgf.19.2018.03.20.19.41.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Mar 2018 19:41:08 -0700 (PDT) From: Chris Packham To: u-boot@lists.denx.de Date: Wed, 21 Mar 2018 15:40:35 +1300 Message-Id: <20180321024037.26393-4-judge.packham@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180321024037.26393-1-judge.packham@gmail.com> References: <20180321024037.26393-1-judge.packham@gmail.com> Cc: Marek Vasut , Chris Packham Subject: [U-Boot] [PATCH v1 3/5] rtc: mx27rtc: remove redundant code in rtc_reset X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As of commit 1a1fa2406689 ("rtc: Set valid date after reset") the command "date reset" will set the date/time to 2000-01-01 0:00:00 after calling rtc_reset(). This means that the mx27rtc implementation of rtc_reset() can be an empty stub function. Signed-off-by: Chris Packham --- drivers/rtc/mx27rtc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/mx27rtc.c b/drivers/rtc/mx27rtc.c index 29ccdf17301b..b42770e05bd9 100644 --- a/drivers/rtc/mx27rtc.c +++ b/drivers/rtc/mx27rtc.c @@ -61,9 +61,5 @@ int rtc_set(struct rtc_time *time) void rtc_reset(void) { - struct rtc_regs *rtc_regs = (struct rtc_regs *)IMX_RTC_BASE; - - writel(0, &rtc_regs->dayr); - writel(0, &rtc_regs->hourmin); - writel(0, &rtc_regs->seconds); + /* nothing to do */ } From patchwork Wed Mar 21 02:40:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 888517 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FIN3/dYC"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 405YyQ4w1Nz9rxs for ; Wed, 21 Mar 2018 13:43:26 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 56531C21E0F; Wed, 21 Mar 2018 02:42:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2ECD8C21DB6; Wed, 21 Mar 2018 02:42:04 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 69EEAC21DD9; Wed, 21 Mar 2018 02:41:16 +0000 (UTC) Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by lists.denx.de (Postfix) with ESMTPS id B4000C21C29 for ; Wed, 21 Mar 2018 02:41:15 +0000 (UTC) Received: by mail-pf0-f196.google.com with SMTP id y186so1465520pfb.2 for ; Tue, 20 Mar 2018 19:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SCMALcfUL2nykQj1/to5hysIEMNBsDMOazDL0mSaCCs=; b=FIN3/dYCuDr43xaJBc2sT8yJOwkgw+AtcFJYhgxRRusOi9cdhXxjLLKYJP1nVhgc38 BK/0YQ+fhY4UAOAVLiod2oY1SNJErQtRQBLM3iIZ+EAmt5jnLdmvBh+a1dU2YJjiMdZx E71Ah/jy30Yd3YzAULFPLF25So7TGt1kzDmHgGU+7vzlUgCl9590+RM6LmnBy0E/VfzL WAMrFCMiDpLKWPIND983wEUZk4ZIhOgUIxQJyfJ4qsr7Sv3w+Er0RHtAREoPJXOrMO4Y 9SHC0mB1sJHLx/Os3/PcRJMoBZx5nkkZ39FL6VoKcwy2TEdBtFpWnP7157r2fSPAMHkq Kkrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SCMALcfUL2nykQj1/to5hysIEMNBsDMOazDL0mSaCCs=; b=ZybW+SGOvWI1wFmEz9nFsrhnoPEQSspvfmYfR5eIJdb3ckOfkaicM8gvH9nt/gIE1b f8YM+CD+Ef5NTJoFTS7B4LSdYnqtf0K6wbW9eCmYuDveL6YDt3mVHUFOf/7VaNeQ70DX xtxMrAVcOcSYkLRUkjJ+ulBMcOmzPqoN4d8QaqgoEOk+Q/j7uhn8IVltHlG4EaZ5mM7/ GBfoRjXh7NkjJt99tPU7HxRmPhjjxEqA6Rg2WDcsNUHowLYYlFqWi+7prbpfFb9E7wf2 QcVRYM/+pB0jhziyIKoKUyKfjb7v5R1uyNoh7rwzTt5ULnyLWgR0UmbJVEQUf7dCspsA FBSg== X-Gm-Message-State: AElRT7GRV8zgGTxVRgme8XymzXIiUqACzIZislJvDXEcUBtwZNWQGmcp g/z0t/OBJ1Syb2dN0yXoFkPH/lgd X-Google-Smtp-Source: AG47ELuRyD0woa8QRTPFVhVlVgJdrlpQ1V1Yka8gmj8Ovy77xpiy4QuIg9C31eVIamh9vDlx31UiNQ== X-Received: by 10.98.15.92 with SMTP id x89mr8977843pfi.7.1521600074126; Tue, 20 Mar 2018 19:41:14 -0700 (PDT) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id h10sm5187829pgf.19.2018.03.20.19.41.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Mar 2018 19:41:13 -0700 (PDT) From: Chris Packham To: u-boot@lists.denx.de Date: Wed, 21 Mar 2018 15:40:36 +1300 Message-Id: <20180321024037.26393-5-judge.packham@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180321024037.26393-1-judge.packham@gmail.com> References: <20180321024037.26393-1-judge.packham@gmail.com> Cc: Marek Vasut , Chris Packham Subject: [U-Boot] [PATCH v1 4/5] rtc: rs5c372: remove redundant code in rtc_reset X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As of commit 1a1fa2406689 ("rtc: Set valid date after reset") the command "date reset" will set the date/time to 2000-01-01 0:00:00 after calling rtc_reset(). This means that the rs5c372 implementation of rtc_reset() does not need to call rtc_set(). Signed-off-by: Chris Packham --- drivers/rtc/rs5c372.c | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/rtc/rs5c372.c b/drivers/rtc/rs5c372.c index 65f45ea5e3c3..c815c915d5c0 100644 --- a/drivers/rtc/rs5c372.c +++ b/drivers/rtc/rs5c372.c @@ -247,35 +247,13 @@ int rtc_set (struct rtc_time *tmp) } /* - * Reset the RTC. We set the date back to 1970-01-01. + * Reset the RTC. */ void rtc_reset (void) { - struct rtc_time tmp; - if (!setup_done) rs5c372_enable(); - - if (!setup_done) - return; - - tmp.tm_year = 1970; - tmp.tm_mon = 1; - /* Jan. 1, 1970 was a Thursday */ - tmp.tm_wday= 4; - tmp.tm_mday= 1; - tmp.tm_hour = 0; - tmp.tm_min = 0; - tmp.tm_sec = 0; - - rtc_set(&tmp); - - printf ("RTC: %4d-%02d-%02d %2d:%02d:%02d UTC\n", - tmp.tm_year, tmp.tm_mon, tmp.tm_mday, - tmp.tm_hour, tmp.tm_min, tmp.tm_sec); - - return; } #endif From patchwork Wed Mar 21 02:40:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 888513 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lTnVaBA0"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 405Yxl004cz9rxs for ; Wed, 21 Mar 2018 13:42:50 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 92067C21D56; Wed, 21 Mar 2018 02:41:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id AD998C21DF9; Wed, 21 Mar 2018 02:41:52 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6041FC21DDC; Wed, 21 Mar 2018 02:41:23 +0000 (UTC) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by lists.denx.de (Postfix) with ESMTPS id 1CA17C21D56 for ; Wed, 21 Mar 2018 02:41:20 +0000 (UTC) Received: by mail-pf0-f194.google.com with SMTP id z10so1454306pfh.13 for ; Tue, 20 Mar 2018 19:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4aXe3YgdBYmsjLCJluNkNFjbNF3QDZRglGOdmILqme4=; b=lTnVaBA0kOJSd42k79gkgKKEsJRzkkj2JCm6zNyVaSHbfix+oCbh9m4MS02L6huzCA Jl+47z69/lgAFnq/ce/UyKsZysVTDLFw8ERVb2C42zmrOsl0UKq322qvmdpqU3tv8xtf utLvrRdkeQkvpHylluPiZIrVn5fdC9kZYr0u30cHk2FpITaTS/QVVk0Z9M0Bg82gnMBe vT/ZlFpxL7W3XYJde4T9ymzqIcS1+Q8RA1L0Nzi32wAp3fzjlokZucesO6NwCQXXQ1+U PmEcTZE5xyE419GQiCZ+cT3MieB4ISGICoBCA3WlivmXvat0Wwh4dQ5PZb3Cz4PR3BTX CUmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4aXe3YgdBYmsjLCJluNkNFjbNF3QDZRglGOdmILqme4=; b=f5cOuLlFzgRatTlbuE+JoSJMQPAIn2Kf1zdpjc+EcWORppAYUvnKBrbBhSXrONas6A GV2WdSSAjQCEY93yNNMYP3wUFybvQ558WDkElzVNdBJIPChxRmURXiedlS/clUli636Z Y2VpUj5/clLMujS1rVPO7JsWaOu6VMerTflRe4/x0XeNsMVtXj3XobD7cJLjtR71ZlZ3 IXrI5Qs1jSrV1F/IwdyaXozcadLvFwOqWyY/1BDof2sVaWOALMzLfB1BuSPAa+/Q9Iln SiJI9H3/sw4zlfxChtde/nFRG0ojjRrjm0JFUKlO9F82+lFbL3U9fsjSHhqUYbK1Qzkx nhLg== X-Gm-Message-State: AElRT7Hjgg6H/6ovQjYud+qlgmz3heY+R81AF1b4L2zycmiE/+4hCg4f T020eOATOvdzQ71kksb45DbpmHmh X-Google-Smtp-Source: AG47ELuK59vT7aOfpFZskOLJ34yEzg1je2Qam/Hw0Qs3iYWI4Qt3I4IgzTzeNm15VGweY4CRTUgtKA== X-Received: by 10.101.86.141 with SMTP id v13mr6843492pgs.353.1521600078552; Tue, 20 Mar 2018 19:41:18 -0700 (PDT) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id h10sm5187829pgf.19.2018.03.20.19.41.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Mar 2018 19:41:17 -0700 (PDT) From: Chris Packham To: u-boot@lists.denx.de Date: Wed, 21 Mar 2018 15:40:37 +1300 Message-Id: <20180321024037.26393-6-judge.packham@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180321024037.26393-1-judge.packham@gmail.com> References: <20180321024037.26393-1-judge.packham@gmail.com> Cc: Marek Vasut , Chris Packham Subject: [U-Boot] [PATCH v1 5/5] rtc: rx8025: remove redundant code in rtc_reset X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As of commit 1a1fa2406689 ("rtc: Set valid date after reset") the command "date reset" will set the date/time to 2000-01-01 0:00:00 after calling rtc_reset(). This means that the rx8025 implementation of rtc_reset() does not need to call rtc_set(). Signed-off-by: Chris Packham --- drivers/rtc/rx8025.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/rtc/rx8025.c b/drivers/rtc/rx8025.c index b4a149b73808..c43966a50d76 100644 --- a/drivers/rtc/rx8025.c +++ b/drivers/rtc/rx8025.c @@ -163,11 +163,10 @@ int rtc_set (struct rtc_time *tmp) } /* - * Reset the RTC. We setting the date back to 1970-01-01. + * Reset the RTC */ void rtc_reset (void) { - struct rtc_time tmp; uchar buf[16]; uchar ctl2; @@ -178,21 +177,6 @@ void rtc_reset (void) ctl2 &= ~(RTC_CTL2_BIT_PON | RTC_CTL2_BIT_VDET); ctl2 |= RTC_CTL2_BIT_XST | RTC_CTL2_BIT_VDSL; rtc_write (RTC_CTL2_REG_ADDR, ctl2); - - tmp.tm_year = 1970; - tmp.tm_mon = 1; - tmp.tm_mday= 1; - tmp.tm_hour = 0; - tmp.tm_min = 0; - tmp.tm_sec = 0; - - rtc_set(&tmp); - - printf ( "RTC: %4d-%02d-%02d %2d:%02d:%02d UTC\n", - tmp.tm_year, tmp.tm_mon, tmp.tm_mday, - tmp.tm_hour, tmp.tm_min, tmp.tm_sec); - - return; } /*