From patchwork Wed Mar 15 09:29:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1757255 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=aURrWdpm; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Pc4qC1HVwz1yWr for ; Wed, 15 Mar 2023 20:29:42 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1AE7A3858C74 for ; Wed, 15 Mar 2023 09:29:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1AE7A3858C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678872577; bh=d9Io92Uqi0VzsVFmbqxMQ9BshN0PL0TTb9afza3oYFQ=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=aURrWdpmH/z3IomULiX7Aoyl95rVYidhpwQRSgMbEu7BL+fjmQg4ikELUNHauR/nT djv7f2XdBz5l09Hf/ohLQK/DlTCKtnde/HrIRjKTlyFuh3/+yeefu82Qs78RO6KU1N vomOtTSF/KPgw4KYSXV9ih1kZkGDY6nAz7UO6AJY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 646ED3858439 for ; Wed, 15 Mar 2023 09:29:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 646ED3858439 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8E1EA1FD70 for ; Wed, 15 Mar 2023 09:29:15 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 836B52C141 for ; Wed, 15 Mar 2023 09:29:15 +0000 (UTC) Date: Wed, 15 Mar 2023 09:29:15 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/109139 - fix .DEFERRED_INIT removal User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230315092937.1AE7A3858C74@sourceware.org> The following make sure to strip MEMs when looking for unused decls on the LHS of .DEFERRED_INIT. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/109139 * tree-ssa-live.cc (remove_unused_locals): Look at the base address for unused decls on the LHS of .DEFERRED_INIT. * gcc.dg/torture/pr109139.c: New testcase. --- gcc/testsuite/gcc.dg/torture/pr109139.c | 12 ++++++++++++ gcc/tree-ssa-live.cc | 3 ++- 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr109139.c diff --git a/gcc/testsuite/gcc.dg/torture/pr109139.c b/gcc/testsuite/gcc.dg/torture/pr109139.c new file mode 100644 index 00000000000..9fa97ebc665 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr109139.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-additional-options "-ftrivial-auto-var-init=zero" } */ + +const int COMPARE_CANDIDATE; +char ipmi_ek_compare_link_record1_0, ipmi_ek_compare_link_record2_0; +void ipmi_ek_compare_link() +{ + for (; ipmi_ek_compare_link_record1_0;) + for (; ipmi_ek_compare_link_record2_0;) { + int link[COMPARE_CANDIDATE]; + } +} diff --git a/gcc/tree-ssa-live.cc b/gcc/tree-ssa-live.cc index 9118e82b4f1..1be92956cc5 100644 --- a/gcc/tree-ssa-live.cc +++ b/gcc/tree-ssa-live.cc @@ -897,7 +897,8 @@ remove_unused_locals (void) else if (gimple_call_internal_p (stmt, IFN_DEFERRED_INIT)) { tree lhs = gimple_call_lhs (stmt); - if (DECL_P (lhs) && !is_used_p (lhs)) + tree base = get_base_address (lhs); + if (DECL_P (base) && !is_used_p (base)) { unlink_stmt_vdef (stmt); gsi_remove (&gsi, true);