From patchwork Wed Jan 11 12:30:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 1724643 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZpVtu/tC; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4NsRpn5Hn9z23f3 for ; Wed, 11 Jan 2023 23:30:25 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbjAKMaX (ORCPT ); Wed, 11 Jan 2023 07:30:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232011AbjAKMaX (ORCPT ); Wed, 11 Jan 2023 07:30:23 -0500 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAF24183 for ; Wed, 11 Jan 2023 04:30:20 -0800 (PST) Received: by mail-pg1-x530.google.com with SMTP id g68so9323913pgc.11 for ; Wed, 11 Jan 2023 04:30:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zABXTqnOS+sR0VK+tpmly/TmJdJD8fpPZyXdF/Osuvk=; b=ZpVtu/tC+7kESiiDpzePypwP/SBHfWV1Q1lpfMXwgwfHUHxxOIpgU6N4lpj9p4Vsfa QT9RcdK8fosGAKDoNV2xikqckVNwHSKqpJSt2tA70diYHYlyLBjjacnWmxDnFBUOju7g 7nXCyuxkiI0Gz3OlJUA/SWBo4hdMAVBo5TNNWCOmRbPANq+jnQ2YILIYxX4WWVBzuzwt qwKTu/uQ88wYL7O3Ux6PjfF70p/5qNbHmvjJOMLFjPw1tnf3FCk2SBfwMTOe/vu6P2N9 k/ZMLSgOfephCGiu3HL/rG4S+Al7DAYP4PI/5KAAcHobyVD76szr9sm6i/u5jaOhtLvH /9dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zABXTqnOS+sR0VK+tpmly/TmJdJD8fpPZyXdF/Osuvk=; b=SE5kV0mIi47HR5/nLcvDkyiA68txkwNVq4Cku1ZNTwwSLf1cDjSgub7F0k9GxpJ/kn EDBRIFi/VLSJV2734IVFnat62PRlwwHAq9Ysis7PbGED2T5B38BW1Hih+TfQfmnykIyk urjdliNNg+9H3uH0IwK2T71taz3vgtdAVobYwVGwDSLgjWphFdR/02/hKAUvkIVzSp9+ DcWk1/I0yuRgo+ltGaqpo4eSLLVanNFGVjWaz7VVqLppdrwoTxt3Rsr/0bVTrPRLA779 22GYzOdq/Rp3+eQcX/+SYi6TTqQLCwjGkwVTaNuY18IjDA2E3tjUQfIaeDDt+EWWjQNY Egcw== X-Gm-Message-State: AFqh2kqNkXf0vS9W6GQ4tIUoTN4P938UKnGfD6nter5KgHO5wY0OpPA2 NLdWXGav4sQmFas38e8LTd5/ X-Google-Smtp-Source: AMrXdXuEZXSoRWhbdC7h8lpHjLHieghHad2OGWe1QGcJ68zuacvSMxcyChFDucfQfzbarERJw7DJ5w== X-Received: by 2002:a05:6a00:a1d:b0:581:73c4:f0bb with SMTP id p29-20020a056a000a1d00b0058173c4f0bbmr65449291pfh.2.1673440220454; Wed, 11 Jan 2023 04:30:20 -0800 (PST) Received: from localhost.localdomain ([117.217.177.1]) by smtp.gmail.com with ESMTPSA id c15-20020aa7952f000000b005747b59fc54sm8719594pfp.172.2023.01.11.04.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 04:30:19 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: bhelgaas@google.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, Manivannan Sadhasivam , Rob Herring Subject: [PATCH 1/2] dt-bindings: PCI: qcom: Allow both GIC-ITS and internal MSI controller Date: Wed, 11 Jan 2023 18:00:03 +0530 Message-Id: <20230111123004.21048-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The binding should specify both MSI implementations and the OS/driver should choose the one based on the platform requirements. Fixes: 2b0d557419cd ("dt-bindings: PCI: qcom: Allow both GIC-ITS and internal MSI controller") Suggested-by: Rob Herring Signed-off-by: Manivannan Sadhasivam Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 01208450e05c..e106bdf93f09 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -119,7 +119,7 @@ required: - clocks - clock-names -oneOf: +anyOf: - required: - interrupts - interrupt-names From patchwork Wed Jan 11 12:30:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 1724645 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=gpkiR1z4; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4NsRq925yXz23f3 for ; Wed, 11 Jan 2023 23:30:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232420AbjAKMam (ORCPT ); Wed, 11 Jan 2023 07:30:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232757AbjAKMa2 (ORCPT ); Wed, 11 Jan 2023 07:30:28 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9BB8B07 for ; Wed, 11 Jan 2023 04:30:26 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id c26so6853246pfp.10 for ; Wed, 11 Jan 2023 04:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jUBhq6gDwIZT95NIs8306ERf1NfWP566N/5jgccgjik=; b=gpkiR1z4I+KOuHdaHilhRu5VCtC51kivd5GKp//dSEGu5DwZiH4SAFcM7NzqrIh1JF Z/ArtivzRkvhOVxaXS1VSZ8HBpMjHz/KQF0EWbFUCwYhAGaxy1jgByeZUWH7TfwFXAyd FOMJ+ImDvD5Vv+a4mrvm1jvtv+gjptCASHJpOZ5G1oQmb945slLCChIZBc4v/pPmBvIe uG6yC/nKHZ0C6N0/HecAf+fxgjk2UejEH1lqcTGXJVvEsTE8Mura07pRZVJdvMl7wX6E yJEUp8pA6o5KXZ0fSE7nB1e12AaH+AjpC6XUHpZ1bOc4qIZ8Pa5xy4VKNlosnV3n6uxJ jjww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jUBhq6gDwIZT95NIs8306ERf1NfWP566N/5jgccgjik=; b=nEgDhnzc7YiKi5DiqiX5WfJIuspAeSuDa5Kr8hY/KiuUznv3sm8QBKKhM29q4RrBBp 1Ntz4DZ/7AqBKoVKfhoOv2A+blkXPF1idq5FnCXC83JeV5PtM0vRDK2zA+FjAy5qBZAk QSkBueGaBUbHZXTHrXq9tYO2ALawvPKIadui+/l+qoOFPya/qYr2jSvuzlmQZJS/Lf4k zs8BRIsumoIJ+aVhoMsrpGquxvoZRpXDloWVqH86RAUnlDBE2beL1jbRO8W1yz0CgEc1 GAKlur7+ZfFC6ZVvgJj3pfaiIHEYSYnQ/AuPpwRvhoUDEYq0Xre4+My7yNuQ5joTrufa dYYA== X-Gm-Message-State: AFqh2koIEeaA7jAGhgNEgpuS9tTT8MHc+TJZcKnWLHn/YoR3HZG/3tCW 2lNs3R7DZc0uuPp0/cfWhvJd X-Google-Smtp-Source: AMrXdXuk2tFmgf8IGHH8e6xsf8DemGt04XaOt1fpa8Kz8SzpJugkztdcodDwZgpBv6K3oXTrSW0GZg== X-Received: by 2002:a62:6001:0:b0:582:33b4:4c57 with SMTP id u1-20020a626001000000b0058233b44c57mr2062856pfb.33.1673440226258; Wed, 11 Jan 2023 04:30:26 -0800 (PST) Received: from localhost.localdomain ([117.217.177.1]) by smtp.gmail.com with ESMTPSA id c15-20020aa7952f000000b005747b59fc54sm8719594pfp.172.2023.01.11.04.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 04:30:25 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: bhelgaas@google.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, Manivannan Sadhasivam , Rob Herring Subject: [PATCH 2/2] arm64: dts: qcom: sm8450: Allow both GIC-ITS and internal MSI controller Date: Wed, 11 Jan 2023 18:00:04 +0530 Message-Id: <20230111123004.21048-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230111123004.21048-1-manivannan.sadhasivam@linaro.org> References: <20230111123004.21048-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The devicetree should specify both MSI implementations and the OS/driver should choose the one based on the platform requirements. Currently, Linux DWC driver will choose GIC-ITS over the internal MSI controller. Fixes: a11bbf6adef4 ("arm64: dts: qcom: sm8450: Use GIC-ITS for PCIe0 and PCIe1") Suggested-by: Rob Herring Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index c4dd5838fac6..442b7be10858 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -1740,6 +1740,9 @@ pcie0: pci@1c00000 { msi-map = <0x0 &gic_its 0x5981 0x1>, <0x100 &gic_its 0x5980 0x1>; msi-map-mask = <0xff00>; + interrupts = ; + interrupt-names = "msi"; + #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; interrupt-map = <0 0 0 1 &intc 0 0 0 149 IRQ_TYPE_LEVEL_HIGH>, /* int_a */ <0 0 0 2 &intc 0 0 0 150 IRQ_TYPE_LEVEL_HIGH>, /* int_b */ @@ -1853,6 +1856,9 @@ pcie1: pci@1c08000 { msi-map = <0x0 &gic_its 0x5a01 0x1>, <0x100 &gic_its 0x5a00 0x1>; msi-map-mask = <0xff00>; + interrupts = ; + interrupt-names = "msi"; + #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; interrupt-map = <0 0 0 1 &intc 0 0 0 434 IRQ_TYPE_LEVEL_HIGH>, /* int_a */ <0 0 0 2 &intc 0 0 0 435 IRQ_TYPE_LEVEL_HIGH>, /* int_b */