From patchwork Mon Dec 12 21:20:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1715150 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sOuft4zZ; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NWF1336nKz23yh for ; Tue, 13 Dec 2022 08:21:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=efzG2XSDkxlniAqLjuNqhte353MQkBIDgIg2j/iiy6c=; b=sOuft4zZd0D/YG oSvDG9r0PUtHonRv0agU9Yai9QA/xv6KeRBOWl0xpIXQ8Mx5xYKN3CVd2w13WFUjQu70AFwiXEF/5 kn+cN1OzBI0enDb/5Hz6LXmd55GJlX224CPdvNCqfw876EvDn7Etdl61XU6r9880YlmYn59YfnS5n ayH6fQW7KJZS7/8igNtx9seE9bcO6o9ofnIg5kkXpM/qbt/K2qPHLuJ2hBoeMtY11wDcldF38t8+H 4TJzBTiNWL3w8aNQ47eTiABY0kMVTIRPMspjufUHQGxiikFUt8Zg0DD5CXfO3+tbW8QHqpjxL1WUa WrXH0FTQRQyqJEpBMyLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4qEU-005hbW-Jd; Mon, 12 Dec 2022 21:21:07 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4qEQ-005haq-63 for linux-snps-arc@lists.infradead.org; Mon, 12 Dec 2022 21:21:03 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4qEK-0006Ab-3e; Mon, 12 Dec 2022 22:20:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1p4qEH-0046Xn-Nu; Mon, 12 Dec 2022 22:20:54 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1p4qEH-004bDz-Lh; Mon, 12 Dec 2022 22:20:53 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vineet Gupta , Greg Kroah-Hartman , Jiri Slaby Cc: linux-snps-arc@lists.infradead.org, linux-serial@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] serial: arc_uart: Drop empty platform remove function Date: Mon, 12 Dec 2022 22:20:37 +0100 Message-Id: <20221212212037.3773636-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1133; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=1ZFqVjickndN0gqkcb1KHAfmGOf0XDUNbl2udK5Prrg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBjl5siEDIfLwerQaKD6mTdBeccjjnlYBgq8kNA2nmO +iufywSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY5ebIgAKCRDB/BR4rcrsCemXB/ 0Sm0090b+aitBLel1JUaVMR8XyTYJa+igBBPJQI/gNOfpFwHjP9Mrv3bT4jLYqPxqVGgvYYzcWFNUP E95ci8fy8jYEZalzn15/eBxzubYvJ9RqCRfKdHPaqAHEkLBsLXArlTsYoNLNmOhi9kr6/h2vLwTwPy VdAwIL4sVZjhupbRWZwzo5N0RS78OJBELeANvHI2eZUyXIrHFb1ejBNuFjPk0MgydjYP3H1CPaT7qQ eHr5/sL4SckeIvK2Y6BhQmQUaAm+B0itAzp1nlGWix8ptAH3VmWaLQw+/z07UljD3ju8HyiXaDkluR Qa5VTKFCYk9VjT2LdDeilrNZWnHYh+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-snps-arc@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_132102_628712_DE92E6C3 X-CRM114-Status: GOOD ( 11.17 ) X-Spam-Score: -0.7 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__A_remove_callback_just_returning_0_is_?= =?unknown-8bit?q?equivalent_to_no_remove?= =?unknown-8bit?q?_callback_at_all=2E_So_drop_the_useless_function=2E_Signed-?= =?unknown-8bit?q?off-by=3A_Uwe_Kleine-K=C3=B6nig?= =?unknown-8bit?q?_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E_---_drivers/tty?= =?unknown-8bit?q?/serial/arc=5Fuart=2Ec_=7C_7_-------?= =?unknown-8bit?q?_1_file_changed=2C_7_deletions=28-=29_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=28-0=2E7_points=2C_5=2E0_re?= =?unknown-8bit?q?quired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E7_RCVD=5FIN=5FDNSWL=5FLOW______RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?= =?unknown-8bit?q?_low_trust?= =?unknown-8bit?b?IFsyMDAxOjY3Yzo2NzA6MjAxOjI5MDoyN2ZmOmZlMWQ6Y2MzMyBsaXN0?= =?unknown-8bit?b?ZWQgaW5d?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function. Signed-off-by: Uwe Kleine-König Reviewed-by: Ilpo Järvinen --- drivers/tty/serial/arc_uart.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c index 2a65ea2660e1..f1b6034addda 100644 --- a/drivers/tty/serial/arc_uart.c +++ b/drivers/tty/serial/arc_uart.c @@ -632,12 +632,6 @@ static int arc_serial_probe(struct platform_device *pdev) return uart_add_one_port(&arc_uart_driver, &arc_uart_ports[dev_id].port); } -static int arc_serial_remove(struct platform_device *pdev) -{ - /* This will never be called */ - return 0; -} - static const struct of_device_id arc_uart_dt_ids[] = { { .compatible = "snps,arc-uart" }, { /* Sentinel */ } @@ -646,7 +640,6 @@ MODULE_DEVICE_TABLE(of, arc_uart_dt_ids); static struct platform_driver arc_platform_driver = { .probe = arc_serial_probe, - .remove = arc_serial_remove, .driver = { .name = DRIVER_NAME, .of_match_table = arc_uart_dt_ids,