From patchwork Mon Nov 21 22:49:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anisse Astier X-Patchwork-Id: 1707577 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NGMzQ2KgMz23nR for ; Tue, 22 Nov 2022 09:50:09 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7B6BA60F58; Mon, 21 Nov 2022 22:50:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7B6BA60F58 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MowXT-K287v9; Mon, 21 Nov 2022 22:50:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id AFF9C60F2E; Mon, 21 Nov 2022 22:50:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AFF9C60F2E X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id C020C1BF3A9 for ; Mon, 21 Nov 2022 22:50:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A8BC1405E9 for ; Mon, 21 Nov 2022 22:50:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A8BC1405E9 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ebhi35R8fBop for ; Mon, 21 Nov 2022 22:50:02 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 91F2C40179 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by smtp2.osuosl.org (Postfix) with ESMTPS id 91F2C40179 for ; Mon, 21 Nov 2022 22:50:02 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id x5so18058352wrt.7 for ; Mon, 21 Nov 2022 14:50:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QmWX3N8yEOl3AqhdXck6feisaGn8K9xrko5QVUGTCu0=; b=K5X3h/Rx/huxiF0H/14/mRWRBhb8KL97ZBlmpl1qXye3EI0wUIRVcl6f5N72h+9AH8 Yk+DVKrNXZMlfEJSexuVS18wAxyhWET7ZEk0/VmwLpCN40WtS3/HIJDIu5ofzbSe38id YDB4qo/UK/4kMG5o55pb+0reJ7CvYDH/lXV0H/Re6q2APfxdJA4QpMkJoY99XCRbTIlf 5XwxhNLkkDTJ7m8kbBNMUdz25jDhMxw3kp58cZLDhF0udklecl3JwmT/tLtG3w43awVF y+EgxpmTOu7fq5E3M1NIfQCwX75j86YJGs0rXUXbmcHTtKbi2Xg/GiKcSoJsualas218 qQTA== X-Gm-Message-State: ANoB5pktRbIe2gIJb+NWfBUcpJZfVe/d+h74MVS3s5YeTg5m5gza1te/ IfpZ6TAD0OxduYkFK87eB6OxAidH+L5NGw== X-Google-Smtp-Source: AA0mqf603pmMB88UYFoTCQ5M+OzmoX0iUB9jFynny7cxRpqWaSY9jlMF0mFOTmx8lEVL5obpaTwQwA== X-Received: by 2002:a5d:4ec5:0:b0:241:d782:9047 with SMTP id s5-20020a5d4ec5000000b00241d7829047mr3781437wrv.681.1669071000436; Mon, 21 Nov 2022 14:50:00 -0800 (PST) Received: from gpdmax.. ([2a01:e0a:28f:75b0:2488:d453:b017:99a]) by smtp.gmail.com with ESMTPSA id q14-20020a05600c46ce00b003c6c182bef9sm24704877wmo.36.2022.11.21.14.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 14:49:59 -0800 (PST) From: Anisse Astier To: buildroot@buildroot.org Date: Mon, 21 Nov 2022 23:49:55 +0100 Message-Id: <20221121224955.951056-1-anisse@astier.eu> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=astier-eu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QmWX3N8yEOl3AqhdXck6feisaGn8K9xrko5QVUGTCu0=; b=KXAMxWjFi7TbNYg6GCPKounq3e6fRfHnKlSZpofmqFr73m3lMq7JjBXTV8XEO+gugw IV2STbejK7DZ77V5jjIFu26rvbG+MTBF76NaUHuEGe/gKXzpi52E7ykhYDzhGQrSZCsD 0rWU9kyVGW4bk4jScVftadlUUoIzJ+UYKtpC4pqIgfaC8fGu7MEnkKLpJILmqF3EVOuV ZojDhV/nwVOFRCD6t9Pa9+s261nVn+MVet/9q20Ce+BxJuRKBLgoijBEYsyBQEaNNHd7 U2NeaGTqrCifh505zW8P3nh52xFnXR8+sD1sfpzMeSF9nRUqHbkH3jR8LdoY9ZTUNJYx JZWQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=astier-eu.20210112.gappssmtp.com header.i=@astier-eu.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=KXAMxWjF Subject: [Buildroot] [PATCH v2] package/go: disable cgo support with static libs X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anisse Astier , "Yann E . MORIN" Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" The go stdlib "plugin" package relies on dlfcn.h which isn't available when we have BR2_STATIC_LIBS=y. This should fix this build error from autobuilders: /buildroot/build/host-go-1.19.3/src/plugin/plugin_dlopen.go:11:10: fatal error: dlfcn.h: No such file or directory 11 | #include Signed-off-by: Anisse Astier Reviewed-by: Christian Stewart --- package/go/Config.in.host | 1 + package/go/go.mk | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/package/go/Config.in.host b/package/go/Config.in.host index ded02d3b3a..9e79a7dfd5 100644 --- a/package/go/Config.in.host +++ b/package/go/Config.in.host @@ -23,6 +23,7 @@ config BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS # Go doesn't support CGO linking on MIPS64x platforms # See: https://github.com/karalabe/xgo/issues/46 depends on !BR2_mips64 && !BR2_mips64el + depends on !BR2_STATIC_LIBS # Host go packages should depend on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS config BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS diff --git a/package/go/go.mk b/package/go/go.mk index fd4caa2e5a..d54be8cd78 100644 --- a/package/go/go.mk +++ b/package/go/go.mk @@ -87,7 +87,7 @@ HOST_GO_TARGET_ENV = \ # set, build in cgo support for any go programs that may need it. Note that # any target package needing cgo support must include # 'depends on BR2_TOOLCHAIN_HAS_THREADS' in its config file. -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS):$(BR2_STATIC_LIBS),y:) HOST_GO_CGO_ENABLED = 1 else HOST_GO_CGO_ENABLED = 0