From patchwork Tue Nov 8 04:26:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1701114 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=mUf5Psda; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4N5w6t1PLxz23lT for ; Tue, 8 Nov 2022 15:27:18 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1osGCd-0003rM-ND; Tue, 08 Nov 2022 04:27:11 +0000 Received: from mail-pl1-f182.google.com ([209.85.214.182]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1osGCX-0002zC-LE for kernel-team@lists.ubuntu.com; Tue, 08 Nov 2022 04:27:05 +0000 Received: by mail-pl1-f182.google.com with SMTP id v17so13135565plo.1 for ; Mon, 07 Nov 2022 20:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=JDW+QdF+8dsr06DirNXwqphtVB0irqL2JlqwVdhftog=; b=mUf5PsdaltveHwdxjREkxo15sThTvlqhoKEhjqIfwX6d5dhA6PGhMXabm6PEqx5CE+ BDOh+FfB06m64i+UeCXRpmr75DlhxlZlnyXGG2L4pk1R2IuQEV4uHSAZUZLljSAYUINf Uq6Caonim0fG+JniAjXB7tXNqHe8++zTCjtwgCsSpZbiUhouVuHnh79/G/dRDdRsdFBq ulYrlFYjMylFFsMMHRWz3J4xUbNwIxyeJQz1t4HIM7eL9HzXQlvaThLDC/9KmBJttabN 6BN+jxrAjlk8E1ucPWW1EYbaMm3/6ZeGxGPO98CO0gkShqx3l58o7zreWdDFzQ/S/Mqy 3Pqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JDW+QdF+8dsr06DirNXwqphtVB0irqL2JlqwVdhftog=; b=ZOmSR+39mbPQ47Y7QTUoJRhd2zk3iNWuHbX8reqbzgZOPdC3JJXhjVQYSZ7+6WzOre Y3aU9cMixrmZFJimABw61IEm+017P6edYc9fmWlWtlwHOmikLH7DEfGrmOJoeuaa4D4Z apL+4/tbqlW79but0zhJFnGYMX+a4iJjrVbylzfbKPxASY4To5idKb2QtE0cN7gINpyv A5LbuCqCxMEGAnYVcWDNd/auUhjUewb3FR+1uQnlxlB8AJIajlC/fGvGT+QuOL3atJvU ORJRlVOST6TfhL3FOOFeUxcl0bvjR5I0N33Mp7kmKQynWZ+yxXAWdRJRccu9Lytirjzl RyjQ== X-Gm-Message-State: ACrzQf02TvMke8phXJ2pEfM0F2YzzcUeZiqqXpxIsf91nWXPFa7ekGdN TuqGviPpsn8CcuI46dlkRI0l2iECaxg= X-Google-Smtp-Source: AMsMyM6FB8r5/b9u28Ou7E6wnen2YzrZiw7AG+UFGdPZ1d3jY378epfYvfHKK1r2QsLQ3Z8Glk2j6A== X-Received: by 2002:a17:90a:1042:b0:213:9d9c:c800 with SMTP id y2-20020a17090a104200b002139d9cc800mr57759387pjd.53.1667881614343; Mon, 07 Nov 2022 20:26:54 -0800 (PST) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c10d00b001743ba85d39sm5783417pli.110.2022.11.07.20.26.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 20:26:53 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 2/3][SRU][K] drm/mgag200: Add FB_DAMAGE_CLIPS support Date: Tue, 8 Nov 2022 12:26:33 +0800 Message-Id: <20221108042634.24176-9-acelan.kao@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221108042634.24176-1-acelan.kao@canonical.com> References: <20221108042634.24176-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.214.182; envelope-from=acelan@gmail.com; helo=mail-pl1-f182.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Jocelyn Falempe BugLink: https://launchpad.net/bugs/1995573 The driver does support damage clips, but doesn't advertise it. So when running gnome/wayland on Matrox hardware, the full frame is copied to the slow Matrox memory, which leads to very poor performances. Add drm_plane_enable_fb_damage_clips() to advertise this capability to userspace. With this patch, gnome/wayland becomes usable on Matrox GPU. Suggested-by: Jonas Ådahl Signed-off-by: Jocelyn Falempe Reviewed-by: Lyude Paul Reviewed-by: Thomas Zimmermann Link: https://patchwork.freedesktop.org/patch/msgid/20220504134026.283417-2-jfalempe@redhat.com (cherry picked from commit 3064debaf55e1bc8f191871ca5f82697ef4c0951) Signed-off-by: Chia-Lin Kao (AceLan) --- drivers/gpu/drm/mgag200/mgag200_mode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 9134be52c9a7..59f850f296ee 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -1137,6 +1137,8 @@ int mgag200_modeset_init(struct mga_device *mdev) return ret; } + drm_plane_enable_fb_damage_clips(&pipe->plane); + /* FIXME: legacy gamma tables; convert to CRTC state */ drm_mode_crtc_set_gamma_size(&pipe->crtc, MGAG200_LUT_SIZE);