From patchwork Fri Oct 21 13:22:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valerio X-Patchwork-Id: 1693097 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TRkimWgb; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Mv4rb1G1pz1ygT for ; Sat, 22 Oct 2022 00:22:21 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2F71C6118F; Fri, 21 Oct 2022 13:22:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2F71C6118F Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TRkimWgb X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jHteqlZArLte; Fri, 21 Oct 2022 13:22:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5F2E860E82; Fri, 21 Oct 2022 13:22:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5F2E860E82 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CFE42C0033; Fri, 21 Oct 2022 13:22:16 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id C4142C002D for ; Fri, 21 Oct 2022 13:22:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 929FC60E87 for ; Fri, 21 Oct 2022 13:22:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 929FC60E87 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2hNf7HzV2jsl for ; Fri, 21 Oct 2022 13:22:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5ECEB6FB4D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5ECEB6FB4D for ; Fri, 21 Oct 2022 13:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666358529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DHmz1QNrVQdRhmQi0Pgx3Swx5v/4xpfStnTPKQw52GU=; b=TRkimWgbXasynItExsrGOw/rNJmsQf8n7/GY82j4+mT/m2LVPn9J6I+jO100KBxgdMCqDO DpEmtsUSnyDZ2jlYlwocJvqUSB1DEHfByr8B8y07GoBlETY3d31czYyrRqIEpLSAe5VAyb 2HB4uswOUroBKhAMvCcyfL9psGccprc= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-116-8LXzYJy-OAW4VAnnLJSXkg-1; Fri, 21 Oct 2022 09:22:08 -0400 X-MC-Unique: 8LXzYJy-OAW4VAnnLJSXkg-1 Received: by mail-ed1-f72.google.com with SMTP id x19-20020a05640226d300b0045dc858ce29so2439945edd.7 for ; Fri, 21 Oct 2022 06:22:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :cc:to:from:subject:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DHmz1QNrVQdRhmQi0Pgx3Swx5v/4xpfStnTPKQw52GU=; b=oUm4kNvB8Unj15dyktfoWwNz1ElgavNL+93V26+MI41Xsnw7QUn/2e4BSD1+1OApzd TbKn1YlzWoQjmauf1YIcnoPfJqxTASoBEYaXJDzz0ZFmj9c1SRHLUS0MOmjIgwTOtUQJ yOAMVMn40MO23qc19I4n8a5EJ2ktvSb/nxdKABFGuAe26hu7mBk9mqk6lbiEAPCQ8Seb mQxI6DUdvqvuNHDWBoJfkia8Emr46EZbi72YFdyUv/tFM2wHaa8Y4C/+2kPlxlGLfCOx SBjri2AUvDMNsQGPWLDCnKYRBpBkmieVw0eJK5jGO3bktJJJbGfligQtJWnVwN0g6pdk /fzw== X-Gm-Message-State: ACrzQf16E+NZZn7Opgtu0vUiKkYhztaahFrpUaBwJbAMBc403R7u5b9c +N4BHJ6KXe9zzQQE+sT2h3Sd+devfPbtkjDb7kyU10M/ILbYaEoiPWv5Zaj+INp9AeXHAy2dyz5 LtWfgpGm8T2PWxAhcJY/+JDwOGbVTJ+e1C8SXE2mUO0d4eLai6cK3icP7XRzULTHN X-Received: by 2002:a17:906:db02:b0:780:24e:cf9 with SMTP id xj2-20020a170906db0200b00780024e0cf9mr15410894ejb.460.1666358527394; Fri, 21 Oct 2022 06:22:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Hh6zo4gl7ok4iZSkayhOj5hMngStuXRkHOhL6w8YJAWDw8LVveN3DSTuh45TNxUtu75gbJw== X-Received: by 2002:a17:906:db02:b0:780:24e:cf9 with SMTP id xj2-20020a170906db0200b00780024e0cf9mr15410873ejb.460.1666358527170; Fri, 21 Oct 2022 06:22:07 -0700 (PDT) Received: from localhost (host-80-117-127-57.pool80117.interbusiness.it. [80.117.127.57]) by smtp.gmail.com with ESMTPSA id ky15-20020a170907778f00b0078bfff89de4sm11532412ejc.58.2022.10.21.06.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 06:22:06 -0700 (PDT) From: Paolo Valerio To: dev@openvswitch.org Date: Fri, 21 Oct 2022 15:22:01 +0200 Message-ID: <166635852137.444103.15469799188583645502.stgit@fed.void> User-Agent: StGit/1.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: i.maximets@ovn.org Subject: [ovs-dev] [PATCH] odp-util: Add missing comma in format_odp_conntrack_action() X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" If OVS_CT_ATTR_TIMEOUT is included, the resulting output is the following: actions:ct(commit,timeout=1nat(src=10.1.1.240)) Fix it by trivially adding a trailing ',' to timeout as well. Signed-off-by: Paolo Valerio --- lib/odp-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index ba5be4bb3..72e076e1c 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -1004,7 +1004,7 @@ format_odp_conntrack_action(struct ds *ds, const struct nlattr *attr) ds_put_format(ds, "helper=%s,", helper); } if (timeout) { - ds_put_format(ds, "timeout=%s", timeout); + ds_put_format(ds, "timeout=%s,", timeout); } if (nat) { format_odp_ct_nat(ds, nat);