From patchwork Wed Oct 19 14:02:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 1691975 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=k/FHtDPC; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Msst512x2z23jk for ; Thu, 20 Oct 2022 01:04:27 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FDEA38582A7 for ; Wed, 19 Oct 2022 14:04:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FDEA38582A7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666188265; bh=m5DF2F8azQhkfjzzbAcSfAUOFvzUUOqupxnRAFtBigc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=k/FHtDPC97MW0FR7Ydx/RT87kCPbXivDP85O4wdpQE7POWjiyLjlHzPJXhVhOJ2PP a1sa4o2ef6CYgaEBuzh60tdHiIma2AEMJHETtcPot1LaQ585MOm7N6/3jAD42+3Y6y XT4xJHdIEOOW7tqgy1TkBM/0Ft166iKBC0TN8inU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DD0BF38582AD for ; Wed, 19 Oct 2022 14:02:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD0BF38582AD Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-hoRNQrCVPLOfgUl0Waw95A-1; Wed, 19 Oct 2022 10:02:27 -0400 X-MC-Unique: hoRNQrCVPLOfgUl0Waw95A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FBE2833B00 for ; Wed, 19 Oct 2022 14:02:26 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.194.255]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 240B34048D84; Wed, 19 Oct 2022 14:02:19 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 29JE2GY8044814 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 19 Oct 2022 16:02:16 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 29JE2GLM044813; Wed, 19 Oct 2022 16:02:16 +0200 To: GCC patches Subject: [COMMITTED] [PR tree-optimization/107312] Make range_true_and_false work with 1-bit signed types. Date: Wed, 19 Oct 2022 16:02:12 +0200 Message-Id: <20221019140212.44796-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" range_true_and_false() returns a range of [0,1], which for a 1-bit signed integer gets passed to the irange setter as [0, -1]. These endpoints are out of order and cause an ICE. Through some dumb luck, the legacy code swaps out of order endpoints, because old VRP would sometimes pass endpoints reversed, depending on the setter to fix them. This swapping does not happen for non-legacy, hence the ICE. The right thing to do (apart from killing legacy and 1-bit signed integers ;-)), is to avoid passing out of order endpoints for 1-bit signed integers. For that matter, a range of [-1, 0] (signed) or [0, 1] (unsigned) is just varying. PR tree-optimization/107312 gcc/ChangeLog: * range.h (range_true_and_false): Special case 1-bit signed types. * value-range.cc (range_tests_misc): New test. gcc/testsuite/ChangeLog: * gcc.target/i386/pr107312.c: New test. --- gcc/range.h | 2 ++ gcc/testsuite/gcc.target/i386/pr107312.c | 11 +++++++++++ gcc/value-range.cc | 2 ++ 3 files changed, 15 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/pr107312.c diff --git a/gcc/range.h b/gcc/range.h index 8138d6f5515..ba3a6b2516f 100644 --- a/gcc/range.h +++ b/gcc/range.h @@ -50,6 +50,8 @@ static inline int_range<1> range_true_and_false (tree type) { unsigned prec = TYPE_PRECISION (type); + if (prec == 1) + return int_range<2> (type); return int_range<2> (type, wi::zero (prec), wi::one (prec)); } diff --git a/gcc/testsuite/gcc.target/i386/pr107312.c b/gcc/testsuite/gcc.target/i386/pr107312.c new file mode 100644 index 00000000000..b4180e3bd7d --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr107312.c @@ -0,0 +1,11 @@ +// { dg-do compile } +// { dg-options "-mavx512vbmi -O1 -ftree-loop-vectorize" } + +void +foo (_Float16 *r, short int *a) +{ + int i; + + for (i = 0; i < 32; ++i) + r[i] = !!a[i]; +} diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 90d5e660684..511cd0ad767 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -3437,6 +3437,8 @@ range_tests_misc () max.union_ (min); ASSERT_TRUE (max.varying_p ()); } + // Test that we can set a range of true+false for a 1-bit signed int. + r0 = range_true_and_false (one_bit_type); // Test inversion of 1-bit signed integers. {