From patchwork Thu Oct 13 08:41:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 1689435 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=eoWxPiIS; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Mp30j4ml6z23k1 for ; Thu, 13 Oct 2022 19:41:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A7A584928; Thu, 13 Oct 2022 10:41:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="eoWxPiIS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DE04284D48; Thu, 13 Oct 2022 10:41:49 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 31EF581F4E for ; Thu, 13 Oct 2022 10:41:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20221013084133epoutp0350f49a228de1f2127f11572f3119f7ea~dlEx7x6P80591005910epoutp03E for ; Thu, 13 Oct 2022 08:41:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20221013084133epoutp0350f49a228de1f2127f11572f3119f7ea~dlEx7x6P80591005910epoutp03E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1665650493; bh=iE6sPV/aJu1v3dxqvwejJCRj+ppsVU4e501cFTZsUNY=; h=From:To:Cc:Subject:Date:References:From; b=eoWxPiISl31jx5d1oX4zxAWHFWioDOzcMj5ZlGGIZCHkzZjJrLQkI9L4dVK6gpZmQ K5PVE3tPYld4vK1UC5fVywXJh2hyxWuGzRSz/1TOrWD5dITeQCg/MvE0mPmpnjlUd4 Vzdny1REXg5JCItdElpfXxfQu9WyyzvAUnkBX/SI= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20221013084133epcas1p3b8c497b28a1afd8c7f5b73000f552802~dlExtNKYM0070000700epcas1p3G; Thu, 13 Oct 2022 08:41:33 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.36.144]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4Mp30D1Z2Rz4x9QG; Thu, 13 Oct 2022 08:41:32 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 46.8D.57013.33FC7436; Thu, 13 Oct 2022 17:41:23 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20221013084122epcas1p32a48d9dbebb95ff823161b9e6843541d~dlEoL7upn3045630456epcas1p3F; Thu, 13 Oct 2022 08:41:22 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20221013084122epsmtrp218fc9fc2a682dbc39e6bb868d7e65d54~dlEoLTpxX1763817638epsmtrp2U; Thu, 13 Oct 2022 08:41:22 +0000 (GMT) X-AuditID: b6c32a37-da3ff7000001deb5-bc-6347cf336a50 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 51.2D.18644.23FC7436; Thu, 13 Oct 2022 17:41:22 +0900 (KST) Received: from localhost.localdomain (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20221013084122epsmtip27669f3be3a49f6f10161c4741737c7bf~dlEn6-bNz1356013560epsmtip2I; Thu, 13 Oct 2022 08:41:22 +0000 (GMT) From: Jaehoon Chung To: u-boot@lists.denx.de Cc: rafal@milecki.pl, Jaehoon Chung Subject: [PATCH] tools: env: fw_env: Fix unused-result warning Date: Thu, 13 Oct 2022 17:41:21 +0900 Message-Id: <20221013084121.430492-1-jh80.chung@samsung.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCKsWRmVeSWpSXmKPExsWy7bCmga7xefdkg5ezeS1u/Gpjtdi9dhGT xdu9newOzB5n7+xg9Dg/1dOjb8sqxgDmqGybjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0Nd Q0sLcyWFvMTcVFslF58AXbfMHKBFSgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpdSClJwC 0wK94sTc4tK8dL281BIrQwMDI1OgwoTsjG3717AVPOasmNezlamB8Q17FyMnh4SAiURfw27G LkYuDiGBHYwSKyY+ZYVwPjFK7GttgHI+M0q8P72TDaZl85ZHUC27GCWWv5sCVfWFUeLZ6qss IFVsAjoS278dZwKxRQQkJH71X2UEsZkFbCQet/8AWy4sYCfR86gNrJ5FQFXixK5GsHpeoJqp TTuYILbJS8y89J0dIi4ocXLmExaIOfISzVtnM4MslhDYxC4x70c7C0SDi8STg/uhThWWeHV8 C9SnUhKf3+1lg2hoZpRYuuQgK4TTwyjxr+E6VIexxP6lk4FWcwCt0JRYv0sfIqwosfP3XKgP +CTefe1hBSmREOCV6GgTgihRkbj0+iUTzK67T/6zQtgeEu+mzAFrFRKIlTi77C7zBEb5WUj+ mYXkn1kIixcwMq9iFEstKM5NTy02LDCGx2tyfu4mRnBy0zLfwTjt7Qe9Q4xMHIyHGCU4mJVE eF1C3JKFeFMSK6tSi/Lji0pzUosPMZoCQ3gis5Rocj4wveaVxBuaWBqYmBkZm1gYmhkqifM2 zNBKFhJITyxJzU5NLUgtgulj4uCUamAyZNJZuuPdTd8FBx4Ynf1SkzL/hNauxIdXLizZ8fuN 7dsXL72CrNr6Ff8kN3Mnndh0S63ilNCu0yn333vX6keePFLzzbmfc9qeVR/eCNtd/vMz6har w8kHepu3zyuNNT72e+vVf11eJtc0lULYP+50XvJk+5Z/2cHHIouvpU9tOF3DeFOcjZHXo3te wDGr9/1nVbszG50akyYen5vq/HlNa9mDp/26RQ0Hg75OuHROpPVglyjPsfwXWc9veLpMP/Fm 6xunmzcPLt7NxdXt157r1rz6ZnKuR+ufizkvmKeHSU9S+WFx4s/J/fJMR1NyDgSW/tg8tfzY IZ0Pc3dEv5RbXjD9qljenhqOJT8FNt8uDVViKc5INNRiLipOBABeD6zY9wMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKLMWRmVeSWpSXmKPExsWy7bCSvK7Refdkg5cNhhY3frWxWuxeu4jJ 4u3eTnYHZo+zd3Ywepyf6unRt2UVYwBzFJdNSmpOZllqkb5dAlfGtv1r2Aoec1bM69nK1MD4 hr2LkZNDQsBEYvOWR4wgtpDADkaJ/T+TIOJSEp+fTmXrYuQAsoUlDh8u7mLkAir5xCix4slZ sHo2AR2J7d+OM4HYIgISEr/6r4LFmQXsJGbu+MAGYgsD2T2P2lhAbBYBVYkTuxrB6nkFbCSm Nu1ggtglLzHz0nd2iLigxMmZT1hA9jILqEusnycEMVJeonnrbOYJjPyzkFTNQqiahaRqASPz KkbJ1ILi3PTcYsMCo7zUcr3ixNzi0rx0veT83E2M4JDU0trBuGfVB71DjEwcjIcYJTiYlUR4 XULckoV4UxIrq1KL8uOLSnNSiw8xSnOwKInzXug6GS8kkJ5YkpqdmlqQWgSTZeLglGpgmtBf 86jBSlzu1ITjIXPbEyU1L/YIh054s+prmMyLu9u1lDQ0eo7dX8Tyss2llXP6BPOZLgmbNHZr PO463v3H79D8Q6m3QiZ+ZNiS8vzgzITji+evsA/z7Hme3zvTMkx9Zr1SgoxvRL3OL50XtYc0 0/Yx5jzb5CvSe6vC4rhbYOu50Ey+9xE6vEnSmlv0+mo3rqyoVWM6ZWbMk6QnsFTbT9N+sn2F jP5rMR/Wh1sZ60xnvGYsl7bcsoVBJOz4sz8uC6b+KPwt3pso6GqoHd3eKnjtEDf/7hxFfSPp Bf0teoL+7h5/NJpOMU+uS8jYpuOfXblTy/vigvNzrh5df20Gj/s6ZZlYY9Xnxbc5ryqxFGck GmoxFxUnAgAkNBv3uAIAAA== X-CMS-MailID: 20221013084122epcas1p32a48d9dbebb95ff823161b9e6843541d X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20221013084122epcas1p32a48d9dbebb95ff823161b9e6843541d References: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Fix unused-result warning about fread. tools/env/fw_env.c: In function ‘find_nvmem_device’: tools/env/fw_env.c:1751:3: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result] 1751 | fread(buf, sizeof(buf), 1, fp); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Jaehoon Chung --- tools/env/fw_env.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index c251e2e6ba7d..c9a8774acefb 100644 --- a/tools/env/fw_env.c +++ b/tools/env/fw_env.c @@ -1733,6 +1733,7 @@ static int find_nvmem_device(void) while (!nvmem && (dent = readdir(dir))) { FILE *fp; + size_t size; if (!strcmp(dent->d_name, ".") || !strcmp(dent->d_name, "..")) { continue; @@ -1748,7 +1749,14 @@ static int find_nvmem_device(void) continue; } - fread(buf, sizeof(buf), 1, fp); + size = fread(buf, sizeof(buf), 1, fp); + if (size != 1) { + fprintf(stderr, + "read failed about %s\n", comp); + fclose(fp); + return -EIO; + } + if (!strcmp(buf, "u-boot,env")) { bytes = asprintf(&nvmem, "%s/%s/nvmem", path, dent->d_name);