From patchwork Thu Oct 6 07:11:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1686662 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=NwCvQCcM; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MjjL35qBnz20Pd for ; Thu, 6 Oct 2022 18:11:55 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1616E418E5; Thu, 6 Oct 2022 07:11:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1616E418E5 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=NwCvQCcM X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FDHfJDmUJRtG; Thu, 6 Oct 2022 07:11:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id D97B3418D5; Thu, 6 Oct 2022 07:11:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D97B3418D5 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A5997C0033; Thu, 6 Oct 2022 07:11:50 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id C349AC002D for ; Thu, 6 Oct 2022 07:11:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7BC07418D6 for ; Thu, 6 Oct 2022 07:11:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7BC07418D6 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id adfYl_4yNwp4 for ; Thu, 6 Oct 2022 07:11:47 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7C6CD418D5 Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn2177.outbound.protection.outlook.com [40.92.62.177]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7C6CD418D5 for ; Thu, 6 Oct 2022 07:11:47 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eq3oOrlpVaxeN524BlHcaRZfKyCW2ctB8YfX3jxpz4o8+1bW8+DHY/k7pDbwcO7R+Xn8uoS8+awbLxB9AkGG7zWRhWcvmV9sXpr1G1EblhMxv3FUJX+UleWR4oDhI54cwgx/uftzauojINnQj9OJHYNRLEddXszkRVksDeEwEH0x47Qp1iDVIgGWlx7kJMda9t9zFM2wFL+F9H5lNlznwFJy8rVvF+zRoEa8d1+i79Z7mf8GJ2hpiZoZe6TYMYbqYiwWw3sdZSTBnJByeqcJryOZTLBXsBFVYdIWMVBmzvAxlNBkMBTwIWXggdWiaLFQV+Vu801eHamz4IvS8sSvzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CYpPfRBd+opVgLygsuL1bITj1rbnbdVDMXJYKsYbVwc=; b=Px9zupDyc7j4rs9zCFhTFhfteJIqQsGEH2KbdbjCwXPEHwejTW07nAC5UB1Is5lyh3Llp9zEcdwEE8DKSmRWPHboZxivFTsjZY+yvUJ2lo0JsnNLrcw0IMA9i19QYzpgUZSP3Uw8P69UWfO0s02Qoi26sZUWaFrGSRUI73+vVMLFkGdGpr+078HeMWJBKSJ/+kWL8rucEQnAZSPPthyv1oFO1fX+OK4KpZho9rgrbM8hL+lBWOUicPPlJYsl4ZVNme6NzzEz1Tg4PC5wYAWd+RnZ0vNCTgyTTUIruqpwsRUv8jTu+MEXmdGgm68XntVMW8kBZ2PP4Uo3MHhy8Gc84w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYpPfRBd+opVgLygsuL1bITj1rbnbdVDMXJYKsYbVwc=; b=NwCvQCcMng7gJNHgmsgHPhHUOC38hdcfZsIJP26wTT4BV9zvHa/4yLIk/nwK44ZjsR3lEmwSCxdI+5/nhaZizxxulzsA9EgBScUFnFH5cAH3fdL7mlyyryASfUEjzQweUgAoN6kc7ceLQ7r37yE2LZvcAn1unjGDbuq0s/bxiykRsTBXxJW8CqSsEQ8hXNSv654bU65Dn3sSCqmRVoJl004JuNE+jkd9fLuUwXGQw3iPxXMEXgtyDzRYNcX5zboSIlpoVblmnpWJoT8RHf+h/vYPhdaCKS+m3rHP4xFIZ7vBymcVafJfTMwvNmvL/4jLaZSp/WO/ntPUPm4FDU0ZtA== Received: from SY4PR01MB8438.ausprd01.prod.outlook.com (2603:10c6:10:19e::10) by MEXPR01MB1142.ausprd01.prod.outlook.com (2603:10c6:200:34::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Thu, 6 Oct 2022 07:11:42 +0000 Received: from SY4PR01MB8438.ausprd01.prod.outlook.com ([fe80::a5d7:1fa2:f4ff:1042]) by SY4PR01MB8438.ausprd01.prod.outlook.com ([fe80::a5d7:1fa2:f4ff:1042%5]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022 07:11:41 +0000 From: miterv@outlook.com To: ovs-dev@openvswitch.org, i.maximets@ovn.org, ktraynor@redhat.com, aconole@bytheb.org Date: Thu, 6 Oct 2022 15:11:08 +0800 Message-ID: X-Mailer: git-send-email 2.37.1.windows.1 X-TMN: [tqiRjBs155fs/bNPJoC/b/IMQwXeQQjmuWvn5eCJrmZE/uCZYdHJQGreneLPerSB] X-ClientProxiedBy: SG2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::20) To SY4PR01MB8438.ausprd01.prod.outlook.com (2603:10c6:10:19e::10) X-Microsoft-Original-Message-ID: <20221006071108.413-1-miterv@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SY4PR01MB8438:EE_|MEXPR01MB1142:EE_ X-MS-Office365-Filtering-Correlation-Id: 39486f7c-73f1-4965-e30c-08daa76a04d3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M8MUQ6xx7jgDCCAacdGk6WRLoo8dMPu2mpYGvEuDJYfBFVv0Bw+CSL3M0HFXMiObVUzIgKG1XvbKuDgSGZKwMrhZi2F4ot1WphXrgPNN4rYeQLVXrzIzXMLmCJZcPoHy3lzwSBzwC3x0XX1Q30Irs/aC8TOVn3cp7JIkZ4JSCqnick5VlTYTiTqwkTlCJB/Ysuuy69q1r028lCrNQOf70hDv4Zuxb1Iob6Cgww8fyOc05jV2CzPxHTH/pEXfa6ibl/1AY5z6om+BQDibmWbvQFcBQTm8VDUpWcXe4o5MdZpsLzDBCpsd118/FdgBFFBHpWtNRZNT95GCmYhsNcbsud8SeU/BmZGLrjeSWkenbGTHlst2A5x+v4qCZvNEvmr20Ga/GOH7ugbrpYdJQU8UQfJ8l4D8UibI5pq0al9XtYIyPB0vn5OJDy1amCZ/QyPN/Ybyf6oI6XltsmFc7U+7kkEhiDVcyhyp2JTuIf+LivTF9GQOwTEutuovzrVyph5arBHd+Cv26+XbidtNV1hi/rEDDB3j9hTLxO5Dpi2uX0f+6jh8MFjP2+wEj1vNWz5Z+5vlDyXxjNlckkZMzTaXe5ZUaHQN9XuUcLAR8g50ZBIpknSI3q8pauv8V7SjvAXZz5n8B+6+zzRmmYIl7ZA5Ug== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uYDWYOgBW7dlPiBkhpKCRy9PbiXbzaGCUyI/zh/0cXiVrV2oCnaKFhkYig3D9XobxeZsAyGXiEUm0Tda4S4NUmA06Z9BtNx6PRXrjFP52kEJAl9dVa24ZGTaDBgipYfBs1o6GoYQo1Xdvk+9TdKYUjBBP8QQfLZ/OS7jlmoizM8osMokvUxoNypI48361kP88BJIDjBF37nUHhgX2oRtTVeY/PRPUsSDBWNxf6MftgEW5nPStgBXT0qoDap16VEZIltj/cMYkEzRdqvimuW/auOl7bjQ4073dEk5cOu7/2/WHZPy5uT5tu/bnbzVwngA8PyZyG0su5JrsBrJvCyJY7xEtDBCYJcB7GFPXtE3Lzmk5ZUYdhD0fFUaZq8IMlM7AVd+L4sRXFnjkJ7ea6PzzAwtgZk6hBLxzkkQYIq4huK2/gmHXfObyuCZMvN9IXIKJO6pfJJb5rwa7YLISWpJ7avozkCBmsx7Hx+F2kwuzKxE+WYlqUih53SwLNDbau8oznM04ETHE8JR+TQzNpKUtq44cR9TzFJhJ94mI0KTGtGfTFcHcGS6uJtAqlb1nxwam9M1IkoPry/o3i8oBA6NOWN09Te8a0yxs6oGY/19muvM+dN5TxTq/wAL9gPNX6jJuKYceP2027bxkTKDyTZOiqji+yourigHX2uDxIoy/WcxoqbIQlnwwwhe7MzVp6gcwyj7wZxM45El+s8LM6rwF6DajythZCuI5OQNX6P6TZbhl9afsJI/K5gJJHccXsUagn/q3zi+eI7nIhpkti4Z8duA+EactcGGrxwoQv6Fmh616/+6jmhDP1Uq2x1JJze4IMy7XcgrlURfCTfpV6aulscotbUo4V939bNMAswDdxuDc1vNZNG1Srd4xn4ZxMgp2HAN5+/wyCig15yae5fqJK2HG12CrnkQDxBd+DmRMfSVuJIP2S9O3qwbCfbFTlDmDP6T5m40QlD6qWdZmidkHuVq9IQmWHlZg+L16+sUExPlYGaLXxV8ENJZpU/p30afHm4xhI2idlr1W8q7pSQTkSmu1YWyGefAcn0/0Oj8ZdJ6G7Hf5JOdN6Oh1VP3RjfHeS8qOi+CqOrQUabtZu/vc+hiHPKsbT1xOVQLcri3N0Kx98K1ZVWSzD3/tGz+dqQTDUjY/at7UHwIz6fCqmWuBNUuWVNtV8SJfE14bFm2hgTdoJcCWaigwuNsLU+yyKDnnuY7JgHyEiO2ERry3DLgC7a5q8RDioUs2JBMOA/wBy5btCi/x7aePakye4VlrZj7G1pxK//HkxzTy44jt5Izo/bTBpyfx/M7nOmTg7uxZIYJIlG3oXpPBoruPdPfBlq6WsJgh+n7B62cGIPTGG3mSQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39486f7c-73f1-4965-e30c-08daa76a04d3 X-MS-Exchange-CrossTenant-AuthSource: SY4PR01MB8438.ausprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 07:11:41.9318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEXPR01MB1142 Cc: Lin Huang Subject: [ovs-dev] [PATCH v1] ovs-tcpdump: Fix bond port unable to capture jumbo frames. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Lin Huang Currently the ovs-tcpdump utility creates a tap port to capture the frames of a bond port. If a user want to capture the packets from the bond port which member interface's mtu is more than 1500. By default the utility creates a tap port which mtu is 1500, regardless the member interface's mtu config. So that user cann't get the bond port frames which mtu is lager than 1500. This patch fix this issiue by checking the member interface's mtu and set maximal mtu value to the tap port. Signed-off-by: Lin Huang Acked-by: Aaron Conole --- utilities/ovs-tcpdump.in | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index 7fd26e405..e12bab889 100755 --- a/utilities/ovs-tcpdump.in +++ b/utilities/ovs-tcpdump.in @@ -225,6 +225,13 @@ class OVSDB(object): def interface_mtu(self, intf_name): try: intf = self._find_row_by_name('Interface', intf_name) + if intf is None: + mtu = 1500 + port = self._find_row_by_name('Port', intf_name) + for intf in port.interfaces: + if mtu < intf.mtu[0]: + mtu = intf.mtu[0] + return mtu return intf.mtu[0] except Exception: return None