From patchwork Fri Sep 30 15:24:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Thompson X-Patchwork-Id: 1684900 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=XhQ6ZP+U; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MfDZ43zvFz1ypH for ; Sat, 1 Oct 2022 01:25:15 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1oeHsq-0002PR-Lh; Fri, 30 Sep 2022 15:25:00 +0000 Received: from mail-bn8nam11on2040.outbound.protection.outlook.com ([40.107.236.40] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1oeHsp-0002PI-1y for kernel-team@lists.ubuntu.com; Fri, 30 Sep 2022 15:24:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVsoacKLteCMxsOf6Xt7+QJxq6wgpqhkyYp6seABjrRgi/1hMNJAec4I3m4BLKG3yTulxy4eGZWsQ3vVRUY31Iq9yyZgvZf4DuJcEX0kXFLsd/H6x9lzaoNCGO+X5b8SvDX1sg6URQbav74kKQxfU2wA4NKMjxXVyBfQlec7ImTKk3GMc5LTouvilQHVHvaz6QU3/MzjRjLFuo8ad6+aNpJ4/AuTGPb/o7lxWr1lWBCzGb6rT8nxm6RZkVWjlJtyRjcRHv4ee+osH/8X/NmSmcvic2duXThePW0pLCJqxr8/Uos/TnaskMEEyAukbZFJRhXcecMJgjrd+7ldzK2ZhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EJ6HmJiECmHtlR6q+/yyGyp4DdsHISqsq/Vpr+PImb4=; b=PIJOabLRRuOcwoOrGLtls5Z5ULpz2zrj91h1g/X2/SOjL8Gpz4yaaGSP/1PdX8dFz7kVRPOrAYrK44xZFNzSuJQFob0LHrRAzWjDcdPd3Nmv4Xe4BYCrExJj1WTJGk9l6RJzdSFJOWjznIdnqD6hB2IaFk1vYF4LCgjX6KDQhfbV5GJc2WL4W3FThw0ZRJpFu64Xs+69A3EM7tlnQwNi43bC1b32egPv4jFukgmN5VRonY+9WEH8IhZiKbicX6RBvd48pPJyZbPapOxIOeuiS/dOLeXmgGdt4K1aAOJqB6vrrnWFGuPvLNIVN2VtZTp/MtchLXqzs9q5FaXILQduxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EJ6HmJiECmHtlR6q+/yyGyp4DdsHISqsq/Vpr+PImb4=; b=XhQ6ZP+UevdlROZMwiomfmgavD0SVAkefzKldWgmZRu3jghPpzj3q4eHMh/6Y9vDlBYsgLiHZNQQcQOHG8pAPsBXtX95Q0C5nb9Le691Erg9cXpQkVryKr8f2NJNXwQ81husKkSvjs7k+1te4jpzeRmsizCXoVBvNqsYCaDN9P15HTRcKgJRGpoVYd3z0ziGohLOgXTKt9d4cqszPtaC2c6qe6l2bAcKSN0n1CFctVM8iOvAppxD1LOEvI+0s6/w9TtZKa5VPvfHeFBQWTEvfFqmjoygnXYf2uF4B8e57fzUjjtECWQaoQZZp79uEUHqwszKUWhuAF7pubKdwuBLHg== Received: from MW4PR04CA0340.namprd04.prod.outlook.com (2603:10b6:303:8a::15) by CY8PR12MB7121.namprd12.prod.outlook.com (2603:10b6:930:62::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 30 Sep 2022 15:24:55 +0000 Received: from CO1NAM11FT036.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::cc) by MW4PR04CA0340.outlook.office365.com (2603:10b6:303:8a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.22 via Frontend Transport; Fri, 30 Sep 2022 15:24:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT036.mail.protection.outlook.com (10.13.174.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 15:24:55 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Fri, 30 Sep 2022 08:24:47 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Fri, 30 Sep 2022 08:24:47 -0700 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.29 via Frontend Transport; Fri, 30 Sep 2022 08:24:46 -0700 From: David Thompson To: Subject: [SRU][J:linux-bluefield][PATCH v1 1/1] net/mlxbf_gige: Fix an IS_ERR() vs NULL bug in mlxbf_gige_mdio_probe Date: Fri, 30 Sep 2022 11:24:45 -0400 Message-ID: X-Mailer: git-send-email 2.30.1 In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT036:EE_|CY8PR12MB7121:EE_ X-MS-Office365-Filtering-Correlation-Id: 6763c0e0-eefa-467b-1f56-08daa2f7edc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Miy1CMg+/w01K+6ixDPiff2+xxHLm9vjwjvFXoHwlMASMp3Awa0f32sWGA+qNfA/Lq9ndtkhDiOqfD/k79tZW/xPn5wrBrFEcBjuhJDZZT4Adxu50ubvBrBozBJcS/18EB57mHXiy3cbSISrokb091jd5fiQFTBZ1ewlwims63HRfhWS11Uo/dnv1cG9ukoSb1yUOuGFsSi6x/vb8eyf+xTfbBqzkVB3B1/G6Ipl4+UvuglGztfV7c4hcmvCX+vXLhOokwgp4j24djM6OkETMxtmAwrnJLN5WIFJAEid9ShYo8GMK8zFXFLI8RYY3gm4AKOz+PG67EVxBNodEENebQmlNORDZRVq7siWhz1WBgZsYrMPyoX4whI8Rff86FsWkp3zYleYsHEZ/eIUjU1VuvP1/E191Occyhw6lSyUPfKggffTCJCVz6UE+ik7auoJDKOrrtEhR9++xx5pRbwTN7h92hsP6VwUQoxWqp8J+66SzrBY7rmGcPueJVJzYI5HHs7oX/z4BFWUTk9yEaBXtQRQy0WLnxVOIwmU/NuCFUDRsWj4BLi1oElS4VCITscJu9uO+F8Lnu0aPntPXnOw3NlbnSOtg+T6nVc6/r/fcrxKRS4bsJe8jA6lRrZj/GARZC+vOXHN/ouh2lXJy8scc0/RMniAOvdzLo3x0783extUn6fGx2S4j+5A2xIZGTV8JHupUCT8aBlk/0Out/wIlI73QTyUxHN2x3pqjmDK1k9MtsCmBUyuHgpbrdlN6b4JiIjDVCSljbBe/cZUhCwkrXDms88eL+barw3nJD2JdEQ9snXaHa5C1/ps+7kZDKIY7nN7pzZpnyf/TlKPYw5+sA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199015)(46966006)(40470700004)(36840700001)(7636003)(2906002)(86362001)(26005)(7696005)(36756003)(2616005)(40460700003)(356005)(82310400005)(82740400003)(36860700001)(70206006)(336012)(426003)(316002)(478600001)(70586007)(186003)(83380400001)(47076005)(40480700001)(966005)(6916009)(5660300002)(8936002)(8676002)(41300700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 15:24:55.4262 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6763c0e0-eefa-467b-1f56-08daa2f7edc1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT036.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7121 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Peng Wu BugLink: https://bugs.launchpad.net/bugs/1991403 The devm_ioremap() function returns NULL on error, it doesn't return error pointers. Fixes: 3a1a274e933f ("mlxbf_gige: compute MDIO period based on i1clk") Signed-off-by: Peng Wu Link: https://lore.kernel.org/r/20220923023640.116057-1-wupeng58@huawei.com Signed-off-by: Jakub Kicinski (cherry picked from commit 4774db8dfc6a2e6649920ebb2fc8e2f062c2080d) Signed-off-by: David Thompson --- drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c index 4aeb927c3715..aa780b1614a3 100644 --- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c +++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c @@ -246,8 +246,8 @@ int mlxbf_gige_mdio_probe(struct platform_device *pdev, struct mlxbf_gige *priv) } priv->clk_io = devm_ioremap(dev, res->start, resource_size(res)); - if (IS_ERR(priv->clk_io)) - return PTR_ERR(priv->clk_io); + if (!priv->clk_io) + return -ENOMEM; mlxbf_gige_mdio_cfg(priv);