From patchwork Tue Aug 16 09:01:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 1666746 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa header.b=ZOdT20k0; dkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KBtHQMOO; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4M6Q9n51HFz1yfd for ; Tue, 16 Aug 2022 19:01:16 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A5DE13858421 for ; Tue, 16 Aug 2022 09:01:13 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id BADC73858C2D for ; Tue, 16 Aug 2022 09:01:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BADC73858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8CEA3349B8 for ; Tue, 16 Aug 2022 09:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1660640461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hoYq5quUVS0WBXZIm/D6587MpdtS11MN3IlMnQXYH7s=; b=ZOdT20k00j/2PJw53WB3J7QZsJRQkb1U04atE9njgrCfLa5M3Uds8tv0Ad0zzDWAJDUS3A WS6KZmgxtkcjz0zO9H6ewo2oBRiKuJO/VTPEQYfE5G6q4g9qTW6WmiXjR91GleCiSlKGB2 Xf+HH8Iy2/5mNw/nwJ1L3/Oz/ljlDr0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1660640461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hoYq5quUVS0WBXZIm/D6587MpdtS11MN3IlMnQXYH7s=; b=KBtHQMOOvp+51sF6H4QWwW0zkYNz47mwM3WbtvGLHZ4Fefuj0tytzsKwLgGdDl5LnGiaC6 uU1PA0QAeNSGYqDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7B0DF139B7 for ; Tue, 16 Aug 2022 09:01:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fdfyHM1c+2KrbAAAMHmgww (envelope-from ) for ; Tue, 16 Aug 2022 09:01:01 +0000 Message-ID: Date: Tue, 16 Aug 2022 11:01:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 From: =?utf-8?q?Martin_Li=C5=A1ka?= Subject: [PATCH][pushed] analyzer: add more final override keywords To: gcc-patches@gcc.gnu.org Content-Language: en-US X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Pushed as obvious. Martin gcc/analyzer/ChangeLog: * region-model.cc: Fix -Winconsistent-missing-override clang warning. * region.h: Likewise. --- gcc/analyzer/region-model.cc | 4 ++-- gcc/analyzer/region.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gcc/analyzer/region-model.cc b/gcc/analyzer/region-model.cc index b05b7097c00..b5bc3efda32 100644 --- a/gcc/analyzer/region-model.cc +++ b/gcc/analyzer/region-model.cc @@ -3425,7 +3425,7 @@ public: result_set.add (sval); } - void visit_unaryop_svalue (const unaryop_svalue *sval) + void visit_unaryop_svalue (const unaryop_svalue *sval) final override { const svalue *arg = sval->get_arg (); if (result_set.contains (arg)) @@ -3449,7 +3449,7 @@ public: } } - void visit_repeated_svalue (const repeated_svalue *sval) + void visit_repeated_svalue (const repeated_svalue *sval) final override { sval->get_inner_svalue ()->accept (this); if (result_set.contains (sval->get_inner_svalue ())) diff --git a/gcc/analyzer/region.h b/gcc/analyzer/region.h index 20dffc7f577..d37584b7285 100644 --- a/gcc/analyzer/region.h +++ b/gcc/analyzer/region.h @@ -919,7 +919,8 @@ public: const svalue *get_byte_offset () const { return m_byte_offset; } bool get_relative_concrete_offset (bit_offset_t *out) const final override; - const svalue * get_byte_size_sval (region_model_manager *mgr) const; + const svalue * get_byte_size_sval (region_model_manager *mgr) + const final override; private: