From patchwork Mon Aug 1 10:05:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Jensen X-Patchwork-Id: 1662462 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=irrelevant.dk header.i=@irrelevant.dk header.a=rsa-sha256 header.s=fm2 header.b=pi2Vq4Np; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=t22oXb3P; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LxDM22ww4z9sCD for ; Mon, 1 Aug 2022 20:07:26 +1000 (AEST) Received: from localhost ([::1]:33250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oISKZ-0001Ds-TB for incoming@patchwork.ozlabs.org; Mon, 01 Aug 2022 06:07:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oISJN-0001Bc-1h; Mon, 01 Aug 2022 06:06:09 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:59409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oISJJ-0000Wh-VX; Mon, 01 Aug 2022 06:06:08 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id DCEBC3200258; Mon, 1 Aug 2022 06:06:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 01 Aug 2022 06:06:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1659348363; x= 1659434763; bh=8GsZ2n0clzxDVX154HAXrQ6e/Ug5JtURfvpd8uglFHU=; b=p i2Vq4NpaIjjroPSLwQOmZ1QvaSmfffE6+Y/EpCQiaSAurI/R6nvRSKK0qRlegDCy /vATIJcn9eQuHvJzkT+3YSCh1zTWrPQpQg/umiYWIf5prI6B2wGLT9s0ZYmG6xbV UVi9gJYH7/w/Yau5vBxt4i48ZmjZfGi+q/Jawb+8aUqOM0Je1Pink4nCcCcYk/6g F3KCnaoPGrSjS46xHM0paWEh8MwiA9W0D8KnxwWX4yfvyEIVwqwdjeHsBLx3xmqW GrB3fgfXQNhEm2Cq6dRfAkkGXq5CXNSoDCiw8Uw49QHGxkvZzmNvcOKK0GnjpNH3 7idM/qpTeQRYWALVuFSHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1659348363; x=1659434763; bh=8GsZ2n0clzxDV X154HAXrQ6e/Ug5JtURfvpd8uglFHU=; b=t22oXb3PAHprNJeyXVUWkH0Ui7w2K SIxP8Hfs+rExHnaE3SRyOCk6Eg4gML3yk/GTVhKxDZiC+yys1DmYZ5yrLTrqzAM4 bOTNtbjKHchPusKALNRN+M6GTqU5bOo5QHuWOe7yLIrz9mVe+AeozpWLdOQa7xbY xEEHY3JI0oc7WcLkkiS2ADGTop+z/MgP5tU+pZIJXTSBE4ajNEm7mEqi/G6JV9dL 1OuvEotE/vLdfIETPn9o+4kodOvwNzarzS0SHenGFzAU7so4PMBIf8k1PFyOp10l 8gSIA37BaGV4zwBtLyXZFezj9jPAmuWDrv9YPBpmdc2YzEX/menwOt4qw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvfedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjefgieelgfeiveehkeeuveehheekfeevgeeigfehfefgjeejhefffeegudej udegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih htshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 1 Aug 2022 06:06:00 -0400 (EDT) From: Klaus Jensen To: qemu-devel@nongnu.org, Peter Maydell Cc: Keith Busch , qemu-block@nongnu.org, Klaus Jensen , Klaus Jensen , Jinhao Fan Subject: [PULL for-7.1 1/3] hw/nvme: skip queue processing if notifier is cleared Date: Mon, 1 Aug 2022 12:05:54 +0200 Message-Id: <20220801100556.2217492-2-its@irrelevant.dk> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220801100556.2217492-1-its@irrelevant.dk> References: <20220801100556.2217492-1-its@irrelevant.dk> MIME-Version: 1.0 Received-SPF: pass client-ip=64.147.123.25; envelope-from=its@irrelevant.dk; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Klaus Jensen While it is safe to process the queues when they are empty, skip it if the event notifier callback was invoked spuriously. Reviewed-by: Keith Busch Reviewed-by: Jinhao Fan Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 533ad14e7a61..8aa73b048d51 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4238,7 +4238,9 @@ static void nvme_cq_notifier(EventNotifier *e) NvmeCQueue *cq = container_of(e, NvmeCQueue, notifier); NvmeCtrl *n = cq->ctrl; - event_notifier_test_and_clear(&cq->notifier); + if (!event_notifier_test_and_clear(e)) { + return; + } nvme_update_cq_head(cq); @@ -4275,7 +4277,9 @@ static void nvme_sq_notifier(EventNotifier *e) { NvmeSQueue *sq = container_of(e, NvmeSQueue, notifier); - event_notifier_test_and_clear(&sq->notifier); + if (!event_notifier_test_and_clear(e)) { + return; + } nvme_process_sq(sq); } From patchwork Mon Aug 1 10:05:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Jensen X-Patchwork-Id: 1662467 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=irrelevant.dk header.i=@irrelevant.dk header.a=rsa-sha256 header.s=fm2 header.b=t5EcFJnJ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=G1q7UJpK; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LxDTQ3k5cz9sCD for ; Mon, 1 Aug 2022 20:12:58 +1000 (AEST) Received: from localhost ([::1]:40148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oISPw-00067W-0a for incoming@patchwork.ozlabs.org; Mon, 01 Aug 2022 06:12:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oISJO-0001Ch-FE; Mon, 01 Aug 2022 06:06:10 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:57999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oISJM-0000Wv-Pu; Mon, 01 Aug 2022 06:06:10 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B511C320091B; Mon, 1 Aug 2022 06:06:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Aug 2022 06:06:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1659348366; x= 1659434766; bh=LgPzmVkdIvrOCWDn7ND8OkxWypGN7bdT3A7dXh2bPwQ=; b=t 5EcFJnJnyGRmBhSoaNbZdbL7ZsztCjDt95wT/JMQ/D6jNwdygRfBuU7IKyq6z6Ry 7KLL+HJvRJewQDhXQm/KTiqQWyB8za47QhEwuKLbw2UFtQaIHJv6xkV5CJ9zljVe eVBTYsTK81cAAPPgaYBQILo2e/Hjl7g0TMAxCWHUahHu8/+k0fu+4Z4hYkbLxHR/ yBQ4N/H4mGBniaO1dj8iLd0uMfIBQ0QjQJGvnlHUYjpSaFzJGSKtEXdj3KZitD5H y9SuECaP1+Lmvs5ZBJTlX5ufP78vM41sIUc3wU/ZwSgBCyqJi3rxB3MC2qYOGiUA SbmrCJrG0H2j3LVxS2o7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1659348366; x=1659434766; bh=LgPzmVkdIvrOC WDn7ND8OkxWypGN7bdT3A7dXh2bPwQ=; b=G1q7UJpKy/1OtfY5mZmySqfO7p/Rr W0PGAsADCQlDjQ3ENw5z3a2asLOfMuOvalqtQYEJclPcwhePITAv7FikbE3WUJtB 6v9kBX8szoqwRJJYJmNWu6rrzrwTM5oRTk8BXbAQbMsrNgJSimizED/hQ4TPS20w 7sRc4JFWA2t6avBIXmjPUsX2Vx+98BnSc73QfCs9TRVGJ/heu4Ao8A6ae1Q8nS8x VLA2wu/d7fCmWpJI3+NbfwU3uFENjI25B6QbHNrS/khB31rj3pjMo9Isr7WnrHW9 PiDGOeszbQby1D65NdhdJbcBFFJXv45/bxp2EITH6ogVAweRPSH4S9XFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvfedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjefgieelgfeiveehkeeuveehheekfeevgeeigfehfefgjeejhefffeegudej udegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih htshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 1 Aug 2022 06:06:04 -0400 (EDT) From: Klaus Jensen To: qemu-devel@nongnu.org, Peter Maydell Cc: Keith Busch , qemu-block@nongnu.org, Klaus Jensen , Klaus Jensen , Jinhao Fan Subject: [PULL for-7.1 2/3] hw/nvme: unregister the event notifier handler on the main loop Date: Mon, 1 Aug 2022 12:05:55 +0200 Message-Id: <20220801100556.2217492-3-its@irrelevant.dk> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220801100556.2217492-1-its@irrelevant.dk> References: <20220801100556.2217492-1-its@irrelevant.dk> MIME-Version: 1.0 Received-SPF: pass client-ip=64.147.123.25; envelope-from=its@irrelevant.dk; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Klaus Jensen Make sure the notifier handler is unregistered in the main loop prior to cleaning it up. Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates") Reviewed-by: Keith Busch Reviewed-by: Jinhao Fan Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 8aa73b048d51..70b454eedbd8 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4311,6 +4311,7 @@ static void nvme_free_sq(NvmeSQueue *sq, NvmeCtrl *n) if (sq->ioeventfd_enabled) { memory_region_del_eventfd(&n->iomem, 0x1000 + offset, 4, false, 0, &sq->notifier); + event_notifier_set_handler(&sq->notifier, NULL); event_notifier_cleanup(&sq->notifier); } g_free(sq->io_req); @@ -4701,6 +4702,7 @@ static void nvme_free_cq(NvmeCQueue *cq, NvmeCtrl *n) if (cq->ioeventfd_enabled) { memory_region_del_eventfd(&n->iomem, 0x1000 + offset, 4, false, 0, &cq->notifier); + event_notifier_set_handler(&cq->notifier, NULL); event_notifier_cleanup(&cq->notifier); } if (msix_enabled(&n->parent_obj)) { From patchwork Mon Aug 1 10:05:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Jensen X-Patchwork-Id: 1662466 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=irrelevant.dk header.i=@irrelevant.dk header.a=rsa-sha256 header.s=fm2 header.b=S1RYhkI2; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=QfuH30ek; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LxDSS1Nttz9sCD for ; Mon, 1 Aug 2022 20:12:06 +1000 (AEST) Received: from localhost ([::1]:39340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oISP5-0005ZD-It for incoming@patchwork.ozlabs.org; Mon, 01 Aug 2022 06:12:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oISJR-0001GK-9t; Mon, 01 Aug 2022 06:06:13 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:56693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oISJP-0000XT-MY; Mon, 01 Aug 2022 06:06:12 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8FD31320094F; Mon, 1 Aug 2022 06:06:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 01 Aug 2022 06:06:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1659348369; x= 1659434769; bh=gDF/qKIKZPKhM3ujgAUdpGUVAx+pT7cb6Y+fUGAVVBg=; b=S 1RYhkI2CUdj4F6KbroJRbqnfEUyahWIsT2oUIYloTAXO1SFUIsGyqR7XGbQSQWxV Kp3yhZ09rxtlhv2l2qBvM9rThdW7/5TJ8cUdoLD6Snsv6IaB/e3v0oMM65qJELEJ +Q30tMI/r4mvw0Wf35+rJpcaIUVjDp38AILRWt1LDpX0Kfe9cwg4uQQ7Tmsgp+Z1 iMC1cjsj97qrKeNKVYdUPwd5sifuBUrnHcxyYR02sMAW/+aF7oqf06QWssxEAQq/ ZvQV96wKzkZ5kZcZXcD2VuHxCTvUAJvx9SxfPI25A08KAkL3qG1e7Afr8WgIFhzD f22rnfuv8z0nC+UG7+8HQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1659348369; x=1659434769; bh=gDF/qKIKZPKhM 3ujgAUdpGUVAx+pT7cb6Y+fUGAVVBg=; b=QfuH30ek+nKo+bILIpwIhEG614EJO 9xJCzyW2oL7ymdb/CcX1KX0dlOV8wmi+puaI2pwsfnXRvXr/h6veg5yq9qOT2Utn fnM8KchlyVebZVdpLW2WYoNh648OfItECr42kJjBRlw8kB/+rFEuOQgbpQvvBP6T cOaBgd2CxFk0wf8nF5UoQWGPRWXQ9EwR3dYiBJrg1mkU508ITyTL3Iaz1T0TLiki XhAmeOipwX2MTU2+yLe5dauh5DRAoy36vuzyi/JSp0Us0NMHWfUukyylKGoFvd52 4onHcrxjE391CixPnfs1SHLXY6VhtZJ2cXo9d/lm3xsaLH2nyLzuV7H5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvfedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjefgieelgfeiveehkeeuveehheekfeevgeeigfehfefgjeejhefffeegudej udegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih htshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 1 Aug 2022 06:06:07 -0400 (EDT) From: Klaus Jensen To: qemu-devel@nongnu.org, Peter Maydell Cc: Keith Busch , qemu-block@nongnu.org, Klaus Jensen , Klaus Jensen , Jinhao Fan Subject: [PULL for-7.1 3/3] hw/nvme: do not enable ioeventfd by default Date: Mon, 1 Aug 2022 12:05:56 +0200 Message-Id: <20220801100556.2217492-4-its@irrelevant.dk> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220801100556.2217492-1-its@irrelevant.dk> References: <20220801100556.2217492-1-its@irrelevant.dk> MIME-Version: 1.0 Received-SPF: pass client-ip=64.147.123.25; envelope-from=its@irrelevant.dk; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Klaus Jensen Do not enable ioeventfd by default. Let the feature mature a bit before we consider enabling it by default. Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates") Reviewed-by: Keith Busch Reviewed-by: Jinhao Fan Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 70b454eedbd8..87aeba056499 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -7670,7 +7670,7 @@ static Property nvme_props[] = { DEFINE_PROP_UINT8("vsl", NvmeCtrl, params.vsl, 7), DEFINE_PROP_BOOL("use-intel-id", NvmeCtrl, params.use_intel_id, false), DEFINE_PROP_BOOL("legacy-cmb", NvmeCtrl, params.legacy_cmb, false), - DEFINE_PROP_BOOL("ioeventfd", NvmeCtrl, params.ioeventfd, true), + DEFINE_PROP_BOOL("ioeventfd", NvmeCtrl, params.ioeventfd, false), DEFINE_PROP_UINT8("zoned.zasl", NvmeCtrl, params.zasl, 0), DEFINE_PROP_BOOL("zoned.auto_transition", NvmeCtrl, params.auto_transition_zones, true),