From patchwork Wed Jul 27 18:54:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chris Bainbridge X-Patchwork-Id: 1661686 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TcUrfpOk; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=bluwireless.com header.i=@bluwireless.com header.a=rsa-sha256 header.s=selector1 header.b=HU+9U4cy; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Ltslt5R7Wz9s5W for ; Fri, 29 Jul 2022 00:02:18 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Subject:From:To:Date:Message-ID: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QzwWcmeESSFb11U7UH1tGSGSC23iz2IQlAT36D8j9eg=; b=TcUrfpOk95l5vQ Uhb2yK5NU/irWwX32M1wP4QmjvkE8wDBQzydJHtwqVgynpa7QrjYc8xuqY5YuGCnXjrtjcESAGBke oOHpoNNHWlKs8phMLdv/48AYBeXed/yb795Phgu/1zJkwvZzRPKJs3D5eA6X/9566h/BStrs+dBzA UK3binCImTGlpVie6zhxvywSItbq/zD79FixtmSljlnhzlZ+cE1cnu5YTBQoWdJyZI8pSRPmWTcDH 4caxtrDZin54XzK1fcUWUqeAXO6g2d5JRuAklESFWwx31sfbY94ctgYkUOd4VPvxD4SLkq+e3hMzK M3uNfhusIYNBAOuuas1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oH44N-009vYo-HQ; Thu, 28 Jul 2022 14:00:56 +0000 Received: from mail-eopbgr60051.outbound.protection.outlook.com ([40.107.6.51] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGmB8-00GloV-Ei for hostap@lists.infradead.org; Wed, 27 Jul 2022 18:54:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S52LEWgm7MS5zm7SoZP+oxGU5uGogbwn0xq368P8S0bqIKtqOM4T3rO41/xBPOkHHb1+lSMbs1I0mghTLIvYvGGo2SDMdfqsonYJzxA/QhNk+itsthJnXtno7mMe/Y3QYicydjmiwmWVAGfTlNtRvPF+FQeYb68YBTJBMF1N2itLj857+7+BRZyHuOEaV02gtbXmYlNfldcmdp9EhNY05QTdzCNjTrcIiLa+hlG6V+e8naSY5uWtv6MKhuTk2X146JVKNdPx5xZFg/NuNpYrhl6MTsW5mERi3e7z60qm8Jpp/dRWtyF8F51AhSZq1KBOoft1UVqqY04zswQQ5nCqxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=82kIYcwFV9FG56+8xlMZA5G8V5BXeVS9C2FKYHImLXE=; b=M/AvNA2Dx1qOpwKyS5nUIEgZ/CZwXfrM8FDiTT/kRu43fTXtFLpk5zt6ZBdzG5U3eAo3v2PdJG6U7Ri+1iU9JVLG61OsPHBKloszLrKS8yzWBKKyLCqDkoGe7LfC6B8OALKjDJ8RlUa0goAPInQqAdtoBNzSAJ4Wi8TO43I/cwwLJMwsVSlemvmADADupbs+vrFeHsuD+i0rTwogt8o+thHSFZzZMXOZEzgJ35lrVEIvrNeK1BX5szzSbQvdFiobKjXXM3MqWkLdpBDP1zTQW68yEJTxMFrkNc6xDpBdUQ7unTeR/KB5p+7sVmKUgEX3ZtPlgLQWEUcm9Pvlozza1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bluwireless.com; dmarc=pass action=none header.from=bluwireless.com; dkim=pass header.d=bluwireless.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bluwireless.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82kIYcwFV9FG56+8xlMZA5G8V5BXeVS9C2FKYHImLXE=; b=HU+9U4cyxm5yCrWrnmixWpvZAC6I9NzQJLnabdGCVNKIJ4pJQ7vVrS3go9VMEMcEgHFhQHWw5kwory9VEnLuJK5AMwoiKljoCp00Qcj02P8G2Rcy76fXuukYvjWUn0FvkbJW8xm1eHpawNdZLcobNEiowZlaeN5viZRi3eoW/OA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bluwireless.com; Received: from AS8PR09MB5301.eurprd09.prod.outlook.com (2603:10a6:20b:372::14) by AM0PR09MB4308.eurprd09.prod.outlook.com (2603:10a6:20b:14a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Wed, 27 Jul 2022 18:54:36 +0000 Received: from AS8PR09MB5301.eurprd09.prod.outlook.com ([fe80::d06a:fcbc:6a61:8540]) by AS8PR09MB5301.eurprd09.prod.outlook.com ([fe80::d06a:fcbc:6a61:8540%5]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 18:54:36 +0000 Message-ID: <090bccae-e466-cee2-df2c-346ee84733e3@bluwireless.com> Date: Wed, 27 Jul 2022 19:54:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 To: hostap@lists.infradead.org Content-Language: en-GB From: Chris Bainbridge Subject: Connect without scanning using PBSS X-ClientProxiedBy: LO2P265CA0489.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::14) To AS8PR09MB5301.eurprd09.prod.outlook.com (2603:10a6:20b:372::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b1ac2a2-6a6c-4168-5722-08da70017348 X-MS-TrafficTypeDiagnostic: AM0PR09MB4308:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQhz7syT1ztFUa+fkoeJuEJOANgWOiFVlAp5DXfkS0CxKhCkGvPjl3YkWTv43TY0xqGo9SazZEMisBVVVTMSkWVTLBvHBHMiQ/+XVEYURvFLkEHVEvcaLCZnX3W1R2ZtU+l9NCUH3o+dzrTLGnwsH4QGyM+BeUBwGncmBgI6kwfnxZICdtimY8LAA/+rvrJKPMqD1Y0R+IUFobUfC4UeUUToE7iLBaARbBCxxTnVnDRHvhe/aSmvh3tJo8nFIrl0aTwC3Lt4pppnlfOwuj8yyporVGqMg9tLS2kh20PRFZ4AqMf0E0PzhbkRTRZPrz9t9LdMETaYLqbGDVhI2k7/1TyWx/TsqARjhGIUh7rDq6Ya6pcd/a+tfrAXI4p30Q1TV8H/ay8MjZH7ZH0XSfEAL1OdzNmwI8aujUL8BFh14RfZpH1fGv0oAgyUc55HgvhEt/XF611SWc5Hbz5W7glLY58kLQiS4R/EsT1d78aTbYPGrrxGEhrF7gf3rKVbxpYtnCiCdmQ0pgpthqymmVMhdpGOWIlZNzytifVkw3wTJsLwYkdFqc60dJNsh3BhRT6/ZkLewn+YsyeKTMCdLUzWi9FtCseSaa2J1EYJi9cUXB+7MGDZBwQSf0NWAcKAceKj8t7oTHIVcIIEeRPb18JTIN3Fie0JltNKnDx6NVjp1zrJEiZechc2OiqcFSlom5K3y1q+KwiLQXgneC7RejQknnyeTM7MvMSE5jYCI3sMvTyyQZOk45GTdW47SoVbfyN27i4BabJAdMnWz9b/rBlJZTyKVVZImENS98zy4HG4Tx2CEsHXU3bsT2YPy4JRO6F78IU/XBei5sgDHMHEUOfS0g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR09MB5301.eurprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(39860400002)(136003)(366004)(396003)(8676002)(66476007)(66946007)(66556008)(186003)(44832011)(36756003)(6916009)(316002)(31686004)(38100700002)(26005)(41300700001)(31696002)(86362001)(478600001)(2906002)(5660300002)(6512007)(2616005)(6486002)(6506007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1Tr2Xeg6Q8OSNArU4Y9LWVo1HEc+?= =?utf-8?q?BRZ8qqx/mXON7QWIdysrJqifwBAoW/KJeQWCASVW/ijo24racr69D+lAtrPyFuO9C?= =?utf-8?q?cP4JwcLTPzrI87CXZ+QeABydOD3pthiHQyFO/XywRvxqU0TkexLYHPLsGk3HiqQGr?= =?utf-8?q?SJFaqpZi1tMp+EVigOAQARJtQm+whb+DjSV4/r6/3BS6foXnfGp0McmDvYmLvI1oq?= =?utf-8?q?6eS0U5NeBNH7Z6xquWOMfXixW8DnJqqrroKO3UlIT6iAu0+DI/Ch/vNT40/v+uUli?= =?utf-8?q?TWeHlbJxZYc8j5PwL1kBDNfdyORLQD6nHWME44XCmjiu3B+xHZ42+E9gfILSvWKhv?= =?utf-8?q?VMUwHNFAJrSCElKzV/JVGtgwx9nptN0QP/tRsTfJ+Rz5Z+cOJxk11dMtHvnMcm2bt?= =?utf-8?q?8gDfJxbvlPMlApay2VMlNLo0W4KHdd3WLEOsNZ2crN4AzW/msy8hsSWiqABpOUN4Q?= =?utf-8?q?YgffHKY1MSWyS7GonWj4u0lVU4Arohzjcnz3iEVMLsHdRcywz6wLpau2yHTINxakn?= =?utf-8?q?Z0DJQXV/AqhrWPtQ1utDO77SZP7kstnzffQfD1q9COXAdmCM4FwQGuMFiVdGHiLgd?= =?utf-8?q?iaJ2wVOzC65cr627Es06HY5qetm+M1dxmc3DhHG8+uteuypTDsXgeidwkZ1IXXMRP?= =?utf-8?q?1yMhspZGEs+4FdlJx/OUsEwWzK8NlqSLW/TjH/cR0swGwvG+xIXGKo3PaEOaGfJLR?= =?utf-8?q?NdH997jME3d9n5ORDseDCaQu0uS61phXYMYDM7y73UPiS0YPQ4wjppRNfvTIivA2D?= =?utf-8?q?toCWrTxCY8JTZCVvi8uOSzkIhoz6jjXfNQhR+JthZ9zYLvdIl9L9jTmATvNUuHUFS?= =?utf-8?q?I2efKux/US0kQ0I8w2b8sdbpsDwu5MqynyKNMlPRv20xNWa1i85ruBCuQrFPqugwf?= =?utf-8?q?BOOQXJNMojIBOjIhzxAJoEFe7gFzfHHK/I/12ycsV7VtrNCW/adR6i3NmKFskTIHi?= =?utf-8?q?xB7t95YKkqo+7zdgA+rTO97IrjhRi0dOAEMXS6h8a2FcFdd5+3Bk5eN6djOWfc3vZ?= =?utf-8?q?1JOP62KpYnz4SL3SSWCpQV/5jw10EIy/QkGXHbr7Jac3UVizPkFuzsO+mHr/IqTfQ?= =?utf-8?q?Umlk5ONjPSIJADnvfCXbOCdS92vHk5vTD4NiKT3q+XabwImENU5lOtHtCH7m+D33j?= =?utf-8?q?VECOIIOtBFVmoDrBUEXrZD7qQIOp2+JQSACGV3OVBE6gs3dmb481xCcW4v7g9JkuB?= =?utf-8?q?WQWHjhekUyuXLAy3Rk1ahfQVvxXzyejgkxWQvO7EXULF6mDltWZNCKN9UXzpV5zEX?= =?utf-8?q?1r5eSSKjlYAhS3J8QgDjVL0VU7+Jk1C6/8xIbIeqf3vF+CmKC3prOrdWnTAFA8CT1?= =?utf-8?q?3F2KzQkbGpbavNcy42nUvdk5muFyR1MEsLTXITYNdZrU6WvVrwRLhlvOG8SrTkhwr?= =?utf-8?q?OS72CL7zFhR1Z0Ds7tafpZxZWYFT0vMBwQ3fZn2fXcVmTLub3dae7sxf/Uss2o6jb?= =?utf-8?q?/HC+CzqN9U+nyzLBhEtSvVo1sJcc+bYDwyc5KTZC1ugsY6TPmV4+wGoFfSJhDxmBr?= =?utf-8?q?PSoyGk6rrP68lVPleCzCgpRA+dP8eLbmXw=3D=3D?= X-OriginatorOrg: bluwireless.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b1ac2a2-6a6c-4168-5722-08da70017348 X-MS-Exchange-CrossTenant-AuthSource: AS8PR09MB5301.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 18:54:35.9307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e906b266-f5ff-4368-b47b-0f526edbc2b5 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bKpiVFVUFGuPAIjVwtO71A4mQNB3/+31ysAlDqF+ZG7FMAfgJHf5z43XM7Wq/2F6HIK5dTtkPlnz3D0TFKnVDQOgLnZghgyKsVRElx52FYyJTq0HfMRKYI32EeuwvJSf X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR09MB4308 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220727_115443_030687_81AD4E8F X-CRM114-Status: GOOD ( 12.14 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, I am working with an 802.11ad system, which uses PBSS. I am trying to use wpa_supplicant to connect without scanning - for this, I'm using ap_scan=2 as per the configuration below: ctrl_interface=/var/run/wpa_supplicant ap_scan=2 Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.6.51 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.6.51 listed in wl.mailspike.net] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Mailman-Approved-At: Thu, 28 Jul 2022 06:59:58 -0700 X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hi, I am working with an 802.11ad system, which uses PBSS. I am trying to use wpa_supplicant to connect without scanning - for this, I'm using ap_scan=2 as per the configuration below: ctrl_interface=/var/run/wpa_supplicant ap_scan=2 network={        ssid="myNetwork"        key_mgmt=NONE        pbss=1        frequency=62640        bssid=01:02:03:04:05:06 } However, wpa_supplicant will not connect because it is not passing the BSSID or frequency down to the driver. From looking at hostap/wpa_supplicant/wpa_supplicant.c, I can see two options: a) Setting IBSS (I believe this is the wrong approach) as per the line: if (ssid->mode == WPAS_MODE_IBSS && ssid->bssid_set &&             wpa_s->conf->ap_scan == 2) b) Somehow setting the bss parameter (cwork->bss) in wpas_start_assoc_cb. However from my understanding this is set when wpa_supplicant scans (which I am trying to avoid, as I just want to connect directly). Is there any way round this without modifying wpa_supplicant? I have done the following, which works (possibly could be combined with the previous if statement..)         if ((ssid->mode == WPAS_MODE_IBSS || ssid->mode == WPAS_MODE_MESH) &&             ssid->frequency > 0 && params.freq.freq == 0) Many thanks, Chris diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c index d37a994f9..73f780145 100644 --- a/wpa_supplicant/wpa_supplicant.c +++ b/wpa_supplicant/wpa_supplicant.c @@ -3787,6 +3787,12 @@ static void wpas_start_assoc_cb(struct wpa_radio_work *work, int deinit)                 params.fixed_bssid = 1;         } +       if (ssid->pbss == 1 && ssid->bssid_set && wpa_s->conf->ap_scan == 2) { +               params.bssid = ssid->bssid; +               params.fixed_bssid = 1; +               params.freq.freq = ssid->frequency; +       } +         /* Initial frequency for IBSS/mesh */