From patchwork Wed Jul 6 14:25:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Immad Mir X-Patchwork-Id: 1653010 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=nbuZGTC4; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LdML46Dztz9s09 for ; Thu, 7 Jul 2022 00:26:35 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C43343858032 for ; Wed, 6 Jul 2022 14:26:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C43343858032 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657117592; bh=x/Kcn/GkISJckyQZjLOt7na6oxrBWDFKh9R7JkZreZY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=nbuZGTC4AXv6X5upFkSNhkhEnybM4bEWE4/WQ7XsjqE4Dh/mby1NayYUCZ3ev6eAe beeRJ9Wk4/cUMa2R84InJgieWXPcP4p9/XRZ8wIrEu9XPbEdqG12SPne+J56QsZTkj f5qxJYoWFBKehVHxdlRbZtJ26fZ09crkuZUl+gjc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2072.outbound.protection.outlook.com [40.92.21.72]) by sourceware.org (Postfix) with ESMTPS id 333B83858C39 for ; Wed, 6 Jul 2022 14:26:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 333B83858C39 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ppenrv8gZOcHlK9YHJgeHcaoadC9rbRGK4YXgHwGeTtXVeNe6g7ttABuIZFNVJiJwlKnQM2Y/HJweUoBdJWaSjdWLPho2IroVzyQ3UIBI/bP8RypMDrEQCkEApJdwYEB2jfCjIfJYnfEMpd9RepNLjUU6T5kXgCp6PdORy+sQ/pV6b2LmlzdcS/FAMfpigEb30ISt7/AQ/ueCY5zogpuX7sp4bCaKYqQvZh6CBEUE3G6Gn6riL/gNBXxbuFjgSsO091hXdh9pddLNts+6HEx/kKZCfQYdWjih0SydqDVKaK+rOtlgyPXQykaRG0pFLspuAlz2eX4CSJxcIYc61i46g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x/Kcn/GkISJckyQZjLOt7na6oxrBWDFKh9R7JkZreZY=; b=MOWPFZyyrfxZLf1sRshUxtjSE0fVac7UBIhK8KyYYGF+JwAjjftnHXQUJ5sSUdC2hDP8Vmm9xAdh3iJiFBdoEDrk3y/OCYpGDJky51UFPG0XR+Ra39Wf4uaPo5dgrdSrFirgQMiBXfnOALD7Ji1d5QTSvhLl0WhteM01tSXNXHhZLOy9dHEfOMKIEr+SRne1Pc6y4TrDMTVS1i67OaVRYp6jer77xzbZpHjwCCgKSjaypNYFEkZzdZPnKLOU+fuL0TxQvZ2q8HfEX2xeJ6sMNzNGti5DumgxUnSvP/I4EGmuWjpovmcZfyG1Z0zfSxACPd1iFeszAqFOLIJtTLk1OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from CY4PR1801MB1910.namprd18.prod.outlook.com (2603:10b6:910:79::14) by DM4PR18MB5098.namprd18.prod.outlook.com (2603:10b6:8:41::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 14:26:08 +0000 Received: from CY4PR1801MB1910.namprd18.prod.outlook.com ([fe80::b99f:e237:735f:8806]) by CY4PR1801MB1910.namprd18.prod.outlook.com ([fe80::b99f:e237:735f:8806%6]) with mapi id 15.20.5395.021; Wed, 6 Jul 2022 14:26:08 +0000 To: gcc-patches@gcc.gnu.org Subject: [PATCH 1/3] analyzer: show close event for use_after_close diagnostic Date: Wed, 6 Jul 2022 19:55:41 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 X-TMN: [6UvxMtgg1+//9WCEIcG2Vy764GUCF/p+9q3iYtX0hObWdnuhP292pjyfiWIPS92n] X-ClientProxiedBy: BM1P287CA0006.INDP287.PROD.OUTLOOK.COM (2603:1096:b00:40::34) To CY4PR1801MB1910.namprd18.prod.outlook.com (2603:10b6:910:79::14) X-Microsoft-Original-Message-ID: <20220706142543.3790-1-mirimmad@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf5b0d43-d255-46f8-dbf5-08da5f5b7798 X-MS-Exchange-SLBlob-MailProps: uIjBWfsAVx9WuN6j61sCvRWo6g6LUAJvnH+4pDHfQYXQ1eslEBBvTFbEAuPQjKKW8eHUP6t8h8Un8htlfGfPmL1VGc1aF01pyt7NJhnU9JoHLfmCpmyLau0zsoc+wilJhGt5m+z1tFPRF0liwjnsrySmDADtj0K6+and9dqnO9v6RP9ZznpVSyZaElLp/76iNw3Bl6aOV2ENR1zpohbtf5/wP25wY7MmNpfBZcw91mVOh9S750wu21DsCY8o1jaX60hTfZuehup5VgC/ynMWdCoSjMejxx5RgDyKH/1kaN6HXE5+hLSXlElD1ruxIrdi/kJsfsLfjflGJhvBvwi+XDtxwyPFTvlkkZmL3Ac1hw3Sni3TpDukbVDiXpRRdrKTrC5UJubX4Jq2n76Qj0vAub5X7Q5Xrds3XWu/2E4oyz4FloDnSkYBm8sY2WuWRsyV1DuaQmIT2ss6hu+IibGDn18zpWJw4VMpVCJGM+/kUo68v9Uwa/A9OzEbUdxlMbqKzh9PWluhgIfuwsR56WLQQws4wi0V7gmMPctXITD1k3cZWwMJZzIJH2BVZtf3tBnAqG2uorYIPu9mutQEi1af1eg2wDtjlk9Lgz/nr5gRuMHewlQRZEzETpRNQjDGuyyHwoO1E3x+43qN5SDE6jsaT5kyYvPBVqFYcXFsivlv2M+TPwfFzSD7N995imBoiiXc8oKWm2QqvZ+bdcF+uUolNA== X-MS-TrafficTypeDiagnostic: DM4PR18MB5098:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DOKdWQnHSYJgbytxoGgc/6yaIbUjwrXXbJVrcDigwtiYSFVnVDkNfjvNOP5DKlNAC9jGWf98YCBRGvx7CYXAHDFaVrG/eq8a+S/PZ+kCLdeFwKVKBFuk6MjJIP0xkgaBbD/xCxmIhmEcHEpqTnhgPEt8CYwEZTLtN6+TbjBinTJ/EC4iZRAA2UVNM6ToIsw4SAKUXLYRrS6H7BCdgjQzWnyS0SE/jBinNNpkCbz8qzfbWg5PAGROQFtCP+zqa5Le6OC2Z80xQabwM2qxJFVYVze9u1xGylUOX+irWRTb/QB+3B3axQ0wQNp/toZZRPJLJsBwL2yUxO+0yHzVAkZo0y1NEahO8zxShSHNazl1MjXvOt2DnbcV4KqUmhUKQ/Lp8WuRZBAg6TzcFlET37VjJnNprMnv3ZjOUYq7UppjqGLnoqSzs2VnecLdNKixbeZPRh+zeNN2Cr6M8WO856feL7OOfaar4i2eE5VuQvqExh3z9xT7GYReA5LRoLUsGKswx3GBE76kJU+XKMeNpEiVQP2eAQ1BPDYjA5o04QJjcmQz3XhDm8Be8gf0iXzwwUmCcyMwR/ujI2+Dz1EA3BMOr08NkZY8Y1rww9H1xIH/1nnULJw/BwetzqIFyDtiCPmB X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZjO1Wvq4J5oirchou2c6UFJ6X/90TH/+xwUcD6coRxlBVDqEzyJVtv7wdfMOvYu3yWjmvo49wY1a7yodSIWaqQ5iMKADgX/juPmelTk+nLJzyREo0jgUAmFidfsZfgmAqu1QF0EbvliZQLY2oLLjM4oDOVdsPQ+wSEVk0byT/Awgv5zgBJsUrGDYAbLtK8wFP1YLEHSadgVZDSf/fdmcklzw5RfRdm67JH5HIkLDqgtiVZq0HmVRzJqhM9ukXnQPZFkfxntxAbrWOzr1Olq+aSHsH24TRs4dW9tQMrQLE87OljzTRmLbLOf+PFe9VMXSBmLomeuZY+VrTxqQSirHQV8vvlAJ/8peVJ+A3GhHLyOyOW/9QiMrhiQx+n5YBTCJXRBND7rUJ8hvVNlsKmXmFXakuIS2wWaz8Y8eK2+lN/JXaCQ0J6B265Pue3mm81DmeT5yiWGVtHmtsFBZMqJ8iDxQwkVqlDfych1F0dDKpzXelCxz5UyiC5ZM39XV4j3et4UAQT9ueU1seI0Q/lwu968n/sjn7ivDlhX56RXVU2y3/QTyU3HvKhwGcqU5OuXvh7AXNjX7sbmUODD2CNDKPI+aAgDfhyBLk/yUWTTco2FXPbKS8ualHv0h7u53AUjAJ64UP6xskr3dmLA9Fh/QiiNR0RAoaAikBqF70vMsBYrC5JIeoA8s5SL7X47upy5rSHxguhDrtpm1SL5AR3qUYz2dPzqv3OYJJ8MQLZUGCrlywfC7DP+1ucfTVv3swaWumXl4aM23aPZR0FJIEz1QiWXHuojbTEzvRU41zzVGNrJD6hbAv4ODMo2ceREkgROQmRQLX8nQHBHLwirkuz9o1X6WNeNCd2vCRqyE9v5G/Qf3Y700s/MeSoyTLhH3drkH/XxQZfaII0sLFszpyKi2ubzBt074LD1huHZfz80yUcdbWHXp4odd5qHU7N8fx66D+L/jZJMd4ggKmoINbV5thlVxuGXLIK5GXDdZ8tTGGx3V6LO0wQe9uXrAdeKQTjS1VxN9ZrYunVgcSyuGq3h+YzXBdupX0ijnOPskDi6PeHa7Jg53WSgmd3tkywuhGOMFiJby18/M2vmy4lHvUamczf13FkvVE66xev3dGBnvPcnFaFlnBQVe0oPdoWWlx0NBUGy89jC0EP5DYYv1AfUoBxi2c+SrCXxOeDZJRpAZ0u7blPMZRXXH7Fqs1pe9SJQ4Xe0Uv3wBAMNcgvG59Gf7OMcScFOxgG4hYG0sccHYUA++mgnPGBKezkU9qrWST+J/SfYzqVP9Xxa9E9NOxq8RyNczdgil2ngtXreMn4G8ZjJ9GwFqhvHZgP0DQNx3jSfh2PkuDRBHRMkwGqyF5utwiw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf5b0d43-d255-46f8-dbf5-08da5f5b7798 X-MS-Exchange-CrossTenant-AuthSource: CY4PR1801MB1910.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 14:26:08.2171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5098 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FREEMAIL_REPLYTO, FREEMAIL_REPLYTO_END_DIGIT, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Immad Mir via Gcc-patches From: Immad Mir Reply-To: mirimnan017@gmail.com Cc: Immad Mir , Immad Mir , mirimnan017@gmail.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" From: Immad Mir This patch saves the "close" event in use_after_close diagnostic and shows it where possible. gcc/analyzer/ChangeLog: * sm-fd.cc (use_after_close): save the "close" event and show it where possible. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/fd-4.c (test_3): change the message note to conform to the changes in analyzer/sm-fd.cc (test_4): Likewise. Signed-off-by: Immad Mir --- gcc/analyzer/sm-fd.cc | 15 ++++++++++++--- gcc/testsuite/gcc.dg/analyzer/fd-4.c | 4 ++-- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/gcc/analyzer/sm-fd.cc b/gcc/analyzer/sm-fd.cc index 4058ac53308..8196d33223a 100644 --- a/gcc/analyzer/sm-fd.cc +++ b/gcc/analyzer/sm-fd.cc @@ -454,7 +454,10 @@ public: return label_text::borrow ("opened here"); if (change.m_new_state == m_sm.m_closed) - return change.formatted_print ("closed here"); + { + m_first_close_event = change.m_event_id; + return change.formatted_print ("closed here"); + } return fd_diagnostic::describe_state_change (change); } @@ -462,11 +465,17 @@ public: label_text describe_final_event (const evdesc::final_event &ev) final override { - return ev.formatted_print ("%qE on closed file descriptor %qE here", - m_callee_fndecl, m_arg); + if (m_first_close_event.known_p ()) + return ev.formatted_print ( + "%qE on closed file descriptor %qE; %qs was at %@", m_callee_fndecl, + m_arg, "close", &m_first_close_event); + else + return ev.formatted_print ("%qE on closed file descriptor %qE", + m_callee_fndecl, m_arg); } private: + diagnostic_event_id_t m_first_close_event; const tree m_callee_fndecl; }; diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-4.c b/gcc/testsuite/gcc.dg/analyzer/fd-4.c index a973704f403..c992db619e7 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-4.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-4.c @@ -45,7 +45,7 @@ test_3 (const char *path, void *buf) { close(fd); /* {dg-message "\\(2\\) closed here"} */ read(fd, buf, 1); /* { dg-warning "'read' on closed file descriptor 'fd'" } */ - /* {dg-message "\\(3\\) 'read' on closed file descriptor 'fd' here" "" {target *-*-*} .-1 } */ + /* {dg-message "\\(3\\) 'read' on closed file descriptor 'fd'; 'close' was at \\(2\\)" "" {target *-*-*} .-1 } */ } } @@ -57,6 +57,6 @@ test_4 (const char *path, void *buf) { close(fd); /* {dg-message "\\(2\\) closed here"} */ write(fd, buf, 1); /* { dg-warning "'write' on closed file descriptor 'fd'" } */ - /* {dg-message "\\(3\\) 'write' on closed file descriptor 'fd' here" "" {target *-*-*} .-1 } */ + /* {dg-message "\\(3\\) 'write' on closed file descriptor 'fd'; 'close' was at \\(2\\)" "" {target *-*-*} .-1 } */ } } From patchwork Wed Jul 6 14:25:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Immad Mir X-Patchwork-Id: 1653012 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=iW1E8R0t; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LdMM93rY5z9s09 for ; Thu, 7 Jul 2022 00:27:33 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3A68D3857826 for ; Wed, 6 Jul 2022 14:27:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A68D3857826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657117651; bh=EPTIJfKHulYVq7vt+N+nCmSLS9174jI2cFWm56589s0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iW1E8R0tMurgJ5o4gU93VK+AzWTt07O+fpYPCWuCIQhEyuC9psjkmyb0p9Jpy7BGL 6Zek41GaNve5A4YsWfcLZFg0P7JViFtaQU8T0kJWh5uQj45o40Mwjey4QWJJrNftf8 tQyapUvHA+yTVreBDsy9SB60MtRKeMnv2lIEDrag= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2039.outbound.protection.outlook.com [40.92.21.39]) by sourceware.org (Postfix) with ESMTPS id 1BE593858C39 for ; Wed, 6 Jul 2022 14:26:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BE593858C39 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QB9hkVLWk3aUARBRYf9GE5Q5mIHK5XLlXV0JFKVUAQyr58+fKquuQ5QBcJ6b262gSidUWEnd3LF5q6K2L2PnHaVUR+QXyZYYkxwzmdQ/7ZKV3RA2HTKanChngJyrN1F2MGw6P2+eKMOju7s4VcBHI85memIAhIxXSbukO4rSzGnWJFvYb8lrxZkP+i6GGhVQiT7E7UeSyFnZu3fWFmOR8mgyeKt2DIvDP2jz67rOacWEYs2Ixd9rh4K2WWLi5JnOzPHE3XMKF4hi1NPTnqHX74Ws1qtQgYznRTAGQ7qgpYKzIzOTzu/v1mS4PCKWyCbxlmjlnSWpnjcToakpkIZZdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EPTIJfKHulYVq7vt+N+nCmSLS9174jI2cFWm56589s0=; b=kBbJT/Xce3Kd/LyTDgJRlBGR+4gzP6akMSb/xa+i4Io4hEYmLudqR/s3WS/NzYMEz1MPy4/+mZ4HXBHFw5XBrDACkxpmegf2UOtnZq12U053GUAwPMK8dPOYDy8o5wu1A+ijLi8+AhMoI1mUVdPQf5cV7U4mw6vMLBrhfxm0PbooUAK8nG2NVpcErReQlr8Joj76+TB+y9bcq6tcvjhHtnqLJl9qU0M8eGRynUhyBvggq+KNiR5QeIN3DCe409E/JRqjOp1Vn2swx7cJrjNUzcN8BXliGUFzvUjJeLyAGUZk6Z8yew5WNjhqKyV1oQASbcOgOPv49g4scSvl11TGHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from CY4PR1801MB1910.namprd18.prod.outlook.com (2603:10b6:910:79::14) by DM4PR18MB5098.namprd18.prod.outlook.com (2603:10b6:8:41::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 14:26:12 +0000 Received: from CY4PR1801MB1910.namprd18.prod.outlook.com ([fe80::b99f:e237:735f:8806]) by CY4PR1801MB1910.namprd18.prod.outlook.com ([fe80::b99f:e237:735f:8806%6]) with mapi id 15.20.5395.021; Wed, 6 Jul 2022 14:26:12 +0000 To: gcc-patches@gcc.gnu.org Subject: [PATCH 2/3] analyzer: reorder initialization of state m_invalid in sm-fd.cc [PR106184] Date: Wed, 6 Jul 2022 19:55:42 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220706142543.3790-1-mirimmad@outlook.com> References: <20220706142543.3790-1-mirimmad@outlook.com> X-TMN: [aIL1pwi8xGfXVW/zDflP8Jq5IDBcQWpfyz/6jftlad2HMpENxgBHJgCB0MaVrKnJ] X-ClientProxiedBy: BM1P287CA0006.INDP287.PROD.OUTLOOK.COM (2603:1096:b00:40::34) To CY4PR1801MB1910.namprd18.prod.outlook.com (2603:10b6:910:79::14) X-Microsoft-Original-Message-ID: <20220706142543.3790-2-mirimmad@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0949be6e-21b5-43bb-ee97-08da5f5b79ff X-MS-Exchange-SLBlob-MailProps: QMhK0M23Qm4yotC2YDKCffzWFbyzoNaGim7MdXJYXZg3uVLLJh3dl/spJgBwpph7dh1Y5D/ViKaaui68KMdL6Nq2unCvE4LYVJLXpafFoIZKC0B6DUA0Xs4svg9Gm3QgkBqgql8B2Njb1GwBSjCrko5OynhUXEj02C+9PB0giyPaI96HeDPM4ARpDlDZMHcxlKlZ7OhQBUSXYB8B2kfXdtO9A7UV2b/zDN8lYamFx+sGmjMNIckKHX5aY9I9uz1zVvfYdJgcWzgp1UhXJQNvKCe8Bl35eHiUrj2nSAG0rjsE7AmQSbSBtO8RtaGsU4+a7eQPjHCHN9cu9rpMYczKUUKY5CSEdBG+3PgYdKFGNcaVjJ66ia8QpoV38xDBoCY8+Ek9cJG021NJegi37LHqqx8ZHPtyydPkCg60csmh+0rEttRu+por8oizyFuzx1iFaXt6GV+tbEkPd+DTH9xL8QGxnCiIPmI6BF0w1bzKRjy5+TM6Jv2kSr/zJyRfeNZ088oFW1DZIDwqPlenlNPCQf8pY3CHONTpbAJsj5JrJA83ftInLaeigrAdNJnr6aF2BF+J7SJxIM9inOxV1jWQqQntER6HNKAZrXbGSOwdGImBqOrheOvlV7DFJhR9bZe7uhCUBF6srAmZjWs2+tBw38N1LBJrZcGjLd8PZIrfgCmHOx8/uGGpx63D6/SudQ6WaQz0UG3/kpFdu2fAybvFE2PUkAOEwj+cYxK1+aODuttcXKU25O2H1yOxEKKUWneRfYNUrypk1bsh8x/xweTscW7rHHwj3Th/ X-MS-TrafficTypeDiagnostic: DM4PR18MB5098:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6B9mNYTHJw7tJT97kpLBaQt+bRd4zk/qB2EtRnp2tmz0VbPQVwMvwVEGuCZGjoIWGxqVRHlaZLQpW+Nx3iVEysk8hXUA2yYdy+v4eB5gIB3eM0ec+z6puHMqdB0HYThhgP+CGCr3scxXO/235KpqygmtURiAZ+8Nt6u9L29ZzYXp9KOx0ktRayexH80anJpAcVgDyNIyJceDLznrKXWLID3nETdOHX+WT7NR2D4OB9JzufT+s+w/42XSDBTkv7Qdis6sTepVPdU9YA3X88uVotGur8lRcLNGgOPIIiYlnO1N0WQIEmvB12cxPhA68s8TnkNHJg3zI512Qkh4erVyxMR3vc20G3CI4RQa9KSpUVHX+RzMpk+kMQYaap4zkTHzDvZ/ZYBWE22vlMD/K1ea/BY1F51cEGEjlQYprpra8BeJzNyvcWENRzWPatGd29Suc+MS3P8Hu8YTB3no4YUW7OZ4QiZ++bVyLdPBXrGKoj/17Pu1NJ69DWBlmIdvMkaACEvwtzq/2pAfLKfpP9KIDVosQi4eC5ptfozbS+Q4nWFKNtQpGpoF5HksRXfOxZVbMMJNpscx2Yfo54woXwXNfLV+ul5OFt9JnhxdqEn0a4MLOKiRw+7KIdsj5cJ3nzp4m3FFrNH0QuqSL5tfOodx/w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jweKSqjO5zYgDIgIe6BmQXT7G3helQUDw6LviY/oWdgR0yges2/TjZN9sUBy56xL68wAtmvhzjrs5y1ro2NXrofxmIIhd3hu8emYzl69VMs4lGZtQQsLdK8vPnhV5xZaUxToaZ6MyLe4D12GdoTro6sYi/uZxsrnIJRgivZEuALRy/TQ5XWzsMU0rpo5kgrjOcwLhZfixGFyfxkGVUpSZDD0hQhafsbPhqNaswAEvggsAWlN/1jVlmA5Gyaj/hkxwDlHvAvES3zDrpSgHPS/JmChrWq7mrKrl9bk5MbSUhWEiBS7aFvYDML71uxR8zLj0NEy8ykq35doV2dwE374/Pv0xp4ULM0Bk1m0Sx/m0ntO+MA18QrP9ATx8/5xBEA7B6/kN37+37ASWlF3Ck0j67qtaIPM6wpaaoBqUZgHC8mYeTGho1wsLWW6vvMYe7YHiSAmsFCRQmXXcLV6MaYqIdpuJcKo51STGaV/Hw2V7IkWRAokSAZV2/B2guQfeGPLZJ7p2KYkPi+DfT9mMTYC24Fk3ZIEPah1mvOXBjfDEFgJlnraR2GOVZFFk5bkzBFAI2T8tnUwy3YcDrXgBoQhAtzQDNiu6U1uSvEm6Psz9BWqJX9YvyQUBDRzwiRDgaiaw410ov3vaCLfrukec5IdF0MuCBCmiOXYxIsiaZvkY+yMYggFoSC5Pq5SWJ+jLTajGHrjW8R4C3n2o4YJl1qVAVss3/KBzLGKNKp8dbODvZVjQgYojAa3WT2utLW5+NnyerWoHUzh+S4/szbJ68DecVUHyFk1fp3I3uLmx3FmzlBTVaCvgcu+H2dqxD4zuNyusTmS9YOqp0Yn4m5owJwRIO/r/oMg+Kl2pZOhwHseLiOTG2FWQaJTN1OZ1W+yxloN/wo1kKrIDoEJJWAICMoBY9BOu7ZBTgTdpfQrKLNuQViWzmyhewEl26XKiIxPA3Ei8OrvFBdADPyaqFyxq3vOmGmj4rB3K6A/zrH5/10C43BVFWq8S1JgSoSyMs1r7Mo73Yfs5yOaTydoWz09IJv75TGMwZejO5nZYsftbSChOotgqU1sIjV5WlIUL5e3CVJn0IcA+gLWcQWniMinEj50tw8WYEhPBp2nrCRzzd5tGpKHC17oYpAFWyWZJE2KyW3RVxVKFkHBGltg/sCQdlo+TZjDgpr5FQEdhNq0QqDlVuLc62eh4LozF7uJYyaknZ4jQVZs5YqsWxo5AGNSUCz/Yh+sz7UqwPYtlfa8s4VjCm4RlZXCppf5IrfkqOqiyiSF+Bxyuhu9Af1q3GKTuHfYcTy+39FlwvITKQ48ufiWJi1OOT+MRNywbnjZe/jR46QsxBThCZOQNossu0cj6iZIwA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0949be6e-21b5-43bb-ee97-08da5f5b79ff X-MS-Exchange-CrossTenant-AuthSource: CY4PR1801MB1910.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 14:26:12.3106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5098 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FREEMAIL_REPLYTO, FREEMAIL_REPLYTO_END_DIGIT, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Immad Mir via Gcc-patches From: Immad Mir Reply-To: mirimnan017@gmail.com Cc: Immad Mir , Immad Mir , mirimnan017@gmail.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" From: Immad Mir This patch reorders the initialization of state m_invalid in sm-fd.cc to conform with standard practice in C++. gcc/analyzer/ChangeLog: PR analyzer/106184 * sm-fd.cc (fd_state_machine): Change ordering of initialization of state m_invalid. Signed-off-by: Immad Mir --- gcc/analyzer/sm-fd.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/analyzer/sm-fd.cc b/gcc/analyzer/sm-fd.cc index 8196d33223a..8e4300b06e2 100644 --- a/gcc/analyzer/sm-fd.cc +++ b/gcc/analyzer/sm-fd.cc @@ -551,11 +551,12 @@ fd_state_machine::fd_state_machine (logger *logger) m_unchecked_read_write (add_state ("fd-unchecked-read-write")), m_unchecked_read_only (add_state ("fd-unchecked-read-only")), m_unchecked_write_only (add_state ("fd-unchecked-write-only")), - m_invalid (add_state ("fd-invalid")), m_valid_read_write (add_state ("fd-valid-read-write")), m_valid_read_only (add_state ("fd-valid-read-only")), m_valid_write_only (add_state ("fd-valid-write-only")), - m_closed (add_state ("fd-closed")), m_stop (add_state ("fd-stop")) + m_invalid (add_state ("fd-invalid")), + m_closed (add_state ("fd-closed")), + m_stop (add_state ("fd-stop")) { } From patchwork Wed Jul 6 14:25:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Immad Mir X-Patchwork-Id: 1653011 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=VM7Z8DaJ; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LdMLD5GX8z9s09 for ; Thu, 7 Jul 2022 00:26:44 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 307683857BA0 for ; Wed, 6 Jul 2022 14:26:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 307683857BA0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657117602; bh=SBYZKxsgc6G8cDniHFThNSNl2/YunTw0yWR0qNcWnRg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VM7Z8DaJh1W8n52Rz1FswCeveQnKullvWbUQoFge3BzrT0T/qzQwZSj2GWxByTez3 6qsFAjvS9Ts8qJD0VT5OoA4VRUy11ntG1rCajy6C6OTGo/Y7T7d+5+Sa4gtHe4zdhm PE6I7Iqn4bFiEte2EKhf1N2W+kuX19rXGrKBtX5o= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2042.outbound.protection.outlook.com [40.92.21.42]) by sourceware.org (Postfix) with ESMTPS id BD09D3858408 for ; Wed, 6 Jul 2022 14:26:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD09D3858408 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyO8xbCDP3VzzqpdLjkJ7abMGsSme8JvX/Yqg4ggR+LN0nAcRKe/IrrSyS45RaL8V9mBPZNKpxj6Mk6v62IBoWNJZVkoKomXbWgK6uG0l9ozvj/ppPYzRCiHNZWnHB9YJYygiOjfhewUfTRfo+gT9pp5Grw7FUWJSJa9Ps2JNFRFFhEoFGOVnfhN5l4YMBLVdKKUKsoJz/KSstw8OeXRt7+9ZWpZ/lwopd1PJnYIZAUpk4W03+xHEx/Ey/Fgom8Xq+9jalF76KezqBUsOu5u/Q+Y8N3IzX2Nq00SvC92w7E8xIYpbPmBbcJiwuUHIXC/pYU+/BaCBwYiSryEoFK92Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBYZKxsgc6G8cDniHFThNSNl2/YunTw0yWR0qNcWnRg=; b=jc54eUYw+xxcTuu1gU6xtHE5QbZkQ4P6ID40XcbAvIISWO/ALtSX9R5wqOdqPy1nGr2Q/JCeJ9LA/HWz1HtIV7I7m2fSC2b1E/BeXujXS/x6jdGeyIS5Xvaxy0p156oxfpyL9F3hRsNazni8jWz4MaEljqpJe3BMIG5u0iIUA25c8l6+89nMZgl+1Q/5i4r1dTwyP+QAwgeQzABpn2H6VCP9W6HFDtgxKUc3DdWglvSh+ruzrPpuK50M0DAozy2fYagxujMovzsKXzIdq5sxtSZ8Tzi5iGRP2mlYNWZPouEyOITU1z8d27QCtj4KPOeUO4YiCojFCvaRTkivmWuDHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from CY4PR1801MB1910.namprd18.prod.outlook.com (2603:10b6:910:79::14) by DM4PR18MB5098.namprd18.prod.outlook.com (2603:10b6:8:41::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 14:26:20 +0000 Received: from CY4PR1801MB1910.namprd18.prod.outlook.com ([fe80::b99f:e237:735f:8806]) by CY4PR1801MB1910.namprd18.prod.outlook.com ([fe80::b99f:e237:735f:8806%6]) with mapi id 15.20.5395.021; Wed, 6 Jul 2022 14:26:20 +0000 To: gcc-patches@gcc.gnu.org Subject: [PATCH 3/3] analyzer: add a new testcase to demonstrate passsing of a file descriptor to a function that does not emit any warning Date: Wed, 6 Jul 2022 19:55:43 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220706142543.3790-1-mirimmad@outlook.com> References: <20220706142543.3790-1-mirimmad@outlook.com> X-TMN: [90Vzu1oM9R6Ac/Ixywc38GSllf3cw6b+sf7Z98MWnlGeEmRYH7I4j/7rM8W7JRVB] X-ClientProxiedBy: BM1P287CA0006.INDP287.PROD.OUTLOOK.COM (2603:1096:b00:40::34) To CY4PR1801MB1910.namprd18.prod.outlook.com (2603:10b6:910:79::14) X-Microsoft-Original-Message-ID: <20220706142543.3790-3-mirimmad@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8bee9b3d-a76d-4f8a-5fc9-08da5f5b7efb X-MS-Exchange-SLBlob-MailProps: vKxeIzzER/PJ+P2h8D2GJuQ3+u+q+BtTmug8GU7+oWvDQhPpwU3Y3n/1obNNWyi5vzoS2cdkY8vYwihH6g/Kjnl0EUYLeElxkCDck99pqBv2MPXvDWBhdg26vg8mfXXG4UYllgOpRkqoGpxtCl9vqzd/iid7SKMrS+ojJdatasFDIyFMKKITNfzihdV7Fz2mfuuCuePvFkcD8sUCd6bduB4AeXhzyIAFmjutwjuB/EyLI1vvPMbg0ZiVflXePqgvfXxhXSI5AXYK+BpVKhCIWC1FWM4jzEvdjci7SxlV92MESQZhhiNW+e5rLeZ/sVDntW/qnATkhJlJKeJ9DSxCFhuHkx6TnYE8YizTnVwWBCNK170wJ03BaktZbMSAjlFL9mJGTqKuOFwT8ZjsmfoVqPQdguFYWe3AFt89BCr3Z+bnLKwsrJBB651Zfi8AmoE9zoSRUIiCnSLIVLS4vL7/9Jbn+LeYt/KrVpgv4CHoKXdm5EkvYwddPQnEsLkVYhzAqmc/Oxrc0p0CcQuGzcyK5AS7ob4g9GhAc59B7Z4Y2gCNfYQzCUdCBSGbFTVtuytv8J3K5HloTSRJ7Cj0UgUl9b5qlp5D3Z/xrIIOHeahTdjBDG4XyfelNi7jXPaxd9377XGwtcAmev/iyZ/Dgv/xaJh4hxiZXVSlPoVHV03jGgV9RXmJkaeEKAXIpX1VSgj3Jodvb3ue0FTdXtESyO8vw8DbS/R/WMcQqH5zURhc/vaNv/XcZHa0gypEfTI9wjJr X-MS-TrafficTypeDiagnostic: DM4PR18MB5098:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F3Hq8oHs+hokifUDYtTJA9q3Xx3lsCK5JZIEFp4WyQxZHoy5N0hu0xnj2PbLM5Go9kHyjcA+41xfCuqdaPQjA2XY17W5il+FQGJei6svOWmdmtG06wRBFCNtQ1RZVn0Q+7Q11vylxj5Ryji15AbW22LmchERBxzc/+rFs4PEPZByIKMD0zxKKjKCzo7yRIoCawmJIxenDyIEosuUUpvBh9c5aBLwJRz2buJ1hG9XE/2idJh+Te0OVQxiWBUoYGEL7WuL4mPvRlkHb1CEwWzKiQNROeGzNX5Bz44W9vbuYI1FNLL1A2V0UQucVJAxYNPn9DvsTzG4WQb4jtif0FUjDV7FrZijnT8W4zGy5PDRdH1ePxlOCe1J9aD8BetPmVsX/bvB8S589qtMpaUI/sdz16KTqktyeRY3uIy9o32fZh52NW1FPZ7weyctXCmKWuEu9kVNL91LFZ00jFBdCZdvsMCpxX+teZwKnoGFYS9eeaHfwv3ezsF4KFDv5LWVEMcMvI1Nee/Tq26upwOzU8PX/L8u3dlFryuKAL09Ymibug7/bYEOZxmzD4++2RZbBsZvrIHb6GU/f1ibC8B4PAXQ17lajaZ0cbM2kfGaE/A8IR/5Bkcev5e1Y6BNmm8+riks X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: AXGHm1fojPL24tzJd6fdFrC5KSlQIQ14xxr8pdxQMBxdmjcFLRxxKy9EBcNZzWRt1+GoEUMUziJhjoLU9fGl/0Q2xN1nCHFjDgBdZNDgO3VjPIx/jkKZgBTwYfRXgOmGwvECF/aroOc8bwER8u3C/yvf6cI21qeWCPH+qaVcTV4YO2GTgu6y0BMG/2jK6cZxtUtfn1OHTUmjz6LZIm+qVIT8oAc99CBfZbuPjKbQMGugAJ1feK7wqxhBHrnj03/mhFiHxEB1bjYR454A5hpCld6m6+oaP8BuF3H0i3FpUl6HSSR4/XfUl+33tIuFjDm4GBtnN4yNp8d8Ub3D1IrB7hOcN48DfCdWK2aEudqcxCcGV4umBSOrCN6ZU2+WF9/Ak6MNKOWIk3e/tVHNtZwOS8tvheqGYav++MkdBuYmG72jSlgrtT2mcFzNZGh8LsD3BthFrEubscmdIIOIbufTXrjpzqmN0D43RQZ+K40VxCV+zXLReBp+s1qFzlioUTDxZOFMOdgdjHwMuFD7eKlj5KpiXNJsbLhBCbRD5GMUZ4eXxQxztzi4Uk/o5oSumZk2zan1Ai8t77U4hUZ2k+AYTcq7RB3kUsiBb8QC9zn/zM2+LIpg2aV+fOYhqrFgNCavOJD15iufcHro/t67UZNK5HC3dqQMzPmmr6sFXPJTJaouBhaNr2q84akoseztWccHzRvSyQ1ifQ/CEghXTnpWGY7FchabbjVn3JjUyuFLeUuHUu1steK8V/1+DQTFBggh7vTTZLdlSnbKHlzG8gxHnhd2yxcLj+E7VHHiMoUbrt2m3D2028QeG4n8DGPeqy379jk+tpX1bodcfblLDEQgwgm9tru3sCvXp/80LYANsfXkqXiOgJYBULKb+HK9QDz0nTWfmj4Fn7uMVP1XFcR61v+F1emJPh9SofOEiEpBqByh5v6XdyIMGF+qDJbdemYyL7tePOzSK16B9wyLqrI72p8nVd/9csGMRwNycZ/fx2j9+oOnwtYgjycwm/nEkGTFRRs+WzHvKnw4zRVnd4uyF3sZ4sL9737BzUJRwLkNaWzSvgshfU+XiD8CxdWsGEUCl3qJKiah+QDKNWHu685KXiUIZFhyBDTTi1JeDzCc8DRnZaLNIZss46eGdQWBK4hwspS1kcysyhEJMFiq+Hz09jIXVLWLQL3mjMdgIe9TiKyHPsNMlzjr44q/go7VFhVYFj7RK0ENdMJwAE7QzDbVP6rnv0zL22Np1wrrBv3kzmRFnrJ1q9HzKk38b2FAYgjMeIl9uG7xjAmU+nN2VyN3pcwjhhEZDVNRfZT+5HajzD3WtBr/CreaxCuMQ2UMBgelDVNnuJwxxYZL78gIyVRCzg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8bee9b3d-a76d-4f8a-5fc9-08da5f5b7efb X-MS-Exchange-CrossTenant-AuthSource: CY4PR1801MB1910.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 14:26:20.8412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5098 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FREEMAIL_REPLYTO, FREEMAIL_REPLYTO_END_DIGIT, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Immad Mir via Gcc-patches From: Immad Mir Reply-To: mirimnan017@gmail.com Cc: Immad Mir , mirimnan017@gmail.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" gcc/testsuite/ChangeLog: * gcc.dg/analyzer/fd-4.c: Add a new testcase to demonstrate passsing of a file descriptor to a function that does not emit any warning. Signed-off-by: Immad Mir --- gcc/testsuite/gcc.dg/analyzer/fd-4.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-4.c b/gcc/testsuite/gcc.dg/analyzer/fd-4.c index c992db619e7..fcfa6168efa 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-4.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-4.c @@ -1,3 +1,5 @@ +#include + int open(const char *, int mode); void close(int fd); int write (int fd, void *buf, int nbytes); @@ -60,3 +62,11 @@ test_4 (const char *path, void *buf) /* {dg-message "\\(3\\) 'write' on closed file descriptor 'fd'; 'close' was at \\(2\\)" "" {target *-*-*} .-1 } */ } } + +void +test_5 (const char *path) +{ + int fd = open (path, O_RDWR); + close(fd); + printf("%d", fd); /* { dg-bogus "'printf' on a closed file descriptor 'fd'" } */ +} \ No newline at end of file