From patchwork Wed Jun 29 15:16:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 1650196 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=denx.de header.i=@denx.de header.a=rsa-sha256 header.s=phobos-20191101 header.b=DfWB/x3R; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.a=rsa-sha256 header.s=phobos-20191101 header.b=Fnn/BICw; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LY4nL5BqSz9s5V for ; Thu, 30 Jun 2022 01:16:52 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0B01E8424E; Wed, 29 Jun 2022 17:16:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1656515802; bh=zFfCkf7nrfS9lxNhc7ujGgtUeIkHTKAzL5PSrMokkZc=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=DfWB/x3RC/1X1ZqTRED7kr1B61Dw54ibE+shQuNBEmnziH6AFSO4YSXqOprTmLLSW BAQJZ0cvXY3YzRCE/tsE8Tx01erENSan4dqEwqW3A2ZrLTHiot2h1tO3uYuBLSWCUx Ntip0+4wV9aEYi9f1f7xx1ULuEHmHtF6c1xT8uLvOM9DJnVTS9/OhU3BDd1K9jdv4Q ebgLUyrpdonaDB9pdy7pesBDsUlqTQVLaAvmEhou0EOyzjoffezQIwgEUutuVC7ddm 5wc9MZLy+1JqtRVax3kX/ZZ7fKfmVo4Z3CNcJi/vGjufXnyNy4ahn+7EfYHR0z7nm/ DFKxtNs/IXrpA== Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 49FE883F17; Wed, 29 Jun 2022 17:16:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1656515800; bh=zFfCkf7nrfS9lxNhc7ujGgtUeIkHTKAzL5PSrMokkZc=; h=From:To:Cc:Subject:Date:From; b=Fnn/BICwVxj03WomRt/sO2o8RTTD24u2SjwONm9OqzorYVwfO/LJAbYKb4YfeDQ9F Vy00cORRP/gdDB9O6eq+6Fk+Zg9NBm1JZmCg2NDvXybZgFvUZlZljExShILbKaD7c2 rlfqwg7cE8J2qNX8uLpXNcKsOabHe5ge1LesXh7PgO1N+UefudW/eZniKgaaIu1Mmy SrTeo0fdhlGkfyMG2ZnkpajEgq9Asw5TeDNUu3gTUCthmfTqz9Q/Lltfaharyl/05E mZd17Z0ZmfzwDWffsrJwgoRaxdf5QTOqpqpgcLWYLdDWzKPFjKL+48CaV+FfNQnwrB AFNXvPQkY+JyQ== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Fabio Estevam , Peng Fan , Stefano Babic Subject: [PATCH] tools: imx8mimage: Keep IVT reserved1 field zero always Date: Wed, 29 Jun 2022 17:16:37 +0200 Message-Id: <20220629151637.111413-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Since fe8acf556c3 ("imx: HAB: Validate IVT before authenticating image") the U-Boot HAB implementation is checking whether reserved1 field in IVT is zero or not. In case the field is not zero, IVT validation fails. Stop setting IVT reserved1 field to non-zero in mkimage imx8m plugin, otherwise the validation cannot ever work. Note that this only affects legacy boards which do not use binman. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- tools/imx8mimage.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c index 4eed683396f..52baf4c9903 100644 --- a/tools/imx8mimage.c +++ b/tools/imx8mimage.c @@ -505,14 +505,6 @@ void build_image(int ofd) exit(EXIT_FAILURE); } else { sld_header_off = sld_src_off - rom_image_offset; - /* - * Record the second bootloader relative offset in - * image's IVT reserved1 - */ - if (rom_version == ROM_V1) { - imx_header[IMAGE_IVT_ID].fhdr.reserved1 = - sld_header_off - header_image_off; - } sld_fd = open(sld_img, O_RDONLY | O_BINARY); if (sld_fd < 0) { fprintf(stderr, "%s: Can't open: %s\n",