From patchwork Tue Jun 28 11:27:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1649463 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=DjaJeSYo; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.a=rsa-sha256 header.s=20210112 header.b=n7pPSVPi; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LXMmm0PHfz9sGJ for ; Tue, 28 Jun 2022 21:28:55 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FGT5tdnysaCCfBgWLhQ6vCq5NnSuD7p9YxDU/E4UVds=; b=DjaJeSYo7ZGnxC PbA19c4rjrPhuRpQs7fpRt4D+ahd28CuDOtDEPlCR76KudP0mLyJXNFIGj2fHDCcpBlhE46i3k3Eo gTwRqGYbo/e8yhq4+rctKIP/FclHlGRk8l2abcNb0q1UHi6EX9WiQhkphQnCcVRBnWcH5ikSoOoFo plMAEfQriKukDhVbFKeqVJ/wszkFRAeyBJ5PTY70hVgk6WbgffFcmU4E1RSBCy5DxjCCFiCTHchLM f2hMA9f5/CDqUJXVvW/Vs2Y9COqWkMxhINiECG7NsGW7HZoYsKXhdCQkhEDghhC6Zxz0rrO9rX7g+ iJ3N4gES0m7Ww91fNpQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OB-005v52-TD; Tue, 28 Jun 2022 11:28:15 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69O8-005v2p-2p for linux-mtd@lists.infradead.org; Tue, 28 Jun 2022 11:28:13 +0000 Received: by mail-ed1-x533.google.com with SMTP id e2so17127366edv.3 for ; Tue, 28 Jun 2022 04:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+LlLZaDtYyevN2FUYLTzNmH0PwKbstBSDwmDMRaV6wQ=; b=n7pPSVPiiSJ1+gdboLLhYJ9f2hGhbzZRAJmZl5PEMUU87GpbDbIYORHNkubL6j125d U3G7vvwWc2C/l5ESEfNezHayvDrhVYJPeLDQPmHXW+nXcyqAGxVu4bEwZYSHgzynMaIg 14hWsOCnf5YzkJE14RXt1lbyHOdu1yL0j4UtR90OXZj2wlpf8IIzBzcwVCXV0n2SqQJw ltnorUr4yOgaKyq1iTwP6B3n2r3Z285MWTN0W+q8iP46pBZnXLuKyRHqt88VjYRc2q1B 5bE8LpsiIAXZAxIGYz+IVVuijgojfzTFg7gpPmURZO1JjWnKCsBbBlAFx6MuqC2eRuFm BCZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+LlLZaDtYyevN2FUYLTzNmH0PwKbstBSDwmDMRaV6wQ=; b=Kl7+C2wUkhrb+cPaFz27HYwRgVtey226tIijHAL7FN3Dr3ozk0yhmw6H/i5mLqC/du 92GcuJ6v/Xz+HXvCdKWQScghNeK0IAlatQ02HsP2rI4R72OkYwQ9jGMncWhVaiGIB3uN GvtC7oOeWi4NrEsYoO332ru6ybItswSVY8d057RwRBTQ/CsEI5/DqG/5yn3/rpmCcbgf lTZ0CKdjmrLBMvwsYRxbgy65+fSOa2nAnD0J1Wx8sf/uAE3sQd9SHPb8ZAZ/V7a5U0zm zMxu0wNPqok/LELcJ5L8Ya4lESYZxwuRZnjdTkYh8JHt2LlFu+xlLjkXkH0zfFqgEV67 icDA== X-Gm-Message-State: AJIora/MbbT456grZNv6sswSBtORQg3Mo0phYhvOtbVqnZ9f9jQFHUKo 9jwrM18MA/PodVKl6rmACCrngLmHJDM= X-Google-Smtp-Source: AGRyM1uhgE91nhjR/KZn+mG1jgfNS2BuoAiTS53aWpUhL4EPUwgHNPi54ElTY6ldhaT1A4HEavdEdQ== X-Received: by 2002:aa7:d709:0:b0:435:6ae6:5fb8 with SMTP id t9-20020aa7d709000000b004356ae65fb8mr21875688edq.161.1656415688197; Tue, 28 Jun 2022 04:28:08 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:07 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 1/8] dt-bindings: mtd: intel: lgm-nand: Fix compatible string Date: Tue, 28 Jun 2022 13:27:24 +0200 Message-Id: <20220628112731.2041976-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_042812_161560_498D7188 X-CRM114-Status: GOOD ( 12.19 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The driver which was added at the same time as the dt-bindings uses the compatible string "intel,lgm-ebunand". Use the same compatible string also in the dt-bindings. Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml | 6 + [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:533 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The driver which was added at the same time as the dt-bindings uses the compatible string "intel,lgm-ebunand". Use the same compatible string also in the dt-bindings. Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml index 30e0c66ab0eb..763ee3e1faf3 100644 --- a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/mtd/intel,lgm-nand.yaml# +$id: http://devicetree.org/schemas/mtd/intel,lgm-ebunand.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: Intel LGM SoC NAND Controller Device Tree Bindings @@ -14,7 +14,7 @@ maintainers: properties: compatible: - const: intel,lgm-nand + const: intel,lgm-ebunand reg: maxItems: 6 @@ -75,7 +75,7 @@ additionalProperties: false examples: - | nand-controller@e0f00000 { - compatible = "intel,lgm-nand"; + compatible = "intel,lgm-ebunand"; reg = <0xe0f00000 0x100>, <0xe1000000 0x300>, <0xe1400000 0x8000>, From patchwork Tue Jun 28 11:27:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1649459 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=eq//wVA/; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.a=rsa-sha256 header.s=20210112 header.b=Kb3GrCLo; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LXMmj3zFDz9sFx for ; Tue, 28 Jun 2022 21:28:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xDVptYwcUqAK+EciOMBhxTI6LK5ImsGgDWe0gJ6NRMI=; b=eq//wVA/ZWzmfg kxf8sHOGkj0X2yqMT8/px5BIF4tQCaeKHeHz7ZrTo/bwEmFf63GGiLOWWrz8Nr2aH2aC/7n6DMebe gkmLmS1N5PmdbAQ6ZwdSjiBu26QNxEaSTNTi5ZN1UMtrmmwI4tTJwQ5ukPzkVEFrC+WPLf9Vw4HjF OcNLUEEtrtXcOgBf71hY7z/NVGnJjOQAUIX7LZ9t65ifvZQ4YCBj9i4OuqHR8V/ESEt8vPVLTu7I2 1gCzeiIRqhhR0GePnKz6eXVBBhxA+h2wECgUkZSfyqbO4F6rN7N6aXGIfFS8jQKVThPdAt91cgeaP Iw/gPvN6xDqJCmy3TW0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OF-005v7y-9s; Tue, 28 Jun 2022 11:28:19 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OB-005v4N-IO for linux-mtd@lists.infradead.org; Tue, 28 Jun 2022 11:28:16 +0000 Received: by mail-ej1-x633.google.com with SMTP id cw10so25131859ejb.3 for ; Tue, 28 Jun 2022 04:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C7hxbvOysOVU/UTQ861hxTJENidUKbCv/fSaMWTU3aI=; b=Kb3GrCLoxkYt2/yVGmqqO4w8RxBfyYZ6rRu+LEu9FAzsG2xDTJNzh8tf9/B84y/aDR bOwn5BfibkkSmxciqncxsdkBGyewMT8FU18aKZ/SvMGZ+tTRZFGB9r1VdT/0TFZbe7M6 LmMDTXWIeqrViuKl8dNo1OB8sHS1F4rT47JUY8ZaDQb0B8Bu5YS+mYbsvPLD/w9MH1Vb fF/AvomeNtZA4qcdckaJjf8slVctIuc8khfDjCv078OE3FYj/ILVVt70Bh8RiwchL59/ LpchdbicFwJOTHOxjYYgkgXM4e3K8mwD95s+2mjFj7x0kuZl96pU8gCLnWNElYRi/xJk VTew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C7hxbvOysOVU/UTQ861hxTJENidUKbCv/fSaMWTU3aI=; b=WZUuOe+MAX+vOYNLzrCOZeZNscjsFzVcHmi1aAwO8HkPxcxm2PBKyJTXBN2828xbmx CKM+9fqHysMRukkkthvgwuPom5wQlNk36mqv1XrijnqKSl76ghGLD4yyHKuYVqahqLk+ 7+v5BqNxmkZioIx/URWbMoa6uvOpIWvMWvJrdWr6oSHXcSlAioxVaMj0uMBeMfIwAagv 9B4X+NWMywJjsdu2E67GuoxQJFXXJNCNtAW3ChXi28vIdetBumZTy+3F7GrARK5lwOfi XqW97qljwZzd6UfYIf8gEOT+IMz27RlEKc+fvOC86t+UIgAsJV5S/Z5/YJ11zoc4pqz5 e19w== X-Gm-Message-State: AJIora+pKj5RTEngX5GGOy4gDiAhs7UuuOwV7gaPJZ4ghTkqrOXRWzF3 gdCiUVeMwGgCT7ooJaa6MHqzBk9/lb0= X-Google-Smtp-Source: AGRyM1slseCRLwPgpXyPajn0dpOI3hl7Jgl4zNknGOXyGIQeIUZzYiCPMBFWkQQsyhJE0Hu+dqVM1Q== X-Received: by 2002:a17:907:7f1d:b0:71d:ea75:e533 with SMTP id qf29-20020a1709077f1d00b0071dea75e533mr17799271ejc.78.1656415691749; Tue, 28 Jun 2022 04:28:11 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:11 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 2/8] dt-bindings: mtd: intel: lgm-nand: Fix maximum chip select value Date: Tue, 28 Jun 2022 13:27:25 +0200 Message-Id: <20220628112731.2041976-3-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_042815_676517_5BA27D78 X-CRM114-Status: GOOD ( 10.95 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The Intel LGM NAND IP only supports two chip selects: There's only two CS and ADDR_SEL register sets. Fix the maximum allowed chip select value according to the dt-bindings. Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml | 2 + [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:633 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The Intel LGM NAND IP only supports two chip selects: There's only two CS and ADDR_SEL register sets. Fix the maximum allowed chip select value according to the dt-bindings. Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml index 763ee3e1faf3..04f26196c4c1 100644 --- a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml @@ -51,7 +51,7 @@ patternProperties: properties: reg: minimum: 0 - maximum: 7 + maximum: 1 nand-ecc-mode: true From patchwork Tue Jun 28 11:27:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1649462 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fDBWZJMi; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.a=rsa-sha256 header.s=20210112 header.b=HaWubVbN; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LXMml6M3sz9sFx for ; Tue, 28 Jun 2022 21:28:55 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MAuhHXIhiWkC+ENyyF8W6Z4HYWAhmcBB4zJp3cn4ecc=; b=fDBWZJMi/DIV6M 2Dzm8Ma1OEaVbVC20VE0CFJWcBMJIiK38ILEF2i0s1O06vfRQHWi8kTBQ+qWhsbdGbv3DdkZnLgy4 gSiXd91fwlorX0Vy9h7Bl4eFF48QLAl7LewnTcn3lmb5fZG+YzNaJ7sk9gGUPlKMvfgww7cGQmBjW 528AZEsrS9OnnXANp2Nim7GPwWzLAXNcFsuMRn3JAsJCSs3+JP2DiNBphUtlDWuuIJERyvmJzCKPl dybO94Jt1sW5JfUiKxAkZk/7Oh8oQs9fJ0przZdm9+Hel4i+6XzemIzO7j7u/VfIfC8ek96mSuNJq ZZ+9DMQMJ8NdZqcRjtPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OH-005v9R-C5; Tue, 28 Jun 2022 11:28:21 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OC-005v4X-OS for linux-mtd@lists.infradead.org; Tue, 28 Jun 2022 11:28:18 +0000 Received: by mail-ej1-x62e.google.com with SMTP id u15so25075188ejc.10 for ; Tue, 28 Jun 2022 04:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L/vVPNNNi/M5hFZ14uI3yR7vQmNxehz58sZt8wiaUeE=; b=HaWubVbNaxSD+nlcHJa49uO9e6VAh9gOOIRMAfHc/SGLurGEg8A6CZo1MHioC4yM9T BF0JznCyJN2tmhkcShwNh03rwsG6BUiTv87W8haV9GF/CxjpFVr2idmrgq0UJzzXm9/a uYVinDWBpYg40+c5lzK2vpa96lAZjgm7jWCu6pIX/lqRa0EYeZFjRqRDsg1d9NjGH15b CazDQm2NN45LJqPwSDHocRDtYiDhXJ7BJjO1W8qbAzWtWcLAiCrOXcF1vYw0WWHSIGlr IYM/6MascnMHRGlSBL5Z137juzIVHeHJAX8YM02AKrWrUgl+7SN4HmN2Y3Rhi5RWeAVI 61jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L/vVPNNNi/M5hFZ14uI3yR7vQmNxehz58sZt8wiaUeE=; b=tqYv/JPJ+K8b5CwcXIcwBxwvlnGaB1RhzK8nrVcldA2JoQ02fhBI0unsD/BG/TeuDV zw/OIbyE25IDZuHn5oW+YZRdEPQDdElyrRovxS4oS3t61Rd8AwCk+zWClkVF0DbpJPyL FsX9A1TH7R9yc/OaBFxADyqQuLUtgBoLqz3GEaay/CrhGUfnbW5J0ExvkDbEjxUpijq/ /hT/OFM4l+RMSzBVIKtbF/CT+krUGSX2NPtvYp6EP1/HlZdIuLe1GoWVcQxTJmwO0vD6 Groly43gtdDPVvA2U8wxB10PQUpLSvsK0rf0hp1CuwWJB/Hxcs0JtI/nvdqSda1p7jTI Xp/A== X-Gm-Message-State: AJIora+/xw/EKX92OfYNVSMHY+miPkQpIyBWGnIJyeTxRNQOcN80lSEw KBOeSl/VuFzRe3RlixPKemQY1s9TId4= X-Google-Smtp-Source: AGRyM1tn25cwZFHS/DKbUQZdk6M3oiSNF7RkIMRFB9m1OpkuIcAdUMVXZJI1tQCvfXCkFMcBZmC9pg== X-Received: by 2002:a17:907:6d1d:b0:726:363e:cca3 with SMTP id sa29-20020a1709076d1d00b00726363ecca3mr17142850ejc.713.1656415692784; Tue, 28 Jun 2022 04:28:12 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:12 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 3/8] mtd: rawnand: intel: Read the chip-select line from the correct OF node Date: Tue, 28 Jun 2022 13:27:26 +0200 Message-Id: <20220628112731.2041976-4-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_042816_831827_C09E66DD X-CRM114-Status: GOOD ( 16.49 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The chip select has to be read from the flash node which is a child node of the NAND controller. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 11 +++++++++-- 1 file chang [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:62e listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The chip select has to be read from the flash node which is a child node of the NAND controller. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index e91b879b32bd..3df3f32423f9 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -16,6 +16,7 @@ #include #include +#include #include #include #include @@ -580,6 +581,7 @@ static int ebu_nand_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct ebu_nand_controller *ebu_host; + struct device_node *chip_np; struct nand_chip *nand; struct mtd_info *mtd; struct resource *res; @@ -604,7 +606,12 @@ static int ebu_nand_probe(struct platform_device *pdev) if (IS_ERR(ebu_host->hsnand)) return PTR_ERR(ebu_host->hsnand); - ret = device_property_read_u32(dev, "reg", &cs); + chip_np = of_get_next_child(dev->of_node, NULL); + if (!chip_np) + return dev_err_probe(dev, -EINVAL, + "Could not find child node for the NAND chip\n"); + + ret = of_property_read_u32(chip_np, "reg", &cs); if (ret) { dev_err(dev, "failed to get chip select: %d\n", ret); return ret; @@ -660,7 +667,7 @@ static int ebu_nand_probe(struct platform_device *pdev) writel(ebu_host->cs[cs].addr_sel | EBU_ADDR_MASK(5) | EBU_ADDR_SEL_REGEN, ebu_host->ebu + EBU_ADDR_SEL(cs)); - nand_set_flash_node(&ebu_host->chip, dev->of_node); + nand_set_flash_node(&ebu_host->chip, chip_np); mtd = nand_to_mtd(&ebu_host->chip); if (!mtd->name) { From patchwork Tue Jun 28 11:27:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1649460 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CvNw8Qp4; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.a=rsa-sha256 header.s=20210112 header.b=CbVDEz1Y; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LXMmk4KFLz9sFx for ; Tue, 28 Jun 2022 21:28:54 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgUUwOt59VL0BXT/EdhwVSeWfDQrkocVthSOjnSQy2g=; b=CvNw8Qp4CEbaiD tahBxfQerLW6RQ24GQvUWSF9FTTyivhVaG6xB4vOxEtArTVgDd8qued2gSSMTPCZbAFCL/8PUnUt1 MGuIImc5EbT1K4ZFXizLHWRnUW4+3Zf93ioVCU7VLwz8tEPKjc4VdsJs0BRRA0Or1Nxr/k6RQA/H/ yDG2Oi4rkOlCfRN2y/oDAE7J1jfTwvy0+iG5PT83qCV3t7Od4MUDA7Qrx2+36q5VE1SR3CFhRi77m kQLn3VpFq71BOg6fUh120RKMJ93bQeldS21UFhpwgIrxEqSbE0bNGbPRepUTyjXLG2Ao20FDZkNDK Z9IlbFm5zCY70dkMMK8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OJ-005vB4-L3; Tue, 28 Jun 2022 11:28:23 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OD-005v4e-EH for linux-mtd@lists.infradead.org; Tue, 28 Jun 2022 11:28:18 +0000 Received: by mail-ed1-x52d.google.com with SMTP id o9so17074108edt.12 for ; Tue, 28 Jun 2022 04:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z/aCGOJhN5hhaa/wf3udZzref7WmmFge/G1kcYg31ZE=; b=CbVDEz1YIhN/CZwz7Po586XwhR1tDqMnUEZiyAz09iRURJR1bDxDRt7GkakaoBMvQV FUKWaFOIETEp7V9O5XgdKEJA7NWf0anlbK2XF9IqbXY517vNSaPnGajPw8WWH79aWnnX Yo1w8ea+6diWxwLYIVivAE/vLlBVoF0SZx3B1avkEBg7d9QO8fDyZ8Zi+70erfT+lKNz Bi+Yy7E3VEodPI3JUG8C94mNeymMndsANF/8MYmTzaIyU7hHK3O0DfHuGsmAs9nxM+xU UhPCe3/LVi3DPW2K3QvEGQUOJV5uPlI9uEmA8bb6T2ZeckMY8mVoQzR9aKbpQayk89iy pPOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z/aCGOJhN5hhaa/wf3udZzref7WmmFge/G1kcYg31ZE=; b=51yk0mRMNaZkBaeJVb3WzKN8e+KlZjSVpgy3zIHtNFEsdoUTbCUHsEqPajeag7Z048 H2Ip+5N3+JXLPA4K2QmbuDe3bQyNKyElAvFYnhHOCVDQGNHJ4MG8qq20Uq3ybtNRrYNt YkpArnUvEGDKRVSgJ5RRQLnWoTrebzqLBqN3vEt3FAGV+/wtym0kvYvsLX4BeFeQ4zkQ IOEw/hn5CDeqAOjAy13b2/cGFk8XEUGM38bBijnVsdyyUEMXcqhkoYI8jabtYAs4PWBA +Xy8Xy6r0ApK09JBPm6yKsNUt4TojQEFtiXACFTQSmLxMwmR08hKCVbMdQgE9KhIQ7OS MCRg== X-Gm-Message-State: AJIora+1K9w+K4ZUMhRnkmjHapk45g3ITPd++qz1sonHWgMwC8jaLeqL FpQQKW1HADDNQNFwgGeEjZY7HrjGy7M= X-Google-Smtp-Source: AGRyM1ty2755DziH+VQSppOQlJavQFFOcOu1ZHriPAA4F7jhidLeXeluQ2PnRW4xmThrhoABTwVnTw== X-Received: by 2002:a05:6402:1c09:b0:435:6562:e70d with SMTP id ck9-20020a0564021c0900b004356562e70dmr22237136edb.203.1656415694067; Tue, 28 Jun 2022 04:28:14 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:13 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 4/8] mtd: rawnand: intel: Remove undocumented compatible string Date: Tue, 28 Jun 2022 13:27:27 +0200 Message-Id: <20220628112731.2041976-5-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_042817_494256_F2EF3190 X-CRM114-Status: GOOD ( 14.22 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The "intel,nand-controller" compatible string is not part of the dt-bindings. Remove it from the driver as it's not supposed to be used without any documentation for it. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 1 - 1 file changed, 1 delet [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:52d listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The "intel,nand-controller" compatible string is not part of the dt-bindings. Remove it from the driver as it's not supposed to be used without any documentation for it. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index 3df3f32423f9..056835fd4562 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -723,7 +723,6 @@ static int ebu_nand_remove(struct platform_device *pdev) } static const struct of_device_id ebu_nand_match[] = { - { .compatible = "intel,nand-controller" }, { .compatible = "intel,lgm-ebunand" }, {} }; From patchwork Tue Jun 28 11:27:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1649464 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=XPNLZrAa; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.a=rsa-sha256 header.s=20210112 header.b=XH74Pz5Y; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LXMmp6FCyz9sFx for ; Tue, 28 Jun 2022 21:28:58 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bqQq+YBRrZzOKVtkejs3QnERxmjUyVkEHxNMIDCAg2w=; b=XPNLZrAaTy4Va+ rM50qbiwugKk2aHkY/O24E7woaA43F/FLROagVbZ6bdPwOZb4D8iU8L4GnzThHka6Il/SeAdyDjAr kMHDb5U1z2EewHZdMbTGy+Ug2Hxa3zxMAwporYwy1IBW+m12VPaq/aVbLUHVT5RRnKH+qCslA95Vt S51zI4YoEii8iB40H/DWG1wXjbYZEOMnpaf4smeArZ2G2Ay5apZbXKRVWDERKz50xw81NcwqvaRu4 Hn69fbwiRAUiSkUc4tPnPUxWqtrBCK9PhO8bb8lwODRdlzKl6/xMRiRer+hwm2ptIAltWZfwda/zj Yv1y5W24DKng9V/YU9iQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OQ-005vFb-8A; Tue, 28 Jun 2022 11:28:30 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OF-005v5S-CR for linux-mtd@lists.infradead.org; Tue, 28 Jun 2022 11:28:20 +0000 Received: by mail-ej1-x62b.google.com with SMTP id u15so25075420ejc.10 for ; Tue, 28 Jun 2022 04:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5wzm8aXQ7jfEpVVa+hUFH1hW1Ct7FIztd1NOXIDzjfE=; b=XH74Pz5YOnB4omNJDTWscDju8Y67UOhoqHfCkZwCx5LLSKKYOOXLjuFrhSnLXqhXB3 abm4wLC2wi/67TJtYAa/4rvjJpmbmWWbhJcLWdWed24A+CE9iREckGSewd0sZjKYPvQ1 e/O2CTyyhBBO+MkRTN4w1gteEFLZI4Dfa8zZGpVa4eYAKrMbkhl8MvxT0Hy9OPUehRhh HZI9X4q0Db5Ykuh0H8l9PpS5SNzz3CtijZO6JId8OMZvKYF9I91K5V/kuYyqvO6JiLbx LqrDKHy7KfRuBMfCTnh1rYHX65tbNn3DWi9TBAqbrkRmMUxrt4QU6HUyQhjgKNE+tKaZ UNbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5wzm8aXQ7jfEpVVa+hUFH1hW1Ct7FIztd1NOXIDzjfE=; b=lCEZGfZbNh6yGzqxbP1VRf1LCFNLpJIGDiG9mRtbXkuwMDtPHgeXGoDXe97u0l+M88 HYxWIdT8XXtpWGVSO9h31O+6O3zs2U12TVu207/rSKdGVWJ+2+thvDIHdKMG5yOfEm7n FWRRg9yjTvCV+xUQavZiYFfblqY1bGeEh++ujBTK7vl2s2gVz68hGarF7NJq6NaA5ffk PnYHv5p7DzSx9CUOi18/eVmOkMW9OvOQaStKyyz9MvY7A8j86PZjdoHltwT6iZrd0VWx nQVkyBS/vsHrJFF/h+vbn/0lSrvGIkbheGVQa4NMfn0UNhNN2BRQHHjhQIwiYFUJNkFv rYkA== X-Gm-Message-State: AJIora9FjQi0iTfHSiGQwx7pWkd7zOHGHZvtraYxKR9fYOWT4vH0OfGm au3FX7q+A09wKA5w6Ok9woOTwcWNtcY= X-Google-Smtp-Source: AGRyM1sDsDKOUmH0i6QVDvM2Jlx6H9R/wRxIYS1gH4CBNfulyXXOOVydVqD0/buMOXrZ4rCojhNJPQ== X-Received: by 2002:a17:906:4fd4:b0:722:f223:8d86 with SMTP id i20-20020a1709064fd400b00722f2238d86mr17271003ejw.558.1656415695311; Tue, 28 Jun 2022 04:28:15 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:14 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 5/8] mtd: rawnand: intel: Don't re-define NAND_DATA_IFACE_CHECK_ONLY Date: Tue, 28 Jun 2022 13:27:28 +0200 Message-Id: <20220628112731.2041976-6-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_042819_456562_550861E0 X-CRM114-Status: GOOD ( 10.55 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: NAND_DATA_IFACE_CHECK_ONLY is already defined in include/linux/mtd/rawnand.h which is also included by the driver. Drop the re-definition from the intel-nand-controller driver. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 dele [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:62b listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org NAND_DATA_IFACE_CHECK_ONLY is already defined in include/linux/mtd/rawnand.h which is also included by the driver. Drop the re-definition from the intel-nand-controller driver. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index 056835fd4562..3df16d5ecae8 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -100,8 +100,6 @@ #define HSNAND_ECC_OFFSET 0x008 -#define NAND_DATA_IFACE_CHECK_ONLY -1 - #define MAX_CS 2 #define USEC_PER_SEC 1000000L From patchwork Tue Jun 28 11:27:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1649461 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=LUEYZFtk; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.a=rsa-sha256 header.s=20210112 header.b=XsIH+2HQ; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LXMmk4bzVz9sGJ for ; Tue, 28 Jun 2022 21:28:54 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ClnRHXf5tP/5g28Zps+bap+YgZErAtshr2k36RgVF04=; b=LUEYZFtkI/q+7V rMb2OOmUbQwigoaBt8kxxLOxXO0TdfzdvmYsa4yJWquaAGQCcR4lMvBpUcYz+hmx+nq4/ELcuclaH MgYT5QJICyQkV5LNUQDWJ99BXWsz9coaEDWs6xYr7Pilk8LymrvwhkkGjq9wst5m7qd+vFhImdVFn OP8p1VjJ4hJDQ36TJnztnSDo6RWVTDfzqHb7s0YrtPbOSsV499mSVuFqFnGKJ15Vq2/XpZ1wYS1o5 Php28jklV4U2Y+Yj/8WE2xKTF2JXv2yRZdhv+SwWmR/AwNsADmu9GUAaRw9VYgz2Lr0Gslg4M25Xb ZRXLqPMA2YrV9XTuL1xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OL-005vCK-T6; Tue, 28 Jun 2022 11:28:25 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OD-005v68-VY for linux-mtd@lists.infradead.org; Tue, 28 Jun 2022 11:28:19 +0000 Received: by mail-ej1-x633.google.com with SMTP id ge10so25096228ejb.7 for ; Tue, 28 Jun 2022 04:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8kX3dUaWuulkCwAMYcRWq/5OXE7N5XumBNg6KTJej40=; b=XsIH+2HQO1P1rHXYTPerAkTGiIM2ijXN6e2a8nA1YzRXVJbepZFT2gr/QLqLOsdi+U R6G1p3JiVf6mXXRNy2NwloPk+XpjErzFnhr9+k90lHUa87Hw8EtMPJv2yTM0jvL5jxIy cg3XL87XUQuJOf2cG+9nqf5K1DHKQ+mKiVBvUSyODcI2i/WNvHG5edVqsGJ1J348XXk8 J97p/fwJN94dnl6V9doQJxzxuZbfvkOO23QWSPDehyMLfsm/H33kznaTuk0VMa0a47k1 4sGwUw1gascOFrbo6akRUDX+vbAX3Kwt74m+SlY72fmFvNUUh5mTVdylQ8v35dmhAqxx kUeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8kX3dUaWuulkCwAMYcRWq/5OXE7N5XumBNg6KTJej40=; b=Q+mLt3uEXcEobrbzZhye830hV/+FzxRS9FNeLG7hrspgbLwc0nAANCpBicyJyepYx5 8cXTpBJ33rB16ho+Gd/bb10f9XC33uLI39WCP/pl/n3ho3dXb0pvKCSITbbmxI8jBcsw aJ7lKEpDU65ee9c5gaHUA1c8RbLi5V9WVLWmY8WyybzJXPuyymwzSaD8AEKOghluO/fN GEJmqiDzi3k+9/9VWDgoBF3NW0rtgbuejK76zQxtlLLaX6ieFMXOrph8RDjDJ1jUQO6C BLBjpJJPHAz72XbjufwO5lLTp/FdHg/gvzvtWGswMkXcrfKwdcS6BkZnmTypcJylr96d qL6Q== X-Gm-Message-State: AJIora8/Ie+7ISx/0gdYXDNlCe2L3ISWRrzLYXAaenCIiBSBN/P49Fny Vd6QpUdfie5eUlPVzpZXyyciePhYAzk= X-Google-Smtp-Source: AGRyM1skiyvCQpAlrk4WuoP4RqWyZwZfLZtvvrUmns96lKuveEOF6JxVfQfbbceXtsM4XMNcuXhTAg== X-Received: by 2002:a17:906:7315:b0:711:db45:af4c with SMTP id di21-20020a170906731500b00711db45af4cmr16554359ejc.412.1656415696584; Tue, 28 Jun 2022 04:28:16 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:16 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 6/8] mtd: rawnand: intel: Remove unused nand_pa member from ebu_nand_cs Date: Tue, 28 Jun 2022 13:27:29 +0200 Message-Id: <20220628112731.2041976-7-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_042818_036780_7CC949AD X-CRM114-Status: GOOD ( 11.87 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The nand_pa member from struct ebu_nand_cs is only written but never read. Remove this unused and unneeded member. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:633 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The nand_pa member from struct ebu_nand_cs is only written but never read. Remove this unused and unneeded member. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index 3df16d5ecae8..de4f85368988 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -106,7 +106,6 @@ struct ebu_nand_cs { void __iomem *chipaddr; - dma_addr_t nand_pa; u32 addr_sel; }; @@ -626,7 +625,6 @@ static int ebu_nand_probe(struct platform_device *pdev) ebu_host->cs[cs].chipaddr = devm_ioremap_resource(dev, res); if (IS_ERR(ebu_host->cs[cs].chipaddr)) return PTR_ERR(ebu_host->cs[cs].chipaddr); - ebu_host->cs[cs].nand_pa = res->start; ebu_host->clk = devm_clk_get(dev, NULL); if (IS_ERR(ebu_host->clk)) From patchwork Tue Jun 28 11:27:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1649466 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xO2ybhnb; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.a=rsa-sha256 header.s=20210112 header.b=T95YBreZ; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LXMmv3qyBz9sFx for ; Tue, 28 Jun 2022 21:29:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cviy81dTZ7tc+jOn1q/NwyCE105tJQ2QLjrr3x36Fiw=; b=xO2ybhnbAgEXyw 1ZFd0Y7rgi48SpW178IR5lSa9c/xY3/Y+JbseCoYGLWnITGLUj5H4tcUBmOELEpUHvUlE0wQGvmZ8 MWCwj0K8+uMmv8XgkiqBtwBgaKdsq1GoJ0pq40Y0UKaQao6xYRDmONaLmtpZE9vXywwygXLyUUH/t FtJuLM6FxkigiI3JJPZowzmzVYOXeuUOV23BP9PrSfC8nv/VTuyF0UOrZpD2unEurq/Qq/w73ShR2 FXax+An7zlOzQA22U7GLkxF8P5Y2yDlEQrv9YkMNyPRZeBFLUUqc52HtM7MIlwvjlZUYuPWBSSikh i97hbkhKNN9opgXRt2Hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OU-005vKO-E5; Tue, 28 Jun 2022 11:28:34 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OH-005v6o-8x for linux-mtd@lists.infradead.org; Tue, 28 Jun 2022 11:28:22 +0000 Received: by mail-ej1-x634.google.com with SMTP id u15so25075622ejc.10 for ; Tue, 28 Jun 2022 04:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wqgc6jUPRcLl2k1wjcuUn82u931h34UR3GkTMv8F/kk=; b=T95YBreZPHTSDKz9UPS5xFBpfWAVG8hi6XrIHo7W9zdKnDZlexZmx9ONBDVkhTa9ws L8QQ8OLu6Ver0m5jCahivuQrSXNQ90kJzWweUUYjzjcbYB9cdf3HBGtPB4qpxD3TFS6a UDP5sxqwtjdY+69yYYwkcvZECJW/fRPUHt7XoUuVoS7Kt2QUgZxyLXiRsHr2h2tuR9cP hrjCQcJFDxdwN/LWyB7bLCY8pY5e3Ks3rpeKYwce+THJ8BJNc+4CoZRa6rXnk/MXIFVD L22apaVIqSmKSwWsGsMGrVHhIE0KALKi/afSsBzevtO0jD2IEyA7tTqu3Em2Pw+YYZWa Iq2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wqgc6jUPRcLl2k1wjcuUn82u931h34UR3GkTMv8F/kk=; b=VlrNbBi0+O4u7fXwoE/Nnz9Z0ToaV3bS29PMod3ou4jS0JL48rNS6JnrD4W8XqnG+E lmTrDYascrkxdNmpHl5T8yEMXt2dzRK9LnnNsGTgfQMHaXRLn5vuUKtkoa2bud7hz8Xz ENH6+Q3NSAM5MS3bfCqnnDwDxkGx0iIm78GXHVIiBR5IohzJpNGgxVMya2uajeMv1IIM YkUueBAW0u/nchGHcUTSPZ3botKq5nHRaBcnmTRc9Kop0jBIPVGLi/K/OIlXpJWr4X8Q /7pdLIq/TPKxbLX4FDC7MlexNXYCIScNX6AFzykJy+lkYshM6hgUv07MChR/7zsyZbG9 qWwA== X-Gm-Message-State: AJIora9hKK5U+Tgm7dJwR0dyaQtlQepqLPjX3dRSptcCkd8BS9wdJGWB jehUAm/M8kx6Ixkw21677K8inRWkSDU= X-Google-Smtp-Source: AGRyM1uI8tzxdpgnoE1YZHUjY+YKpwDRC1XmWEmYBE3VDOktzn/VoqQrNVoFIeXHaES1lKfRHOvuCQ== X-Received: by 2002:a17:906:58d5:b0:722:fc0b:305a with SMTP id e21-20020a17090658d500b00722fc0b305amr16784769ejs.251.1656415697498; Tue, 28 Jun 2022 04:28:17 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:17 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 7/8] mtd: rawnand: intel: Remove unused clk_rate member from struct ebu_nand Date: Tue, 28 Jun 2022 13:27:30 +0200 Message-Id: <20220628112731.2041976-8-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_042821_331758_D154E32F X-CRM114-Status: GOOD ( 11.68 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The clk_rate member from struct ebu_nand is only written but never read. Remove this unused and unneeded member. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:634 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The clk_rate member from struct ebu_nand is only written but never read. Remove this unused and unneeded member. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index de4f85368988..e486db11ecc3 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -118,7 +118,6 @@ struct ebu_nand_controller { struct dma_chan *dma_tx; struct dma_chan *dma_rx; struct completion dma_access_complete; - unsigned long clk_rate; struct clk *clk; u32 nd_para0; u8 cs_num; @@ -636,7 +635,6 @@ static int ebu_nand_probe(struct platform_device *pdev) dev_err(dev, "failed to enable clock: %d\n", ret); return ret; } - ebu_host->clk_rate = clk_get_rate(ebu_host->clk); ebu_host->dma_tx = dma_request_chan(dev, "tx"); if (IS_ERR(ebu_host->dma_tx)) { From patchwork Tue Jun 28 11:27:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1649467 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=NgCANoYK; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.a=rsa-sha256 header.s=20210112 header.b=FvZMPG4R; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LXMmy5BYxz9sFx for ; Tue, 28 Jun 2022 21:29:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VViL0v//zti4KFpoMaZMHJ/+ck8XsU/2hpnZUlyJiOA=; b=NgCANoYKNbj1OK rWZHK0KeHVV/aPwmUE+Wp+1t3U5t+hrzMmpEQUk/npzo41PMd13ftO9PmUXCEpWrTzxs/5elLzZT+ nieUAPyJJrSAyAdZXsHsOn1i/qRAqzd+U3JpA4QBB4FLT7hmxGtMNXUylIRH6dtaxAxojyCoOMcbR ZeOW+ZugPxUvCgcT6hYurzBzZcKTK89905kVKOsov8P8oCCb1FJdlJ+H5PWtUEvsq/PM/pSnDcwh8 /C+Re8FJ/QqtUhpE/jOW9b+4DtlUIFYOqLQSyAC9NoeovOafzWSdGwdlbZppt/P9kzCfr7XLzBKCY SWqKPEedCwGgLy9hcYtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69Oa-005vO3-4x; Tue, 28 Jun 2022 11:28:40 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o69OH-005v7a-Ij for linux-mtd@lists.infradead.org; Tue, 28 Jun 2022 11:28:22 +0000 Received: by mail-ed1-x534.google.com with SMTP id z7so17060502edm.13 for ; Tue, 28 Jun 2022 04:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wSWuOS2cAYv5FuJkZUEc6ND5j48qnvL32xgmlNFYci4=; b=FvZMPG4RvTvduiJLbxdgkpBmHO0eivfuDB3c9SxChryaMNJW+RHsG0LmEDG9Dw19sU +7kHR0ctkFPFGOzNyssScuN0/V6YJe1/jvh9gInfgAzF6JsMIKuFIEyXLrCsof1hI6uN ZkQgi842QELzR98SBpzr4fT6W/EvvNFPTkJlL2EMmHMiuCjvTXVkGI+ZQgEeXhmKYkdd zFWcZrdkpewXgyHVxaAEbaXRvd+LMr44fGqNdY4wToMrbyw8vJdaEaDMhAE92k31vfoq igJWVXzBZ29TByMze6b7uWTfch6DYTBA4eItcWvNKFVAqGqKk/g6Vzz4ucX1bg8aMnps vSsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wSWuOS2cAYv5FuJkZUEc6ND5j48qnvL32xgmlNFYci4=; b=StTCdyigLrmgp1j+5CN/kJ5cWYQda+FDn+NjfN0PBs1Z+dWg6LpLtC1hpVApYT8zDk vcoA4VW+PQMCWfkT+tcJwVY/TOM273Nr+W2k7+64fCQ9AYRMABSOZpFjkKJyRZZnChK/ mgdcVVF0D70WuktAWkiU23Y8KW1Z48K5rgGO11PQbP2HvOFKPNjmSlnfwLbCIQvlOLkd 6/v4VhHLAWDnK2sSL9r6/4cJwunerM6pLQvK6A7ZHrNA1+97CiLkWheeJRV26rv49R5J ZcmjaaqYXUUGzy3IJEcZ6v6B87R90NkZpFKuAGd5yfR/NkmhRmmMOyFMSVP/7ABaVPP5 WzAA== X-Gm-Message-State: AJIora8ywSnGDPjrC/JAYnVmNLNc/oC7GUx+BzFwQeRBLBUbGuPgT8t9 jEg+wvqTdKYFNjJ3IMg7XM+xZfJy0WU= X-Google-Smtp-Source: AGRyM1tN9+xICqng9ViA9oB4fb9cf2sQb53hvOku9jNJTaaO+oR/dcUdswOIf+hv1Nr6y/+uWwoFfw== X-Received: by 2002:aa7:c7c4:0:b0:431:75d6:6b3 with SMTP id o4-20020aa7c7c4000000b0043175d606b3mr22099442eds.280.1656415698324; Tue, 28 Jun 2022 04:28:18 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:17 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 8/8] mtd: rawnand: intel: Use devm_platform_ioremap_resource_byname() Date: Tue, 28 Jun 2022 13:27:31 +0200 Message-Id: <20220628112731.2041976-9-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_042821_675050_7071D32C X-CRM114-Status: GOOD ( 13.02 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Switch from open-coded platform_get_resource_byname() and devm_ioremap_resource() to devm_platform_ioremap_resource_byname() where possible to simplify the code. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:534 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Switch from open-coded platform_get_resource_byname() and devm_ioremap_resource() to devm_platform_ioremap_resource_byname() where possible to simplify the code. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index e486db11ecc3..d4a0987e93ac 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -592,13 +592,11 @@ static int ebu_nand_probe(struct platform_device *pdev) ebu_host->dev = dev; nand_controller_init(&ebu_host->controller); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ebunand"); - ebu_host->ebu = devm_ioremap_resource(&pdev->dev, res); + ebu_host->ebu = devm_platform_ioremap_resource_byname(pdev, "ebunand"); if (IS_ERR(ebu_host->ebu)) return PTR_ERR(ebu_host->ebu); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hsnand"); - ebu_host->hsnand = devm_ioremap_resource(&pdev->dev, res); + ebu_host->hsnand = devm_platform_ioremap_resource_byname(pdev, "hsnand"); if (IS_ERR(ebu_host->hsnand)) return PTR_ERR(ebu_host->hsnand); @@ -620,8 +618,8 @@ static int ebu_nand_probe(struct platform_device *pdev) ebu_host->cs_num = cs; resname = devm_kasprintf(dev, GFP_KERNEL, "nand_cs%d", cs); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, resname); - ebu_host->cs[cs].chipaddr = devm_ioremap_resource(dev, res); + ebu_host->cs[cs].chipaddr = devm_platform_ioremap_resource_byname(pdev, + resname); if (IS_ERR(ebu_host->cs[cs].chipaddr)) return PTR_ERR(ebu_host->cs[cs].chipaddr);