From patchwork Mon Jun 27 07:27:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joerg Vehlow X-Patchwork-Id: 1648757 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=jv-coder.de header.i=@jv-coder.de header.a=rsa-sha256 header.s=dkim header.b=emTP8P8u; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LWfSv1XZFz9sGp for ; Mon, 27 Jun 2022 17:27:41 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B42C33C88F4 for ; Mon, 27 Jun 2022 09:27:35 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 3735B3C14B2 for ; Mon, 27 Jun 2022 09:27:32 +0200 (CEST) Received: from mail.jv-coder.de (mail.jv-coder.de [5.9.79.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 5FBD61000465 for ; Mon, 27 Jun 2022 09:27:31 +0200 (CEST) Received: from ubuntu.localdomain (unknown [37.24.96.116]) by mail.jv-coder.de (Postfix) with ESMTPSA id 93A609FF8E; Mon, 27 Jun 2022 07:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jv-coder.de; s=dkim; t=1656314850; bh=u5ndKJAr6Xib1GaIdTBFEQFJ0V0dWMhVWaL0cPIBA+w=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=emTP8P8u+8FBxOv9ug1jFoBYu3fW5h0aNcbyLMlv0iFTOSp9MNOziU6f1YanKNdCH dNjvaFTJrfMAbNHfh1Ky28Gb28qvy+mjj+wP21uV6ixd+JVBkzfwktEAIOp1/fHKk8 66QSNp6v0VX0vSvmzN2hGdkPU+P+YlHdX8yw3zI4= From: Joerg Vehlow To: ltp@lists.linux.it, pvorel@suse.cz Date: Mon, 27 Jun 2022 09:27:09 +0200 Message-Id: <20220627072709.709035-1-lkml@jv-coder.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on in-4.smtp.seeweb.it X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH] net_stress: Fix usage of variables from tst_net.sh X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg Vehlow Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" From: Joerg Vehlow These tests use variables (NS_TIMES, IP_TOTAL, ROUTE_TOTAL and IF_UPDOWN_TIMES) from tst_net.sh, before sourcing it. Fixes: 04021637f4749a4797bf105862c45fe07374a161 ("tst_test.sh: Cleanup getopts usage") Signed-off-by: Joerg Vehlow --- testcases/network/stress/interface/if-addr-adddel.sh | 7 ++++--- testcases/network/stress/interface/if-addr-addlarge.sh | 7 ++++--- testcases/network/stress/interface/if-route-adddel.sh | 5 +++-- testcases/network/stress/interface/if-route-addlarge.sh | 5 +++-- testcases/network/stress/interface/if-updown.sh | 5 +++-- testcases/network/stress/interface/if4-addr-change.sh | 4 +++- 6 files changed, 20 insertions(+), 13 deletions(-) diff --git a/testcases/network/stress/interface/if-addr-adddel.sh b/testcases/network/stress/interface/if-addr-adddel.sh index cb453e612..0750501f0 100755 --- a/testcases/network/stress/interface/if-addr-adddel.sh +++ b/testcases/network/stress/interface/if-addr-adddel.sh @@ -7,9 +7,6 @@ IF_CMD='ifconfig' -# The interval of the check interface activity -CHECK_INTERVAL=${CHECK_INTERVAL:-$(($NS_TIMES / 20))} - test_body() { local cmd="$CMD" @@ -89,4 +86,8 @@ test_body() } . if-lib.sh + +# The interval of the check interface activity +CHECK_INTERVAL=${CHECK_INTERVAL:-$(($NS_TIMES / 20))} + tst_run diff --git a/testcases/network/stress/interface/if-addr-addlarge.sh b/testcases/network/stress/interface/if-addr-addlarge.sh index 3c876c17d..d0759c86b 100755 --- a/testcases/network/stress/interface/if-addr-addlarge.sh +++ b/testcases/network/stress/interface/if-addr-addlarge.sh @@ -7,9 +7,6 @@ IF_CMD='ifconfig' -# The interval of the check interface activity -CHECK_INTERVAL=${CHECK_INTERVAL:-$(($IP_TOTAL / 20))} - test_body() { local cmd="$CMD" @@ -110,4 +107,8 @@ test_body() } . if-lib.sh + +# The interval of the check interface activity +CHECK_INTERVAL=${CHECK_INTERVAL:-$(($IP_TOTAL / 20))} + tst_run diff --git a/testcases/network/stress/interface/if-route-adddel.sh b/testcases/network/stress/interface/if-route-adddel.sh index b50da268a..51445e4f7 100755 --- a/testcases/network/stress/interface/if-route-adddel.sh +++ b/testcases/network/stress/interface/if-route-adddel.sh @@ -7,8 +7,6 @@ IF_CMD='route' -CHECK_INTERVAL=${CHECK_INTERVAL:-$(($NS_TIMES / 20))} - test_body() { local cmd="$CMD" @@ -64,4 +62,7 @@ test_body() } . if-lib.sh + +CHECK_INTERVAL=${CHECK_INTERVAL:-$(($NS_TIMES / 20))} + tst_run diff --git a/testcases/network/stress/interface/if-route-addlarge.sh b/testcases/network/stress/interface/if-route-addlarge.sh index 7d09d1216..355b6b4ab 100755 --- a/testcases/network/stress/interface/if-route-addlarge.sh +++ b/testcases/network/stress/interface/if-route-addlarge.sh @@ -7,8 +7,6 @@ IF_CMD='route' -CHECK_INTERVAL=${CHECK_INTERVAL:-$(($ROUTE_TOTAL / 20))} - test_body() { local cmd="$CMD" @@ -76,4 +74,7 @@ test_body() } . if-lib.sh + +CHECK_INTERVAL=${CHECK_INTERVAL:-$(($ROUTE_TOTAL / 20))} + tst_run diff --git a/testcases/network/stress/interface/if-updown.sh b/testcases/network/stress/interface/if-updown.sh index 9a5709c85..71c78d785 100755 --- a/testcases/network/stress/interface/if-updown.sh +++ b/testcases/network/stress/interface/if-updown.sh @@ -8,8 +8,6 @@ IF_CMD='ifconfig' TST_CLEANUP="if_cleanup_restore" -CHECK_INTERVAL=${CHECK_INTERVAL:-$(($IF_UPDOWN_TIMES / 20))} - test_body() { local cmd="$CMD" @@ -47,4 +45,7 @@ test_body() } . if-lib.sh + +CHECK_INTERVAL=${CHECK_INTERVAL:-$(($IF_UPDOWN_TIMES / 20))} + tst_run diff --git a/testcases/network/stress/interface/if4-addr-change.sh b/testcases/network/stress/interface/if4-addr-change.sh index b9ece2af9..f162e6a51 100755 --- a/testcases/network/stress/interface/if4-addr-change.sh +++ b/testcases/network/stress/interface/if4-addr-change.sh @@ -9,7 +9,6 @@ TST_CLEANUP="do_cleanup" TST_TESTFUNC="test_body" TST_NEEDS_CMDS="ifconfig" -CHECK_INTERVAL=${CHECK_INTERVAL:-$(($NS_TIMES / 20))} # Maximum host portion of the IPv4 address on the local host LHOST_IPV4_HOST_MAX="254" @@ -61,4 +60,7 @@ test_body() } . tst_net.sh + +CHECK_INTERVAL=${CHECK_INTERVAL:-$(($NS_TIMES / 20))} + tst_run