From patchwork Tue Jun 14 14:12:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 1643316 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-weidmueller-onmicrosoft-com header.b=WLiw7G9V; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LMr4H4sL9z9sGk for ; Wed, 15 Jun 2022 00:12:47 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CDD0E842DC; Tue, 14 Jun 2022 16:12:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="WLiw7G9V"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D2A3A8399B; Tue, 14 Jun 2022 16:12:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0602.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::602]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 87B29842DC for ; Tue, 14 Jun 2022 16:12:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JIZNqlRxzze3MwMWyoHRDBKUWg8277jDijdoSspUwpS5+PIBRqXs+7nTRWU+I7KBPGF++m8i2tbFPjT8JdvsKLltdbpsyXzrXHtfVotuVUk0HOphPALkPsN24bVc9T15PzgFh7YX/0aMGX6cAzcll9wtww56X1jumhF863s28NXgWT1748Onr+l73gGrf0/Ud6XzeYqjJwJIPVFM1UBWvIfB43GVA20FTmRX2Y9dY/FoxopUqSxOozdXOxYcivQoOelX0MJTpLKr1qd3278k1ZLl9ucTeR9JrlxJlRnQJlPPc56o8P3qKPNCmU4JtPDDgr9dZBSHskBMtlVwxr6xLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gp4NRItLho7rO2x41e263xvVSbKdeZLNtQ4oE9fnX8w=; b=anV2IKlkTMZsCMYi0L85Kz5qeL5htTnI9a8hQ38H0oOyMXdZ15cH9f3vMyHTDIGVERwpmIXskZnYRSiyFv1Z7MIA4TVt4TYAx/OvCqHx+yzGk1C2f2yjZXtVOAfQ9rFFFLNiruq4cvknj3m9v1Z7apznQ56fdnKC6kky2ej6OEgpLVKCfZmljB7w9z86GxHnxgwEZA/OuMT84U6NbXCN+DRZdg8ekiTmTYZb7MZAZiUOr51njJukpEAp+crbj2QT6aKuZ9X2A/qTXBrwuxdj2170N8qdvAhgkFHmSYPm0Qxv+YtHifr9FJmFYEPV/MHWRlPpZ9tTtk9XYoi7tTLHaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gp4NRItLho7rO2x41e263xvVSbKdeZLNtQ4oE9fnX8w=; b=WLiw7G9VNiQ2v5Tb0UY0rRo4GTFKKqb6Rsm22EY/G6U27p+oI08ORpFwCqNXl5EGe8xWnOCWFAQ/burNW9WDbMOKKqqvTkBTCc2a1IpHtYY4ppx0Pamom0JjP54t1zHE4e3n1Isac/sFhiQXUjfemrJWjyMzhuPi9MhvgAlyCgE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.11; Tue, 14 Jun 2022 14:12:35 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::f938:78d7:da4b:8d23]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::f938:78d7:da4b:8d23%8]) with mapi id 15.20.5332.020; Tue, 14 Jun 2022 14:12:35 +0000 From: Stefan Herbrechtsmeier To: u-boot@lists.denx.de Cc: Stefan Herbrechtsmeier , Aswath Govindraju , Heiko Schocher , Michal Simek , Nishanth Menon , Simon Glass Subject: [PATCH] spl: fit: Allocate buffers aligned to cache line size Date: Tue, 14 Jun 2022 16:12:00 +0200 Message-Id: <20220614141201.27886-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.30.2 X-ClientProxiedBy: AM6P194CA0052.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::29) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c39d75a4-7193-4780-f4c3-08da4e0fedc0 X-MS-TrafficTypeDiagnostic: DU2PR08MB7325:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3NJvosTWJOACMgUs74zO15EsAk95yYh4tMJtWp34Sd/l1hQizHe8EvnoCkQ+2ZJmtJrxa1PK/Q2ft0i3wFapDAaMkGcnrEYfr3br69UnII7CVe14dzi1F2IRStLwsYCn/LLqtuOA9FRc8IfRxXd0Ow+rMZ2tG+SawtjuslSGsy6vF/BYWfuQIOEKYQWZq1RhLYuSlLzAbHaSmA4/eOO/D+pWSHUfv0sk7gSkhoi+fmG7ysgU6Bb8tjSKjU53kMPRq6HclOBZbwTY5FtuZPSesf7ie3DAqXj5ZA3goUJTSTEqCaAq4Y8EoKcuRRPawm6/FkW9HqTbIiWOaazu63JEk0W5VTjtxXfW4ftKHQtmbzvU6gv+eMjaJRKJXnyzIXcGZpd+whegiS90YLNyezZ+Mjq2F3qHKkfQiLeJAkLgwuTt0Zzh99PSt+Ru9qNMMw+x/c77AsA4/UMcn1lxmKn5a4/cfvEZuxj3fiJzlPqMEcLQrad0PKepbW7/SSQT1/5VcREpMiAs7+CgJ9U2O7tUtWH1H4bQz3ZvoB4JIvRxO5dve7nHiY2dMxxILaLK4Q9pEbCkfbj2xT+ur+aSzkqaUBMEnIgB4O4S8yekt38a40+Q3S/7K2Y1y+jcsAYkRTQvIU2l8VstpWb39a6/aGtbaOwb4tvIo2MATbqV3UkRt13wojReMYD17e9vmmEc8OKx X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(66556008)(508600001)(6486002)(186003)(2906002)(66476007)(83380400001)(4326008)(66946007)(5660300002)(38350700002)(8676002)(316002)(38100700002)(86362001)(6506007)(54906003)(6916009)(8936002)(2616005)(52116002)(1076003)(26005)(6512007)(36756003)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vUHJijvi2cCDR7ILxTlUItUcdNOJjeWSZo6Jg2PfnvjxYSc4lXrKybMLdSM3Jp2SOpAW3himqt4aBkQBRLszdgO2k/8auWApOlwz83p4opcjACMUct/tv/yGipSmnmJkFuL+1IJLI2u/3BRZdQhcMC14X8RBigwKfN4T60fOulUQIJVlnK8cWQ/A5d45OgA11rwnengQQq+Dw/Arqk9TUlxAm4DAaoq6O2eMkXB9CqKlMLN2jsUT1eiyEc4n6a8IVzOVi5PQOqwABXaVnrM7ROPgXCJrAmR6wZnIHFnI/+p3Gy6yZG44IfwD1RlYuZeSSlXeSDakVEiAK/SJOTMaR+xfLrObK1BUYUnQufpppsPt1P3c5rw08FbooFtsfTN/+tUIsUmG0ENy0Ap6l/hQlwa22/Aldtd6/w/XRyyqwd188kVsjsFLYIA+ZnsiXGKc+o45Fl8xEAX/SwfSMcyCuD593QOXYKPHvyJFRc1nk2GJZoV87LqbGx1YswFusG2NNVDfrFGptJ7SPlATeeuBUjkwxve9LpiyeusbrpT5MYKp+O6SGkrHTQw2IqKy4QvXGMiguwL66t0FB6tagxEJRSK9o4ss1P56l+6I/GKfzPRGX4U32IQ/UKMiJG7m1w9BNshOErdW7loaoWzAVHji9eu5fc0yAb6+HuiooiSNaU5R76vHZKJWDbZyGbPe/ZD8B1leta7EeGxu8m9ZfNdIAdr/u1kVHC1WLEVANgWMGebSbfiBY9PBolUpuSgTSORTUmTiCnGGCEAPlhJH17Q7mFlj5a0nIfKf5gVbhcUk7PHZrtFoG20kko/bRYqAD8oHZsJCp8jnOmpwQobbGemZND/wf/NzZlaIWnMj23tGj71WlDVuM26iGday2tPNb2pSfCEePw+iAMrz+ru9eZ2v7D8FMh2BCydBCNNY1fbpa6x7UJiUCiu7KgYKdLoJxj12Pn4xG3XOve9L5LjJo1vWiyeo1fEHBS4HqwmNp6B/1QidfkCIzHqOm9lXDbct5D1Wkoe7FKjI9vNCAzTGSi82GWiI6kQ+b4CKCBoCmXaFUUy3nR5vahIfqKUNay03ZKBnmhgZsZIU5gokkHJZId72DEX5lkZSh02WuJ3LNFdsjkqacWl+NV6PTvH53fTupnGSTcAzR6n/4aRCdv8EkMYf+g8tdGFeFYcSQgCzDwYZTF++fyee/3QfCX3FQNl7jBmolOHnoDurHizFyASx6HUHUoUwRNiPeh6bGqB9VjepK4oKaUuKGOSmLH+xOMDoGQFvIPzHri5DKYSPQVctTV5LmQtT8XIwWcrdqieRXLJtx0jBIAi8fC9KCvRXPSVEXTZkDHY+yeRNji1VN2HarpA/CUmzjwRp8raiR3RbFR4FG85VCfr+c+z5xdiFulrf4SyTZ06dM9nWWUuzi4Wl6HGDl6aCtoGKaYIwVgyf+ry9m90ETs0K4mRPCHixixMfmH7MtdYN6AtcWG2eaxvyp1O3cuVOF4CFfdzk9PNnQfpy1UB12Wm/ADp0S7Ky7LyL3bGU6AGcQH+GW801Ws+yhWdiNksX6jDpKrFtQGOh62vCZD6Y6I27J3LELBg4bvZbXsdK6XzEcfPEWP1BfmltNBISCIKqxa4NTegrgcBSDSkvh7Gel2GqPSoBkKg7qMCGn1hobhI8hNoGzVWx33MsEXw+Za2W6YK/xMr07BtZroF2LqzPzfvd3EzYkW7/GdnsMLICHcSHJ6Zsr6fvSn15U1liQ2zzsfEPIfFVbbJOiSnDe6k= X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: c39d75a4-7193-4780-f4c3-08da4e0fedc0 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 14:12:34.9011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2L4ssv+fyADL5IS9EzEWPVIcsd4XoCYCHj7PbJsWetU1wykth7wr+tkNpOsXPrHYRvvmaVJgDyqJtKP1wjPRuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7325 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean From: Stefan Herbrechtsmeier Allocate memory for buffers at a cache-line boundary to avoid misaligned buffer address for subsequent reads. This avoids an additional sector-based memory copy in the fat file system driver: FAT: Misaligned buffer address (...) Signed-off-by: Stefan Herbrechtsmeier --- common/spl/spl_fit.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index 1bbf824684..d61e1556ae 100644 --- a/common/spl/spl_fit.c +++ b/common/spl/spl_fit.c @@ -10,7 +10,7 @@ #include #include #include -#include +#include #include #include #include @@ -429,7 +429,9 @@ static int spl_fit_append_fdt(struct spl_image_info *spl_image, * depending on how the overlay is stored, so * don't fail yet if the allocation failed. */ - tmpbuffer = malloc(CONFIG_SPL_LOAD_FIT_APPLY_OVERLAY_BUF_SZ); + size_t size = CONFIG_SPL_LOAD_FIT_APPLY_OVERLAY_BUF_SZ; + + tmpbuffer = malloc_cache_aligned(size); if (!tmpbuffer) debug("%s: unable to allocate space for overlays\n", __func__); @@ -537,7 +539,7 @@ static void *spl_get_fit_load_buffer(size_t size) { void *buf; - buf = malloc(size); + buf = malloc_cache_aligned(size); if (!buf) { pr_err("Could not get FIT buffer of %lu bytes\n", (ulong)size); pr_err("\tcheck CONFIG_SYS_SPL_MALLOC_SIZE\n");