From patchwork Fri May 20 18:01:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634017 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=JYqMfbjP; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZMP40NMz9sFs for ; Sat, 21 May 2022 04:02:57 +1000 (AEST) Received: from localhost ([::1]:52956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns6xi-0003q7-Qy for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:02:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wU-0003n7-Jg; Fri, 20 May 2022 14:01:38 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:46714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wT-0004F1-2H; Fri, 20 May 2022 14:01:38 -0400 Received: by mail-ed1-x534.google.com with SMTP id j28so11687756eda.13; Fri, 20 May 2022 11:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2cwM4uPgDq+G3YSHb7SuW/x1hOJyj11CFWN9orv9ojo=; b=JYqMfbjPXAkcNPm4/8PSLnpOSBy8MmAfN3VKcqjR5XHMpmLvHDtSy1RJ6TqHWaq04x H1eOw4yDROh3Cn9kED8TEZz0YyBx41AERv0PmfjwrY1BgT3TL0xjWFo0w4f6svqg4pD+ 8Wxd4qNdePqaK/CNDYFddxo24bZtaHGndG9UUIoeMajb3j+1rKK1MFQNf+mOuXE8NIUT 0vUZrYQmkZnAwgKreRMFNDdAK1DpYs+sthH22A9pr9mEn18HCLhF1DFwqbreT3ccV5tz KTZbSKP3s5zwpGp/Hyb7Q38Oh7PnvwHUsEXs1B6chuKIodVci5axItvUND1O+vMw18tS J9IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2cwM4uPgDq+G3YSHb7SuW/x1hOJyj11CFWN9orv9ojo=; b=AUPSjSuKg9UAXu+bd9Jbfp+aTUUGRUFpqLm0VEIoUZQVsI7kWfBhAtpOrZvfryEGyK vmj8jE/6EhK+QI2LXtsC4N5xjUmwtjKLjEhcoFMUfcIBN+5hcfW58XPCf8l1YkwarhJq haYQCrS8O2tGG6tv799Ir05/EO0hr+K5w3i+/Dv4pctOF8nuVRdmbg9u+vS+/MjLY1mo Ss+ySSZkgOC99pEFijxssdtfJghC/BuKN+NOlckdCJ837rZm0zI177aXycBM7cKlAJ9/ 3EwyFLwPMBeBFjgRS0s1LNbJbED3ApHGR1Y035V25SkFfXYPHxt/uopm4t0Medd70f9R c0Hw== X-Gm-Message-State: AOAM533tQQCRmYxnhSK+7BBEmMfNnXGZVmQ2NhaC9HHDvhCgtc25n5c/ ShhSQHX1YkA4okqWKfkEE6pEk+fPaKc= X-Google-Smtp-Source: ABdhPJySAKCLyPq2oS2QLoQ+nabDhi0i6flR9LBG27rD9ZXDeN1y0BnnQEjLVwrXONJ4qPjCKBeZZw== X-Received: by 2002:aa7:dd07:0:b0:42a:eeba:a0a8 with SMTP id i7-20020aa7dd07000000b0042aeebaa0a8mr12225593edv.371.1653069695243; Fri, 20 May 2022 11:01:35 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:34 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Mark Cave-Ayland , Artyom Tarasenko Subject: [PATCH v2 01/10] hw: Reuse TYPE_I8042 define Date: Fri, 20 May 2022 20:01:00 +0200 Message-Id: <20220520180109.8224-2-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=shentey@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" TYPE_I8042 is exported, so reuse it for consistency. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- hw/i386/pc.c | 4 ++-- hw/sparc64/sun4u.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 7c39c91335..c914ac0154 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1088,7 +1088,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl, return; } - i8042 = isa_create_simple(isa_bus, "i8042"); + i8042 = isa_create_simple(isa_bus, TYPE_I8042); if (!no_vmport) { isa_create_simple(isa_bus, TYPE_VMPORT); vmmouse = isa_try_new("vmmouse"); @@ -1096,7 +1096,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl, vmmouse = NULL; } if (vmmouse) { - object_property_set_link(OBJECT(vmmouse), "i8042", OBJECT(i8042), + object_property_set_link(OBJECT(vmmouse), TYPE_I8042, OBJECT(i8042), &error_abort); isa_realize_and_unref(vmmouse, isa_bus, &error_fatal); } diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index d1bc77d27e..0e27715ac4 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -334,7 +334,7 @@ static void ebus_realize(PCIDevice *pci_dev, Error **errp) parallel_hds_isa_init(s->isa_bus, MAX_PARALLEL_PORTS); /* Keyboard */ - isa_create_simple(s->isa_bus, "i8042"); + isa_create_simple(s->isa_bus, TYPE_I8042); /* Floppy */ for (i = 0; i < MAX_FD; i++) { From patchwork Fri May 20 18:01:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634020 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=h3QSCAAp; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZQm66RRz9sFs for ; Sat, 21 May 2022 04:05:52 +1000 (AEST) Received: from localhost ([::1]:33254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns70V-0001QA-Bs for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:05:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wW-0003o1-Bp; Fri, 20 May 2022 14:01:40 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:45880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wU-0004FL-IN; Fri, 20 May 2022 14:01:39 -0400 Received: by mail-ej1-x633.google.com with SMTP id jx22so3546763ejb.12; Fri, 20 May 2022 11:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WuOiQ2vcTETClbMc2XlIIc/4ePmzXGMTxL5W/8IV79c=; b=h3QSCAApZbYbktnQmv+Tgw6NjOB+og9pBmE99u9OJ11n4RndA9hZTC2BzFKY69NAHC f8ju5NxfKquBpcVZAS2jSC32bgs6a39uxKEcUivweTXGXBcdeilRfknfy3wEkbNPJ4i2 3ThVew+maAqN1dtLk2oxgjv2VztCIa9e3jx3ggw7g22FWrFz0TSkpIm9tG0NqPrG+IPt VRf1YUReZHPfHNTNfwEYui0ntASuaNXfCWTHIwA8KCzST7xPDyAfkYvPRho5BhW+K1Ot qdQ/WER6Hi4xuFPtNTNP5Y5gAp7Sip33cHVqtTJu9bx4u+8cf/1IWsBS27no5oJgV6eg PxTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WuOiQ2vcTETClbMc2XlIIc/4ePmzXGMTxL5W/8IV79c=; b=0YCY9hJbqRJSEww26Kncp/bZGn9SzgAi8fO3Ha8R+y/owQOPbgTj/LVZKhf4usIijN UpCCihyRDzMMGDdcfYBKw2fJcMaa+SLYTPP2FhCOm5VzPin5z0FuMMgZ2JrYZkntoYAB H7KyYxtGGDRNzvVOxPb8EnEJKKvhjS4/1JvL+HA3DzEulW2DrIfkwQb3tBparpRA9Z35 W0rMNefH3DoXnLIuunhc35TIC9FAlkSEf+ZLKvYQxb/8xjjxc/IgCy+TLPJKmr22LBBD tvtuFJXPwYVsqbfHZDKKTyUBlLeT2f88NFB8tmewlOLNaUeBlXo17q1ZF+hZDkGzbCbR HupA== X-Gm-Message-State: AOAM532d7m9ghYEWSBMZmdkrS4XP1UQVXJfyoxqXyrgH7K+QQs4AOeeF D0ljAsgndSxfU9qIrF4ZZCBrQvLCriU= X-Google-Smtp-Source: ABdhPJx507p8y+0w+lF08x+eJCgbJOJHX9mBvW9kCERe9Lzh3/+QrgMSZSQybSVzES8aa8avLvLHuQ== X-Received: by 2002:a17:906:6d91:b0:6f4:5433:72f5 with SMTP id h17-20020a1709066d9100b006f4543372f5mr9522912ejt.414.1653069696757; Fri, 20 May 2022 11:01:36 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:36 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann Subject: [PATCH v2 02/10] hw/audio/cs4231a: Const'ify global tables Date: Fri, 20 May 2022 20:01:01 +0200 Message-Id: <20220520180109.8224-3-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=shentey@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The tables contain spcifically crafted constants for algorithms, so make them immutable. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/audio/cs4231a.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index 0723e39430..7f17a72a9c 100644 --- a/hw/audio/cs4231a.c +++ b/hw/audio/cs4231a.c @@ -84,7 +84,7 @@ struct CSState { int transferred; int aci_counter; SWVoiceOut *voice; - int16_t *tab; + const int16_t *tab; }; #define MODE2 (1 << 6) @@ -142,13 +142,13 @@ enum { Capture_Lower_Base_Count }; -static int freqs[2][8] = { +static const int freqs[2][8] = { { 8000, 16000, 27420, 32000, -1, -1, 48000, 9000 }, { 5510, 11025, 18900, 22050, 37800, 44100, 33075, 6620 } }; /* Tables courtesy http://hazelware.luggle.com/tutorials/mulawcompression.html */ -static int16_t MuLawDecompressTable[256] = +static const int16_t MuLawDecompressTable[256] = { -32124,-31100,-30076,-29052,-28028,-27004,-25980,-24956, -23932,-22908,-21884,-20860,-19836,-18812,-17788,-16764, @@ -184,7 +184,7 @@ static int16_t MuLawDecompressTable[256] = 56, 48, 40, 32, 24, 16, 8, 0 }; -static int16_t ALawDecompressTable[256] = +static const int16_t ALawDecompressTable[256] = { -5504, -5248, -6016, -5760, -4480, -4224, -4992, -4736, -7552, -7296, -8064, -7808, -6528, -6272, -7040, -6784, From patchwork Fri May 20 18:01:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634026 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ebi6bPTo; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZVT0zX6z9s0r for ; Sat, 21 May 2022 04:09:05 +1000 (AEST) Received: from localhost ([::1]:41578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns73f-0007Bb-7X for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:09:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wY-0003rM-5d; Fri, 20 May 2022 14:01:42 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:43866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wW-0004Fd-Cp; Fri, 20 May 2022 14:01:41 -0400 Received: by mail-ej1-x62b.google.com with SMTP id m20so16968911ejj.10; Fri, 20 May 2022 11:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2JfOSXedVx9zd/uj2U6R7U6NlLpjul8WVbgYbN02e5g=; b=ebi6bPToYWk4BUV0EvqKGDP4zpqySNZ5ajFoul4NlDAsyQ9VnbgpoLQNFtCST15sT6 e4zIIIPnfx92vC8olRbiNk6+bHskr78u49dmD3HCUX0aGzMj1/3i1hT6nXgcIGP8s6bK xwe0xLau48k178Yuxeai+nbI/C3/HMN3k5t8aQHPMAgB8rsOdYD2ssH1cJGOzgtdy5sF BORXnpnEuURlCZL2+cG1QSXqWPGtGk/OG3s+OVhlTZoZC+VaN7/qKOfrxme0Rdvw3ray cZmLknuyKKYbUuoUCBaaGmXmHAyk6rmEw5QEqBtNmwOj/hDtGTmRoBZbIv7CPsFuhUNf YkuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2JfOSXedVx9zd/uj2U6R7U6NlLpjul8WVbgYbN02e5g=; b=Pfp/+Wt9XJn3pF+VYscPftVyDcaYRb7v4Ymu7y8RsEvyWjRz4ZIt8tLWC+ajO20vQI rAUSYNJOoWWxHzGIPqoN6wlqfIsznXq5eCKTZSumrELCN+pjzoUisYkwlxf75TlY6/gd wU+GRfkGc2Dzs3XBB+P+1R5bh3lmKXyE618Aw6d0Mccash+vY5yAhfYNfV7tZq0d41Kr nf7Bz5NwARCwVN0bMtCOY7GuOGvNKOrLfsFcMILrr5uRN3KchKrlLgo7W+pYwgqs9tcO fq3Nv8vUskwuBSSA1eQXTV0s3ezfjjue21+L3byntFj+HofSjpfkE5tAdjhAFzSI3Yo/ yaUA== X-Gm-Message-State: AOAM532hSqjB/yEs/MDiESs5RvmzDa+UWxcf7TA3Xy6y2R46hyMNv8Kc +I7/7Wzsu+GriWlnlse8M4vyS1uwW8c= X-Google-Smtp-Source: ABdhPJwAIa6JMAX7NhXQXDdrHB+Phu01dccMM8fqoIQabowHveKI/UR660lBBeZwSOXexcNvHK95bQ== X-Received: by 2002:a17:907:9609:b0:6f4:d4d7:7c82 with SMTP id gb9-20020a170907960900b006f4d4d77c82mr9467330ejc.483.1653069698191; Fri, 20 May 2022 11:01:38 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:37 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , "Michael S . Tsirkin" , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum Subject: [PATCH v2 03/10] hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro Date: Fri, 20 May 2022 20:01:02 +0200 Message-Id: <20220520180109.8224-4-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=shentey@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The macro seems to be used only internally, so remove it. Signed-off-by: Bernhard Beschow Acked-by: Michael S. Tsirkin --- hw/i386/pc.c | 9 +++++++++ include/hw/i386/pc.h | 8 -------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c914ac0154..2ffaac52fb 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -96,6 +96,15 @@ #include "trace.h" #include CONFIG_DEVICES +/* + * Helper for setting model-id for CPU models that changed model-id + * depending on QEMU versions up to QEMU 2.4. + */ +#define PC_CPU_MODEL_IDS(v) \ + { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ + { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ + { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, }, + GlobalProperty pc_compat_7_0[] = {}; const size_t pc_compat_7_0_len = G_N_ELEMENTS(pc_compat_7_0); diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index ffcac5121e..38be346a13 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -287,14 +287,6 @@ extern const size_t pc_compat_1_5_len; extern GlobalProperty pc_compat_1_4[]; extern const size_t pc_compat_1_4_len; -/* Helper for setting model-id for CPU models that changed model-id - * depending on QEMU versions up to QEMU 2.4. - */ -#define PC_CPU_MODEL_IDS(v) \ - { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ - { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ - { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, }, - #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \ static void pc_machine_##suffix##_class_init(ObjectClass *oc, void *data) \ { \ From patchwork Fri May 20 18:01:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634018 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=BYtvYPnK; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZMf1HHhz9sFs for ; Sat, 21 May 2022 04:03:10 +1000 (AEST) Received: from localhost ([::1]:54064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns6xw-0004j2-7e for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:03:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wZ-0003uP-IH; Fri, 20 May 2022 14:01:43 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:45875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wX-0004Fp-Bu; Fri, 20 May 2022 14:01:43 -0400 Received: by mail-ej1-x62d.google.com with SMTP id jx22so3547018ejb.12; Fri, 20 May 2022 11:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BkoLUUqOUpg64L+o/OfEbmvOBo9ja3MouuFs8JpKIj8=; b=BYtvYPnKYOAF1t+tyRv29oQfnkv+GPqtuiiXtB7AcbkDCskvym0OmFK+EFADax3SmM WlGYWbVxK9Yby6cdah2TjbnfWfR+g6ZOHrOMnYcJ+Zws1oQS74g9WEL/iS3Urz/nBklx MOH8yxnSRTD0fmLjpr0Ja+SxvVf+ac8w5XCdBIOhMagSysCfjSiojkgkO9IXVx+YOxGY SK65rNFxZ/l+O6v/jeVqEhQx2wrmeP9Ef3s73ADFLzNr3BxOm51Dh1hbRBMssium/hlE 3xTXh6r6OuE3bhPH1ogHcPF7FazQaM3+1NGUTgnjxhzsAbS8MRqPO1YwfnHpHH3gSEkk uD+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BkoLUUqOUpg64L+o/OfEbmvOBo9ja3MouuFs8JpKIj8=; b=HRwGGMXBZRK/h7Q7I03tgIOfBGTSJTLLoJIRW/8grlC2+Whw9421LorL/64FtPXeIe S6uwQh9dpoWwNCzLsx3kT48ZYP3/yWdfO8A5Yr+E9AczRrOCFcuk5jQrbxiIGYpltLd+ nP3oGS/PuPi7bfvOjOe/sXjOmmIPw8L8t0tehvQv0n9q5kM42Kx47oly2L82b4Z+hSJn I8se+UMM1pfy5TZXowAt3zV0AmXNmNA9gXyTpY2hVu4BpfKagIssOCFkarvKUMp4eqdc mZBRXn2U55LV5vtVSwYjhm0L/CSso4KjM6tznkeREcegzgrDgiUTJUi36shTAPjmQuKE vTHQ== X-Gm-Message-State: AOAM532vPlWkZF52smTgRsmy+mluiPwUDfjD+A//UFHB6pnYy64m8sUY ut+qOPbAC3xqwRaExU2fAWkiSjeDWBU= X-Google-Smtp-Source: ABdhPJw00MGR53Z7uJLSh7wpT3r6kiRU1wEasHF3SGPdUdxIllmfISOG7hDBuXD8O6PieF+KkJ4NTg== X-Received: by 2002:a17:907:16a2:b0:6f4:eeb1:f7de with SMTP id hc34-20020a17090716a200b006f4eeb1f7demr10049326ejc.446.1653069699542; Fri, 20 May 2022 11:01:39 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:38 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S . Tsirkin" , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum Subject: [PATCH v2 04/10] hw/i386/pc: Unexport functions used only internally Date: Fri, 20 May 2022 20:01:03 +0200 Message-Id: <20220520180109.8224-5-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=shentey@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- hw/i386/pc.c | 4 ++-- include/hw/i386/pc.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2ffaac52fb..d7583045a0 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -570,7 +570,7 @@ static const char * const fdc_container_path[] = { * Locate the FDC at IO address 0x3f0, in order to configure the CMOS registers * and ACPI objects. */ -ISADevice *pc_find_fdc0(void) +static ISADevice *pc_find_fdc0(void) { int i; Object *container; @@ -714,7 +714,7 @@ static const int ne2000_io[NE2000_NB_MAX] = { 0x300, 0x320, 0x340, 0x360, 0x280, 0x380 }; static const int ne2000_irq[NE2000_NB_MAX] = { 9, 10, 11, 3, 4, 5 }; -void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd) +static void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd) { static int nb_ne2k = 0; diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 38be346a13..cb491fc43b 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -166,7 +166,6 @@ void pc_basic_device_init(struct PCMachineState *pcms, ISADevice **rtc_state, bool create_fdctrl, uint32_t hpet_irqs); -void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd); void pc_cmos_init(PCMachineState *pcms, BusState *ide0, BusState *ide1, ISADevice *s); @@ -177,8 +176,6 @@ typedef void (*cpu_set_smm_t)(int smm, void *arg); void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259_irqs); -ISADevice *pc_find_fdc0(void); - /* port92.c */ #define PORT92_A20_LINE "a20" From patchwork Fri May 20 18:01:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634019 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=d7Jnv7UH; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZN64jvmz9sFs for ; Sat, 21 May 2022 04:03:33 +1000 (AEST) Received: from localhost ([::1]:55028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns6yH-0005Qk-6b for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:03:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wZ-0003uU-Jr; Fri, 20 May 2022 14:01:43 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:45880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wX-0004FL-QJ; Fri, 20 May 2022 14:01:43 -0400 Received: by mail-ej1-x633.google.com with SMTP id jx22so3546763ejb.12; Fri, 20 May 2022 11:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N+TZy6cwDLZ0W5+ZsmiQT5X+1/OysDgnSgLOs65PewU=; b=d7Jnv7UHRd14Umu1RL0OZv6I+x4H8W4Bur+KLwbLvUoKeBl3Eifyn0Ow1p4GlnTevs uuzz+4HFVbtGLU9RtTcjdqyKRZRKBQO6PtIeV513NW+jqYRS5kWBLVSGve9mGK6QXaMK /0jlnSxYYGIn9vBW3avN+pql5LoveOnalfwufRzsS3pmlMi0VUTbDj+c/AJod9slaG0y bQOFI8CHduIIs34SoSUisnc5moN+VgG7BgKvnuCaNubO4P6ARGwNfEQR0mcbkNvJ9zoT gDEeudaFzhRSqy74B7F+ZElOTur0mhprg52GsJrGJhrcgC7X6PQyeMypfYLeAAMUSqzV bnhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N+TZy6cwDLZ0W5+ZsmiQT5X+1/OysDgnSgLOs65PewU=; b=vITvo3JQEj1MZzRJx+QKNNaiaZZ2iSa0Z5eqfj88stHTgPwK43ULRbPABKCBNVN3V9 JJNTkglgaBtdScsDKo1ujNoY7rVC7RpvrZ8Y/DCEIDip9AfcspwgkS8EpQHXvCHXnDp3 CXm3obFSHya4l2N9vR42e690H9F07MkvGquAy7c2SydidIaIPoNhccLJswdhpSmBCiw8 ARhFtra0TgKsdC+aS1/LLK6gwtCjbjWjtZf0YBOBVd980BruM/jPszXzFVVmtzy0IIil 8gxX3FGKorJQbnkD59WN8nAMNI/Qx1CQ+tZom19AkHbaZNDFdgVTDTbafpCEYtnjfLny 8A1A== X-Gm-Message-State: AOAM533A+87oHShaRMgKnq4t3II2YEEd0lMGo1vefwFV7zV22IvmuMTD gtBQd9r7Za++CZJPZSFnSI/GH1BaUXc= X-Google-Smtp-Source: ABdhPJw77nI3S/cFQpHPboGsZZVYFvKCqEe7eQw2YiVrb7sF3TwDgNPbjCFax1n3mZtq7RmVWOR6kw== X-Received: by 2002:a17:907:e92:b0:6fa:8125:c92a with SMTP id ho18-20020a1709070e9200b006fa8125c92amr10147571ejc.45.1653069700693; Fri, 20 May 2022 11:01:40 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:40 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , "Michael S . Tsirkin" , Marcel Apfelbaum Subject: [PATCH v2 05/10] hw/i386/pc: Remove orphan declarations Date: Fri, 20 May 2022 20:01:04 +0200 Message-Id: <20220520180109.8224-6-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=shentey@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Bernhard Beschow Acked-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index cb491fc43b..9c1d1c0a7c 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -170,9 +170,6 @@ void pc_cmos_init(PCMachineState *pcms, BusState *ide0, BusState *ide1, ISADevice *s); void pc_nic_init(PCMachineClass *pcmc, ISABus *isa_bus, PCIBus *pci_bus); -void pc_pci_device_init(PCIBus *pci_bus); - -typedef void (*cpu_set_smm_t)(int smm, void *arg); void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259_irqs); From patchwork Fri May 20 18:01:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634023 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=SAUbQxsL; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZRY3MxCz9sFs for ; Sat, 21 May 2022 04:06:33 +1000 (AEST) Received: from localhost ([::1]:34906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns71D-0002dj-EW for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:06:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wc-0003zI-Ao; Fri, 20 May 2022 14:01:46 -0400 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:44998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wZ-0004HV-Pd; Fri, 20 May 2022 14:01:46 -0400 Received: by mail-ed1-x533.google.com with SMTP id eg11so11702852edb.11; Fri, 20 May 2022 11:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nWDcRVdXYE3sAImE1usB8tpS7epBj9zKDdsVsgZYncc=; b=SAUbQxsLROwyQy6el6duq/Fnqh7JhaFXnUZN3OoAvI4tTBVujoiI19FkqAMLugPoBg 5YAWL2sy7cyeXrOoe2Yd/J7i4AhzbnO7wths7pat2gHkOpL0fbjqp1+/Ya+6YhV1C0G0 F2iaDPvCwAD2hD5NTMXWwiQ3aysVrD3eNm92B3SfzJyOUonIdWGAMY9jqJYsspjWYwuW rTi89oRjg502/OUMBWd3HW+kP2RJYE2gawj9nWnkzt6Ld366L1qVVkhM0aX+M6UXVO5c TG8YglBdY9COJ2pHKrxy/xFnvLMnAquvNn2LPorHtPitx0vE/RIqrn3RjPD3TM1I8Rt9 XXtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nWDcRVdXYE3sAImE1usB8tpS7epBj9zKDdsVsgZYncc=; b=Ku7t+EY+HIwZCO3oQyxoiXb1YWFUNwF1MX2Zxsb9hF2LVhUvqwJyX/b6fOaAEva9Z7 byNZ0zhQW1ByyKoi/ObNRvTGPP+4Z6M5tJxZr7kN2QmbTv6nqpVoktOzmrNPTbtR+K4I 7/8EafYkDcy4Hx5JOjYK3euT3zMTLAXvYiEgUSsyX7HrSSqvxJJLde1HmGm6SfIu+CWW pVdSjFuDDkW4hbA+oWkRnFm01uuzpNWzIJULxPgG1Bh96YX3WC2ACmntyDqYjiUzsfCU 5qMYxP6nz+Rof09PtjbJhPlFb0c/B2wH0zwENnQYMoermkBZArjxQeflsC79iO+3dQnk 0xBQ== X-Gm-Message-State: AOAM532YtGWm2ZW6wwBdYR2UMtIjBBMviB85Lgnqg88PVtHf4+xHsdW9 +dLUd8PFeKzU4LC6KduZ+VGgi/x5jiw= X-Google-Smtp-Source: ABdhPJyKcKi+bdgxYUWrYZtRfaWsbTuoA2WP9ZeMl1K6UyGu+yIikZ3Fom02HOEmE3/olpalfrFkzQ== X-Received: by 2002:a50:fa8e:0:b0:42a:b1f4:91c7 with SMTP id w14-20020a50fa8e000000b0042ab1f491c7mr12105620edr.140.1653069701586; Fri, 20 May 2022 11:01:41 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:41 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , Daniel Henrique Barboza , qemu-ppc@nongnu.org (open list:e500) Subject: [PATCH v2 06/10] hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE Date: Fri, 20 May 2022 20:01:05 +0200 Message-Id: <20220520180109.8224-7-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=shentey@gmail.com; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Commit 28290f37e20cda27574f15be9e9499493e3d0fe8 'PPC: E500: Generate device tree on reset' improved device tree generation and made BINARY_DEVICE_TREE_FILE obsolete. Signed-off-by: Bernhard Beschow Reviewed-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2bc3dce1fb..7f7f5b3452 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -47,7 +47,6 @@ #include "hw/irq.h" #define EPAPR_MAGIC (0x45504150) -#define BINARY_DEVICE_TREE_FILE "mpc8544ds.dtb" #define DTC_LOAD_PAD 0x1800000 #define DTC_PAD_MASK 0xFFFFF #define DTB_MAX_SIZE (8 * MiB) From patchwork Fri May 20 18:01:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634029 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=kDUPgaiJ; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZZB227vz9sFs for ; Sat, 21 May 2022 04:12:18 +1000 (AEST) Received: from localhost ([::1]:49538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns76m-0004A5-CP for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:12:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wd-00040h-Ff; Fri, 20 May 2022 14:01:49 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:44990) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wb-0004Hk-TY; Fri, 20 May 2022 14:01:47 -0400 Received: by mail-ed1-x52a.google.com with SMTP id eg11so11702921edb.11; Fri, 20 May 2022 11:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PJXOJrfQs925pSEapuM0H6kX1hHTrkqiCBU6Uf/0iC4=; b=kDUPgaiJEsdA54oB648Z0faBCpoJKipV6SrhjjeZyv8y2U6XWBrCgNJ/FdIERRmvS4 BOV9QakYOA++O1TFkNVw8NNdK2ySCmzq5VnFt3EImWPwsqdGcqHmEZegcQyD2F0+KLZ9 7BmYFEGfBeBlVTC1BSqm0OpBfuuW6vHIi18Jt5ml1l0JH9nAZjSxijhEYYNF0ZnVN9jr ZKzwt3NP0eRzR+sx8eluYVcXNSzyg8eQ3V8dNqLLzAFGUn0TtNbMQgjvdH3WuX3dukkd wsZmlA8jjfaet6buoJdBsuQd6GWkEuhtcT7I5NTKSt6jYTGMNxMQIoBskfrEVA/u4zZU IIkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PJXOJrfQs925pSEapuM0H6kX1hHTrkqiCBU6Uf/0iC4=; b=jtQEKzVKo4Zm7ADjAt82Rj3V0EanL3Hpz7d/fS4hscccu8QdJ4B2ElExhJdgYJZjZH 9BUBh7HXP+guXv5Ga36RRftvAcltKMz7ukCUOtfCNVYbXsVEMl9O5V8WOEEy8bHSXALj AdgO9cakW+/LBwSW3kGnRJixXxaO9qM3iDg55axWmpRbcwxiXK0ChpCCi2fCbBvaQtBo cT9EqPXjM2+IDF52gqffkuiik5aK7qGz9NgU/zqznYzgX8U8D2vbW1ZmnwddJjnkrSPB l5UEYzmAq51nQz0OQAZCKBpPhaFoid6/17Fkcn3gd2TAPdSEcxqzsuvZuGivxe9NO9KS KpDA== X-Gm-Message-State: AOAM533zRzSFZkH2qi841RE8cihhm/w86g619f8IkqtVbYSYTcTsdpih ZZfR0R8Ov2lsX3JcIXreVnHmPVgqq8o= X-Google-Smtp-Source: ABdhPJwbu5qJuilmxHA2D2Ya2f80AH9xdI3fbUSFhZWOeKEZHpVU2VDGyoXaSTZsyl95eCr+ZzzVww== X-Received: by 2002:a05:6402:2752:b0:41c:b898:19a6 with SMTP id z18-20020a056402275200b0041cb89819a6mr12467154edd.30.1653069702880; Fri, 20 May 2022 11:01:42 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:42 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Jason Wang , qemu-ppc@nongnu.org (open list:e500) Subject: [PATCH v2 07/10] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() Date: Fri, 20 May 2022 20:01:06 +0200 Message-Id: <20220520180109.8224-8-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=shentey@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" etsec_create() wraps qdev API which is outdated. It is also unused, so remove it. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- hw/net/fsl_etsec/etsec.c | 23 ----------------------- hw/net/fsl_etsec/etsec.h | 7 ------- 2 files changed, 30 deletions(-) diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index 4e6cc708de..b75d8e3dce 100644 --- a/hw/net/fsl_etsec/etsec.c +++ b/hw/net/fsl_etsec/etsec.c @@ -443,26 +443,3 @@ static void etsec_register_types(void) } type_init(etsec_register_types) - -DeviceState *etsec_create(hwaddr base, - MemoryRegion * mr, - NICInfo * nd, - qemu_irq tx_irq, - qemu_irq rx_irq, - qemu_irq err_irq) -{ - DeviceState *dev; - - dev = qdev_new("eTSEC"); - qdev_set_nic_properties(dev, nd); - sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); - - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, tx_irq); - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, rx_irq); - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 2, err_irq); - - memory_region_add_subregion(mr, base, - SYS_BUS_DEVICE(dev)->mmio[0].memory); - - return dev; -} diff --git a/hw/net/fsl_etsec/etsec.h b/hw/net/fsl_etsec/etsec.h index fddf551544..3c625c955c 100644 --- a/hw/net/fsl_etsec/etsec.h +++ b/hw/net/fsl_etsec/etsec.h @@ -155,13 +155,6 @@ OBJECT_DECLARE_SIMPLE_TYPE(eTSEC, ETSEC_COMMON) #define eTSEC_TRANSMIT 1 #define eTSEC_RECEIVE 2 -DeviceState *etsec_create(hwaddr base, - MemoryRegion *mr, - NICInfo *nd, - qemu_irq tx_irq, - qemu_irq rx_irq, - qemu_irq err_irq); - void etsec_update_irq(eTSEC *etsec); void etsec_walk_tx_ring(eTSEC *etsec, int ring_nbr); From patchwork Fri May 20 18:01:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634027 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=n+ZlzKQO; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZVl1wTyz9sFs for ; Sat, 21 May 2022 04:09:19 +1000 (AEST) Received: from localhost ([::1]:42374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns73t-0007hO-1h for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:09:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wd-00040d-CP; Fri, 20 May 2022 14:01:47 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:34461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wb-0004IB-QW; Fri, 20 May 2022 14:01:47 -0400 Received: by mail-ej1-x62d.google.com with SMTP id n13so15109757ejv.1; Fri, 20 May 2022 11:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JDiYaKv05xlAnTCFF/GxQrTBnijEkAdSBVZLfqAvB1o=; b=n+ZlzKQO7XNgG420rQZwx3sT1jwTuwHFibrvRTYDlf6pUfwW8KTMShsayATJSvKYh6 jqEWugbTEq73gaP1m0SE3pT1FDXSoTsAxZ/l51JO23DUiERotDj5GNXWrOcXLux93lIr XfnWsokK13zbQkUbZhRhBsnegq6qQALsBQND1RkeTzHdgpNaoCa+g+oeVndBa8X2cxPw BVr7KxJcvLlWDFLF5XeQZ/+/D0gzUEW0eaeX+tvXTcaD7///9gsTdbSlistS+izWO0w4 ebUR0Qp1vMybmobGIGPuCXNI97i9fDTVobahD/V970sWXVr0ABaSV9nlOxRyB9lXyTyS KRgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JDiYaKv05xlAnTCFF/GxQrTBnijEkAdSBVZLfqAvB1o=; b=yJY6fQik/jgHljI8JYbnweU/AiFNq5ynB88haCp+A+3p6hMEfykpcohj3zvdcSpvpK O2WwhUAOE+sPtRRTvo95wJqRSkpCekkumqZJk6iqKL5oPNV5tr/stgCIn/CKQ/45vCZM JzDQycqxj7pYo7VnUxckM7jS0d2o2ajRMoxRdjbuLbHdtIBoD4l1MSEkSfTgR2OpENlB VfuVxKij25xRpai8A0Y4BYflZpOi+3qjoA1t6Rq8PgFJ/KVuHMYd/1XCeNS+V1FW/iSk aAraA+nmalDMOcm1v2KMj0yy0lpiZMqgWBfSXP+6/bq1qKMYzm9LFS3LlE1z8iYARGkn 4yFg== X-Gm-Message-State: AOAM531Z3/8Az01c8WvNKrfQ4pqLKCLlTmOEgZjgTlAhim5/nFYrUpET Hw5zEspAANiFkaw3aqWl83FmWG2da0s= X-Google-Smtp-Source: ABdhPJwfo3zc+GpKd8RILJ+KQpeOR+UBL5CUdyAeu17RKRGvVeMjMLZAhGPqpJjVBObg6FssxpSESA== X-Received: by 2002:a17:907:9490:b0:6fa:7970:3eb8 with SMTP id dm16-20020a170907949000b006fa79703eb8mr10101795ejc.457.1653069704060; Fri, 20 May 2022 11:01:44 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:43 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , Richard Henderson , Paolo Bonzini Subject: [PATCH v2 08/10] accel/tcg/cpu-exec: Unexport dump_drift_info() Date: Fri, 20 May 2022 20:01:07 +0200 Message-Id: <20220520180109.8224-9-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=shentey@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Commit 3a841ab53f165910224dc4bebabf1a8f1d04200c 'qapi: introduce x-query-jit QMP command' basically moved the only function using dump_drift_info() to cpu-exec.c. Therefore, dump_drift_info() doesn't need to be exported any longer. Signed-off-by: Bernhard Beschow --- accel/tcg/cpu-exec.c | 2 +- include/exec/cpu-all.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 635aeecc0a..7cbf9996b7 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -1048,7 +1048,7 @@ void tcg_exec_unrealizefn(CPUState *cpu) #ifndef CONFIG_USER_ONLY -void dump_drift_info(GString *buf) +static void dump_drift_info(GString *buf) { if (!icount_enabled()) { return; diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 5d5290deb5..9a716be80d 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -419,8 +419,6 @@ static inline bool tlb_hit(target_ulong tlb_addr, target_ulong addr) } #ifdef CONFIG_TCG -/* accel/tcg/cpu-exec.c */ -void dump_drift_info(GString *buf); /* accel/tcg/translate-all.c */ void dump_exec_info(GString *buf); void dump_opcount_info(GString *buf); From patchwork Fri May 20 18:01:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ku0NzfoM; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZRS12gpz9sFs for ; Sat, 21 May 2022 04:06:28 +1000 (AEST) Received: from localhost ([::1]:34398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns718-0002DI-7Z for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:06:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wf-00041O-Hh; Fri, 20 May 2022 14:01:49 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:43866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wc-0004Fd-E4; Fri, 20 May 2022 14:01:48 -0400 Received: by mail-ej1-x62b.google.com with SMTP id m20so16968911ejj.10; Fri, 20 May 2022 11:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DBvS+pFO863lsAYFzkOqAuhOuaOf26uAgucILAzfDNA=; b=ku0NzfoMSPHBIXgJV4k4tW+lmZAK47zJXjXOuPdUn0lQ55zxtREkpP/Ps3RCLoCrWT ZH8KAs1kIgEKfQc2n90ClrSm8uPaSNg4yGRc7j0vJxD65pPpmRZ9NTKVie85YjkcaaR4 c41/+fupoBD1uOXmBPsrToZz04hViZMyGJLzwza0ipfCOESYaL9O8pKbE4ySysuSTQs9 BggGKqLXyVq7uh/vLvy6eaHV4vfon09IynHeI32k0s9aK+COLBmCJ93IjSZ6+UB50DYt 5Yd7OUtCYTgWJeiG1UryMMzbd7a/w0CYKIh88D9HGJLjlViX9B6ZD9I11BKLQma2KLxV aI2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DBvS+pFO863lsAYFzkOqAuhOuaOf26uAgucILAzfDNA=; b=Ymmp5/qbgG6B4dAC10YXRioHxteZDk/VaMKYca4seZW5woPh/wHa1HYGJoBrFlpuEq epHoNOgbTRI+wk7PrYGLyhheYW7mJyBQ74poZGQRiRSSU9iaX7hTzMjPzfM0UxlTpSCM bx8mlTlsUgo6DKU5i1VDFfL+6j9BI/UW61elECmkiM+VYPBo/9YxbtpSTbvuDevjX/hO JOzecYQPuE6WuCbCqHxQF5xfcAY4PARYNTkDe4OixhQCJZKEmZc7L1IzlzgOwpYNue+s ey9HlZv5faNGg6CJ8AltcSDHasdwayPOOFukFAEnNDFcaGYE7c0HQqjX+PLBd0T2Umnd zksA== X-Gm-Message-State: AOAM530LMkaB8cyD1fHHYIQi/HCh1qKvzR8uwL5OAgrFonZEA2O5SVL4 xLOCohabIOm1QmdPx5DlJYc+PTsXRnM= X-Google-Smtp-Source: ABdhPJweJv0UWDL1Lk+iwZvv5wTTV32BOSYaVDMJKDjQdAjkP0z4DAjpM6K4f59JyVx2V7k04VAYuQ== X-Received: by 2002:a17:907:d9e:b0:6f4:2983:c371 with SMTP id go30-20020a1709070d9e00b006f42983c371mr9960076ejc.558.1653069705205; Fri, 20 May 2022 11:01:45 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:44 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , Richard Henderson , Paolo Bonzini Subject: [PATCH v2 09/10] accel/tcg: Inline dump_opcount_info() and remove it Date: Fri, 20 May 2022 20:01:08 +0200 Message-Id: <20220520180109.8224-10-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=shentey@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" dump_opcount_info() is a one-line wrapper around tcg_dump_op_count() which is also exported. So use the latter directly. Signed-off-by: Bernhard Beschow --- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 5 ----- include/exec/cpu-all.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 7cbf9996b7..a565a3f8ec 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -1091,7 +1091,7 @@ HumanReadableText *qmp_x_query_opcount(Error **errp) return NULL; } - dump_opcount_info(buf); + tcg_dump_op_count(buf); return human_readable_text_from_str(buf); } diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 291034cb09..8fd23a9d05 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -2124,11 +2124,6 @@ void dump_exec_info(GString *buf) tcg_dump_info(buf); } -void dump_opcount_info(GString *buf) -{ - tcg_dump_op_count(buf); -} - #else /* CONFIG_USER_ONLY */ void cpu_interrupt(CPUState *cpu, int mask) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 9a716be80d..f5bda2c3ca 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -421,7 +421,6 @@ static inline bool tlb_hit(target_ulong tlb_addr, target_ulong addr) #ifdef CONFIG_TCG /* accel/tcg/translate-all.c */ void dump_exec_info(GString *buf); -void dump_opcount_info(GString *buf); #endif /* CONFIG_TCG */ #endif /* !CONFIG_USER_ONLY */ From patchwork Fri May 20 18:01:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1634033 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=LQes4T2Q; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L4ZgF4YXTz9sFs for ; Sat, 21 May 2022 04:16:40 +1000 (AEST) Received: from localhost ([::1]:56010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns7Az-0000Eb-Av for incoming@patchwork.ozlabs.org; Fri, 20 May 2022 14:16:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns6wi-0004B2-Pv; Fri, 20 May 2022 14:01:52 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:35574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns6wf-0004Ip-IA; Fri, 20 May 2022 14:01:52 -0400 Received: by mail-ed1-x536.google.com with SMTP id c10so11777311edr.2; Fri, 20 May 2022 11:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6rHOlZhcSAmUz+LYlTjXbwVj8AtLeaPWMpPlecCUMcU=; b=LQes4T2Q7dUXvDjqW8i9MNLsvvCQ+8+u1EnDaPEoFII0bgxb/6fsyijhfXNBBltmy2 3oaPss/k9DIULOZ23bx6YKJpvGAloa1Q6L/iFZJMrQ/wWlmgKuijnPv8CRdPoMrO5f01 G8QNNlxQZKTo9QD1+4bF7le6vuYlBvgmP+qsWFazy9uOkbBN9OHLlUNcNJcRpEez9iHY g1p3FqGvq8jSwnqYh+sqvAuGpjPeoGtl0mkB75CtB2f0zSdPSEcDOiNvbXSW1vIcdRnN dk1m39LUhs+njDzkF6rv+zcrdDS6df+tSiCKQjB7PqbrZMpiMeLSMFR4LyhfYPro136p ouTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6rHOlZhcSAmUz+LYlTjXbwVj8AtLeaPWMpPlecCUMcU=; b=lr/gW0IChGfouPuoZd2LlvbkDr8ENZtFcHrxkqMR4qmg+i4977PVa7K2XDLwEj3MbM FBqI+LSC0YKhqgXPFz/UAmPHckJXnBqSPyXiCfksnYSc76nB9Khy1Tr094BnCBMm/zP4 3ixdD4RUXr781Dw1RCPmYOeb1BvpgKmCp9ut9SdgSrzI9h4EW/IoQX/6aIKlC6WHrIFQ zU8AibQO9/eAqrqHzNiLiMEuLRwk7U5MeuEIz1RyXjGfLcYKoTCcIiJi8L9MN0x55L6P +AIlrI9Pe0RweFXjZNY9uWaQqw437RVNchrEgPoFCEdOqKaQsWy/UAWWNc21pOPtpJ4h 6cZA== X-Gm-Message-State: AOAM531TIFnnRrZjzOU2/EMDyHdMOIV5zWznsKSwEM48bBcbIT0ILjoJ qFnPLYn75T1q+lK/NmLtkcLWAnYJOm8= X-Google-Smtp-Source: ABdhPJypnHD85eZ7BXazWYqZQFaP0RQLw0JWBOoYkbtq0iRStoGLwOGnudbfIMHGVtvwqEli5XI8ww== X-Received: by 2002:a05:6402:d0e:b0:413:3d99:f2d6 with SMTP id eb14-20020a0564020d0e00b004133d99f2d6mr12217907edb.189.1653069706358; Fri, 20 May 2022 11:01:46 -0700 (PDT) Received: from localhost.localdomain (dynamic-089-014-209-236.89.14.pool.telefonica.de. [89.14.209.236]) by smtp.gmail.com with ESMTPSA id w5-20020aa7cb45000000b0042aa7e0f892sm4622029edt.15.2022.05.20.11.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 11:01:46 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , qemu-stable@nongnu.org Subject: [PATCH v2 10/10] docs/devel: Fix link to developer mailing lists Date: Fri, 20 May 2022 20:01:09 +0200 Message-Id: <20220520180109.8224-11-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520180109.8224-1-shentey@gmail.com> References: <20220520180109.8224-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=shentey@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Ammends commit 9f73de8df0335c9387f4ee39e207a65a1615676f 'docs: rSTify the "SubmitAPatch" wiki'. Cc: qemu-stable@nongnu.org Signed-off-by: Bernhard Beschow --- docs/devel/submitting-a-patch.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index e51259eb9c..21ed52bd82 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -18,9 +18,9 @@ one-shot fix, the bare minimum we ask is that: `__ policy.) ``git commit -s`` or ``git format-patch -s`` will add one. - All contributions to QEMU must be **sent as patches** to the - qemu-devel `mailing list `__. Patch contributions - should not be posted on the bug tracker, posted on forums, or - externally hosted and linked to. (We have other mailing lists too, + qemu-devel `mailing list `__. + Patch contributions should not be posted on the bug tracker, posted on + forums, or externally hosted and linked to. (We have other mailing lists too, but all patches must go to qemu-devel, possibly with a Cc: to another list.) ``git send-email`` (`step-by-step setup guide `__ and `hints and