From patchwork Wed May 11 11:37:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1629552 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=kYw84BI/; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KytFb6ms0z9sFx for ; Wed, 11 May 2022 21:38:10 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 75DE5383D800 for ; Wed, 11 May 2022 11:38:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75DE5383D800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1652269087; bh=FJ2HprJ+MjjfecmyoWBUZZQbL+/dBkoClAMNEshcsBM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=kYw84BI/HGJlVkF1rzFB3VzkY0ISQTVn5xGnVmIFKd8Nj7AaclC5LBo43ramdyIOf h8oqW0HMDI6frr250I0LyqNepwweSNhZ0j89OxCsP0bhoFCMP/TyMgl4we4yK39D3N knPYezXYqAX4F8NLjnc7LNLj6KYKX5KzQak0EJxg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id A61343858401 for ; Wed, 11 May 2022 11:37:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A61343858401 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2510821B10 for ; Wed, 11 May 2022 11:37:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1285113A76 for ; Wed, 11 May 2022 11:37:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0Qh/Awmge2IFTQAAMHmgww (envelope-from ) for ; Wed, 11 May 2022 11:37:45 +0000 Date: Wed, 11 May 2022 13:37:44 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] rtl-optimization/105559 - avoid quadratic behavior in delete_insn_and_edges MIME-Version: 1.0 Message-Id: <20220511113745.1285113A76@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" When the insn to delete is a debug insn there's no point in figuring out whether it might be the last real insn and thus we have to purge dead edges. Bootstrap and regtest running on x86_64-unknown-linux-gnu. 2022-05-11 Richard Biener PR rtl-optimization/105559 * cfgrtl.cc (delete_insn_and_edges): Only perform search to BB_END for non-debug insns. --- gcc/cfgrtl.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/cfgrtl.cc b/gcc/cfgrtl.cc index 74ea14efc61..8e9fd1266b3 100644 --- a/gcc/cfgrtl.cc +++ b/gcc/cfgrtl.cc @@ -240,7 +240,7 @@ delete_insn_and_edges (rtx_insn *insn) basic_block bb = BLOCK_FOR_INSN (insn); if (BB_END (bb) == insn) purge = true; - else if (DEBUG_INSN_P (BB_END (bb))) + else if (NONDEBUG_INSN_P (insn) && DEBUG_INSN_P (BB_END (bb))) for (rtx_insn *dinsn = NEXT_INSN (insn); DEBUG_INSN_P (dinsn); dinsn = NEXT_INSN (dinsn)) if (BB_END (bb) == dinsn)