From patchwork Sat May 7 16:31:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1627933 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=Be3lMtmE; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KwXxg0CxKz9sG2 for ; Sun, 8 May 2022 02:31:18 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C1BE1825BF; Sat, 7 May 2022 16:31:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O8U-E0wysGhN; Sat, 7 May 2022 16:31:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id EFEDE826C1; Sat, 7 May 2022 16:31:12 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C41C7C0039; Sat, 7 May 2022 16:31:12 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id B88D0C002D for ; Sat, 7 May 2022 16:31:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 99C77825BF for ; Sat, 7 May 2022 16:31:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H5Cw0mB00ukY for ; Sat, 7 May 2022 16:31:10 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn2081f.outbound.protection.outlook.com [IPv6:2a01:111:f403:7005::81f]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7CD6E825B1 for ; Sat, 7 May 2022 16:31:10 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B9bX7vuHBk5d/SXNrzF2iFHA/689iXSRH40xCoZyTvlH1MdxVb/n2nb+yxRNbr/o0j2/+EcJRRlSPVZzRtzP2hWe34N9r1LkTKCNLe5nfDglo1Z9VTYBIRZFZZMcL13UcRLyXJi/JIqK4UG5h90mofP3MEwLakmIgJFPSQN6jJjC63SRZ5x9Y1Y+ETKHdmjPEK1Kr2GEjR9pdkrw6JFUgAMK8m7Tjd04lr6BpIoEDNAfQTuHq5fmiqwUhY7qNpiO0+XAc16OuWYXALB97y4mo83lHcxuixv7o4zwmI6wJEOXujwsxkORHRRWNRPJn4AkeB4ZPQqwomEo5N2rD4kpIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkNefvzP87Rq59LYAM+XfgJP+9x10XmWc2Ir+PvfzqM=; b=JkQrh41YILLT7NwUnJb3viDp0Ylucf03ThRL32RFtmy2rqwKwmb1chNxEjKJKxy5asnH3yiGMhllwlDhE3Oumt/MTl5d3nnkdx+o1SJITJuyjcUYapIixM+vnECfHBIwTW053yyT71itrlvPJ+sIUL8dCjFzqUWj1U5vCa4vO52h9KeGXSAJnealJlSvAgoefwUn5mykbyP8GFGz9WA/PfDwL+Eqot8oXuqQVRS/K2T/e84RM8UUgexPzSx92RcX9jdgPqbNFznbuSdTAb66zjTmr6LTZhqH775s5/wpyL86Qxahdv2PqX1gtAz1+Wd7Ls+pM8sHcG4QWKxIfEY+qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkNefvzP87Rq59LYAM+XfgJP+9x10XmWc2Ir+PvfzqM=; b=Be3lMtmEBkAkdgGGOgde6B1w4GrVQhFoestfyPI3L/zXQVjKe27I+GlpWgmICm5dZWeoq0h/N6xaJRlUojDfhA+NyJUhvvOZHd4bPWtTUKj9ob+rZibc9YIpDSCsmAIzVSwiDWuurpkZSZi7DDWTzdmruZs3E1K3VmzBnAToEh4rAotEqglENucfpzgKfCdKbqwz4GaJ81P3vKITYgerU13Zn2z6qoMkOvsaH8U+0kpSjTq5rpKZIGAfzPRielaaM+BW+5SwnoKm6JqxpUTg7n9oWy4nG8NlDl43L/zxlYf08PTzhQNfqFK4ONVGGQHZ0H1F3sy+5jDoQaN7WlRuiA== Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:15b::24) by SY4P282MB3584.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:17f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Sat, 7 May 2022 16:31:05 +0000 Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::f1b0:b062:c467:b9a]) by MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::f1b0:b062:c467:b9a%3]) with mapi id 15.20.5227.022; Sat, 7 May 2022 16:31:05 +0000 From: lin huang To: "dev@openvswitch.org" Thread-Topic: [PATCH 1/2] dpif-netdev : Fix ALB parameters type mismatch. Thread-Index: AdhiLxv6IzjbeX2nTUKub7aXlj5FpA== Date: Sat, 7 May 2022 16:31:05 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [lasT6tSwD7OxULxHt0t9D53T7gIee3js] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 889fb624-9008-4a43-491d-08da3046fbc7 x-ms-traffictypediagnostic: SY4P282MB3584:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TcqJfxRvUCJTugYfcInuWiZLv/NVWtKgQAFblnfreABgNBFyzyQi9BfIt2tWbjLPs8dLZRoZqH20gbA0ahZqOHQQNhPyDtjGygkHalovEDHYLXp8osWMd2xRn19BWncY5D57fcPyIwRRQv8P7ffwo3i0yieHAQqE0KlIEJmMldbs1rf1dum4S1Eb98nPaMD5vjis3VurEeiaZ7Wbsvc16E6RJ6tmX3yDnqONeCkU/iI6yI0njYFon5bCfj8MH1GJCk+TnW9wzFr6/CCGf1fmmZNFrVH6mLO1vKmvQ7K6gRfHdP+8ViUHmxqyL1Y4lsW0P3k/C4hLlobwzaamVKDRzK/JfYS9E6OEDLU6eDPJZcqIJJ74MIF5yxvm00UOpyyindcGsxpaAOlQMBOx0PA3aJd/C5QDfo7RXhIBdMhK2PqkCa4xVMVq2uVeIlc3LF22UM2L+xQt6EEexeJhtTTDYj84ZlaD0mo61p9vJj7tfnCzojq4RXp3uLb1HTFOJn4JXElhDGnriHGxGcgU+XXjTf1fJXKWwIaDFSzPAP8lFT5tdUlY5ltW81CZAHc6O2xYOtVA4JcGaabsnjRIbGubFoQBpefXI3ORlXPI3gxWOtLo2fCh3CG1fj6HqunGSP+aqzbSRrj061pTfoQuBntJhA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?MlY0NVBiMVVlL3JjYlhrd3NJ?= =?eucgb2312_cn?b?R2o4cUpybGZIWlRrSzNtWEFlSElTSnhNSXJ6Tm56bmg1cmJJWDMvdTN3NHU5REdm?= =?eucgb2312_cn?b?c2VVU0ZkeUVQdndFbkFzNUlYaGwzRGt6ODlKaE9aY0t5eWFKYkRNRGhwUXpsNmZU?= =?eucgb2312_cn?b?Z0hPcExYRTZWd1FXSWhFVTRCSEM3YUNCVTZkWGptL1crTTVMTDVlakRkWXNUT0d6?= =?eucgb2312_cn?b?dkphenVuN3l5dWt2MmxsTy9TUDdtRmMyTmVTZmRmZ2NuQThhSGFjUkx2SDQrWFoy?= =?eucgb2312_cn?b?dWJ4S2lpZ2QyR2RaZnBmdWt4RzYrNzBBQnNEbW1TQnRza1NKMlZlRW5wZEx4T0xG?= =?eucgb2312_cn?b?d2NyMGdBelJPOVBsSklnSVpVcHlCbGM4U3NKY0RIc1d4UWRqVitKNGJ2YnBGNXNX?= =?eucgb2312_cn?b?bkhrV0ZGbUYyTjYrMncxZkg5Z2E1RjJjZ3k4MkNzOGdJOUdyaUs2TnFvNHdiTTY4?= =?eucgb2312_cn?b?Y2l0V3FsSUQvQUdnVmxuTUFaUm9mQlZ2YTUzWjhybG0wTEsxdmRreC9yS05LQ1BS?= =?eucgb2312_cn?b?WEdQb25ja2tIQmpkbnVCa2lpc3FKWHNPUTEyWVRaM0h0QnFscE5PT01iME8rMUxq?= =?eucgb2312_cn?b?NWI1UkJDUlRFNmZnemM5UXpWbk9sdkVZZ2Z2Q2dFTzloaGlzbXFTTG5wUmNlQy9h?= =?eucgb2312_cn?b?RE9icW9rOUhIZ1crZU04T3JOeWM2RkUvck0vMC9lZFFEY3lJd1RuNXZMMTRpYUhP?= =?eucgb2312_cn?b?M0xmRWJQN293ODNiekIxeFZlNXluOCtQWkEvay82c1o0S2lzUGRUZWhZV2hFMGJO?= =?eucgb2312_cn?b?NURsRWR1YnhIb3pXOEh1TTBkd0hHZFlFL0RNMWtMRDRYWWh4WmhLSWlqY2hkc2Rt?= =?eucgb2312_cn?b?aXBlUWk3dWRaRSswVFNVUnB3VTZsUmR4RUxzQmhZeXdkMFhCQkhPOCtSWnNFRVRY?= =?eucgb2312_cn?b?b1cxK2tzd01VVVRrZ0M0Z1lpWmlvRGN1OUFsSitJVVNCRnNRays5QTBRSkRjN1FY?= =?eucgb2312_cn?b?akV6akVzcUxvcHQ3V3pJRnNiWnMvU2dFTGxSNU5hQ2ZGNmJLeGx6Znh6bm5zc1lh?= =?eucgb2312_cn?b?a0JrdGVsSlJ2T1N3OHVzb3NxQzBRM0VPV1JuZEUySzAzeGdOU2RyU3pudnF5UGtW?= =?eucgb2312_cn?b?L1g1aGRDMGVLczI1cjBJNkFTRVdlaGhyL05rZ04rTG0yUThiNG56YURSVkU3cUtV?= =?eucgb2312_cn?b?d2V2Y3BUUTJqekJPT3hpUjNHZUVoc1dkeHp4MnMzUFJEc0hsdVRadlUrT1dMMno4?= =?eucgb2312_cn?b?TXU1N3I3S1Q3QXFMWVB3VTBOcUNNQ2dLNUIvM2JGZmNiUU1QK0NrU3lxeFlDRUtx?= =?eucgb2312_cn?b?TldpTDV3cXppYytoRVB2dlB0Wko3TTJTRlZlYXhuNWN4Sjl3UUlIamxORHZTOHRy?= =?eucgb2312_cn?b?UVljSERPUC9PelZhVWNobFEzeVZPREZIblJjcGVHdmhHYzRLelU5OVI2dmZEY2Mx?= =?eucgb2312_cn?b?Si94M2IycnJNZi9GY3ZGVmlpbTFaeHprN2w5UG5kekJTblpzNmZGMGx5ZDZmd0xy?= =?eucgb2312_cn?b?ajFoU1hpR0QwdGxMTi95RG02MTIxenRCQm4yaHJmcElRZHFNZ09SS0xKMElxMVk0?= =?eucgb2312_cn?b?R3RvNlNSUVIvNG91M1MvaitMMFlndjVJMG1OZkZkdFFPb2lZZmRuYUxHYllzcUZI?= =?eucgb2312_cn?b?SWlxOG4rZG55YmNqeHQyYzZYTGZHUmRzSzN0QXpJczI2OEZXM0dWcXhsYVNVUW5r?= =?eucgb2312_cn?b?cXhsQThwa0p3U2hYNENnYzNOWlJTeWw3a3RGR2xBWXpxNTBXWjYrVE5pY0lNc1Ru?= =?eucgb2312_cn?b?R0R2VHMyQWppS2Z2NHlYL2wwdS9MNjlYNHc1UzZFcW0xWStvOStvaG9xbGt3OXow?= =?eucgb2312_cn?b?ZkNOTUthR0kwUStSQ3YwbFhoam56SDlvTWswRmN2QVdJbnc5aHN3YUtVbmIxR3Fp?= =?eucgb2312_cn?b?NVd5QWdvTENiV3c0Z1RHMkZxRmc9PQ==?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 889fb624-9008-4a43-491d-08da3046fbc7 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2022 16:31:05.5707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB3584 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [ovs-dev] [PATCH 1/2] dpif-netdev : Fix ALB parameters type mismatch. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The ALB parameters should never be negative. So it's to use smap_get_ulonglong() or smap_get_uint() to get it properly. Fixes: 5bf84282482a ("Adding support for PMD auto load balancing") Signed-off-by: Lin Huang linhuang@ruijie.com.cn --- lib/dpif-netdev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.27.0 diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 88a5459cc..2e4be433c 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4879,8 +4879,8 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) struct pmd_auto_lb *pmd_alb = &dp->pmd_alb; - rebalance_intvl = smap_get_int(other_config, "pmd-auto-lb-rebal-interval", - ALB_REBALANCE_INTERVAL); + rebalance_intvl = smap_get_ullong(other_config, "pmd-auto-lb-rebal-interval", + ALB_REBALANCE_INTERVAL); /* Input is in min, convert it to msec. */ rebalance_intvl = @@ -4893,9 +4893,9 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) log_autolb = true; } - rebalance_improve = smap_get_int(other_config, - "pmd-auto-lb-improvement-threshold", - ALB_IMPROVEMENT_THRESHOLD); + rebalance_improve = smap_get_uint(other_config, + "pmd-auto-lb-improvement-threshold", + ALB_IMPROVEMENT_THRESHOLD); if (rebalance_improve > 100) { rebalance_improve = ALB_IMPROVEMENT_THRESHOLD; } @@ -4906,8 +4906,8 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) log_autolb = true; } - rebalance_load = smap_get_int(other_config, "pmd-auto-lb-load-threshold", - ALB_LOAD_THRESHOLD); + rebalance_load = smap_get_uint(other_config, "pmd-auto-lb-load-threshold", + ALB_LOAD_THRESHOLD); if (rebalance_load > 100) { rebalance_load = ALB_LOAD_THRESHOLD; } From patchwork Sat May 7 16:31:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1627934 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=PS21COoW; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KwXxk1657z9sG2 for ; Sun, 8 May 2022 02:31:22 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5B52282951; Sat, 7 May 2022 16:31:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oj2S5NZayGuL; Sat, 7 May 2022 16:31:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8A085828DA; Sat, 7 May 2022 16:31:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6D7BFC007A; Sat, 7 May 2022 16:31:18 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 87D6AC002D for ; Sat, 7 May 2022 16:31:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 76A5540603 for ; Sat, 7 May 2022 16:31:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=outlook.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K2k3orkJ0cfh for ; Sat, 7 May 2022 16:31:16 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn20826.outbound.protection.outlook.com [IPv6:2a01:111:f403:7005::826]) by smtp2.osuosl.org (Postfix) with ESMTPS id 555FC405F4 for ; Sat, 7 May 2022 16:31:16 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Npkp2h1ArbgD7RljDZfuUbB547AlBGH0N4kQ+IVGtXmIAcJel00xswLF2DbQs04xUD4F8+OqN4A1tzp70F5iFhvAgpHTu1GiQ66jWFSDf6vkFrUxRlGh9CajRCnqKq8i25Ojm+7eoAwvVZpY4HzqoQhwdkENFoolGrTg0G5W4OB1yQHfKyZJsvEhd0ZrhhVr9oy258Md1/dcP2tD6hjP0SxiPz8BmGb5Jio2aMI4SG9kE051hQ0AWv4imDt2o69WswOePYMofU9HNA7c6TePkzcyo3gGZ/z+i5abvspCi4WqQPLtLd9sCkXO6sXVyJj64O/t8aZ7g4kTUYth6Mbu9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QAm3CCcbCa/AyO5gnfO4Ba9c5D5oS4LGNOycqQu8MZU=; b=bfdBLpG/ljCVtbuv8+g5zniyHzMnxRdKX5wXnT58Vne491jOt4E9hPXtzMVZeYcmBdThr44Xurkd0sjmFdA5t7M4Pl0JyJFn1ajXdsoGX9vg0Yk742/4SXcWXZjvvYxscCHUmTPnmT4WhzBz6JsCcEUWR7+8I9fiRuT+jGtOle4wJyy2OT4EziPHZPLGO5NZzySlLZIkDegwBw6rTBZaIGCNlwVmdLzjd8S2UOiAt1kLHnID3dI0aK7UqnEPpPmeBfF6GWfgaJldya0yCwki8GEjorvp9VuFn9fdBf6r26KDyQhC+0n+3iqpJJiE3lfGxpPdQgghNYQL5CCWwUkrJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QAm3CCcbCa/AyO5gnfO4Ba9c5D5oS4LGNOycqQu8MZU=; b=PS21COoWOuzMSZIR22ck+DvrW+awmZAqDYGB6GVlF9nsNKLE/K1KYBJL4faeMu7GYmjjNaDh7KNXxqYQJSh8jl4bhdheqAmEFUhscp0O8JBYDZzrKLjlRx566VMp4xbHuamjgAiGFeEVL74QmiY7TRtSqh0YOkUhxheef0rqfTQfopYxLo4jnTNs40e3socIMJKbdFVjccaf/kTWf/bYIbrnENCuRUPITmRInNEdFdoVwHYQgVc+ZDsdGCXmPF1rNqA5Jjr2Z31eSfULwvT1xo+Gd3V4GXbd5XrUwusdl9ZgFY9DcZLlo7aAAtq2vd7HoNRr+2tHGxgkeolh8kHhkg== Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:15b::24) by SY4P282MB3584.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:17f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Sat, 7 May 2022 16:31:11 +0000 Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::f1b0:b062:c467:b9a]) by MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::f1b0:b062:c467:b9a%3]) with mapi id 15.20.5227.022; Sat, 7 May 2022 16:31:11 +0000 From: lin huang To: "dev@openvswitch.org" Thread-Topic: [PATCH 2/2] dpif-netdev : Fix ALB 'rebalance_intvl' max hard limit. Thread-Index: AdhiL6QS/QziVyZOQfuUxIKvojdIjA== Date: Sat, 7 May 2022 16:31:11 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [SPXnGyLBAJRVfI2MboefakqUS/b3C6NO] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5d18a6cb-2412-4231-57f2-08da3046ff2b x-ms-traffictypediagnostic: SY4P282MB3584:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 40idoyLt9P0UzJnpeic4NwjU7zCnmGAqWwwIE3cDqD9X+KP7pK6RrW7ln/msUpDlTfcD1ywGdY5gmZbqaLTWYj19vNA0RoDkPEkQ5f7iRi04C4WY/uzAY+nFrPWgkYE0M9kh2W1NNWKkQBU7PuUK52ahIlWZ+CWpDWVKigpQLmc8JdIsiJXhaSjQOfx7Mj2puTHIjupUXqg5yd2z+gbeTACg7GuyPcsId8EAjTn1BOqWx/kSdirPJZIKnnwgxq2x+R6Fom2Y5NVSKRZFn31TauAJE1lfI5JsHHPAaL+KIuWWeqpSTsnVTTLh5ogk58SSY8BvpWwHtseWprMpTmtqrDu7Nsphv5MRisbSvUUjXQnLnNWkX9EdlevgMTJgzb7vdx2Nfp7VF6VoBgNFZn7596haW/XIqnkoDFHI52WsgrDVxj5TJcXPhaWPdfMfv57rTfBz7gAnCb8zL8v9GZPsW4CGbx4HkJSw+d7y0hdiWvLP2oU7n3gjndnHwyxpxFMiBKQnRZNk2OvNtKsrhIWHhmLG+3J2yfUPCqhQ73iGrBsbjVr7+WDA6thZCDbocKFM5Xp4CqbU4sdadDRlX/0Ix4bYKkmpwAH2Oo4DzEdfkuhNrJ2rB5FVub/S1tPb42Xd x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?MnFDaS9La1BPZjErVXRBSzB6?= =?eucgb2312_cn?b?UkYyZnNXb0MzOStaSWFxL3E4aDFmWlFNd09qdXk1VnBJam1GMTdIRGlZSjVLYm5B?= =?eucgb2312_cn?b?OW1qODhieWFXaU9YbGk1SEZpVU1qVXFvMHFTaUhKR09LQXllQXlzUGs5Smh2SXRO?= =?eucgb2312_cn?b?dFRaREhKcVFXbEJ6T0phbHJOdDVOejZmNzR4MnR0aEZjaE5pL0ZVMjRGSXE2bGFy?= =?eucgb2312_cn?b?TSs4VllYRWZoZXlIUHhoRVJteFZTbFIrMSttRC9QdW5WQkVwaC9rU2lqZWdNQ0pw?= =?eucgb2312_cn?b?Z3NIeUVyUVVJS0FaaC81WnFDRW1EOU9DN0llNzlxR3JVOFdUVEJaSEQ2TWljSVZk?= =?eucgb2312_cn?b?MWR2SUN6Vjd0S3hHMThTRmgzUkRPajJVVnJvYXNNRllXdExJVnBJRW8rOTZDNjVP?= =?eucgb2312_cn?b?NUVVVmRMRkZ1T29GNkFZK3h4MktGaEFRZUpyUGo0YnM5S1psZm9lMm9vSWc5aDEv?= =?eucgb2312_cn?b?dlBrK3NORW9JUDQwYnRJWlFmcnR5aHZReHdCZS9UaFlFdlUzU1BBNy8zS2JJS21v?= =?eucgb2312_cn?b?NDFIYkZCMEVScWhRNllJM2tmeFhjdHFGRkhPS0RGUGZMMWZkc3dVdE1aN1BxaGQ2?= =?eucgb2312_cn?b?RVI5NUtEY1FCMldLc0grWFhCb0IvamZiVXhWUkpIKys2OVpwZmlrTW1lWUZzZFJS?= =?eucgb2312_cn?b?TmlqV2Y0M3lseGJSUTdTeTVvMlNBNy9kTzMxZUJWemFRMlRWNVRDclYxSWhGbVlh?= =?eucgb2312_cn?b?Z2dBUG1jWTEwVW5XeVVNVHUzS2hDTDlySisyMWRTWWZBaGcxMGNhRUhFc2haQ3hC?= =?eucgb2312_cn?b?bWRoZnBKN3NpZW0rMWE4bENvRndVSm5EZ2ZVUG1yUEZ2THN4dWJ2OFNuSFNxaTQv?= =?eucgb2312_cn?b?RmVkeG93TjFmTFN5RXViVHRWN1lZbkNvNG1TdHFuSnpSeER5cnE2bGNCM1NMOXdG?= =?eucgb2312_cn?b?NHFJSVpSdUJuUFBDeUlhbks1c2d0MEhaSG1DTmE0THVQbmdjaDZZejFQbTlBUUd2?= =?eucgb2312_cn?b?akl4MFhGc2RLejZxVFY0Q3NlY3BsSXNySll6VVN0OTcyZWsxcXVTNmZTc0EwWjdp?= =?eucgb2312_cn?b?Vjhvb0xrdFY1M2x0TnYwN0FoamxxWUIzb1NFTm5nWlMrVHVpaFR3MVVJVWFva0tp?= =?eucgb2312_cn?b?UU9KN2lMTDZNOGQvdkk2VnNDV2RnZlJ3ZDZlQWFDSHVod013Sm1JRHZsSUh3OHgr?= =?eucgb2312_cn?b?R3Z0QThET3VITmlUeG5yeDA5aTB1bllmdUV5ZFJTOGk0UFlWU2xQbmU5SWprV2pR?= =?eucgb2312_cn?b?ellZbmVjbitZdWlqSjBSYUFHZTlJSHVrQjM1cFZEazZ6QUNTdnhIeUY0VjRNM21R?= =?eucgb2312_cn?b?Q0RvMmlsaHErWjBYWUVWQVNLWDhFOFVxWmZYUzllWGcxakVVME5oZVVWN280bUQw?= =?eucgb2312_cn?b?QWJqL25FTEhOaVluRmN3YTd5c0c1cWxIbktTQ3VtR0o0WEszbUlDbDlPQTBXeTYr?= =?eucgb2312_cn?b?aW5FTEsya2taQjc1eW5heXFWeDRrUnZIT0pGM0ZlR0tnQUhJRHlHa2VGdGFPWlRK?= =?eucgb2312_cn?b?ZlFVbGxZempnSzFkd08wNXB1NXhDSFB4SVR5dzRrUEZSWU8zekpDR0NIUGlOZVM1?= =?eucgb2312_cn?b?SlhmT0d6eWJjNlpCTjZabmpVS2NLNGhYbXJKWVE3Qmo0NnozdGh0dGdjT0YvZ3FJ?= =?eucgb2312_cn?b?aVloN00xZDBlSDdlb3JyVDVlbVVNVklZaVpKOVVQZlpPRmQ2M1dGZGdwZ0tDVnQy?= =?eucgb2312_cn?b?b1ZiaFB5b1YrMTh6cFU0QjJvWjhUYy9kcnV1VU9zaXppc2Z0d3NlWmxER1RldkJF?= =?eucgb2312_cn?b?STFQaGxnaTB1aFZRK29LMUlXcmxmOGFEN2hWT1puL1g5ZXBJQW8wdTRYTTRuRzN4?= =?eucgb2312_cn?b?QmQxOEtXTWZGOElMQlF0bVF2NHlnR09LZ2NIWGloeW5qeDFsSVNqa2doRFN0NVBM?= =?eucgb2312_cn?b?SWg5Y0t1RmVDZXhjcGZWOEZiSmc9PQ==?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 5d18a6cb-2412-4231-57f2-08da3046ff2b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2022 16:31:11.2752 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB3584 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [ovs-dev] [PATCH 2/2] dpif-netdev : Fix ALB 'rebalance_intvl' max hard limit. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Currently the pmd-auto-lb-rebal-interval's value was not been checked properly. It maybe a negative, or too big value (>2 weeks between rebalances), which will be lead to a big unsigned value. So reset it to default if the value exceeds the max permitted as described in vswitchd.xml. Fixes: 5bf84282482a ("Adding support for PMD auto load balancing") Signed-off-by: Lin Huang linhuang@ruijie.com.cn --- tests/alb.at | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/tests/alb.at b/tests/alb.at index 2bef06f39..17bb754ae 100644 --- a/tests/alb.at +++ b/tests/alb.at @@ -197,7 +197,25 @@ get_log_next_line_num AT_CHECK([ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="0"]) CHECK_ALB_PARAM([interval], [1 mins], [+$LINENUM]) -# No check for above max as it is only a documented max value and not a hard limit +# Set new value +get_log_next_line_num +AT_CHECK([ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="100"]) +CHECK_ALB_PARAM([interval], [100 mins], [+$LINENUM]) + +# Set above max value +get_log_next_line_num +AT_CHECK([ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="50000"]) +CHECK_ALB_PARAM([interval], [1 mins], [+$LINENUM]) + +# Set new value +get_log_next_line_num +AT_CHECK([ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="1000"]) +CHECK_ALB_PARAM([interval], [1000 mins], [+$LINENUM]) + +# Set Negative value +get_log_next_line_num +AT_CHECK([ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="-1"]) +CHECK_ALB_PARAM([interval], [1 mins], [+$LINENUM]) OVS_VSWITCHD_STOP AT_CLEANUP -- 2.27.0