From patchwork Wed Mar 23 10:43:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhiram RN X-Patchwork-Id: 1608528 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=RBfOhGN5; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KNlMQ6Ssvz9s0B for ; Wed, 23 Mar 2022 21:43:46 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A909A81457; Wed, 23 Mar 2022 10:43:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sner9KxJ55PD; Wed, 23 Mar 2022 10:43:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 0967B813B0; Wed, 23 Mar 2022 10:43:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D1E8FC0012; Wed, 23 Mar 2022 10:43:42 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id C0E49C000B for ; Wed, 23 Mar 2022 10:43:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id AD5944028D for ; Wed, 23 Mar 2022 10:43:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wqfdBdtLoD0W for ; Wed, 23 Mar 2022 10:43:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by smtp2.osuosl.org (Postfix) with ESMTPS id 64BF74012A for ; Wed, 23 Mar 2022 10:43:40 +0000 (UTC) Received: by mail-pg1-x52c.google.com with SMTP id i184so794142pgc.1 for ; Wed, 23 Mar 2022 03:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DjP5MRXA0OZ6+JlizIdeJnUbc2kI3NjLRrwvfJhzSGY=; b=RBfOhGN57qMUSx32eOgbMBHNbqsPoqk8zDtQPizOxAIP6pLBGp/CATdsVaIJPl5ta7 SjAn50IpTsIQ83GoiGUl7X9GxHOrfcDZgRD9SWv1AYmTGU06DrEAMruxCtDi5ucEgwNi 39SD2zOjriAWsERT2Jk75kOOozffCc/pyFuQUHAiaR92DK8Y20tuObu8lHnjB4nMOtUl FbfTvUtVCx5o5MnnINcuzHFsW9GdQGhzXROVjCrqEwzV0tczDBCAAN9HBvtsE/FephlN oOIQJ7jjNRxbdR2n9udu5IQGrsMTFR4JamTz+sGduEAjIHATxSy+gdj0PBiT3sYqb+5q 50mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DjP5MRXA0OZ6+JlizIdeJnUbc2kI3NjLRrwvfJhzSGY=; b=mSm/x0YJhFliwNkDXs/RSjCXE1OFk9nrWjFfdvLp4Wy3/7Iv/b7VotPZ/0LOpQuE/U rmYjlJvQ0mZZAecbmTHXhkwFUAG6mGVXn0y+x8qWIzAz5xSVEICgUmR9yRCDwHy3rKVH l9yj9XGkOOn2fGazWBM2AryRBoOe2bSeLPyYS1qdaJhDp0Gv3zCOOIPhyUM6bod59O/T eVCOyUTzLqj67PuG7nQpaAJUfEjIBJmpuepYd2+bLudh5AUmgip0H7VlDcuIjNoUE3R7 HSJgb4V3ns+TWffwL0gPNOggH+K3rMm2erc+pls5cIxjeivRHHoDAvii9H/5qPcKJQ0v tIYw== X-Gm-Message-State: AOAM533mGnvRB5nNv+eq//S8iPtnSwIZzFEQMIDS5DoZUPS8n4umcbUX YV4FWBv1d+9rRJJZyhzuX9YtPyylRlDeSvL9 X-Google-Smtp-Source: ABdhPJxwsYjkLXntfv60eksS1EMfgW5j1oXv1BWZo14CqOFPspsiamKC9Q58wynfCRSKVfYv3P7Pog== X-Received: by 2002:a05:6a00:1312:b0:4e1:58c4:ddfd with SMTP id j18-20020a056a00131200b004e158c4ddfdmr33856045pfu.65.1648032219546; Wed, 23 Mar 2022 03:43:39 -0700 (PDT) Received: from arn.com ([49.205.133.255]) by smtp.googlemail.com with ESMTPSA id o1-20020a637e41000000b003804d0e2c9esm19685593pgn.35.2022.03.23.03.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 03:43:39 -0700 (PDT) From: Abhiram R N To: dev@openvswitch.org Date: Wed, 23 Mar 2022 16:13:29 +0530 Message-Id: <20220323104329.279559-1-abhiramrn@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220323083506.267244-1-abhiramrn@gmail.com> References: <20220323083506.267244-1-abhiramrn@gmail.com> MIME-Version: 1.0 Cc: arn@redhat.com Subject: [ovs-dev] [PATCH v2] netdev-vport: Register IFINDEX for ERSPAN device X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" When enabling offload for ERSPAN we are seeing one error as below netdev_offload_tc|INFO|init: failed to get ifindex for erspan0: Operation not supported netdev_offload|INFO|erspan0: No suitable flow API found. Adding the NETDEV_VPORT_GET_IFINDEX to ERSPAN device resolves this error Signed-off-by: Abhiram R N Acked-by: Eelco Chaudron --- lib/netdev-vport.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c index 64331f74b..3b3927865 100644 --- a/lib/netdev-vport.c +++ b/lib/netdev-vport.c @@ -1245,7 +1245,8 @@ netdev_vport_tunnel_register(void) .type = "erspan", .build_header = netdev_erspan_build_header, .push_header = netdev_erspan_push_header, - .pop_header = netdev_erspan_pop_header + .pop_header = netdev_erspan_pop_header, + .get_ifindex = NETDEV_VPORT_GET_IFINDEX }, {{NULL, NULL, 0, 0}} }, @@ -1255,7 +1256,8 @@ netdev_vport_tunnel_register(void) .type = "ip6erspan", .build_header = netdev_erspan_build_header, .push_header = netdev_erspan_push_header, - .pop_header = netdev_erspan_pop_header + .pop_header = netdev_erspan_pop_header, + .get_ifindex = NETDEV_VPORT_GET_IFINDEX }, {{NULL, NULL, 0, 0}} },