From patchwork Thu Mar 3 12:39:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaoke Wang X-Patchwork-Id: 1600314 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=foxmail.com header.i=@foxmail.com header.a=rsa-sha256 header.s=s201512 header.b=mlWvuDcf; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4K8VzC6Bwcz9sG9 for ; Thu, 3 Mar 2022 23:43:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230388AbiCCMod (ORCPT ); Thu, 3 Mar 2022 07:44:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbiCCMoc (ORCPT ); Thu, 3 Mar 2022 07:44:32 -0500 X-Greylist: delayed 197 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 03 Mar 2022 04:43:46 PST Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DD71117C85 for ; Thu, 3 Mar 2022 04:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1646311422; bh=2mTqmg1W9dS0Kv/L7soH7R821Fj9eiYWYXJ3eGCvI9M=; h=From:To:Cc:Subject:Date; b=mlWvuDcfv4D5VP+9NYeqfBVBk/SDZPzjLBNIWZGVz4xwOKsTA5zQ02dIcSnKT6mas vYWbz0sSFUE5ONLlIM5RRqicWVSyJpSOx7qtOVQdVR3jcoXwmDMfsKq2E8GKqNwevk mNnY22ZZdlfIVeflR7stUnpvppLtIlCAHkNHzwho= Received: from localhost.localdomain ([218.197.153.188]) by newxmesmtplogicsvrszc9.qq.com (NewEsmtp) with SMTP id A153102B; Thu, 03 Mar 2022 20:40:21 +0800 X-QQ-mid: xmsmtpt1646311221ts9xpavs0 Message-ID: X-QQ-XMAILINFO: MR/iVh5QLeieskBkOQTC34GkjTtKFjnqAHbO7jTmPOdIcJoSGaezNK0TEBMRHs YYcz+lzJoRrC/rHx5sTHDkeORDBya205PJhtKQFDbxUhGqQlsD640Ck2lA7Lh+F4VNjRTum9MGt9 zicMXBkOOZ4pYMQddG5lSG3wVyVlVt3ByV5Q7wjXQZkXz+c+ue17Q0GhxAd1iM9oAKGdYPuf3Hg/ Xi7PVekZsxGTWYbOOnc6oLYo1zAcr6ms4YgL4qnplgaiXdeI5dukTkGgkt4cYGNuvfOdD4D0mk7w aYZL/fo55eXSVTBk4ad+Rad13h0J7VMBfEQDDY8J3JbydIHGXZV3/in09S52lndaQXzaom3zb0b2 gGEGRkzBJxOy67GswFBIKdWG2pMWtnC3P8wHUFziY0h3HmwtjY0KxFPt4wN2pJGS+EcpQW5RfRGd zP+eL7DJvCcvyKVLlZg+TvMPBUgJB/Fieb3A/BhUvZrEzPaKkpFtO5fAx6rhUnZp8+iOz097fta6 UZmt8voNzBTgydJI0S5Aqgqz57F7l12MtU+Fgh5PBQMXa8GkK/3xAtfDZSbKEYhky/3rrXN8gNsA wzoPDw7QflYrwtYVu0chHF12+vJZD6UIZRjsZVVxAPDo1RZsTrmJjVsZiBt8e7LAgzYJ1CnJdYbn p2cUn1GpRIn/H26Eo5tJGm1fMXtTTpAmR4a/K1OVOISVKqufl9izDxOTfrWQMlJo0VvhaRuElCFY aZn2FHEVh/wxbYyguvi+4tzpZQo3BXuq8X/dG4t+7RhY5dgPZI7BdHCZUfyZtR1jKa/uueDmBoaj ehcJesVJYM/6zWIFc1z7bkuLD52xdaYE5Awa1TLqObXd2O6iwH0WuclE+tjLZzagMuQQzpHlzC5W 6rO2xT9GDsvCWlcF8iGPUyPFebI4KcW08/yVQI3LBk/+ojlhQegDSTXz2Mp6jblG9PYUbdWFcX From: xkernel.wang@foxmail.com To: wsa+renesas@sang-engineering.com, peda@axentia.se Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaoke Wang Subject: [PATCH] i2c: mux: demux-pinctrl: check the return value of devm_kstrdup() Date: Thu, 3 Mar 2022 20:39:14 +0800 X-OQ-MSGID: <20220303123914.4469-1-xkernel.wang@foxmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, HELO_DYNAMIC_IPADDR,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Xiaoke Wang devm_kstrdup() returns pointer to allocated string on success, NULL on failure. So it is better to check the return value of it. Signed-off-by: Xiaoke Wang --- drivers/i2c/muxes/i2c-demux-pinctrl.c | 4 ++++ 1 file changed, 4 insertions(+) -- diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c index 5365199..3203361 100644 --- a/drivers/i2c/muxes/i2c-demux-pinctrl.c +++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c @@ -243,6 +243,10 @@ static int i2c_demux_pinctrl_probe(struct platform_device *pdev) props[i].name = devm_kstrdup(&pdev->dev, "status", GFP_KERNEL); props[i].value = devm_kstrdup(&pdev->dev, "ok", GFP_KERNEL); + if (!props[i].name || !props[i].value) { + err = -ENOMEM; + goto err_rollback; + } props[i].length = 3; of_changeset_init(&priv->chan[i].chgset);