From patchwork Wed Feb 23 13:20:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1596662 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=RnEUOLaO; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4K3cBP1Fnxz9sGY for ; Thu, 24 Feb 2022 00:21:33 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 758C683C90; Wed, 23 Feb 2022 14:21:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="RnEUOLaO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6899883B58; Wed, 23 Feb 2022 14:21:16 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062a.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::62a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6787083BC6 for ; Wed, 23 Feb 2022 14:21:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JZpUazwVZ3y/nvj65WRYUoEL/mSAvkZL3IiL4q412knmfq2B4L49sMVP+ACYnF4G1BuBggArhCFpvJeqKm80qhFjErGob4tS7C8TXpdHKyYREoArI/TCk/0U/ZAGMCTnlJlVuEvWK2Vm5mn1hiLJwvuHIoyrwelwi5blgAckDbiUSuyT4mNyJD6/kAvGi9ZF8p52ILVkH1JKOFANjqeinI6E/3yvMdPa4O3gg+y3TxDlpVOAe2vB/VeO90FCQC//X2WsoeGWTtw8KonrS2Ma71pfIcdvJekADdKcNccZ0ql4IKf+5nVTMlhOQP9pFfSVxUzZz5S3NNroyieZI+NirQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5hWMq1Zra19B/YdHjfzF91F+G9zqTC4hXUe5+BISNYY=; b=Z2dnIkeoJPEFPtTjn48yD+qlyQPwQ/Dh+fWWc1sDTlW1YyFt4IxiBngCt21X0AoWI0n5RvTr3pAwb+1Z7HTKFGGwHY7sGtAoQ6I8c6WJFC8FPk52omxGoJnycRTz73lnWKi0O6VL5nkRp37QGF2sfdixAxn+aQpFGlmDQ9ayOD7TMfTu1FcTraUro1SY+MInlY2JN5/O6jYWVJ2zr+dgvmiAdZBvaKUhMrotrb7xtzrjoRExtpMhPdy3ACjBudCPqDNGngfGtmxjD30b6P3zbfySxQCYIFdf+fQYqbP6dBZt7aK2jQrYwP7vRbOqlsr+4pCJK51x4JZaMGuacU/VrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5hWMq1Zra19B/YdHjfzF91F+G9zqTC4hXUe5+BISNYY=; b=RnEUOLaOd6rViq21m5Ue4LLrGLK7MBQx5L4xEmFG26nUXhaDjvRPoL73Jr5kqhhBu4CML1DKeRS/22gIvDvJ0B0Z8MS5Jo6sfuORZ5lXwQOe92VhovJB0R0ykBacjSyKMoPGq9f5F0XZHM2zceouFb5FQf+nlYWr5G5/SjxIVP4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by DB6PR0401MB2502.eurprd04.prod.outlook.com (2603:10a6:4:37::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Wed, 23 Feb 2022 13:21:12 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::95cf:8c40:b887:a7b9]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::95cf:8c40:b887:a7b9%4]) with mapi id 15.20.4951.019; Wed, 23 Feb 2022 13:21:12 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried , Michael Walle , Tom Rini , Priyanka Jain , Dan Murphy , Michal Simek , Grygorii Strashko Subject: [PATCH 1/2] net: phy: dp83867: avoid error in dp83867_of_init() when PHY has no OF node Date: Wed, 23 Feb 2022 15:20:55 +0200 Message-Id: <20220223132056.3364440-2-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220223132056.3364440-1-vladimir.oltean@nxp.com> References: <20220223132056.3364440-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: AM0PR08CA0012.eurprd08.prod.outlook.com (2603:10a6:208:d2::25) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9930ad16-320c-4164-dd0f-08d9f6cf5c61 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2502:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j+5HsJoprP9meS4nxNLJyRlPlQJe5Hp53Cm4yQ5Cxi2YOirqq3jo6VNrMOjxLJs87AfXVv97pBbdJfyJYIvaAlhKOItAk/QFp6y+OE02+XP4p4TbI0B/CPfo4Du8+WURoVWpS4raQi/TplJ3yhdOEWIT9EUdcZhGgcnZuzbDEWgsWNAAMmTEIBiqZs34InV1QuH4e39HY4SaaAWF0oM3xIL62wQx5Y6hPmKHBMGdfVoote7i1ACrkFtMZ5+ywXjoUut6mRM1gsrrqKhEMSUrijxXafLcWXwtEx9ULFSLPmf3yLkfeI9K2kWzVObd4SkIik2zDRwC5ojlYBB1wDxhfMdwaquTAGqmDkca/rZ3cFBE0ZmwPOgbsTeNncz461zod02xNStpo0UFG9JGrbzENQfDkiT15bW791HizznriWrsY/404x60l/94ESEDZSchByVxXQMJSWGY1h7N391FbQD2gu5oGZ3RzOxSLMDg5IY5PjLITA+I0vE0aG3T0svf44FESUifLWS+B5KaCu2LdqRyIg4hOLqLawSKsMPHSCEWpaOUOwtie8yyQKkRoevq/RPXLDH25XVjlTiQhDwECIfweP41xKnwyoHL/VzXxrhjXbgCVHYVAAMANHz9PFWvtXNcwMsOp6DqAD+ISaObRF3eK0QPSCFv+LqlWR65I1I4rhr69pBblrZ+bJ8PyKSdXhq0gWGYK32c79EgMaqTXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(86362001)(66476007)(66556008)(5660300002)(6512007)(38100700002)(4326008)(66946007)(6916009)(316002)(54906003)(38350700002)(2906002)(6666004)(1076003)(83380400001)(8936002)(44832011)(508600001)(8676002)(186003)(26005)(6486002)(52116002)(2616005)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: s8zJuQJEctX2bKxw7EHS98if41tHodifeaZDU1wFYCH5uQd7ZTL+UojXH15PxGpBPuR1JaoMOXd8bttWaPH6PxWgVdUVIW5jkMjrLB53lS1d8DRb7E5JUX7SbrJsC762EKSWKprAvr8oPfhRFNLArjMnSzG5oUM7V3m/u+cDxVPQsSvCvbaDTNw8TeHxcFjV5Om9KlYpDW7DhfhEbz59YrkPRIRzwPG/BYtDbeyGG/XwLmXgpRT8U3PEHpCFkmKKgJZE1KdeRZYkbKYA1u/kSv5TxGYCOEz8XJiJkpuC1E93Nm+v7bp9+9E9vd4cNaI+7YL8mhdEFa4bnM7Pb/qJTi9kqldSUnhfi4ny0J0pcubtFwOqskDrhZpZN18yi6O7R7yfu2LxMNIoxM7efuLxO5rpGbyB8gzMhyXEKFPGW3zi0LxkMBTjINzICYxPoVKtUFcS5ApaBI5gWVx2ewOqm3HRtQ16oMvSSo3REl3ybTnTpbSWSdot4Z2amCUCidcHWPjfP3WjVnIuAcMjq5CkNFsvcmmdnOBEIiL/1jrTuxcb+6QYQzr2y6qmekgkcyaWTwSNn9Full7c+9JjnsK7BqUXA7B8WaMXYlWS8KjYzh0VWNHO4Mo5eOxXI8Nh8NPFkllm1Iv8If59i5Ucv7RkgsaUu2EmhhR2mirC1qpHS6l/aWpNrOYWnoVYQTdmsikJLm0iqy5w/vRPGmKzTV+ccbJBjf0bedqN9UpNbfBJl7ZQL5rQm0zzNEK4jnHsY/IigRKNOPpmMqgpNiWa/SlPsqStx2MjlnJ8xi+9OhKlyAcInpeo6aHZbBBPTNwaefdkDQOYzYiBKWZwxsXR/S8/i7hBknay6+FmxrkC4wAwM4EBjmVUb1mqbt0SXAs5aiP+OQRYMyM9cCPvLpSq0lPEEELzP4tfrYhFqUTbi92uo916G5BvzxBGDL8AKWpEgy513OnKA4TkzOIV7wXq5JIYlofywAnhxyzH80C3eHXymO+jgxHwoawAbHxTwfMV1FZQIW9M+McIGYyIZpOzTsinyOstyEVUYRNmst8kYyz8RYKekWEa5O+6DbAJWjBd6Uaw0FHdkUivcbLN7uETvtej6Ms/KqYqJoO8ygpieG6cZc9P5X7V4xYn/9qS9NdqhlnG99iOpCNLUFOj8uh2VxypeMuk21ntVfVTgv0EbQ3U1Xap+o6yuusIJh9htgxtu7NrFF2iICbNv+AanA0lxfCEdb8xu1Xxy4/e8zNyXL+JjUEQSMk3SN+m9SoKilpcthgf4NipAq1rTyKRy5A4A/h46A/udoUi1SRPHODdHO0Q3/7qovNt4XKwfFVrIr1ArtIvSqiH7L0+wOr2Z1cmtc6iQhPYk25SeZ9GuLzc8MEMjvg0/kzPvKkLKspkvcPkAa8jHqhSiGQCnzwhFWNVywgk8QL2KSzDU/mwizlTUf01jcVyChOsQ4NDjDzIqPU0hTh5jLj7mLe6IuCIjVNMhxRMBWamWHjh36GDghiMOcKCWqS/Us7f0Fxq5j9FU1AOt2xK1LD9CZQYPKWUPUwQkLi9bTVRLve8WhhZc8gzaLFNt9Xj5+OvmbqtwazTRPK2000aPpYMVDMb9q9nOzrn8Q/STsfmbV++OMmEbEIYEUFQx6M= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9930ad16-320c-4164-dd0f-08d9f6cf5c61 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 13:21:12.0247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UtX6S/mYNlMgO4QTyvVDn2TJLYhO6bc51+H1vipUQ2WaoqYr4JUpkBIVmWYdEiUR9aG0lxe2Q5UP1kdToZ2Zsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2502 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean A DM_ETH driver may use phy_connect() towards a PHY address on an MDIO bus which is not specified in the device tree, as evidenced by: pfe_eth_probe -> pfe_phy_configure -> phy_connect When this happens, the PHY will have an invalid OF node. The dp83867_config() method has extra initialization steps which are bypassed when the PHY lacks an OF node, which is undesirable because it will lead to broken networking. Allow the rest of the code to run. Fixes: 085445ca4104 ("net: phy: ti: Allow the driver to be more configurable") Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried --- drivers/net/phy/dp83867.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index eada4541c9c3..49978d0f25f3 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -158,7 +158,7 @@ static int dp83867_of_init(struct phy_device *phydev) node = phy_get_ofnode(phydev); if (!ofnode_valid(node)) - return -EINVAL; + return 0; /* Optional configuration */ ret = ofnode_read_u32(node, "ti,clk-output-sel", From patchwork Wed Feb 23 13:20:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1596663 X-Patchwork-Delegate: rfried.dev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=Xm8shtR3; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4K3cBY3mh3z9sGY for ; Thu, 24 Feb 2022 00:21:41 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9702383CA9; Wed, 23 Feb 2022 14:21:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Xm8shtR3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1227A83C1F; Wed, 23 Feb 2022 14:21:20 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20611.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::611]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3668383C37 for ; Wed, 23 Feb 2022 14:21:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HTgP+3gKNjv92h/yyDL5rW5kLt/LaztwZbZtLsUov7EOSTeoSk3A8aBN4sllemkC4VnVHf5rdcBvt4fxSfG5CNFbh/KIA7+1OBJh2cujSV2Z2q++DRCUmNH4ZXe73WPF7ZjOqAkrXoG0CoIS2RV5pxjEzVxJ2zuVi5HHJuBrsMunfW6vMtHmYC5wFHlWkIAR54lLpsyl99vDuYKP2NgS8exDTsV+JwWyQyDjo6EFFWUO/yvFwzZWM611FoppEMa+ewjDXQ235C2KqaMnOyQ9vEXDy5qNmtyOPH0marzkoy4drkt7FJMMTX7tfV6OKUOnmAKnvTHjhnBjbRXU2TzLeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T9pAwjgXVT+oc/LiLDAtm40QFJ2L8pKuI9HfwkEgrEk=; b=IQWIAH9hhqJavvi/2acgVM+4za1pccDqXaOsLXFZSXnWVB4gCnO1GxbhEr5wFVql/HXSOq5rTtK0dVQW+gHoGPIlzMvreriJ9yEtBxqffgwKcn5W8XHk3Vm9AegTjxcGiHiuD/vei4fTGTpNetsTd6kBC5Yq7sfCGSbL7hYPYuEsvL6w//XLjmIg8YfHdrmHlb5V4AuOfJvcoG9Ys5SdVVTj0WKQjZMOOK5WqFe6OCV1ayrLVvIReQaQtkAHFK1Usu9PhRZDubZKSVIU5QrxiSHOYLqyRoYeJGyRy7p6bDtBOl7DJw9rb6dXl/g01cWIHgiIN5Q/v18dZMosbu/i6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T9pAwjgXVT+oc/LiLDAtm40QFJ2L8pKuI9HfwkEgrEk=; b=Xm8shtR3EM2aoeuT1mxirgvuaR/PaG8Int134Y1nchwquir2c9H2mOv812t3S83zmUCXLX5lbXRaeJfow7/MK+rmfzgq6Da0hEVtDqlRWgxZhSL/lEBA9mNDwdZDiA3K+ch+8PMtgUpfhuIxRGLRlYJHM+elLFp0v4mlw8cZhwE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by DB6PR0401MB2502.eurprd04.prod.outlook.com (2603:10a6:4:37::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Wed, 23 Feb 2022 13:21:13 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::95cf:8c40:b887:a7b9]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::95cf:8c40:b887:a7b9%4]) with mapi id 15.20.4951.019; Wed, 23 Feb 2022 13:21:13 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried , Michael Walle , Tom Rini , Priyanka Jain , Dan Murphy , Michal Simek , Grygorii Strashko Subject: [PATCH 2/2] net: phy: atheros: avoid error in ar803x_of_init() when PHY has no OF node Date: Wed, 23 Feb 2022 15:20:56 +0200 Message-Id: <20220223132056.3364440-3-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220223132056.3364440-1-vladimir.oltean@nxp.com> References: <20220223132056.3364440-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: AM0PR08CA0012.eurprd08.prod.outlook.com (2603:10a6:208:d2::25) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6934eb89-602e-4e30-bea1-08d9f6cf5d08 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2502:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gRZwJQYtizTp5mMN8s0iXZdVNrLVFe9C7J56aspdO82acxNPk/gldNzTEUse7U+SpgXgEM8AFO7lL3pcds0RRdvKLvorMD1Pcgv/jt75FOTBOXN0fhXep+T0bpfmemjdo01r4D+FbJODR52h0kDN81ZAzSYeb99La0hiVwFI1GIOpKAPoXZ3SaVQ4x6t34MQDIxA8sPjFTAtmB5YzCiLvQ3fLEonLJba0lUScI/Rp48RGxQYlm+ye7pVymG2LazEtW8qYyC3Cd5S2RbtnBfH4BmdfeoS7vuBIL2YQh619p4WzNL9dZhSLqUKnY9aKl+ogK9uzbw8/jOhBAUIWcgPEVnxRJGFfYMV0BZT3C/58Vz0ls7YMXMElDVmBxax2jBPbMpRhZqjk2y9HSEeY3QT8SVP0TES/wpPJfo47kx/WLleeg1hAYXd4k3lhTIfGMlJXD1NQV6ALbwbvtKc2Tyus8dnVV1MOiFEY2fAihfZOjq8DSrbQxHCEJseKkxCh9Xa0LiT1IbsX/asvkMXE2jLJyC3uQWG4OaqMVZPfay9RpYLT8J9dfPlJquqeyCn5vJpMNMYL77aaIWf/RDo+DdMowZh/6R/sGHoSBHTNbxOumOAigyO+H13ohI3LbfpZssP0Dv94HX634ch84F/TFXghVhxiwkGFnKeOuG+dzyX5p6waQfUvVTU4V+vsmdneFfkReakBGPljJbtlPLjri8G4A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(86362001)(66476007)(66556008)(5660300002)(6512007)(38100700002)(4326008)(66946007)(6916009)(316002)(54906003)(38350700002)(2906002)(6666004)(1076003)(83380400001)(8936002)(44832011)(508600001)(8676002)(186003)(26005)(6486002)(52116002)(2616005)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Uug3p6OCj2QRoB8I8H9xBpiaFrrgjerAAKig2NPsgAOx3b6n9/i1OXbyrqNLln3lrj0xSeHMeg9uKEiXAFsOyBfvtHMj4KRDKdgtDEHmMeNKHz2Og+4m9XI/ThrLJzG1+oUVBF6JVewFfuwbJY5ZQyOReOStW6T3w/SoLIc3gG9RDz823evb39v8vJZbgWODxC2W3TWVowR/36RGqF9VA+Rq3M2VY0OAyMR1xv9RJYiMsv18tq+DxEW++LINYw19W7ociuEsY/cO1RP3PCgkSOZEH5qXkBwW2VbG6+gfjw4U9GDzDDqIQXNA+9F2QadlzvngNZSQQSAEP2/W7VSLtB1SbpU1jeqZOsfLELJlK8oJO4M1dPMBx5HcB7wyPMG+gLVjupkgPm42/Y+nvtvsCvko/HhXxI8bKcNLnQjiiQ2PMclhBWTzCNGjvAFa/FdpEWG9kwql/VXgQ0B8FqYTAQY7/iDsVy/IMrl8yaQseGjA1FhjLvRBlkxJOTEBYpoeAoW8UmqEMXdEgbGXjYr8KtJ899yDQmi6wjtTAqSDQq9uNJ9XCkDAZCoSZtup2V/FGzzw27GjWZy07RG1HrAav5nB5SPFuP8lJrR1fHdl5rHFw+71oCknun0vnIGXvYJBAEclzkuLM2YUFUsRf0oNYWHRXPLqB200VY2xtn3u4pEs02YW2g/wvGjPWNXeOZc9gEMk+2KNMNEUsPUA+GdIo/MNdfokIo962rtVxZLzTZHF3dLn9FtzuA1l+M6/WKF135cKsTZePs196j4kOAtvS5/nSgsZa9hBuzMWuSffkvndVpP/qBI3UJvfuqtWLT0iBEf2nWmPsRwNgasNdBTRQP/7er9YVN4qrvD539tojQ1PBYvqLMIq03iesLSdOzO6JkumPTswB3HeE8ks8qY7XPjC8+roHT9puvWJz8MiDfi48kKolpHs+5HCoflHq/eOHEznINkVJvH8IiFf+i6PqAljYoacdib8PJxyqSyYFvJRXd6kAbWLusHZ9QRJ8yZPEQFqcNs+AcCk2d//ulK9iaGOC3HO4PGNkKnSKU4Mrxwa8FyKHNxrJi4XPsTF8gFlR/FP/6Ar7VubgWnCq8/y5BUfRZqAWkQoHYB+8GzQRJb5a/s3yJeBOyER504ZJizrSkPe1bR1oHKObtryGL31mOVQ4KrXz0ETa+85lAavSoujVcXl8SRXkwjUxJ0b4mJCz8rGMQwptXEv8bR6AqBl05HIzLGRz47fhVEtWKqcyGSWFJ7JOPQ0DGdav93YprlNNc9kZ5u6V2fttDifWkEDvyqZ3Thz4AV94YDo5FgkbfYEa2sWgI3BjaKhRM7dqoAWs0GpkG9lsjuYo31HI2b5e61GfpZBxplRSL7PY0uNAHruYbMRzzMlWPshIUIy3ZOJNIGauSmOdc7/twG74qsPTvKLDG4nns6OapUFRIgRM1Ub8qQ7wkSUx+N3r2hBoqYc2oqqLbpfqVPZNTgWWmyJM5dXiiEv+oHNKRb6A/uyA7s4GrdCV8hr7wcavXLQrGZYTVAYTfD/ST8QrK0LfMPmJSxFQTQN9xrhLJAN7W1jY5iAUGH99emg7rJIuUuTDCuenOnriOG759HajEu99P/tnqyzav37HXIaqdaOlpLysZA= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6934eb89-602e-4e30-bea1-08d9f6cf5d08 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 13:21:13.1028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /wu3zdMCuRBB54RR9WEaqM+u9dNgqxUSwsg9LT1gYpK3G2FVXdIJ280c72fW5For1vLvpSNYVBPu4INFVbjrJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2502 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean A DM_ETH driver may use phy_connect() towards a PHY address on an MDIO bus which is not specified in the device tree, as evidenced by: pfe_eth_probe -> pfe_phy_configure -> phy_connect When this happens, the PHY will have an invalid OF node. When ar803x_config() runs, it silently fails at ar803x_of_init(), and therefore, fails to run the rest of the initialization. This makes MII_BMCR contain what it had after BMCR_RESET (0x8000) has been written into it by phy_reset(). Since BMCR_RESET is volatile and self-clearing, the MII_BMCR ends up having a value of 0x0. The further configuration of this register, which is supposed to be handled by genphy_config_aneg() lower in ar803x_config(), never gets a chance to run due to this early error from ar803x_of_init(). As a result of having MII_BMCR as 0, the following symptom appears: => setenv ethact pfe_eth0 => setenv ipaddr 10.0.0.1 => ping 10.0.0.2 pfe_eth0 Waiting for PHY auto negotiation to complete......... TIMEOUT ! Could not initialize PHY pfe_eth0 Manually writing 0x1140 into register 0 of the PHY makes the connection work, but it is rather desirable that the port works without any manual intervention. Fixes: fe6293a80959 ("phy: atheros: add device tree bindings and config") Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried --- drivers/net/phy/atheros.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index f922fecd6b5d..fa1fe08518f4 100644 --- a/drivers/net/phy/atheros.c +++ b/drivers/net/phy/atheros.c @@ -199,7 +199,7 @@ static int ar803x_of_init(struct phy_device *phydev) node = phy_get_ofnode(phydev); if (!ofnode_valid(node)) - return -EINVAL; + return 0; priv = malloc(sizeof(*priv)); if (!priv)