From patchwork Fri Jan 28 03:40:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 1585457 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=denx.de header.i=@denx.de header.a=rsa-sha256 header.s=phobos-20191101 header.b=jXGOTUJL; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.a=rsa-sha256 header.s=phobos-20191101 header.b=uHeh+J5y; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JlNWj2mDhz9t5H for ; Fri, 28 Jan 2022 14:40:17 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B1B29837E7; Fri, 28 Jan 2022 04:40:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1643341214; bh=DglLMe+na3xLIbJ3gUDPe6jXGjZwkx6BKNqIUk1Ng0M=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=jXGOTUJLCWPNjdrWMHoR6wbilfc0Y7hEoy2IyiS1uurBxLiQ5I4i9KflvhUKZacwD T4Q7+NsDQREJyT20kGSAQRes1DzZXKW+EY7PUqDtCfwPx/NnF1q4njnEJhe21vGLg8 0IrwHNVzaKkdQUmuZfl+cbVuMhOJVOSBY6f+hplH5GTVOOZpxXPykw0uclGcWpfhUj 15ZThdoEAhGpys2kQ2AFTb2qRhlqwxiMgwmOrvZ7NbqjdkWZBF/xpfyoB+rzJ90kC6 akaQT3e9VZyF/Zq5KSAHKMF8OZkOa5qGuOH38nIqAqff12G4zOe6BscBprw7ASJ0Kp TXSh1Wgau9xyw== Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B13A783809; Fri, 28 Jan 2022 04:40:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1643341213; bh=DglLMe+na3xLIbJ3gUDPe6jXGjZwkx6BKNqIUk1Ng0M=; h=From:To:Cc:Subject:Date:From; b=uHeh+J5yN5siWA0KAtcGS9v7zVsGyZcWs82P/N+Gx6jjmdiba4BX5FLRduMZLntw4 3c1U09UShHiOoo9QTBDV+CY+GxA0YQXqiq7bHhWNh/pZDbuQF7TxvAKydq5zUhTUKK uPYjzrdd7588CZKfxayMQKW5mNzrzlxAD4TXtr3V1pQCvlOM1+rCmYWGCTUe+uoV3K E38Fk4k6FCDJuAx5l6y39iRO9Bzbc526S4kq526mxZ4soBF7Q6lFn9V/nZ5jO99U9L lYXb6Elrp6W+29/nEGzflWI8vtuB9jzhUZ5Jie4I4jbcYAbV60koiYDh2WXrb9DFar BL5/dYgXIbc3g== From: Marek Vasut To: u-boot@lists.denx.de Cc: sbabic@denx.de, Marek Vasut , Haibo Chen , Igor Opaniuk , Jaehoon Chung , Peng Fan Subject: [PATCH] Revert "mmc: fsl_esdhc_imx: add wait_dat0() support" Date: Fri, 28 Jan 2022 04:40:06 +0100 Message-Id: <20220128034006.1410704-1-marex@denx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean This reverts commit b5874b552ffa09bc1dc5dec6b5dd376c62dab45d. It seems the iMX8MM SDHC controller always reports DAT0 line status as zero after voltage switch at the end of mmc_switch_voltage(), even if it is supposed to be high and scope confirms the DAT0 is high. Reverting this patch makes SDR104 work on iMX8MM, however, it is not clear why the DAT0 status is not correctly reported by the controller. Signed-off-by: Marek Vasut Cc: Haibo Chen Cc: Igor Opaniuk Cc: Jaehoon Chung Cc: Peng Fan Cc: Stefano Babic --- drivers/mmc/fsl_esdhc_imx.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c index 9299635f509..5465992ec95 100644 --- a/drivers/mmc/fsl_esdhc_imx.c +++ b/drivers/mmc/fsl_esdhc_imx.c @@ -1552,20 +1552,6 @@ static int __maybe_unused fsl_esdhc_set_enhanced_strobe(struct udevice *dev) return 0; } -static int fsl_esdhc_wait_dat0(struct udevice *dev, int state, - int timeout_us) -{ - int ret; - u32 tmp; - struct fsl_esdhc_priv *priv = dev_get_priv(dev); - struct fsl_esdhc *regs = priv->esdhc_regs; - - ret = readx_poll_timeout(esdhc_read32, ®s->prsstat, tmp, - !!(tmp & PRSSTAT_DAT0) == !!state, - timeout_us); - return ret; -} - static const struct dm_mmc_ops fsl_esdhc_ops = { .get_cd = fsl_esdhc_get_cd, .send_cmd = fsl_esdhc_send_cmd, @@ -1576,7 +1562,6 @@ static const struct dm_mmc_ops fsl_esdhc_ops = { #if CONFIG_IS_ENABLED(MMC_HS400_ES_SUPPORT) .set_enhanced_strobe = fsl_esdhc_set_enhanced_strobe, #endif - .wait_dat0 = fsl_esdhc_wait_dat0, }; static struct esdhc_soc_data usdhc_imx7d_data = {