From patchwork Thu Jan 27 08:09:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvaraj Palaniyappan X-Patchwork-Id: 1584858 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=proofpoint20171006 header.b=OHHNshsh; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JktYM5GBMz9tkM for ; Thu, 27 Jan 2022 19:09:58 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9D77584E86; Thu, 27 Jan 2022 08:09:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3AiHtQufhl5H; Thu, 27 Jan 2022 08:09:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id CBDF584D6E; Thu, 27 Jan 2022 08:09:53 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8F1C4C001A; Thu, 27 Jan 2022 08:09:53 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id EFE55C000B for ; Thu, 27 Jan 2022 08:09:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D0BEB40986 for ; Thu, 27 Jan 2022 08:09:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=nutanix.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LN5pKKHosl1e for ; Thu, 27 Jan 2022 08:09:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) by smtp4.osuosl.org (Postfix) with ESMTPS id A0181403A7 for ; Thu, 27 Jan 2022 08:09:50 +0000 (UTC) Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20R6b3Rr032431 for ; Thu, 27 Jan 2022 00:09:49 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=proofpoint20171006; bh=LAvzY52eqKeTnKWInjnrw9VolfAgyk0GJBEsi5cR63M=; b=OHHNshshpODcaE4uftlHewK1eKNI0sFFCQfZTFBJve0YxWyrz/9sJqFJIW+b7lMruvqI CPYsVwMWzJGe+Fcz7zR8PH+RyurhCz27F+3634i+R9ofDINNPfbr8ndXwJhywughaQtc FShaTuZ3cAnfoCQ0sQluStsOdPrCnswFqu0/P5L+6BFipJkmuxphDksTECqnqdHfnMbN eDgVsI6Ra8fy70QXNO8sYmUQzqsMX1LJG0W5kGG6MBkin3gRvkfkZvPKfo6Woh4wr9k6 rMnCK7UfZnz872BwXRTvGK9+OOwkiQLnuIJ6uf3dem7TVPdrB9DmaRz8Mq0l4fekoEVt Iw== Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2172.outbound.protection.outlook.com [104.47.58.172]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 3dtkh5c0wv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Jan 2022 00:09:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EyCp8j1behX2FHifTusywBjHt/RETwXP6Ogab7M0bWAtrOrtkbRBSkY7up5BjkmFi6qZ0FLBRrw3MCnh8aY9M2pd65foUHOAElRjKzp3wtWSRgBMx2Hco4bwyDJMA9S1fC0uuWUS/c3HfS4fjSse44pIxui3f/xp2ah38gbeozjUod4UjqDAuLC7WRTo7ZVAhRWz0OfK9Kl7eR6t4G/6sNuZtlwRiefyQJ1hLYdKosCodWCjf3J+hwvHoXkFwt241YvqMCAxBc1yTjtr5Hyd5mgqPClT60EV0U+RZBfd71pp/aXdh3VP9I1bYg30qUYj3eIhz9tYyo6R/QrwDkhNpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LAvzY52eqKeTnKWInjnrw9VolfAgyk0GJBEsi5cR63M=; b=eof0SWBF+OtmorihEAMZUlyKqGER/xYNvRGZWi/rGmQcJX53xmKxcQGly/XJ0vmlgruuflLTbopuzfE4rEV6yu6ZT4h9yTM8qK87JxHjUhCS2I7AT965/75isDpmHDqPXqMCUqAk02ojDYAJS9LbQD9IbYqK086geWlFDmsMehhIkmNit7W4X6C5rrZMHGUvIc2MqCYbxIMCjPVkK/xOb5tgA5BwNKegytlcyrlgyjt4VTinSkzIa00ttkj73U9CTUyWXyr4JibUeALU0UHOkXB+hEIYbqIO4MVaiwznOwAEBdweowhorTjA+iwVsOxjS/wRaXZc0iJr+rVJ51zFpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from SJ0PR02MB7711.namprd02.prod.outlook.com (2603:10b6:a03:326::9) by SA1PR02MB8480.namprd02.prod.outlook.com (2603:10b6:806:1fb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Thu, 27 Jan 2022 08:09:46 +0000 Received: from SJ0PR02MB7711.namprd02.prod.outlook.com ([fe80::20e8:555c:c9cd:dc75]) by SJ0PR02MB7711.namprd02.prod.outlook.com ([fe80::20e8:555c:c9cd:dc75%8]) with mapi id 15.20.4930.017; Thu, 27 Jan 2022 08:09:46 +0000 From: Selvaraj Palaniyappan To: dev@openvswitch.org Date: Thu, 27 Jan 2022 08:09:29 +0000 Message-Id: <20220127080929.181056-1-selvaraj.p@nutanix.com> X-Mailer: git-send-email 2.22.3 X-ClientProxiedBy: SN4PR0501CA0125.namprd05.prod.outlook.com (2603:10b6:803:42::42) To SJ0PR02MB7711.namprd02.prod.outlook.com (2603:10b6:a03:326::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3e7ff53d-3fdd-4be9-ed39-08d9e16c61c1 X-MS-TrafficTypeDiagnostic: SA1PR02MB8480:EE_ X-Microsoft-Antispam-PRVS: x-proofpoint-crosstenant: true X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iJE5djLJA43jtlWTvWkCth27ZBRFtXS7N9PYda3zGKXEnDWD4F4+DBy8fZEtcUQp4lk16uW9Wx6XFcm4TjdyFojOAJPOd+7rrtvq5PtGoS/Qu/kwMZTZ2UbP82PenkLnuZIPP8ZHgGPiu9UqJ3UyBG+Qjl2zEkBPnq6VDMMbn+j3eWw4hKFpPQ/PQib60AnwINfFxuOgYLhlp244xz8UIS5WGC+SX6ovSLJL8gzMvpzmQ0cGnfmIGIhbJ3OgBLVK2A1rFVwxdSZrWrIQGgK/Bzu1ygrufFbs2HE/hFFJ2gqOmD2VE49WEUVXsl04PkOCfK+PKvIJcPlE6ymVX6t/j1BUDNAaLg47w52Wzksg8qnRIqSOACf32NtTXZ8+dSxB2HVOjMf/qOVhODD2Q/l9PtWz7/gpWKL1YYqS6vGOALvQPhr9LWb90ZU4dGOJhuKDyH7GNmoiDBbuYJIn3FKXm5zQ0ZvjXXR72aUt3AMSJKTmOSTyaFkigwxXCHqobrz3nuBMO9oK0gXVjqxYiuFRVwsyQ3DtMNszzRF+9xpUSqQFARCxP5bVl6Hj1hGfH+MtPmSw8UUszz7cUG6Pprg5oJYMpIMZiByXZrLH6OcWE6IF0kE0D6FBJ8gavWTCpoZmi8aWc0GTIxo4O0NGDkYXwq/xuDvM4z9Ld81QUrrAKU5JknhVdBwsnk23lPLpF5zrbBSR5NmEdTFjw7ZNuD/ZNKCSpMqDRH/Ae41pyqATe18= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR02MB7711.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(2616005)(1076003)(2906002)(66476007)(38100700002)(38350700002)(8936002)(26005)(66946007)(508600001)(66556008)(66574015)(36756003)(5660300002)(83380400001)(52116002)(6486002)(4326008)(8676002)(107886003)(86362001)(6506007)(6512007)(6916009)(316002)(6666004)(130980200001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vbX6DnbKx4MMMvij+/YnsX2i/Tqt8D1riZx0q7c7YoMLtoetF1fDueXprSf1Ez2ZWiFl6hCZEuce+LFtUTJ5rELn6b9w1GNIiUx++TzL3M7Q9CUwPvsreiM7yAzv0OI8nens0qh+tphKtAkbn06yJF8RB2iV+mt4COJhFblCKGhFFgyICqADF61SgofaCEIdi8wPl3zRSyD6Be60izmChXyGLQ49Xcuy2WV7kRimC6RI8zmx/8mTqWDsD/OAKo+NCkDEJbkfiiwZHC9GVCHiboukV84qOepgDLYvJsGsk0IuitgIpBS7ZSYvDxO6zPGq5QKjZagiu0JOfus1HKvGF9eBlNLGxFs9dIjKP4wSAcGNaXxJtckCqLY3xDZrOBWTfm31ws5GEKGBvUB6KHSsjMgLtuyyZTDOp3ZY0qWah6iLiH23tDR1OhAjFe+wV03zCoikEZ4RpstW+H1RnrY2sSEBjouMXzUgQcPJPHN69iAk6DfrWEzJO3veNgfbq8d1r5jcHoLNNpIQNpI5rCaaGH13+25TS8tbf7BGNqFnOxw4OztvXOwuAcCeYScPrnH3Il7kBvtuZTaycqQxM0YeoUzOLRtm8ExJAK0UQNyKstvOPCzVv9J73GmX4COhAtG8pQsUij1bEaMa4ADAEe2I6D5xF/Q2oX+50VVGHZERh9UJ8YkqlLAR6IeBgh3JQ7KLtFjsP0DK0h4GOv3qrnydG2Zw8e/9R3JBPipmV8jBEnLig+MdnAy8IhKMGzOaKlMZesJGee1Gels4yNjHJKm5Cg8M5SIeRzcVbMwN3DBIK4MKklaCssGt+Fe2Nyax5APOpxlFYU3u2FoldxUVKYOnv/UK7GYSfunO8DXNKvHQPZUR/EoMCqgdOnIEoWIbIK29v0Dy3ObqFuuLqPv7vnrTSmdHL4Q7nAs5kDO9ZPerkxQCnDj9uOdvud97mQzNs1WeIHBuVQXQ3Dzz+5CJ0aAe/cOjfv6am/IxjtLMpWmEQquC6TQ47DY7/D1nTtfXwALZXTpj4jvwCP1ZLcxgTzgxryUu5oJOcdJVkXkAILaCtnP6+8KwSC1jTen/KNIoN2MrVYNG2Gz2QWaZyLWX3pSi9oJMcdWd4lRSqDR/rMf9rUbcyYOZFt9BagQVU2jZ4ziJx6qGBjVRnMZCErfssbt5a3JP7U1P53swWw0+XqYndF9Obhlssc9y1/LKxj7qyO6Vmqd5tIv5zvOZyonP8AAdDe7+3DC40I/9bRtY/7MlUKamXY+roPhPnrNZKVCAUcpJmCAoJqXNB/n35972T3pNPpwQms/TX/dSjE7+foAanppGvg4uoGHGi27QI05v6Tnx7EyF81ihruh1k5qRIv6WZwjVAwOu8GGUzcHlT+bQ5QdIJETER2z4owEojUUxGeklAN3n6NlQoN9OtiDERFELvUU60qqqMBkGP8Ncl04bkR0sdBtvYGBVf5KtlDPNu3hchJqnRFT1C4eCxg0tLBRqxnYB9psJp7wxosE3QRS+F1ij2wiBR8cjbibqXC22IvvL9U3zaouYaixj2ZWLuoK9cHeYwqags797ScFC+BJwIEgw3jwQjKm0dZbEZIDmIH5tb5QcWVSK199plJvAeBtIwtUVupp2HNMRoCIdvIftDFzmjvkundkdehyTFlhAXZr8AOLnN8QLbofFjeHb/gmOptlv8apfGvX/br5VNRQZtyE= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e7ff53d-3fdd-4be9-ed39-08d9e16c61c1 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB7711.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 08:09:46.4483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DLhBxAMSe3ckvNzBi6z4PM6OSxrCRUmmfKHVbyGPb83Fy2gyBVxTtUkB0F3AwQ2MocElaGWhZql++j+abmO5iYxd4o7iai4EefbKloexv7Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR02MB8480 X-Proofpoint-GUID: FgymXzTAXAaobo85EtUsMpvxocH5HlZa X-Proofpoint-ORIG-GUID: FgymXzTAXAaobo85EtUsMpvxocH5HlZa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-27_02,2022-01-26_01,2021-12-02_01 X-Proofpoint-Spam-Reason: safe Cc: srini@nutanix.com, Selvaraj Palaniyappan , raj.iyer@nutanix.com Subject: [ovs-dev] [PATCH ovn] Copy external_ids from Logical_Router_Port to SB database X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This patch makes ovn-northd copy all string-string pairs in external_ids column of the Logical_Router_Port table in Northbound database to the equivalent column of the Port_Binding table in Southbound database. --- northd/northd.c | 1 + ovn-nb.xml | 6 ++++++ ovn-sb.xml | 3 ++- tests/ovn-northd.at | 14 ++++++++++++++ 4 files changed, 23 insertions(+), 1 deletion(-) diff --git a/northd/northd.c b/northd/northd.c index fc7a64f99..090922ae2 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -3240,6 +3240,7 @@ ovn_port_update_sbrec(struct northd_input *input_data, ds_destroy(&s); struct smap ids = SMAP_INITIALIZER(&ids); + smap_clone(&ids, &op->nbrp->external_ids); sbrec_port_binding_set_external_ids(op->sb, &ids); sbrec_port_binding_set_nat_addresses(op->sb, NULL, 0); diff --git a/ovn-nb.xml b/ovn-nb.xml index 6a6972856..293d25b32 100644 --- a/ovn-nb.xml +++ b/ovn-nb.xml @@ -2895,6 +2895,12 @@ See External IDs at the beginning of this document. +

+ The ovn-northd program copies all these pairs into the + column of the + table in + database. +

diff --git a/ovn-sb.xml b/ovn-sb.xml index 9ddacdf09..f7c41ccdc 100644 --- a/ovn-sb.xml +++ b/ovn-sb.xml @@ -3354,7 +3354,8 @@ tcp.flags = RST;

The ovn-northd program populates this column with all entries into the column of the - table of the + and + tables of the database.

diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 84e52e701..f9c5259f1 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-northd.at @@ -144,6 +144,20 @@ AT_CHECK([test x`ovn-nbctl lsp-get-up S1-R1` = xup]) AT_CLEANUP ]) +OVN_FOR_EACH_NORTHD([ +AT_SETUP([check external id propagation to SBDB]) +ovn_start + +ovn-nbctl lr-add ro +ovn-nbctl lrp-add ro lrp0 00:00:00:00:00:01 192.168.1.1/24 +ovn-nbctl --wait=sb set logical_router_port lrp0 external_ids=test=123 +AT_CHECK([ovn-sbctl --columns=external_ids --bare find Port_Binding logical_port=lrp0], +[0], [test=123 +]) + +AT_CLEANUP +]) + OVN_FOR_EACH_NORTHD([ AT_SETUP([check IPv6 RA config propagation to SBDB]) ovn_start