From patchwork Tue Jan 25 09:22:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Schwermer X-Patchwork-Id: 1583949 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=svenschwermer.de header.i=@svenschwermer.de header.a=rsa-sha256 header.s=mail header.b=kylaB1OV; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4Jjhcw4QP5z9sXM for ; Tue, 25 Jan 2022 20:38:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574312AbiAYJiv (ORCPT ); Tue, 25 Jan 2022 04:38:51 -0500 Received: from mail.schwermer.no ([49.12.228.226]:54040 "EHLO mail.schwermer.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573874AbiAYJel (ORCPT ); Tue, 25 Jan 2022 04:34:41 -0500 From: sven@svenschwermer.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=svenschwermer.de; s=mail; t=1643102593; bh=lzXvkmM5klQyazDKfd5oiSRvvKpYE6wa/9zpt4EmyIs=; h=From:To:Cc:Subject:In-Reply-To:References; b=kylaB1OVjLLpk6x8rW069cVa4uvEMKPHcN5lRnWEqBEchIxj62132pvpCn7AWBot4 R/24L9FOzd5l0ZqjuGA0HvYHZDyDdxWJINMVLF4myDBEA930CfQCVPzah9Umx5R/SS kl2fy42TzjxQ6qNtWuRPfcihdlhIK3LG/iOUY0VmwHH71GkJX4oKYPUJ5hhCGpJNoL 9ZlAFU3l6lQ/+FvrXeemREABNVYpscxai7SLiojj1A4GRjYclDceceAG/MmjlHIgr5 HOV5hhOrkCCJRe44BcpqNBkNbxhBhaLKOIi+hK1/bOf15rfJqVp6NHEPx1qYYaSjEY 1jBh/FWi9lr0Q== To: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org Cc: Sven Schwermer , pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, lee.jones@linaro.org Subject: [RFC PATCH 1/2] dt-bindings: leds: Add multicolor PWM LED bindings Date: Tue, 25 Jan 2022 10:22:38 +0100 Message-Id: <20220125092239.2006333-2-sven@svenschwermer.de> In-Reply-To: <20220125092239.2006333-1-sven@svenschwermer.de> References: <20220125092239.2006333-1-sven@svenschwermer.de> Mime-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org From: Sven Schwermer This allows to group multiple PWM-connected monochrome LEDs into multicolor LEDs, e.g. RGB LEDs. Signed-off-by: Sven Schwermer --- .../bindings/leds/leds-pwm-multicolor.yaml | 73 +++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml new file mode 100644 index 000000000000..8552a5498bdd --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-pwm-multicolor.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Multi-color LEDs connected to PWM + +maintainers: + - Sven Schwermer + +description: | + This driver combines several monochrome PWM LEDs into one multi-color + LED using the multicolor LED class. + +properties: + compatible: pwm-leds-multicolor + +patternProperties: + '^multi-led@[0-9a-f]$': + type: object + allOf: + - $ref: leds-class-multicolor.yaml# + + patternProperties: + "^led-[0-9a-z]+$": + type: object + properties: + pwms: + maxItems: 1 + + pwm-names: true + + color: + $ref: common.yaml#/properties/color + +required: + - compatible + - pwms + - color + +additionalProperties: false + +examples: + - | + #include + + rgb-led { + compatible = "pwm-leds-multicolor"; + + multi-led@0 { + color = ; + function = LED_FUNCTION_INDICATOR; + max-brightness = <65535>; + + led-red { + pwms = <&pwm1 0 1000000>; + color = ; + }; + + led-green { + pwms = <&pwm2 0 1000000>; + color = ; + }; + + led-blue { + pwms = <&pwm3 0 1000000>; + color = ; + }; + }; + }; + +... From patchwork Tue Jan 25 09:22:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Schwermer X-Patchwork-Id: 1583950 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=svenschwermer.de header.i=@svenschwermer.de header.a=rsa-sha256 header.s=mail header.b=N2xryDmQ; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4Jjhcz42Pzz9sXM for ; Tue, 25 Jan 2022 20:38:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574540AbiAYJiw (ORCPT ); Tue, 25 Jan 2022 04:38:52 -0500 Received: from mail.schwermer.no ([49.12.228.226]:54042 "EHLO mail.schwermer.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1574435AbiAYJel (ORCPT ); Tue, 25 Jan 2022 04:34:41 -0500 From: sven@svenschwermer.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=svenschwermer.de; s=mail; t=1643102593; bh=qN4cSBfS22kZL2/XFAdvektXweDw0g7tirZ7rjxVajY=; h=From:To:Cc:Subject:In-Reply-To:References; b=N2xryDmQ8DclhAETGCHfILpgGo+9sWHS37Sn2QrazMmNGppabn9OFWwhm2MhaaNRz +z1u/dbwQNvkt2Q1uT0k0kvnkUNiowSddN8RyaaOlA2lfZHne5l7wlxPvOjdyCGFHX ektOtlpQ2usR2LrJBolPbdHvWEiUvIJ32SYx3SL7dH/APAglxni4TuWmfYlKWOOrOr cqyhaY5f0PNv7Z9I/3qMbGbS24+PnBwyWOPRk7Xx/YXKr7IfYOZPZkzvXzEFS7mGWT nFg951AB8TRkJErUAibebgVak/1/TYZpnhBQgLddkauIKoi0NVDjBGvT/U9pCYD6l9 GRAK767Ev4tsQ== To: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org Cc: Sven Schwermer , pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, lee.jones@linaro.org Subject: [RFC PATCH 2/2] leds: Add PWM multicolor driver Date: Tue, 25 Jan 2022 10:22:39 +0100 Message-Id: <20220125092239.2006333-3-sven@svenschwermer.de> In-Reply-To: <20220125092239.2006333-1-sven@svenschwermer.de> References: <20220125092239.2006333-1-sven@svenschwermer.de> Mime-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org From: Sven Schwermer By allowing to group multiple monochrome PWM LEDs into multicolor LEDs, all involved LEDs can be controlled in-sync. This enables using effects using triggers, etc. Signed-off-by: Sven Schwermer --- drivers/leds/Kconfig | 8 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-pwm-multicolor.c | 184 +++++++++++++++++++++++++++++ 3 files changed, 193 insertions(+) create mode 100644 drivers/leds/leds-pwm-multicolor.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index b6742b4231bf..2e5058696fa6 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -586,6 +586,14 @@ config LEDS_PWM help This option enables support for pwm driven LEDs +config LEDS_PWM_MULTICOLOR + tristate "PWM driven multi-color LED Support" + depends on LEDS_CLASS_MULTICOLOR + depends on PWM + help + This option enables support for PWM driven monochrome LEDs that are + grouped into multicolor LEDs. + config LEDS_REGULATOR tristate "REGULATOR driven LED support" depends on LEDS_CLASS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 2a698df9da57..152f69374632 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -79,6 +79,7 @@ obj-$(CONFIG_LEDS_PCA963X) += leds-pca963x.o obj-$(CONFIG_LEDS_PM8058) += leds-pm8058.o obj-$(CONFIG_LEDS_POWERNV) += leds-powernv.o obj-$(CONFIG_LEDS_PWM) += leds-pwm.o +obj-$(CONFIG_LEDS_PWM_MULTICOLOR) += leds-pwm-multicolor.o obj-$(CONFIG_LEDS_REGULATOR) += leds-regulator.o obj-$(CONFIG_LEDS_S3C24XX) += leds-s3c24xx.o obj-$(CONFIG_LEDS_SC27XX_BLTC) += leds-sc27xx-bltc.o diff --git a/drivers/leds/leds-pwm-multicolor.c b/drivers/leds/leds-pwm-multicolor.c new file mode 100644 index 000000000000..c54bed4536d3 --- /dev/null +++ b/drivers/leds/leds-pwm-multicolor.c @@ -0,0 +1,184 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * PWM-based multi-color LED control + * + * Copyright 2022 Sven Schwermer + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +struct pwm_led { + struct pwm_device *pwm; + struct pwm_state pwmstate; +}; + +struct pwm_mc_led { + struct led_classdev_mc mc_cdev; + struct mutex lock; + struct pwm_led leds[]; +}; + +static int led_pwm_mc_set(struct led_classdev *cdev, + enum led_brightness brightness) +{ + int i; + unsigned long long duty; + int ret = 0; + struct led_classdev_mc *mc_cdev = lcdev_to_mccdev(cdev); + struct pwm_mc_led *priv = container_of(mc_cdev, struct pwm_mc_led, mc_cdev); + + led_mc_calc_color_components(mc_cdev, brightness); + + mutex_lock(&priv->lock); + + for (i = 0; i < mc_cdev->num_colors; ++i) { + duty = priv->leds[i].pwmstate.period; + duty *= mc_cdev->subled_info[i].brightness; + do_div(duty, cdev->max_brightness); + + priv->leds[i].pwmstate.duty_cycle = duty; + priv->leds[i].pwmstate.enabled = duty > 0; + ret = pwm_apply_state(priv->leds[i].pwm, + &priv->leds[i].pwmstate); + if (ret) + break; + } + + mutex_unlock(&priv->lock); + + return ret; +} + +static int led_pwm_mc_probe(struct platform_device *pdev) +{ + struct fwnode_handle *mcnode, *fwnode; + int count = 0; + struct pwm_mc_led *priv; + struct mc_subled *subled; + struct led_classdev *cdev; + struct pwm_led *pwmled; + u32 color; + int ret = 0; + struct led_init_data init_data = {}; + + mcnode = device_get_named_child_node(&pdev->dev, "multi-led"); + if (!mcnode) { + dev_err(&pdev->dev, "expected multi-led node\n"); + ret = -ENODEV; + goto out; + } + + /* count the nodes inside the multi-led node */ + fwnode_for_each_child_node(mcnode, fwnode) + ++count; + + priv = devm_kzalloc(&pdev->dev, struct_size(priv, leds, count), + GFP_KERNEL); + if (!priv) { + ret = -ENOMEM; + goto out; + } + mutex_init(&priv->lock); + + subled = devm_kcalloc(&pdev->dev, count, sizeof(*subled), GFP_KERNEL); + if (!subled) { + ret = -ENOMEM; + goto destroy_mutex; + } + priv->mc_cdev.subled_info = subled; + + /* init the multicolor's LED class device */ + cdev = &priv->mc_cdev.led_cdev; + fwnode_property_read_string(mcnode, "label", &cdev->name); + cdev->brightness = LED_OFF; + fwnode_property_read_u32(mcnode, "max-brightness", + &cdev->max_brightness); + cdev->flags = LED_CORE_SUSPENDRESUME; + cdev->brightness_set_blocking = led_pwm_mc_set; + + /* iterate over the nodes inside the multi-led node */ + fwnode_for_each_child_node(mcnode, fwnode) { + pwmled = &priv->leds[priv->mc_cdev.num_colors]; + pwmled->pwm = devm_fwnode_pwm_get(&pdev->dev, fwnode, NULL); + if (IS_ERR(pwmled->pwm)) { + ret = PTR_ERR(pwmled->pwm); + dev_err(&pdev->dev, "unable to request PWM: %d\n", ret); + goto destroy_mutex; + } + pwm_init_state(pwmled->pwm, &pwmled->pwmstate); + + ret = fwnode_property_read_u32(fwnode, "color", &color); + if (ret) { + dev_err(&pdev->dev, "cannot read color: %d\n", ret); + goto destroy_mutex; + } + + subled[priv->mc_cdev.num_colors].color_index = color; + subled[priv->mc_cdev.num_colors].channel = + priv->mc_cdev.num_colors; + ++priv->mc_cdev.num_colors; + } + + init_data.fwnode = mcnode; + ret = devm_led_classdev_multicolor_register_ext(&pdev->dev, + &priv->mc_cdev, + &init_data); + if (ret) { + dev_err(&pdev->dev, + "failed to register multicolor PWM led for %s: %d\n", + cdev->name, ret); + goto destroy_mutex; + } + + ret = led_pwm_mc_set(cdev, cdev->brightness); + if (ret) { + dev_err(&pdev->dev, "failed to set led PWM value for %s: %d", + cdev->name, ret); + goto destroy_mutex; + } + + platform_set_drvdata(pdev, priv); + return 0; + +destroy_mutex: + mutex_destroy(&priv->lock); +out: + return ret; +} + +static int led_pwm_mc_remove(struct platform_device *pdev) +{ + struct pwm_mc_led *priv = platform_get_drvdata(pdev); + + mutex_destroy(&priv->lock); + return 0; +} + +static const struct of_device_id of_pwm_leds_mc_match[] = { + { .compatible = "pwm-leds-multicolor", }, + {}, +}; +MODULE_DEVICE_TABLE(of, of_pwm_leds_mc_match); + +static struct platform_driver led_pwm_mc_driver = { + .probe = led_pwm_mc_probe, + .remove = led_pwm_mc_remove, + .driver = { + .name = "leds_pwm_multicolor", + .of_match_table = of_pwm_leds_mc_match, + }, +}; + +module_platform_driver(led_pwm_mc_driver); + +MODULE_AUTHOR("Sven Schwermer "); +MODULE_DESCRIPTION("multi-color PWM LED driver"); +MODULE_LICENSE("GPL v2"); +MODULE_ALIAS("platform:leds-pwm-multicolor");