From patchwork Wed Jan 12 16:19:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikita Yushchenko X-Patchwork-Id: 1579605 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=virtuozzo.com header.i=@virtuozzo.com header.a=rsa-sha256 header.s=relay header.b=QLCZBskI; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JZQ9s4svHz9s0r for ; Fri, 14 Jan 2022 00:23:45 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 962413C950B for ; Thu, 13 Jan 2022 14:23:42 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 149CA3C94AA for ; Wed, 12 Jan 2022 17:20:14 +0100 (CET) Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 471C62001D5 for ; Wed, 12 Jan 2022 17:20:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-Id:Date:Subject:From: Content-Type; bh=9/3hr+Dr7XbVSBz4JGfgVWwnYj5nFi/A329OH3uaPSg=; b=QLCZBskIz2HJ xH+1YJ1BFKT/EDJdJoolSjTg2dWiOhbt24vR96Jt3rDST3IuQW4OEMTmcNCsCaQ8ckGc1cbqJATjH vdcCKL+vQAUc5Xgx4NvYSuM08zZiuf/B1nGls413fCCpDNORjb/Vd+ZBO3n2Ac3SHiGE5seO4Mrvd yvBNo=; Received: from [192.168.15.37] (helo=cobook.home) by relay.sw.ru with esmtp (Exim 4.94.2) (envelope-from ) id 1n7gLn-0065uv-ED; Wed, 12 Jan 2022 19:19:51 +0300 To: ltp@lists.linux.it Date: Wed, 12 Jan 2022 19:19:41 +0300 Message-Id: <20220112161942.4065665-1-nikita.yushchenko@virtuozzo.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on in-7.smtp.seeweb.it X-Mailman-Approved-At: Thu, 13 Jan 2022 14:23:20 +0100 Subject: [LTP] [PATCH] nfs_flock: fail the test if lock/unlock ops fail X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Nikita Yushchenko via ltp From: Nikita Yushchenko Reply-To: Nikita Yushchenko Cc: Nikita Yushchenko Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Since nfs_flock is testing locking operations, ignoring errors returned from those operations is nonsense. Signed-off-by: Nikita Yushchenko Reviewed-by: Petr Vorel --- testcases/network/nfs/nfslock01/nfs_flock.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/testcases/network/nfs/nfslock01/nfs_flock.c b/testcases/network/nfs/nfslock01/nfs_flock.c index a7673c751..a13ddd251 100644 --- a/testcases/network/nfs/nfslock01/nfs_flock.c +++ b/testcases/network/nfs/nfslock01/nfs_flock.c @@ -63,16 +63,20 @@ int main(int argc, char **argv) continue; } - if (writeb_lock(fd, offset, SEEK_SET, BYTES) < 0) - printf("failed in writeb_lock, Errno = %d", errno); + if (writeb_lock(fd, offset, SEEK_SET, BYTES) < 0) { + printf("failed in writeb_lock, Errno = %d\n", errno); + exit(1); + } lseek(fd, offset, SEEK_SET); /* write to the test file */ write(fd, buf, BYTES); - if (unb_lock(fd, offset, SEEK_SET, BYTES) < 0) - printf("failed in unb_lock, Errno = %d", errno); + if (unb_lock(fd, offset, SEEK_SET, BYTES) < 0) { + printf("failed in unb_lock, Errno = %d\n", errno); + exit(1); + } } exit(0); }