From patchwork Tue Jan 11 07:19:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 1578281 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256 header.s=corp-2021-07-09 header.b=jYMFWZ/f; dkim=pass (1024-bit key; unprotected) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-oracle-onmicrosoft-com header.b=J1h2pyfe; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4JY2CG3xwpz9ssD for ; Tue, 11 Jan 2022 18:20:10 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348475AbiAKHUH (ORCPT ); Tue, 11 Jan 2022 02:20:07 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:57454 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233597AbiAKHUG (ORCPT ); Tue, 11 Jan 2022 02:20:06 -0500 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20B3TJkX022671; Tue, 11 Jan 2022 07:19:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=TvdQb23R4+kdvV7zq2LOWfvTZD+wlNDSUtuQ9bzSrHI=; b=jYMFWZ/f79XEo7qVgGy2uT31QNtyLIL+XiieGR3jCf/xkTtDni0aocfUuG7gn/HxdRD8 3pij7GoVxcSIhKNLnY28ytlXw6cXuEVAU0Djw2rYbkClZ8QuAPNvS4Le0j7Tfk63G8xi uVo1tnhmbvyT/E1Yx/AKfjND71zttcdcQ+GzdNTEi6h/nPTmyvGcJiK6X99ye7Moatvj 2RljPSNia95NwtgYYH5eIrlm9xtbel5UTNyV73tKHmivzA89npLZ7VNWxcaB5P0rsDPV MdtDUx8McijuB/0Nod8k10bACr88aci+s4/NCidM2L+pzFdmnQTBxHmxjLdfc1yyWfl/ jA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3dgjdbtmhk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jan 2022 07:19:40 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 20B7Fb2u146884; Tue, 11 Jan 2022 07:19:38 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by userp3020.oracle.com with ESMTP id 3df42m8bbd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jan 2022 07:19:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAHfAyCZ6g5iTbMW+UqNr42vj1cqs8HR/Ma1sIQS/3tfwsGXHvfkahfuWgY2Mzxcv5O6d4f52MDFq/eM68KR9/MikuWmal+Y7nxrLiOAG6sUrqCIlOjgD2tnnFWDYgEbR4NKwiheR1x1FwquIbweb9SFZuxWSVS2z4cB23MxIeVP5gMurAv8rzuImFiFoYVw8WVeoTefHiXzG7n0ADklwmho4uhhvGX446stZIevw9Sz1/JP20g+2KSDS9/FByfXheaH8sw9Y0hvrua0IOoICfAun9uhqWh9n+Lx+IwIm7Gy1OuNbMV8r5xzYVby6KBg19ApncnNqmKx7eU7zetRVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TvdQb23R4+kdvV7zq2LOWfvTZD+wlNDSUtuQ9bzSrHI=; b=JfT8K1uTMU32fUPtgBX03KVrr1C+1UrDID0slmQvGHjUlXdyaRnJYAG+OYg3rEBM19AfCU2lsmKy0kqdSl2PUysS+mNBt3VzwaR9vobVhhV7MOkY/C6TWMORbGzR4UmnbFm6P6eONfNt034uGzRJ0/RbKGKm2tYyhC9brLaA8Bfla6rIFH5D5jKUq+2kbsn8XfwhFApua/zSaNfaNe5LdGbdSxiWK42EDt9xd2c32g/+JBVyEzRhjrMPpQyzdn7idpLpIWMFtKUooYMl7yPj5s068w+AQpLcr7+kv8y8yCuhaVplAHVsGXZrSsMniI1OxQhaljXBBywi6ya81u5BBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TvdQb23R4+kdvV7zq2LOWfvTZD+wlNDSUtuQ9bzSrHI=; b=J1h2pyfelvuDCYLjb1bN0h2YkPBk+/cg7E5pEddq+HA72/3JwpqlHgeQSe0qriutg51DmWyuql064UiGr8d8w20cFrRpOUZ1YZ6FMcDaZ3aMg9LopBpmGX9le7HsD/ZVTy0t1gdZ30TwZ2vkjfFGUqh/gHzN4OSEsqqUByqQSzo= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MWHPR10MB1421.namprd10.prod.outlook.com (2603:10b6:300:24::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Tue, 11 Jan 2022 07:19:36 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b889:5c86:23c0:82b8]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b889:5c86:23c0:82b8%4]) with mapi id 15.20.4867.012; Tue, 11 Jan 2022 07:19:36 +0000 Date: Tue, 11 Jan 2022 10:19:22 +0300 From: Dan Carpenter To: Giovanni Cabiddu , Mateusz =?utf-8?q?Jo?= =?utf-8?q?=C5=84czyk?= Cc: Herbert Xu , "David S. Miller" , Alessandro Zummo , Alexandre Belloni , Marco Chiappero , Fiona Trahe , Wojciech Ziemba , Tomasz Kowalik , qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time() Message-ID: <20220111071922.GE11243@kili> Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ZR0P278CA0036.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::23) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91bc0f5a-3e63-4f0e-7252-08d9d4d2b904 X-MS-TrafficTypeDiagnostic: MWHPR10MB1421:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TWSVB2rRYRA39e5WxUG2hbp+wa3LU12fEUEP35cok8Frf6KQqknx8PQAxeiKXow2/UV72CqnSVfKnwPJJI2NFZxcUGWsXNNOrePNNDTOblAjPHNfOw2OK7lYOF6voxL6a4azk4aBZYxXAOgIf/MeQQ8I/J9udfn8jo+Rb+hrCdvXC5dpSiNoWNBE3HcvKVSc3bZ+5mbTus7R/WuL+QXTcqbPSD/GRkSZx7ViXTB+n0hTRNCu/+rvMB3tZu2MTQoUk0zEVfT3ynxnGHcxuaddySZdtPYiMyVawA1CaE6Gh1HwXs4Tq117qSr/jgZtZAXuuEC0r7V1WB0qBpEV/Rr5gaW07t9blAkefpwkFMj86JTktt8bZg2flsmFJ8JxOCUFDTvg3CwydqdHCA47dvdKmoCbL7tKTAr6K+zPKp1v+Xm28uLaz3t+oYBo4X8TWNSLQelFfZsn3esIHhWAY6woO88KOYLXPkwOtTcx74CgLueuC9/mxSJrbn9GrNsjUAtmB6Q7rlYrBZTIBdrz9fpNMfWkWw74y6NhHe5I628xGlQyhCIg5QSOMh4qRjmDnw9qUgDSZGlnM+64eHs7uOOZFxqTCF9n/gaJKb8+Vh34/0G5S9ihCg3VcIgHYhj7QoreRjOSL5GwdGnEJSiv+Cz8c9YmldJU5n8HdK6H6Nvq/oM/yIyqqtuNErV+f6HLTX9aJWy4cqcysMGARDVQfTpbyw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(366004)(33716001)(508600001)(44832011)(4326008)(52116002)(86362001)(2906002)(186003)(8936002)(54906003)(8676002)(6506007)(66946007)(66556008)(316002)(6486002)(26005)(66476007)(7416002)(6666004)(9686003)(110136005)(1076003)(6512007)(38350700002)(5660300002)(33656002)(38100700002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: E4W9pWZq0ppmeoQCZ8Jn2r6ap6y4LhCaRFqxpc8x7LyKLgFrrAX3dONom7W+Nwbors6O8+wFv75HCRM4+L5MmP5lcPtZvqZchW+F1EbnTCM/fe5DhbsjOVwIeXcQ8hIFOxbGci6VkklQsxF9mCbtuhVum8QTeQ+dNv/mMYwa3GS8tSRr6MNO3w4gY+2zwPRxt7kUa5CkSlAyNtWSizO4HsxGye4nnyhStHkWH38y0XSEkq/BKC1rpFOsNdQGpdHaOu3CI4v70lJsGvjHUj+QT+S44DAU17+qAHoYAWdxB1/DrnTs09Rboie8JxgxItbThssXD1l+7n9+e2ijMNXe1sdxd6wveH5L09QcfbkN1nc6w7ci5zTL2W69pxjp0I+4Fw6rwhl6WasMSasYpedsnypvZmUxxNatK3wRHFsjBjWZ3/HIQrj90F0LrdRJOtOUec55JsDeWmCIMnaVT7EH5m3XhyYMYstbcwP0+KgQGBBw/QSy4RCJFLFltRE4MMzXZf4tbVBSyM99JRx4qwif3rmzAjNtd0XHTxncB3yEWLcc/SfUz1oZIvrOv8SDk8uQMqJ36uby00QBJ6x+2lRM9G0AjhPvzH0jYLmWH4lYHFrqcgMzt//FXEOHc40cLVb5j3GDu8MEoo/ZVpp9o0a5LkNgRshbSCC0BQYdvYDznYv+RmgAX94p6IFqS2UumdIq/v1pc7dLfFQ4Cuw3exkXT3oGNX1isjq7dFVL7xmxzLxI66yC/mDYzd6da0h0tUPz7ScyaNvlFk9QKxDbXTX2O0/H3paLRjrhz8YgZ17GE5yMq1xBE/Vrjk8QASInp1JlXPZD/pSYY/yjQaxl7CPX6Qp3HWk7P1cJYggOQh19BU/+k/YDCPHGx3EyLS/+8yxCRN2Amz3T4sGw3Vy63PB+vkfZkL4M2khMJN0sUMhhJYSclNvnoVY9o6vAxO6/iEfX8zK+5QvCKr+dETysp/nC5a2/brsonuKnSVIikou+xZ/571lkLyKfDd/N505bym1zWzdFT5S2VJTC0iZ4aBTeCxItuPZL99+0FHoUe0dRVOz1Ix6kUQ9tE1EBd4pNyCrdg1TaHftS64xGlDl30Im5WlpHOlKXt5i0uD2X7ZfgvX56YLkuOPXqPbuSEDQkLKh3nro4DGHEbcMHVkOtTpGjjjEZAVGhtyNruCR02CUE1f0YufsRBGLxKc9nVnqWWwi79ulwalSPfyESpjgAvmyqKo9SLlL2ajJ2v14+fRcLxk0t9dW2Yh5AANfAIoaI1D58bKsd+xIwdz0k8T7ZfmmVa/kZkRG+yJ1t2JAKzrXGiO1JfL6mJ/fkaFUyuNP8XKrQ593XNKWi0CV+M+8ffZgHa04CpH+z69PHt3eOW5vK1F4KlBjeJRfe8sGIFfLF5Kx1HP29GTNH+9BeRXJoUNKM94aujj4/zsEJH2DK2smBuUD58ZIT9WLglQTQUlDnaFv4GniTZsDQEcCMcCR/hbxZ+jal8MibJU43pKNhLo6M2CSgopxy9kL3Ld7zm9a244PMfrj03qu/jHdzjOCX3OLznjZAWnomInrOUsyY4HlOW9c9Rd3ZYtJfjB73xasxiF292uSaW03IrL51ZYdtw0RloiMH1mD3zUfNRRZOp05WtuagEwk/l20Xg9z9jqxewD43dfJChQ7EJhPBnNAWweuB3l78enElpacUsa6tHs9MUCo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91bc0f5a-3e63-4f0e-7252-08d9d4d2b904 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 07:19:36.4432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L4DYtMoO1hMkXy+rokOEsVZ3XBuR/KsVyJSiBiBL0R6K8YFLPcpVJiMa+2IiikQUAH6q3KHHGqecXNieEDEsxFq1g41VkIvIEMpKQ8gXae0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1421 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201110039 X-Proofpoint-GUID: OyQMVpgJZTz8UG0jDDERFRYkcmmEHKOQ X-Proofpoint-ORIG-GUID: OyQMVpgJZTz8UG0jDDERFRYkcmmEHKOQ Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The mc146818_get_time() function returns zero on success or negative a error code on failure. It needs to be type int. Fixes: d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()") Signed-off-by: Dan Carpenter Reviewed-by: Mateusz Jończyk --- include/linux/mc146818rtc.h | 2 +- drivers/rtc/rtc-mc146818-lib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mc146818rtc.h b/include/linux/mc146818rtc.h index 67fb0a12becc..808bb4cee230 100644 --- a/include/linux/mc146818rtc.h +++ b/include/linux/mc146818rtc.h @@ -124,7 +124,7 @@ struct cmos_rtc_board_info { #endif /* ARCH_RTC_LOCATION */ bool mc146818_does_rtc_work(void); -unsigned int mc146818_get_time(struct rtc_time *time); +int mc146818_get_time(struct rtc_time *time); int mc146818_set_time(struct rtc_time *time); bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param), diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c index f62e658cbe23..7f689f1bafc5 100644 --- a/drivers/rtc/rtc-mc146818-lib.c +++ b/drivers/rtc/rtc-mc146818-lib.c @@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in) p->ctrl = CMOS_READ(RTC_CONTROL); } -unsigned int mc146818_get_time(struct rtc_time *time) +int mc146818_get_time(struct rtc_time *time) { struct mc146818_get_time_callback_param p = { .time = time