From patchwork Mon Dec 20 13:54:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Salvaterra X-Patchwork-Id: 1571061 X-Patchwork-Delegate: rsalvaterra@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ihZou/i1; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=kRDCdI8x; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JHhJ2031Bz9s3q for ; Tue, 21 Dec 2021 01:08:01 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ibwxJbhCwzuclWkgXKy/q2ECPDT01d+WTSRYB8sVM+4=; b=ihZou/i1ngwsX6 ESj/eY5zbdLNavzrhk765uV7o8hymBJzOdk55QKqzsCHdXI7w7gcDPYGsuXwEl3qATcNCkRrRoCjg G6KcOQgNyz5MjYSNY9u87NEcOOSy7I3WBVkhEtMtzIuPkYmXyloYRMx1C8Ib2ts/bZPekG+6/NxLn xBjgNQZ4qZuUjDfm8xGD1o0cop5sUyTOoZo3/bdeLxZ02UTXoHYKkBbI6Ha0Y8uGIwJdi2bUWvwb3 Bd+hWtu5VI2reNB/VJB0uVosPjL0H6kY93HGUqIolwx1FfSu8HO2TvXFNlusPkgLVHXRzDHSpsR+4 TIoTiSw0O/Nanxp2QFLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzJHj-002h5T-CU; Mon, 20 Dec 2021 14:05:04 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzJ7I-002e3L-Ih for openwrt-devel@lists.openwrt.org; Mon, 20 Dec 2021 13:54:17 +0000 Received: by mail-wr1-x434.google.com with SMTP id d9so769673wrb.0 for ; Mon, 20 Dec 2021 05:54:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AX8ewI0zbOKtD1XDFTtTqKMbmoT4JWfVeUcPzZfVXMQ=; b=kRDCdI8x+VFo7kWr24SZ4lP3IWj+VqoH0weTrktUUc+srRBBVhaNUDb8YHoRr9ukni jcX7VocS8GpP+T2fg5ZvyfWSKTIC99UmvzzaUMtM9x2ASsUMUhwlLHJfC+EoBQLP3R01 w7A6vtjyOYjE6Pa87sj3uE0cKrhZ/IvEZ4NkNqJWL/7qDD+IxOoQjntzjItUP/2HKEMT FW1iey7lmQS8sA8cQkJWKExYSsiQnljcHujaUef8m3cU6XECzRYOeC7ZJvt9XZTvBJEW AtoT+POGOm0fsiu5zEZAI+cLuwfBwkf9k+fRsIyhTGhTFK7mUUmXeoS9mZGXqTZV1DG9 Uwxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AX8ewI0zbOKtD1XDFTtTqKMbmoT4JWfVeUcPzZfVXMQ=; b=VErI+SqV9PxT1/syg4vjeUyivOX5uE9qQ6XqFE8yrNAzPCkm1wfDG4C/jIKAofrL3o Wfw1Y2WUd5EBXphhFlryhJeD8Ifzawbx3iteS1bPt13K8AhnkJOzmxCwZE17A88A/Qpv PfMeyc+k7ouoO5IWnBMopzDvckEAvLUErmunRhSznVfJB4PlKREpgUxmbubtEsjMmeEy kQbeL2hQSZYOrQI9sz2btJ8YIBjUIGNQmaZgAMSuYuPdwVuhnY05LZL1I+yFFjCI9Q/t BEZQ/xGJMbDhUBpqONEVdy04v0elXkUsC7/4GHOAtyMHj/cUit2BtNI7lHEyAl2Psmrs eWRw== X-Gm-Message-State: AOAM531/nYstdf+iJwJgbahiRsPjvGtCvlev95pAZMzw4k3mqjxTaw0m lUCo/vwRx8eRWu6kD0I29UPzA/bmAg== X-Google-Smtp-Source: ABdhPJzNmNh7fLPqXWSee6WbKIYhUWxoe2bbfzFAtwIJDqDPN4/ew0vAKsGmCPWLsUy62OvDt3Qjmw== X-Received: by 2002:a5d:4fc2:: with SMTP id h2mr13048819wrw.262.1640008454988; Mon, 20 Dec 2021 05:54:14 -0800 (PST) Received: from crystalwell.adg.lan (a109-49-8-180.cpe.netcabo.pt. [109.49.8.180]) by smtp.gmail.com with ESMTPSA id c11sm13841670wmq.48.2021.12.20.05.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 05:54:14 -0800 (PST) From: Rui Salvaterra To: openwrt-devel@lists.openwrt.org Cc: nbd@nbd.name, Rui Salvaterra Subject: [PATCH] kmod-sched-core: remove fq_codel from the package Date: Mon, 20 Dec 2021 13:54:08 +0000 Message-Id: <20211220135408.271139-1-rsalvaterra@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211220_055416_654529_93FCB75A X-CRM114-Status: UNSURE ( 6.96 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Since fq_codel is the default (and built-in), it's unnecessary to make it part of kmod-sched-core. Remove it. Signed-off-by: Rui Salvaterra --- package/kernel/linux/modules/netsupport.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:434 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [rsalvaterra[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Since fq_codel is the default (and built-in), it's unnecessary to make it part of kmod-sched-core. Remove it. Signed-off-by: Rui Salvaterra --- package/kernel/linux/modules/netsupport.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/kernel/linux/modules/netsupport.mk b/package/kernel/linux/modules/netsupport.mk index 166172dbf3..25266594fe 100644 --- a/package/kernel/linux/modules/netsupport.mk +++ b/package/kernel/linux/modules/netsupport.mk @@ -722,7 +722,7 @@ $(eval $(call KernelPackage,mppe)) SCHED_MODULES = $(patsubst $(LINUX_DIR)/net/sched/%.ko,%,$(wildcard $(LINUX_DIR)/net/sched/*.ko)) -SCHED_MODULES_CORE = sch_ingress sch_fq_codel sch_hfsc sch_htb sch_tbf cls_basic cls_fw cls_route cls_flow cls_tcindex cls_u32 em_u32 act_gact act_mirred act_skbedit cls_matchall +SCHED_MODULES_CORE = sch_ingress sch_hfsc sch_htb sch_tbf cls_basic cls_fw cls_route cls_flow cls_tcindex cls_u32 em_u32 act_gact act_mirred act_skbedit cls_matchall SCHED_MODULES_FILTER = $(SCHED_MODULES_CORE) act_connmark act_ctinfo sch_cake sch_netem sch_mqprio em_ipset cls_bpf cls_flower act_bpf act_vlan SCHED_MODULES_EXTRA = $(filter-out $(SCHED_MODULES_FILTER),$(SCHED_MODULES)) SCHED_FILES = $(patsubst %,$(LINUX_DIR)/net/sched/%.ko,$(filter $(SCHED_MODULES_CORE),$(SCHED_MODULES))) @@ -737,7 +737,6 @@ define KernelPackage/sched-core CONFIG_NET_SCH_HTB \ CONFIG_NET_SCH_TBF \ CONFIG_NET_SCH_INGRESS \ - CONFIG_NET_SCH_FQ_CODEL \ CONFIG_NET_CLS=y \ CONFIG_NET_CLS_ACT=y \ CONFIG_NET_CLS_BASIC \