From patchwork Wed Dec 8 07:51:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 1565127 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=WZG72vIs; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee2:21ea]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4J88Wm1w3Lz9ssD for ; Wed, 8 Dec 2021 18:52:04 +1100 (AEDT) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4J88Wm0ZM6z4xZ1 for ; Wed, 8 Dec 2021 18:52:04 +1100 (AEDT) Received: by gandalf.ozlabs.org (Postfix) id 4J88Wm0Wpfz4xhj; Wed, 8 Dec 2021 18:52:04 +1100 (AEDT) Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: gandalf.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: gandalf.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=WZG72vIs; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4J88Wl5GVfz4xZ1 for ; Wed, 8 Dec 2021 18:52:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240855AbhLHHzd (ORCPT ); Wed, 8 Dec 2021 02:55:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231739AbhLHHzc (ORCPT ); Wed, 8 Dec 2021 02:55:32 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFEB5C061574; Tue, 7 Dec 2021 23:52:00 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id p18so985766plf.13; Tue, 07 Dec 2021 23:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OugZMT2M5ZDnSu+JcYein3ciyAIl9s8J2Fw+G4vDbaE=; b=WZG72vIse6pieieXJfgtY6m3c4REzAHoko54lnE2THEZl3iNBw4kGeFiRZYCOoDrTA QGLv24VrIsj+yBHpN6gtQx23CMKoVFVVqXZIyo3saHjMdSvlSk1OX7b+bHqMpyhUga8Z IOEe8BEvgMQSipzbSEpxMgOHYLhPM4DBqGNG7YdBkky7MjBZamXDMJ2eLAE1OhIF/8IL KipdDAuLRNvxl1wR0YMl4hHsKSdwkxIldRT/ZBpjPDZVnmqab+u8SHxtqs1UEKmwnsk+ lET3UQi4C4cMEEvO6e0fsLtaj7R0AirpEw25OmLgDfBg7ckYq6ujJOxG2S85iQbsrDpv DKUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OugZMT2M5ZDnSu+JcYein3ciyAIl9s8J2Fw+G4vDbaE=; b=M+5BiVTAOXc5JYp/3/4IDwriYyTbcVloOAsiV9bl+o/e/WOJlUs4PXhbNAEktebYHf Amy/Qb4sYdBKZ/GtiuBJicHGxaxYqBWWUr1w+T06cb6V/YOdHWy08orDqI4/9IjI1oYP DYcwYe0KCvLAej+ruqEPXLh2Y7IoIWuHlVB/EdWRkRDbIO8CfWwT1UGGdVccYRjxl1tp ulfQkTShQ21ihKusW0PuGx9w98qavepV0jDGz8mX+oo2m6ndHMB/r3SwnD1pjpLwkgZT WC4Bdv6dpBDgKzMxQQc3mCJDlpmtHdSpJszF5l0iyjWGEikXj7k2TO4GXg8crAuv3Bol B3/A== X-Gm-Message-State: AOAM530MbrIUxfGWTdRhNBu1sjHK8YS16k9DzslLb0Uy3o2mRsoS7Qte +UYKNYiuOzrx1w70TbHr0ZM= X-Google-Smtp-Source: ABdhPJwqjN0muZvKsgEQ8OaB0heymV0D93JX4akDCaURb1Tm5etVnUPT15Mo3hPhSG1NbqNELWShnw== X-Received: by 2002:a17:90b:1b03:: with SMTP id nu3mr5418749pjb.240.1638949920380; Tue, 07 Dec 2021 23:52:00 -0800 (PST) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id h26sm1634548pgm.68.2021.12.07.23.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 23:52:00 -0800 (PST) From: cgel.zte@gmail.com X-Google-Original-From: luo.penghao@zte.com.cn To: Theodore Ts'o Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, luo penghao , Zeal Robot Subject: [PATCH linux-next] ext4: Remove redundant o_start statements Date: Wed, 8 Dec 2021 07:51:57 +0000 Message-Id: <20211208075157.404535-1-luo.penghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: luo penghao The if will goto out of the loop, and until the end of the function execution, o_start will not be used again. The clang_analyzer complains as follows: fs/ext4/move_extent.c:635:5 warning: Value stored to 'o_start' is never read Reported-by: Zeal Robot Signed-off-by: luo penghao --- fs/ext4/move_extent.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 64a5797..95aa212 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -632,7 +632,6 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, __u64 orig_blk, /* Check hole before the start pos */ if (cur_blk + cur_len - 1 < o_start) { if (next_blk == EXT_MAX_BLOCKS) { - o_start = o_end; ret = -ENODATA; goto out; }