From patchwork Wed Nov 17 21:28:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 1556394 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=wQol7O8v; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HvbfH618Tz9s5P for ; Thu, 18 Nov 2021 08:29:10 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 19D4E385AC3E for ; Wed, 17 Nov 2021 21:29:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19D4E385AC3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1637184547; bh=85NbAZ8W/9ODZPx8Hkd7gdh2a7oiZveZZJhghnEgZwA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=wQol7O8vyomMNMF87mV7Qk39ZH8u39ZBZuNVphGvEsqYTyKtgX+LmoynWVGlERpDz Jm+ur/IRLbX2kVrrPqn3gSy+I1uLFdBdNLi3OKtMCiBiWbSuLZ/GSv5fcECWwtV6e9 9r5t+T2GSLgXedJOrl0ihYU3ClYPWELQxoYq2c4o= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id EE39D385AC2B; Wed, 17 Nov 2021 21:28:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE39D385AC2B X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [79.251.8.28] ([79.251.8.28]) by web-mail.gmx.net (3c-app-gmx-bap70.server.lan [172.19.172.170]) (via HTTP); Wed, 17 Nov 2021 22:28:00 +0100 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH] PR fortran/101329 - ICE: Invalid expression in gfc_element_size Date: Wed, 17 Nov 2021 22:28:00 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:pd4QnTmIdZ2YEuBM9RogURbB7UoVp3zJWsda2X3uSPJQf3wR6hoBVz8ja6Qpo2pFznLoD Ed60td/glE2+krJS5NdPn+Lx4O26xsAPKYwvimd5cXyP/rkQnkYfWYYqkkhugbR2OZ2/ZAa8R9un abDTi8Ty/AkT03A9WC7vsf17mdKElGpIPSMXrWPyFPiQcVW+RIuzTF9cirK7vwJp+Otj203mlZmQ fWx/HCjZZgVRnW/EEeDuIhxM9YVzPX3/ItxFBJk989dN7UQsbHSIBBYWgelAuZu6zLa2j/ZADd9L zY= X-UI-Out-Filterresults: notjunk:1;V03:K0:QLTYLtfIIx8=:12sxlsayXpkN24m3QjYrZH Bc4+vKOK4WCDe0idaG4YC0JSnPgyV6xlX5XqNkD3+NDOYqjHf0PCfySwWh/z5zZcbZSOrySvf lWkdg7sGm436o3A37huz+lA1qmEAX+REAGWHkjyZhF2TlT0+bB71ZQFTGlu3ljg0mryEQzxDd Inb/SZTk9yqlJH9QQaEDrHZm7yh/ffR0K6vazA486SwbyY2uXluLRbiS70YIgUbZ+IODJIAKD Qd124u7ABKXCMuxYr+uVHgN7vWQgQlJBeJWllv3jJKD/RVzlpNP+zr7vtvuAKOsMdnPSAaonf y8+S07I4zCz1+MVnOcVr3SLuuT2dYF+NDVJA5iIp+x9PhM0Sj3J7RBphywm+jpm5t7xG3mmDk Qnpndxyo2TtoDYwLCVSMOwSQvAbfNdCyDAjUQBu+FbYe4cuRtMTaCrAo4YS2gyfOJc8ec6EF/ pXpYRY3Iv76hxAiHyN0NFQvez3BStZ49xXN16W/m0JslGaEfcWqrV281yqUt9UOUEPTOMYJ44 /KC1GIH4CZAwLdMbrmmrU/8iyc/qO5vEGCK1CgJD0VsNlstqHWIjKND9qicfd/h73MdrS9mhX jK8bI3Gz/JWh4KeY2deWB1TtUIo70FcYmN3UVhCLJPFX6jZMLPSPFLIq36yZNb1B/5hgQmJxH /IrDUWvZukVOnPBMLpbN4sBpZsSU72M+UN0ZJ+a2MSg50V4/9Xgq5wASF4m5+OuwrVp88xmN5 Gu++j2mjyRrCeq8Hz4y0zCFRH2/VkiXqlaZBsb+R4J3thujorHJWX8Hfcl7NaAANCNav8QzMz W/Q710l X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Dear Fortranners, as NULL() is not interoperable, we have to reject it. Confirmed by NAG. Other compilers show "interesting behavior". Obvious patch by Steve. Regtested on x86_64-pc-linux-gnu. OK for mainline? Thanks, Harald From 52a3ee53f0a12e897c4651fa8378e045653b9fd3 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Wed, 17 Nov 2021 22:21:24 +0100 Subject: [PATCH] Fortran: NULL() is not interoperable gcc/fortran/ChangeLog: PR fortran/101329 * check.c (is_c_interoperable): Reject NULL() as it is not interoperable. gcc/testsuite/ChangeLog: PR fortran/101329 * gfortran.dg/pr101329.f90: New test. Co-authored-by: Steven G. Kargl --- gcc/fortran/check.c | 6 ++++++ gcc/testsuite/gfortran.dg/pr101329.f90 | 13 +++++++++++++ 2 files changed, 19 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/pr101329.f90 diff --git a/gcc/fortran/check.c b/gcc/fortran/check.c index ffa07b510cd..5a5aca10ebe 100644 --- a/gcc/fortran/check.c +++ b/gcc/fortran/check.c @@ -5223,6 +5223,12 @@ is_c_interoperable (gfc_expr *expr, const char **msg, bool c_loc, bool c_f_ptr) { *msg = NULL; + if (expr->expr_type == EXPR_NULL) + { + *msg = "NULL() is not interoperable"; + return false; + } + if (expr->ts.type == BT_CLASS) { *msg = "Expression is polymorphic"; diff --git a/gcc/testsuite/gfortran.dg/pr101329.f90 b/gcc/testsuite/gfortran.dg/pr101329.f90 new file mode 100644 index 00000000000..b82210d4e28 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr101329.f90 @@ -0,0 +1,13 @@ +! { dg-do compile } +! PR fortran/101329 - ICE: Invalid expression in gfc_element_size + +program p + use iso_c_binding + implicit none + integer(c_int), pointer :: ip4 + integer(c_int64_t), pointer :: ip8 + print *, c_sizeof (c_null_ptr) ! valid + print *, c_sizeof (null ()) ! { dg-error "is not interoperable" } + print *, c_sizeof (null (ip4)) ! { dg-error "is not interoperable" } + print *, c_sizeof (null (ip8)) ! { dg-error "is not interoperable" } +end -- 2.26.2