From patchwork Mon Nov 8 07:56:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 1552229 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=sWP7x3eD; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Hnk2j2Qjzz9s1l for ; Mon, 8 Nov 2021 18:56:29 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E000F835F9; Mon, 8 Nov 2021 08:56:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="sWP7x3eD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8394483257; Mon, 8 Nov 2021 08:56:20 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D809B835DD for ; Mon, 8 Nov 2021 08:56:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=etienne.carriere@linaro.org Received: by mail-wm1-x331.google.com with SMTP id r9-20020a7bc089000000b00332f4abf43fso9822366wmh.0 for ; Sun, 07 Nov 2021 23:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=wsIZew6J9qD+cQNpgGmrfSulC3+E3VA7KK5eSzyOjtI=; b=sWP7x3eDfiatWLHAdsLKnjZYL6d/Gi6zro6xvAyUhO6SIKdJjvJU+5fx3hHrWaCxeF cAOqS5iZHVYKozaEmrmQJgKoMsRPb8SDnGlMWOsNffwMV7WIpbwqZVcY5j0iJ4GcOnFU EHwO4YgDab8olkdxWERxrcya31X00yBaYipDQSU+b97cgEcvTNEeiGN0f5pJeRDTrCah 0jz+Yk2h8nRChTYWZbeffG7FC0UHkC8qDSVjOh3GxITH0dkJROqPCuoI2UGaFXRU6jRB 6Vwx6Fjj7yijDZCPhtukbb2IImJqc2+Uwal8Q2EYA4h+Ac4gO8JQ25oq+5G9+/yrBS7M tgaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wsIZew6J9qD+cQNpgGmrfSulC3+E3VA7KK5eSzyOjtI=; b=2XtdV+NnNzyZFTqgptrrCYx6evx/L/iQgpvhGOh7OQyenxybVqYGDtw+IKBlSzIpJr rmBbgaeBxNYqd1BMjEgYRtWHQx/eHjs6sX5WEQSGlXfNHCXOVtWuWlP9ebpvTC3lhzix Q7rLU68UH1ft3xo1H9VZD4Y3Rtlm6fq91WmHe0fEOjurrJ2r4YJGa/12UXjSOXdgftOl 6urZkGfOLvbCIhJLRe/RmMb9qK7VGGDxeSQE8i1u5NUUZxEzzNu4/o1Zgo1ByNIe90gp 9srRd0Lj4BpMB3xn7tEYBJm35Jst1rrgl5fumi08Wlgm+T0yH5ZmxgugD/W16QKEV88K Tt3A== X-Gm-Message-State: AOAM530B+Iv7MGWhUdjmXHq1VD2/qZ0NxNsQNPRE0iiUqxfmIXzZVQ5/ P6iZY64ngcjj5uGRm5fP57Z7BA0vnNS86g== X-Google-Smtp-Source: ABdhPJxmiKBCqI4KqSfxWuE3/Js/eHzGCUWmcDm9nJZgjiUfj1xxbAoe2MxvCBiPfo4HRL3txCbzlw== X-Received: by 2002:a05:600c:198f:: with SMTP id t15mr45823260wmq.94.1636358176271; Sun, 07 Nov 2021 23:56:16 -0800 (PST) Received: from lmecxl0524.lme.st.com ([2a04:cec0:1097:d416:ed93:5b26:60a4:aace]) by smtp.gmail.com with ESMTPSA id t9sm17183725wrx.72.2021.11.07.23.56.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Nov 2021 23:56:16 -0800 (PST) From: Etienne Carriere To: u-boot@lists.denx.de Cc: Etienne Carriere Subject: [PATCH 1/5] firmware: scmi: fix description of an API function Date: Mon, 8 Nov 2021 08:56:07 +0100 Message-Id: <20211108075611.30759-1-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Correct inline comment describing API function devm_scmi_process_msg(). Signed-off-by: Etienne Carriere Reviewed-by: Patrick Delaunay --- include/scmi_agent.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/scmi_agent.h b/include/scmi_agent.h index f1be9ff209..ed40c7360a 100644 --- a/include/scmi_agent.h +++ b/include/scmi_agent.h @@ -45,9 +45,9 @@ struct scmi_msg { } /** - * scmi_send_and_process_msg() - send and process a SCMI message + * devm_scmi_process_msg() - Send and process an SCMI message * - * Send a message to a SCMI server through a target SCMI agent device. + * Send a message to an SCMI server through a target SCMI agent device. * Caller sets scmi_msg::out_msg_sz to the output message buffer size. * On return, scmi_msg::out_msg_sz stores the response payload size. * From patchwork Mon Nov 8 07:56:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 1552230 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=I32r4kYl; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Hnk2x3Bjxz9sRK for ; Mon, 8 Nov 2021 18:56:41 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 362B183608; Mon, 8 Nov 2021 08:56:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="I32r4kYl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 38503835DD; Mon, 8 Nov 2021 08:56:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8DA9D835FD for ; Mon, 8 Nov 2021 08:56:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=etienne.carriere@linaro.org Received: by mail-wm1-x32a.google.com with SMTP id o29so8399172wms.2 for ; Sun, 07 Nov 2021 23:56:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TNGeMGzQ1BOr122NDXiacKY02vVRxcAbdrThVWX2RbE=; b=I32r4kYlPeMXjJvzTEDS4B9hkDs7FDWG94U+yAGpVdXgwP30xCdBVu4puyvu16kX82 zMcksf2NcOfdFYi7m3o8VIA8B+MDVQywVqIkdM670PWq3VP/vm/bzBM4APVk94TNNs99 sR5W/BM6d6NQPgmZa7bPQuUGPj7vIY9nQd4r0ETUT5QfrNJVsSctPnvv5mBpMs3c7bJL 30Y3nMXdKnh+jIwts5lt87ekolNaXqEUIus6mimCwwbObgyfAeVanqtH0ePZE1f0UGOU cgtJiYstFd3FTxTbhLHfjRvrtBRKhxMiN0EUtouBWANPvavH66IfeogBMEag0wEayw5n v1tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TNGeMGzQ1BOr122NDXiacKY02vVRxcAbdrThVWX2RbE=; b=tKCB+6iI/zdKV4XTT+53G6rqwwOHHHs7rS2IYWqE768C87s7DcDPB1VJaEog+KOR22 BTJRK47DTOvpXd0Ve4gnDax8DIRnsZWClCjzSKZDDecXI6Gm8T5CfBcmgqsVwATxckWf afTu8cBHJ9fWMbcW3Edk+TDTFT5AtkTRW0JyIWjggSUNE+aVRmAUGKr3a8JFc74wgHKZ 0Gs5VvqlMR2wtlB+4U+wNEVakiBpASwAsbNSP/NTTYUn1c3PO/PuIu6nuMsZSv8Ckg5h 7lqe3l9UZHdsqJdfMci3VByzp1nXkCSGK0BFwzvpoAv3PblVeQI7rqZTRF1JrWq1qa8T BO8w== X-Gm-Message-State: AOAM533O6O43hM4OHfkNd1CaR/nU0rXHFLFrMZpgr/EnLZL4WbjYw8XD 6n3gtWQUQafke1fvVotp6oh5/vezQsFgTw== X-Google-Smtp-Source: ABdhPJzRavDb6T+/er8C54DbSOp4qkj2m2qDklkLIsVhlqrfpH2gfqPRuVfDJjEHPynYKtVONNOmww== X-Received: by 2002:a7b:cb07:: with SMTP id u7mr50549098wmj.178.1636358177033; Sun, 07 Nov 2021 23:56:17 -0800 (PST) Received: from lmecxl0524.lme.st.com ([2a04:cec0:1097:d416:ed93:5b26:60a4:aace]) by smtp.gmail.com with ESMTPSA id t9sm17183725wrx.72.2021.11.07.23.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Nov 2021 23:56:16 -0800 (PST) From: Etienne Carriere To: u-boot@lists.denx.de Cc: Etienne Carriere , Simon Glass , Patrice Chotard , Patrick Delaunay Subject: [PATCH 2/5] firmware: scmi: mailbox transport: fix probe failure implementation Date: Mon, 8 Nov 2021 08:56:08 +0100 Message-Id: <20211108075611.30759-2-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211108075611.30759-1-etienne.carriere@linaro.org> References: <20211108075611.30759-1-etienne.carriere@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Correct scmi mailbox probe function that can't free the scmi channel instance since its auto-allocated by the device model framework. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere Reviewed-by: Patrick Delaunay --- Changes since v1: - No change. Patch re-send. --- drivers/firmware/scmi/mailbox_agent.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/firmware/scmi/mailbox_agent.c b/drivers/firmware/scmi/mailbox_agent.c index ea35e7e09e..eb841d692b 100644 --- a/drivers/firmware/scmi/mailbox_agent.c +++ b/drivers/firmware/scmi/mailbox_agent.c @@ -72,17 +72,13 @@ int scmi_mbox_probe(struct udevice *dev) ret = mbox_get_by_index(dev, 0, &chan->mbox); if (ret) { dev_err(dev, "Failed to find mailbox: %d\n", ret); - goto out; + return ret; } ret = scmi_dt_get_smt_buffer(dev, &chan->smt); if (ret) dev_err(dev, "Failed to get shm resources: %d\n", ret); -out: - if (ret) - devm_kfree(dev, chan); - return ret; } From patchwork Mon Nov 8 07:56:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 1552233 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=OSVXbbGz; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Hnk3V1jQZz9s0r for ; Mon, 8 Nov 2021 18:57:10 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A4BF183817; Mon, 8 Nov 2021 08:56:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="OSVXbbGz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A8AC083608; Mon, 8 Nov 2021 08:56:27 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7889983613 for ; Mon, 8 Nov 2021 08:56:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=etienne.carriere@linaro.org Received: by mail-wm1-x333.google.com with SMTP id r9-20020a7bc089000000b00332f4abf43fso9822406wmh.0 for ; Sun, 07 Nov 2021 23:56:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JqJ9sDVd5D3/NRf06aTboyXaFbst7Besn9EdZpl57Jk=; b=OSVXbbGz3bMKg+eqS+tlBbaEtEWznPGQoVtCjMihYy1HjvkpVcSg3S/97su7O6zK37 baiXE0b4BodoDfTYU98tLudc4Ym8R22vzj3hdjbCdhDUFcajZeFwEeJAIDtqtcLxRmKV oLZrQ/etwXjHWKMAHHmDRSFx90t6CNRnnMA9TKagxb0ec35Q/A1CkH6QDUiSTclSA/8N 9mYlRrwcVLzHD2vBoAHf0BjB0mbNEdFNtJRxDyCHaarwf/vplXCSLNs5TC2FG2cqQ78G ESyjZl9h46cTa6MfHMvB3npi5V+WW7Wsvtl/msR21n83oBD0U/3O6P5hN21+mxCHqu/R 850g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JqJ9sDVd5D3/NRf06aTboyXaFbst7Besn9EdZpl57Jk=; b=2aojW31FEo1O4sEWfhUKL1I3WIx0pS0Ldblpq148Jky10GgDB0kaZP8vw/j3mEYw0s vp5F1u4HajYWskY46L4oxRTpGKasO6nbJG8qOFRR76W3g5LFzlueqPF4pSdKx0t9cDNT NtgKNKkayKZr3JnhwUSMOoP4OCoHfgAHHiGjojZEdLx4AnHvqya6ublz+XI/qWtdbyWl Wo9V3ucZZFfQnaPrs5ApSC93/xgXq4XbDCioeRRiq9xlinc5Y33EOkY1gN/ONrgkYmrq SjiePVf01tCVuxqVVSo4+4UNSlcquxhDzvXRJnHkF6Q2Qr05Gc4avICbHxjIUlGx29a/ Vv4Q== X-Gm-Message-State: AOAM530+gU7FxeFFi0vYNECp0MSvRova26oOcbSBliOeja8fqsrYEwmV jWs8JTCRcvCT/OEzr5oJ298ASzyVfmRSfg== X-Google-Smtp-Source: ABdhPJymivuicOTnuQGahMOSoZNArtVHDWNVsNz3U76a/EzGnW/M8WVf2z/SNRqn1xw1nMUVAShqqw== X-Received: by 2002:a1c:4d15:: with SMTP id o21mr31976826wmh.171.1636358177910; Sun, 07 Nov 2021 23:56:17 -0800 (PST) Received: from lmecxl0524.lme.st.com ([2a04:cec0:1097:d416:ed93:5b26:60a4:aace]) by smtp.gmail.com with ESMTPSA id t9sm17183725wrx.72.2021.11.07.23.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Nov 2021 23:56:17 -0800 (PST) From: Etienne Carriere To: u-boot@lists.denx.de Cc: Etienne Carriere , Simon Glass , Patrice Chotard , Patrick Delaunay Subject: [PATCH 3/5] firmware: scmi: mailbox transport: use plat data, not priv data Date: Mon, 8 Nov 2021 08:56:09 +0100 Message-Id: <20211108075611.30759-3-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211108075611.30759-1-etienne.carriere@linaro.org> References: <20211108075611.30759-1-etienne.carriere@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Change SCMI mailbox transport drivers to use platform data rather than private data for channel reference since it only stores platform data retrieved from the DT. Consequently the probe handler is replaced with a of_to_plat handler. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere Reviewed-by: Patrick Delaunay --- Changes since v1: - No change. Patch re-send. --- drivers/firmware/scmi/mailbox_agent.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/scmi/mailbox_agent.c b/drivers/firmware/scmi/mailbox_agent.c index eb841d692b..8e4af0c8fa 100644 --- a/drivers/firmware/scmi/mailbox_agent.c +++ b/drivers/firmware/scmi/mailbox_agent.c @@ -33,7 +33,7 @@ struct scmi_mbox_channel { static int scmi_mbox_process_msg(struct udevice *dev, struct scmi_msg *msg) { - struct scmi_mbox_channel *chan = dev_get_priv(dev); + struct scmi_mbox_channel *chan = dev_get_plat(dev); int ret; ret = scmi_write_msg_to_smt(dev, &chan->smt, msg); @@ -62,9 +62,9 @@ out: return ret; } -int scmi_mbox_probe(struct udevice *dev) +int scmi_mbox_of_to_plat(struct udevice *dev) { - struct scmi_mbox_channel *chan = dev_get_priv(dev); + struct scmi_mbox_channel *chan = dev_get_plat(dev); int ret; chan->timeout_us = TIMEOUT_US_10MS; @@ -95,7 +95,7 @@ U_BOOT_DRIVER(scmi_mbox) = { .name = "scmi-over-mailbox", .id = UCLASS_SCMI_AGENT, .of_match = scmi_mbox_ids, - .priv_auto = sizeof(struct scmi_mbox_channel), - .probe = scmi_mbox_probe, + .plat_auto = sizeof(struct scmi_mbox_channel), + .of_to_plat = scmi_mbox_of_to_plat, .ops = &scmi_mbox_ops, }; From patchwork Mon Nov 8 07:56:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 1552232 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=twPCaS9T; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Hnk3J5gCLz9s0r for ; Mon, 8 Nov 2021 18:57:00 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8871283702; Mon, 8 Nov 2021 08:56:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="twPCaS9T"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 25EA781E47; Mon, 8 Nov 2021 08:56:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5E35A81E47 for ; Mon, 8 Nov 2021 08:56:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=etienne.carriere@linaro.org Received: by mail-wr1-x42f.google.com with SMTP id c4so25264446wrd.9 for ; Sun, 07 Nov 2021 23:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IA3OGWIdzae6YHz7qV2boZuYVOb1wQGJgliwD/Gvsu8=; b=twPCaS9TxlAFUFrOls7qQ32CVAXKaGRFVbYkquLK7ET1zeEgbrUb9DPhSBDSRzET1w ++4R8NqBHNsQWqfFtgvFP+xyvFM5xe8dnbMkINLc5Mm8i7KiDEFYicwtwBIF3iQF6qLr /994FjvNUJUSpcXfKW5uCFHYeb70ztXup249h5UHpdNTiI64XxkBXfhUuQlOEy/SGyHe U34w3UhLiFbUJYE2oLOryyeJqnD/vFmeFfX7RYpAaE3Oi6lkCE8qTQ8rFy+a89+7OPdo k/ngfUSuoDTlRGQslzlOA6NMCIdY+qphtevcKRCdnto7RUg4hVM8uF73K71Yv3SGy9qL frPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IA3OGWIdzae6YHz7qV2boZuYVOb1wQGJgliwD/Gvsu8=; b=GNP/ryh8Iy/Pe+dJgAQX7TK8w/HbXrPqBAOWnSAjiwlAOvgwSoV8vg6NnHowUGpX/o of+QZDnOWYg+rKSzdp8k6SIWZKmDwhQXXUfM6paSoO7kA162Fa0y7eXLYssjsIZSGY9d Qi/sWiUcsdCW3tcLWDj8gghl3Flq4si8SmDaIfUHF+koC+CdqDfkI+QlcZSDF/IO+9Ys farutnGfXPJtPWOUUU+aeH6ZrjhU/ad/p/IM82bTdm7Wx+Gr+CEUcla4L1g8Rdld/EfR qgJsOpSAH9CcL9Jd7PmsZfZvFAMpBrZBil+A3AtZc0O8T748Zl7lffjU8JOgk4QpAqZL cPlQ== X-Gm-Message-State: AOAM530JR1yf6nIWQG3a10rsOn5HY7JB6B3mf9OQSJFbraaU1jhJd1jQ HC1LIapib/2sf1MdcUFVeN8N0odgecYzQw== X-Google-Smtp-Source: ABdhPJxm1tlzKdZFcSXfKLW+SNomfsj5SlKUiM/woKnyoMHXg4S7Lvuh4MAMDp+N+1xhWSLSht3gTQ== X-Received: by 2002:a5d:400e:: with SMTP id n14mr82908396wrp.368.1636358178749; Sun, 07 Nov 2021 23:56:18 -0800 (PST) Received: from lmecxl0524.lme.st.com ([2a04:cec0:1097:d416:ed93:5b26:60a4:aace]) by smtp.gmail.com with ESMTPSA id t9sm17183725wrx.72.2021.11.07.23.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Nov 2021 23:56:18 -0800 (PST) From: Etienne Carriere To: u-boot@lists.denx.de Cc: Etienne Carriere , Simon Glass , Patrice Chotard , Patrick Delaunay Subject: [PATCH 4/5] firmware: scmi: smccc transport: use plat data, not priv data Date: Mon, 8 Nov 2021 08:56:10 +0100 Message-Id: <20211108075611.30759-4-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211108075611.30759-1-etienne.carriere@linaro.org> References: <20211108075611.30759-1-etienne.carriere@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Change SCMI smccc transport drivers to use platform data rather than private data for channel reference since it only stores platform data retrieved from the DT. Consequently the probe handler is replaced with a of_to_plat handler. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere Reviewed-by: Patrick Delaunay --- Changes since v1: - No change. Patch re-send. --- drivers/firmware/scmi/smccc_agent.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c index f185891e8f..f0477b91dc 100644 --- a/drivers/firmware/scmi/smccc_agent.c +++ b/drivers/firmware/scmi/smccc_agent.c @@ -32,7 +32,7 @@ struct scmi_smccc_channel { static int scmi_smccc_process_msg(struct udevice *dev, struct scmi_msg *msg) { - struct scmi_smccc_channel *chan = dev_get_priv(dev); + struct scmi_smccc_channel *chan = dev_get_plat(dev); struct arm_smccc_res res; int ret; @@ -51,9 +51,9 @@ static int scmi_smccc_process_msg(struct udevice *dev, struct scmi_msg *msg) return ret; } -static int scmi_smccc_probe(struct udevice *dev) +static int scmi_smccc_of_to_plat(struct udevice *dev) { - struct scmi_smccc_channel *chan = dev_get_priv(dev); + struct scmi_smccc_channel *chan = dev_get_plat(dev); u32 func_id; int ret; @@ -86,7 +86,7 @@ U_BOOT_DRIVER(scmi_smccc) = { .name = "scmi-over-smccc", .id = UCLASS_SCMI_AGENT, .of_match = scmi_smccc_ids, - .priv_auto = sizeof(struct scmi_smccc_channel), - .probe = scmi_smccc_probe, + .plat_auto = sizeof(struct scmi_smccc_channel), + .of_to_plat = scmi_smccc_of_to_plat, .ops = &scmi_smccc_ops, }; From patchwork Mon Nov 8 07:56:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 1552231 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=h+LkoYLU; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Hnk38361Sz9s1l for ; Mon, 8 Nov 2021 18:56:52 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B0D98379E; Mon, 8 Nov 2021 08:56:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="h+LkoYLU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3FA68361E; Mon, 8 Nov 2021 08:56:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 151D58361C for ; Mon, 8 Nov 2021 08:56:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=etienne.carriere@linaro.org Received: by mail-wr1-x433.google.com with SMTP id c4so25264482wrd.9 for ; Sun, 07 Nov 2021 23:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HLMd+XAGCkuMG2RpZPbkAa4y7hJzRZ3Nq577DjlwWGQ=; b=h+LkoYLUynA/vQgg3/fK2JyRBPfcJjwwe7z/VjfIBuX/iylUuI615m1MIhF3ISDHob vGIUIc8YCL3jw/9ktrcUY5C6sdMsMr72DJYvW81NyAYdPF6Uu1hQ/FP6AQXsHx1Kz2St ixx1veNOBy2SMoG61VJUP1mwHBmjhPTxr3WWEhEgxo0MxBbPjW6XiJ/XzDKGI7OcK9uS X5qVMpKmV5xtJ21VziMs0cqSvnphhGnV9p7AASa7Oo4W3JZdWV4wEzag15Jwf56SLvnH mrsUgowE/sZtvqqQzY/Wbt5t6+lHbZ8ZCSAFxE8heZ+Jhk1Jkhgr9mqdKDIfaseS3C6J rD9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HLMd+XAGCkuMG2RpZPbkAa4y7hJzRZ3Nq577DjlwWGQ=; b=LO6HMY4Nc7AqlRV9pQr/52YKXnZCBMRqnamb9R07fE0vBHZybrKmq//d3aUiK6WUAW xZd0REqTjukma7NQWwZQ/gGrw0QqGnPQniE0pSDYNpbtvgXxnfeuch9r03N912OM2MA2 Q/vPf4FSzooTdyymeuDBmLiBrBt+X20GvDVl2Kre+C3zkatOJu+jw/x7yTgv1G6Kb5U7 Kt9XvQwjnUA3bimp4K6vojjSbzVvf0JPl+K3Xsosk76yNnb97bFDIH49Ram0OHgs+pbM SqnOeVU5dsOlAmsg8yVm1Vwq+et4XiG+yjxbcpRdDJbItzaDDZJP3w2B4M06pQWT8gEG 03QA== X-Gm-Message-State: AOAM531rx6Mt8ITV7BLwlE+JeBZtai2dYPdnGB4XRvULnN7SDMvl7pAY wFESY1huHwE+3xKQb3HGt18S2RR+wHB/2w== X-Google-Smtp-Source: ABdhPJxm+ejhysmgrXdbUFgs3o7YdpZ6Zc10NLqjp/FBwPshzmiN4LXLYVRKfyIsQ9H5uw3swQcgHg== X-Received: by 2002:a05:6000:156a:: with SMTP id 10mr72927479wrz.87.1636358179567; Sun, 07 Nov 2021 23:56:19 -0800 (PST) Received: from lmecxl0524.lme.st.com ([2a04:cec0:1097:d416:ed93:5b26:60a4:aace]) by smtp.gmail.com with ESMTPSA id t9sm17183725wrx.72.2021.11.07.23.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Nov 2021 23:56:19 -0800 (PST) From: Etienne Carriere To: u-boot@lists.denx.de Cc: Etienne Carriere , Simon Glass , Patrice Chotard , Patrick Delaunay Subject: [PATCH 5/5] firmware: scmi: smccc transport: simplify probe sequence Date: Mon, 8 Nov 2021 08:56:11 +0100 Message-Id: <20211108075611.30759-5-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211108075611.30759-1-etienne.carriere@linaro.org> References: <20211108075611.30759-1-etienne.carriere@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Minor simplification in scmi_smccc_probe() exit sequence. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere Reviewed-by: Patrick Delaunay --- Changes since v1: - No change. Patch re-send. --- drivers/firmware/scmi/smccc_agent.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c index f0477b91dc..5e166ca93e 100644 --- a/drivers/firmware/scmi/smccc_agent.c +++ b/drivers/firmware/scmi/smccc_agent.c @@ -65,12 +65,10 @@ static int scmi_smccc_of_to_plat(struct udevice *dev) chan->func_id = func_id; ret = scmi_dt_get_smt_buffer(dev, &chan->smt); - if (ret) { + if (ret) dev_err(dev, "Failed to get smt resources: %d\n", ret); - return ret; - } - return 0; + return ret; } static const struct udevice_id scmi_smccc_ids[] = {