From patchwork Fri Oct 15 10:15:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Art Nikpal X-Patchwork-Id: 1541558 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=VRu0maKy; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HW2GL5KVKz9t0T for ; Fri, 15 Oct 2021 21:15:36 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A2A40837E4; Fri, 15 Oct 2021 12:15:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VRu0maKy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A8CFA837E4; Fri, 15 Oct 2021 12:15:22 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0A373837E8 for ; Fri, 15 Oct 2021 12:15:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=email2tema@gmail.com Received: by mail-pf1-x42e.google.com with SMTP id 187so7945565pfc.10 for ; Fri, 15 Oct 2021 03:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xDUAPA398OfbWzfs+zAafKwU+M4Q96/6cLv0lwezP7M=; b=VRu0maKytqTxY7WsFMfoiiDTmbZdTE3VKlWKCtVbqPsbqFROuZwNXrkyDDrSchOP6p Ti0r/j8Y9rguKaw8YPXmNFTA3UQfpsTNu/k8/zIKaBkPeUs8eqxafzckxOLuyLGri0Se 8NLb/Maa8xeQblarsrxLgBUdPkXu0hzKb/NPJBczltC8h92WMV1Kmx6wjQLGdj/HOoDn 2/+qZZcBVKx9luGUe5kSAXJsDE5SKh54z9QP9DzycOO1u4GZfKSJWipPemx/5pmN9OYA +zj663lSTVdWBkgxwa1dkSxtKgMeqKxRitLJ57Nx43SNT+Mi6D3bHp/Ikw+3+kqIiQf2 bJdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xDUAPA398OfbWzfs+zAafKwU+M4Q96/6cLv0lwezP7M=; b=iUGbcdU7paN5D53AZIURF7tV5SLZ1uPM2qE01IxY5m/zravej3oskR3AhE+ISSS4X5 YYPpJC7Q3tsBrgcWah4uPsb/GZCTxWoMyNvdS+P6z18OHWa72aLF+1FlvlMXMcSHc5ER EiL0nsr0l6IzGHp5BeL47jCA+u7nUk+Sd7EP7nLXy1ABuhR1lcMCKxNZHndXihZP1xRI ZjKTBV9B9W5z572m63sYPl0Yh6jEtlYVJbl4pkLkuQjqbqIZH8kxsNvrAcXrQBXDmSDB C/y3VLQtqnArrnuIqNRTNva+GfZ7nO039Q/cOth/PeqbOwfV1mm8UaDRdC1odwiZF9rf 06QA== X-Gm-Message-State: AOAM532Tnq4BTTWat4a5RVeHOH+x20VhN7zspgT4GjM/Lfy9PFGlIJOa DrCKioplBbvlkKGWEdHI9j0= X-Google-Smtp-Source: ABdhPJy4PFbH0xbiqalm6LO57N/JAGsZ64HiD6teXStK05aCir6+B6jzWQjlfc+xdaS2Kddr4oDn9A== X-Received: by 2002:a63:8542:: with SMTP id u63mr8492204pgd.402.1634292916210; Fri, 15 Oct 2021 03:15:16 -0700 (PDT) Received: from localhost.localdomain (199.19.111.227.16clouds.com. [199.19.111.227]) by smtp.gmail.com with ESMTPSA id 73sm4633666pfv.125.2021.10.15.03.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 03:15:15 -0700 (PDT) From: Artem Lapkin X-Google-Original-From: Artem Lapkin To: sjg@chromium.org Cc: trini@konsulko.com, narmstrong@baylibre.com, twarren@nvidia.com, andre.przywara@arm.com, u-boot@lists.denx.de, u-boot-amlogic@groups.io, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: [PATCH] image: fix select_ramdisk for raw initrd Date: Fri, 15 Oct 2021 18:15:01 +0800 Message-Id: <20211015101501.4091141-1-art@khadas.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Problem We have unbootable raw initrd images because, select_ramdisk for raw initrd images ignore submited select addr and setup rd_datap value to 0 Solution: setup rd_datap value from select Signed-off-by: Artem Lapkin --- common/image-board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/image-board.c b/common/image-board.c index e7660352e9..e3c6ea806a 100644 --- a/common/image-board.c +++ b/common/image-board.c @@ -439,7 +439,7 @@ static int select_ramdisk(bootm_headers_t *images, const char *select, u8 arch, end = strchr(select, ':'); if (end) { *rd_lenp = hextoul(++end, NULL); - *rd_datap = rd_addr; + *rd_datap = hextoul(select, NULL); processed = true; } }