From patchwork Thu Oct 14 14:50:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1540952 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=DUrhp4zk; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HVXRH3RMWz9sP7 for ; Fri, 15 Oct 2021 01:51:37 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5EC36385802E for ; Thu, 14 Oct 2021 14:51:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5EC36385802E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1634223095; bh=6BGrA3yWMruI5yduqaO1yMvaAHputOhxOcgWVMg2bxE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DUrhp4zkcS2SUKugKSIQDVS9v/yvlZKxI89Oj3Ylb4S7FVDWr41jmG0kjrDoQNErZ rYLVd92SgE/WNxYzBsWdpIqfGVbGkKMckOUBO8tD55uUqdHt+iBlE7/f+4ycrwrsUq Z/16ew5c4zJlmmFkQ3SCLQDzonbpa1cvvNgd3rrE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 8E0173858C2C for ; Thu, 14 Oct 2021 14:50:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E0173858C2C Received: by mail-pj1-x102d.google.com with SMTP id q10-20020a17090a1b0a00b001a076a59640so5667071pjq.0 for ; Thu, 14 Oct 2021 07:50:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=6BGrA3yWMruI5yduqaO1yMvaAHputOhxOcgWVMg2bxE=; b=f3siaH+79rShdlfI2opa5nHnyGJyvyDlqKt0uLOjlluPyz3cQTWeuhZFTreZuiW6KV 34VYYVNQANazBsoLkUE3BmFd6vf8KVFVqJrJSAUOfBh0SzyAWnxIBKBt+EvKvyAF8dLA Eo/5GNCq0pXM3w0LGV26L/F9mq59C1/gWMFHDSxiREx+efqj+n79Lsf+z80Bfa5wMFxx aqFVToSYGqORPok9s7H4RYrn3M0cr3OuP1+WIhLeLoFvyo+0s5M+siw2pn5bmlQ+XIQ2 vNcT1F3zK47jcyQJ5Sk/hETx/eX8ygqyAbxYwvqbhcLItNYPcCpSRJ+IyCiT8BZaLmb0 TlTA== X-Gm-Message-State: AOAM530vbsz6gu9oCFEMzEwxEbgtYIm6MHCm3e7Z748kFbugFYewxUYY j9c9pBzMQRtbonizcmzfAVMdeZZMdQk= X-Google-Smtp-Source: ABdhPJwtAc7MK+dDnGiCLT68IEoCMis+UEfZi96682+He+di9oedDts9oEgt5SWyLBSKd65PvhAVKg== X-Received: by 2002:a17:902:8d8b:b0:138:e09d:d901 with SMTP id v11-20020a1709028d8b00b00138e09dd901mr5577712plo.34.1634223053122; Thu, 14 Oct 2021 07:50:53 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id c8sm2785452pgn.72.2021.10.14.07.50.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 07:50:52 -0700 (PDT) To: GCC Patches Subject: [committed] Fix mips testsuite fallout from vectorizer changes Message-ID: Date: Thu, 14 Oct 2021 08:50:51 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 Content-Language: en-US X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jeff Law via Gcc-patches From: Jeff Law Reply-To: Jeff Law Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" The mips ports have been failing msa-insert-split.c since the change to enabled the vectorizer at -O2. This test expects to see insve, instructions to move data around. Those come as a result of the gimple optimizers using BIT_FIELD_REF expressions. With vectorization we just emit a vector load and a vector store without any BIT_FIELD_REFs in gimple.  This translates into simple loads/stores and naturally the test fails. Turning off the vectorizer seems like the right thing to do here. Committed to the trunk, Jeff commit 8ececf9b8c5a2bf2f231db0c3bcf2be927990e7c Author: Jeff Law Date: Thu Oct 14 10:49:05 2021 -0400 Fix mips testsuite fallout from vectorizer changes gcc/testsuite * gcc.target/mips/msa-insert-split.c: Turn off vectorizer. diff --git a/gcc/testsuite/gcc.target/mips/msa-insert-split.c b/gcc/testsuite/gcc.target/mips/msa-insert-split.c index 50f3b8a61a1..9ad5987ac03 100644 --- a/gcc/testsuite/gcc.target/mips/msa-insert-split.c +++ b/gcc/testsuite/gcc.target/mips/msa-insert-split.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-mfp64 -mhard-float -mmsa" } */ +/* { dg-options "-fno-tree-vectorize -mfp64 -mhard-float -mmsa" } */ /* { dg-skip-if "code quality test" { *-*-* } { "-O0" } { "" } } */ typedef double v2f64 __attribute__ ((vector_size (16)));