From patchwork Sun Oct 3 17:57:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535845 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=IVyerHTT; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMs6L6CBlz9sX3 for ; Mon, 4 Oct 2021 04:58:49 +1100 (AEDT) Received: from localhost ([::1]:37894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5l7-0002Zf-Fz for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 13:58:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5kH-0002YN-Vj for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:57:54 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:41525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5kF-0003GQ-Kp for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:57:53 -0400 Received: by mail-wm1-x32f.google.com with SMTP id g198-20020a1c20cf000000b0030d60cd7fd6so2730888wmg.0 for ; Sun, 03 Oct 2021 10:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l/rdeP+spIdDQqIh+wJEBCFICiFkl7U81t6jAZeqrt0=; b=IVyerHTT0VCQqvddoVXjqHnagM4Pd0Se+ZDSmQ3DyD9994+zWYKzdacsrXpbUI5Thk r2I2jrNCcYQ4yv+otw/sZBnw+9h8VIYj6xvIIiLQBTX49wqJ9AOSQxvzRTsp9Gbx/W10 JnM80W6B1xE2d7CrBMKjI7BkANanx52Q9RV78qn/EXViOiRff37VrBe1LYbK3dK28W49 FJo6VYr35oDMR6jEDUxYBwXQB1rq23fZnmjJ6SwxfEFKd9RFpuAH5rJTxEEBzvpAKz5L 9qihwGrBmQUZw9VDkJwJNBSaHDbUGB9eD/cWuD0gK727wW9I7l2Ibs4aMWCHiu1GHC88 L97A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=l/rdeP+spIdDQqIh+wJEBCFICiFkl7U81t6jAZeqrt0=; b=F/DD8HuJVYn3JWyd2CmKq2ZqsJ50cU3mzHK7aGkgTYPUkAls+K+VIi7Mscn5AirYOu 18GikOCHq4PFVo1g6PIwypMslwVce4XZvRQUOW9LmGTF/sZSJDefAhwhJLY3Rw00Jov4 atGnWHIeOH7CAnrt+KRObYqNJ9e6+hyXucwWGJvBBu7qg663KMuAPFZxjYCnFR6i+ibv W3vOW4w0H5SmxQORBdvMsPmS42eWULKYH8/AEtazcmBIWmiuXbIv5m0JPjIhqXfyxjCF qDVMSGzCDobfOadfTCRAEEbhobHvgD3vW7Ji8pJEmVvt6/TxQP/AdKaqJtrKgIj+rMOh ZDIw== X-Gm-Message-State: AOAM532N/z16aI9Vj4K9iibmdcStHdDczZYe1gFffTFgx8fUUG2h7A1l n73unSL/SlRBUZ/xFRBMBWbkNutlUFs= X-Google-Smtp-Source: ABdhPJwobKwnGAaDESJAVMFn9/4BTR2DuQBOsm48oMFxGb3fG0/WN2bolX2PfusiIJ0zienHkw/c9Q== X-Received: by 2002:a7b:c307:: with SMTP id k7mr12706920wmj.170.1633283869861; Sun, 03 Oct 2021 10:57:49 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id z12sm12230540wrv.31.2021.10.03.10.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:57:49 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/8] target/mips: Remove unused register from MSA 2R/2RF instruction format Date: Sun, 3 Oct 2021 19:57:36 +0200 Message-Id: <20211003175743.3738710-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Commits cbe50b9a8e7 ("target-mips: add MSA VEC/2R format instructions") and 3bdeb68866e ("target-mips: add MSA 2RF format instructions") added the MSA 2R/2RF instructions. However these instructions don't use any target vector register, so remove the unused TCG temporaries. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- v2: Reworded, removing the Fixes: tag. --- target/mips/tcg/msa_translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c index 8170a8df26b..ee6424126f7 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1942,13 +1942,11 @@ static void gen_msa_2r(DisasContext *ctx) { #define MASK_MSA_2R(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21)) | \ (op & (0x7 << 18))) - uint8_t wt = (ctx->opcode >> 16) & 0x1f; uint8_t ws = (ctx->opcode >> 11) & 0x1f; uint8_t wd = (ctx->opcode >> 6) & 0x1f; uint8_t df = (ctx->opcode >> 16) & 0x3; TCGv_i32 twd = tcg_const_i32(wd); TCGv_i32 tws = tcg_const_i32(ws); - TCGv_i32 twt = tcg_const_i32(wt); TCGv_i32 tdf = tcg_const_i32(df); switch (MASK_MSA_2R(ctx->opcode)) { @@ -2018,7 +2016,6 @@ static void gen_msa_2r(DisasContext *ctx) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(twt); tcg_temp_free_i32(tdf); } @@ -2026,13 +2023,11 @@ static void gen_msa_2rf(DisasContext *ctx) { #define MASK_MSA_2RF(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21)) | \ (op & (0xf << 17))) - uint8_t wt = (ctx->opcode >> 16) & 0x1f; uint8_t ws = (ctx->opcode >> 11) & 0x1f; uint8_t wd = (ctx->opcode >> 6) & 0x1f; uint8_t df = (ctx->opcode >> 16) & 0x1; TCGv_i32 twd = tcg_const_i32(wd); TCGv_i32 tws = tcg_const_i32(ws); - TCGv_i32 twt = tcg_const_i32(wt); /* adjust df value for floating-point instruction */ TCGv_i32 tdf = tcg_const_i32(df + 2); @@ -2089,7 +2084,6 @@ static void gen_msa_2rf(DisasContext *ctx) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(twt); tcg_temp_free_i32(tdf); } From patchwork Sun Oct 3 17:57:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535850 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=gTN5zezd; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMsCj1TDXz9sX3 for ; Mon, 4 Oct 2021 05:03:29 +1100 (AEDT) Received: from localhost ([::1]:47936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5pf-00017w-0l for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 14:03:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5kL-0002aG-Fz for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:57:57 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:43675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5kK-0003Jz-3G for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:57:57 -0400 Received: by mail-wr1-x42a.google.com with SMTP id r7so10613591wrc.10 for ; Sun, 03 Oct 2021 10:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z+JF3MQH1rPB321dugVt3oY5emnBWy8JVQSDmjDElJM=; b=gTN5zezdAI7zDYzDDp0bgpvnbz444LUBIKgTrp+evuNkz4THywspCnymhDPPp6ZGJV tc3+V4bU3nonQVxaqTc4DptUpFr5nz4b4RYHMz0PBjGslqY0HUaNDhb+OPfWzpZ6Ah4s pZojM4DHnTZdfX/1UlNKe8XwZudn0KZw/emWV2dzZXU+yujqGlNt4v5tQM58OJ1/Oisu t58py7SjpVyd2FKJSLCNMyZ1XiGuRiNqMCl4E9nKTGOvpCgtJHPCLuxImuA1FbGMpaeX Fdh50VG6nAXhBdfyAeUjS6H2b1/N4dZ/2+QKRoLbBfJi/i2mzT6lWggmtUDRa+b1zMv2 GbDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Z+JF3MQH1rPB321dugVt3oY5emnBWy8JVQSDmjDElJM=; b=PcX+a2f4rI1xxuqmode0Qs04DMRohnpbmvTDyO5u74t2nX+qaefpPjoQbZ2u6q5pBZ mxxeylpdQJsF4QJg+IOur7H2W3PXQ/bzNYfYLjGoM/D53GBkndpZbq9sObkC2l8zn+A6 1AuBPkmSLo2QmGXYVJhVSfBz8AIqWE+6qU/U5s7c9HV8w8fQDwdqPbLipovQKn2zAxXZ JiZa0Kh+hD08nuH5vG+co4E7vqcUMxfz+F3wb0oAitb2j++05e5rpVFlbsZVP9Q1OrZa 1uDemn/rlobge+v6k/brU+Yrf2dTv1a4KM98FhvewQFziRCN/eXd/8dyQDNb1wYyyETg EFqQ== X-Gm-Message-State: AOAM5309SymBsno14yvvmE287Slr/MR+dGJhRTDTVU0Q2HC7SRMLQQkE 37LdZT7jA7uKds0WKJ9M2v46Dk6fQHY= X-Google-Smtp-Source: ABdhPJxO63WBk+01WFgmdd2dJgUsM4toHKC6jF9Ywk6l0Pl7FwPm2TSbUvkbN1O2tRglg3CFuK0Eww== X-Received: by 2002:adf:a51e:: with SMTP id i30mr8985653wrb.206.1633283874316; Sun, 03 Oct 2021 10:57:54 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id a17sm2473793wmj.48.2021.10.03.10.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:57:53 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/8] target/mips: Use tcg_constant_i32() in gen_msa_elm_df() Date: Sun, 3 Oct 2021 19:57:37 +0200 Message-Id: <20211003175743.3738710-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Data Format is a 2-bit constant value. Avoid using a TCG temporary by moving it to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c index ee6424126f7..20036ae4968 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1650,7 +1650,7 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t df, uint32_t n) TCGv_i32 tws = tcg_const_i32(ws); TCGv_i32 twd = tcg_const_i32(wd); TCGv_i32 tn = tcg_const_i32(n); - TCGv_i32 tdf = tcg_const_i32(df); + TCGv_i32 tdf = tcg_constant_i32(df); switch (MASK_MSA_ELM(ctx->opcode)) { case OPC_SLDI_df: @@ -1748,7 +1748,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t df, uint32_t n) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); tcg_temp_free_i32(tn); - tcg_temp_free_i32(tdf); } static void gen_msa_elm(DisasContext *ctx) From patchwork Sun Oct 3 17:57:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535848 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=I9wcFshD; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMs9t5Lskz9sX3 for ; Mon, 4 Oct 2021 05:01:54 +1100 (AEDT) Received: from localhost ([::1]:44722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5o8-0007Gl-Gp for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 14:01:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5kR-0002fF-VB for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:03 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:52079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5kO-0003P0-GO for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:02 -0400 Received: by mail-wm1-x32e.google.com with SMTP id p21so1819279wmq.1 for ; Sun, 03 Oct 2021 10:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XxuEIy1tj7Fs3MbSgOfbbhEpKEgia9N0pym7Jb9gPes=; b=I9wcFshD0ucYa2NhQzSylmOLO5zpFA6uYnC/roHPmREspjyv5rEzoGORGOmmB+ZcRX UFpit91wLeIcB8fFWoApSK8y18uCIoRtaeyhdivy0MF207mTuueq69syYB5XiAjYwUG0 UoBg57YpJR7FfvK71YNhQ8dTQlL5S4HOjIQSnWwqISkq8ldRg9BlT4VIrSgFqUP/u4cV pSLDSYijPPN4rdHNEA45dBr2D5nkiMKt8kvl2SLuhjs+t72KdAJcBvmmf1oQ7gh2KlLO QivTLYVkOhwt8RQ2NoxWCyaNXqE99wr4c+mJ1vkDaSOC5DgEG6jNKHeNSZv9hFPFq5Vt /wvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XxuEIy1tj7Fs3MbSgOfbbhEpKEgia9N0pym7Jb9gPes=; b=hpFHp+/s9dCI1ckvsv6gMaSef6vM9zLH2bVbqAk/rWWtUcOejG2xXp/rv0H90x5DUN hMl4qL+3VnpcWbBOVBcR8Hu0hIMs3XdUcMm+2a8MFX6WtveCOXRNwQmPCAI0hYDiKnsd MrQL42J1yX6GAfh4s+21BaNz4b+YzZzZS4wrL6f7trL+L18oyEhep7wrmYnOqNIeSeov wQjqgeyQ+4GuXsAjfLtRwpLKi7B8koU+5xStpZMERMDPdZkgcz1Q48262ayy+ju2tnNn LxaxXpcymmw/P6kkeyAnJuUA8SLQLeNosPY1s0n0UqfMCdIAIEsg7YYjgRuFeaWpSX+6 H8Qw== X-Gm-Message-State: AOAM532Ggp/wxNz2xK3V5SJakWXBf5CZwzZutXBHXcYxmc7Hc8X1EYXj uKNBIAXVJ76RVXnSrun7oKbUs7MBz7w= X-Google-Smtp-Source: ABdhPJxzQPm7/EkbskeBO4xIHgdQBj8QcWThbKZDRYLSKkw+47WVVi2FWbwPkPo1nSIq8I9H89CqvA== X-Received: by 2002:a05:600c:218:: with SMTP id 24mr2675927wmi.124.1633283878905; Sun, 03 Oct 2021 10:57:58 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id i27sm14364760wmb.40.2021.10.03.10.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:57:58 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/8] target/mips: Use tcg_constant_i32() in gen_msa_2rf() Date: Sun, 3 Oct 2021 19:57:38 +0200 Message-Id: <20211003175743.3738710-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c index 20036ae4968..5e8f80f2f23 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -2028,7 +2028,7 @@ static void gen_msa_2rf(DisasContext *ctx) TCGv_i32 twd = tcg_const_i32(wd); TCGv_i32 tws = tcg_const_i32(ws); /* adjust df value for floating-point instruction */ - TCGv_i32 tdf = tcg_const_i32(df + 2); + TCGv_i32 tdf = tcg_constant_i32(df + 2); switch (MASK_MSA_2RF(ctx->opcode)) { case OPC_FCLASS_df: @@ -2083,7 +2083,6 @@ static void gen_msa_2rf(DisasContext *ctx) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(tdf); } static void gen_msa_vec_v(DisasContext *ctx) From patchwork Sun Oct 3 17:57:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535846 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=lCMszzer; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMs6T1jFGz9sX3 for ; Mon, 4 Oct 2021 04:58:57 +1100 (AEDT) Received: from localhost ([::1]:38144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5lH-0002kq-13 for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 13:58:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5kU-0002iS-NZ for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:06 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:39508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5kT-0003Ss-5E for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:06 -0400 Received: by mail-wr1-x42c.google.com with SMTP id d26so26045701wrb.6 for ; Sun, 03 Oct 2021 10:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zN28LoK0n7WogBiC27sRyJmL1zm0wkkrymJdJPui0K8=; b=lCMszzerOt0W6S+GW2gZq3LQATrzK6Di1V5xx6XtZPvTrZugnQWJcDNG0oVBkCrnlo d+fMYGdsK71KUovubzmAwI1ff5m5nmAB/oMZ1VzvGrKmcE2RINZEoDQ3hRoPbypwSoVI 8RK45riqdxFwtL9rfN+qh1BT5gXPRS+S3HLIzFdtPiEaGmz0XpDoaw3ke0BS0F+qNc66 huGVDm5vfjY/FU1ixrWNnGGSTd88+wxyeJCwtkV54W3B/8QN2KBAvXn6GiYLwtwXrNOt Mc2SBpE3YYIhuA2GIHKfAzOKEKoe+6JOhKKn86IfBrp29v7lz1MbgNqSoxrnRh/n6exO GWHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zN28LoK0n7WogBiC27sRyJmL1zm0wkkrymJdJPui0K8=; b=350BesaYQoIeSEpgy2KDkMPkjqPTaLruH52UbtN18CVlYX3FtcrNRuInE5vDqtdCnd EHhBPBSDPGWWfsFtxWri9Zi5XurMX1+vYEaH9Zu7059XeE4zqjQ1e1uC/y+up77CRxgW rRL9WyJlMJclyxwIx+ZmJn3yrqW/0oUcUEffT8yR14bhw86PKDWnCGOSLtDBF/WAIu4P IsfbEVMUabhiLfUYI2QIviw/KpYAYt3VPxrk/35trP1Gest2mQP8BnSyw732jWkEnmgx 6upRdqFdTQTDW172VENOe5t7pUaVVCkK9D+zYaAK6I9Ox09+FZrRmgnyxb2WB8xV+N1i fKYw== X-Gm-Message-State: AOAM5310r4gv+jzrRHBrmmzkmttPpohrVhZIgNV+szTFij7XlvYeGbk9 1rAI+UfwdJPSHsOhafEgV9GcuJLanZk= X-Google-Smtp-Source: ABdhPJxeLyETKmygx3tyus9BOqZyK6kgYmlTDp38a3YFsAySC+L2AIGjyWg67CzaKfG+ex8fBxgrvg== X-Received: by 2002:a5d:4b11:: with SMTP id v17mr9700086wrq.313.1633283883566; Sun, 03 Oct 2021 10:58:03 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id m21sm13178388wmq.37.2021.10.03.10.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:03 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 4/8] target/mips: Use tcg_constant_i32() in gen_msa_2r() Date: Sun, 3 Oct 2021 19:57:39 +0200 Message-Id: <20211003175743.3738710-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c index 5e8f80f2f23..bbe9146513a 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1946,7 +1946,6 @@ static void gen_msa_2r(DisasContext *ctx) uint8_t df = (ctx->opcode >> 16) & 0x3; TCGv_i32 twd = tcg_const_i32(wd); TCGv_i32 tws = tcg_const_i32(ws); - TCGv_i32 tdf = tcg_const_i32(df); switch (MASK_MSA_2R(ctx->opcode)) { case OPC_FILL_df: @@ -1957,7 +1956,8 @@ static void gen_msa_2r(DisasContext *ctx) break; } #endif - gen_helper_msa_fill_df(cpu_env, tdf, twd, tws); /* trs */ + gen_helper_msa_fill_df(cpu_env, tcg_constant_i32(df), + twd, tws); /* trs */ break; case OPC_NLOC_df: switch (df) { @@ -2015,7 +2015,6 @@ static void gen_msa_2r(DisasContext *ctx) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(tdf); } static void gen_msa_2rf(DisasContext *ctx) From patchwork Sun Oct 3 17:57:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535849 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=SO06pSfq; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMsB32VvXz9sX3 for ; Mon, 4 Oct 2021 05:02:03 +1100 (AEDT) Received: from localhost ([::1]:45136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5oH-0007Wb-4Z for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 14:02:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5kZ-0002tM-G8 for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:11 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:35749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5kX-0003Wl-TM for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:11 -0400 Received: by mail-wr1-x42e.google.com with SMTP id v25so15404461wra.2 for ; Sun, 03 Oct 2021 10:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2n9LSU1b2DlEwFolRpa1OCTd/teoFX3/1wugs2VhoEo=; b=SO06pSfq2CCDJxqQQ5sCvbpP5HSge2Hl36omH3M5jizdjqg/lkmu5dRqvP4G88TpYi sV3TVQBtJPp/PjoYH84URx0xRnPAsbbcXNufDpNPpc/IgZXn/I1j2sbKEPk++BG0Gl2N Slpe5MkFHxrNOnX5Apok/tqDyC6Lyfq8GYbd6dL6vpkpEFNxT3isv9WmzSRUZX5j71lg l+IGa3cB814m4DNoSTKgJ2cR+ZXniCNnYXgzFSbpB8U4bKeE4PIzX4dF0A0gMXq2EdfS 7VU4EsjwmrUQkUs1rN+W7ZNt1CEOWBZ+9PuygdD/utaGhcRCyRzQYxvWY2/AELIaQ0Zi bDmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2n9LSU1b2DlEwFolRpa1OCTd/teoFX3/1wugs2VhoEo=; b=Zu+iK8Hv08LJgBXVn6atosQiDggv4x4ELVKriHvUKlKAfkMMhtyX1I1TkCfKmBw4Ez LNl4WhkZ6Ot5x4AdAw+K6bPtpVBRIE5OjJeUVYxQ1M2cycVqK/VPuAxoL5SboclGVhQB vWSj6fWRPG0cl9+Vrf3uG+vhgUvoMkjIQ94Bm5jhyfm3pV6j8SeSr3cbxa15uFdeRx5q qjvma7IYmeQ25kDKSC6bQ2mwgbH5eokQoB8m/CsgXHb9qr79gXobNRKbhaRkey629OsZ 61TL/8Zjp3YPV2bTcuTPDEBRPi9INc9UffzQalq677ffzLbYMvQZglUA9Aa1TZsE0bkB gqZA== X-Gm-Message-State: AOAM531vXhp7oDBcpgA5ftOxCTmpphe4aJrakrOsa17EA8HiLr4MU8ub AkhnVDzWNwfhEu/yX2wnLnUL4Rh07TE= X-Google-Smtp-Source: ABdhPJxw+wMy5P1ZQfwNeBbQoeaFyc7lv9XiHtXRAEhGQoGlYoE1/+D9087VqBkRwa+Ma+7UJ9kz8w== X-Received: by 2002:a5d:6d8e:: with SMTP id l14mr9803986wrs.196.1633283888347; Sun, 03 Oct 2021 10:58:08 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id k18sm11933999wrh.68.2021.10.03.10.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:07 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 5/8] target/mips: Use tcg_constant_i32() in gen_msa_3rf() Date: Sun, 3 Oct 2021 19:57:40 +0200 Message-Id: <20211003175743.3738710-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c index bbe9146513a..e107cad57ee 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1790,10 +1790,22 @@ static void gen_msa_3rf(DisasContext *ctx) TCGv_i32 twd = tcg_const_i32(wd); TCGv_i32 tws = tcg_const_i32(ws); TCGv_i32 twt = tcg_const_i32(wt); - TCGv_i32 tdf = tcg_temp_new_i32(); + TCGv_i32 tdf; /* adjust df value for floating-point instruction */ - tcg_gen_movi_i32(tdf, df + 2); + switch (MASK_MSA_3RF(ctx->opcode)) { + case OPC_MUL_Q_df: + case OPC_MADD_Q_df: + case OPC_MSUB_Q_df: + case OPC_MULR_Q_df: + case OPC_MADDR_Q_df: + case OPC_MSUBR_Q_df: + tdf = tcg_constant_i32(df + 1); + break; + default: + tdf = tcg_constant_i32(df + 2); + break; + } switch (MASK_MSA_3RF(ctx->opcode)) { case OPC_FCAF_df: @@ -1836,7 +1848,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmadd_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MUL_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_mul_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCULT_df: @@ -1846,14 +1857,12 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmsub_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MADD_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_madd_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCLE_df: gen_helper_msa_fcle_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MSUB_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_msub_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCULE_df: @@ -1896,7 +1905,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmin_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MULR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_mulr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSULT_df: @@ -1906,7 +1914,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmin_a_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MADDR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_maddr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSLE_df: @@ -1916,7 +1923,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmax_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MSUBR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_msubr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSULE_df: @@ -1934,7 +1940,6 @@ static void gen_msa_3rf(DisasContext *ctx) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); tcg_temp_free_i32(twt); - tcg_temp_free_i32(tdf); } static void gen_msa_2r(DisasContext *ctx) From patchwork Sun Oct 3 17:57:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535851 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=heyTkqrE; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMsFX2Pmzz9sX3 for ; Mon, 4 Oct 2021 05:05:02 +1100 (AEDT) Received: from localhost ([::1]:51656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5r9-0003dD-K4 for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 14:04:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5ke-00038v-7n for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:16 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:46877) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5kc-0003b5-Ml for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:15 -0400 Received: by mail-wm1-x32c.google.com with SMTP id o4-20020a05600c510400b0030d55d6449fso4377423wms.5 for ; Sun, 03 Oct 2021 10:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yhXr0CImE+7NvBwyuzdOAZs7t1J2dHvRPqJwA4cIlkQ=; b=heyTkqrEddrxX4nRPI+sZdGCq825lzySUhCayps+4/7gOV95EorAgm3BX44r1ZEbgJ b5YSZtnf6eU6ua0Afil7vRJXd9aa2MLAyI1Q4lKOYq9+nMlArMFX+kifBsV7aqMgBshY mMW/5qknzuXquUFCbtrsrefjiD+gyK8Bv/BjYVNWWo6Xd13fpnX6u4HhGFBEMbEhbeF5 2WqMAdPvOFCRbsV3aCcLE4heBwsm1+UwZjVcGlwmxB7Y+a9a6TobE1v+MhZ5j7Vl3Zlb jYqmBUQyIIaZcfi7TZ13OQNDSWTQ2AdQkEudj0kOJTgwJF6gLzMUv7FV7GvbHOdW5Ypm OtOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yhXr0CImE+7NvBwyuzdOAZs7t1J2dHvRPqJwA4cIlkQ=; b=j9joBMBLHrKjr+9S+msk8PkPw+y53FlkQ5dsv1V6C6gvM4ZJaQWa36dt0oB2dvcqDY CSyAbsdjYzz9+esX6nZgbmaFa961n6DwJ99tZjQ4VFKIIKH3qUpiAG1r8LiO64LAUmhP 5YvN0WMD6fyIWUSKcDrqLxVlHHuNkqY20dAb1VTHb1S0i4Fb7sMorglGPLyM5fhphSIJ ntMJmiJzwYiOBziBKuKRQhmUW4+ufKB7/JUGsmh0aQI5twXekh3iV/35GGHeVfuNFRBr rBTtJVUS/XAe6oBvubDVW/9M7CscnOotLcKqlC70WhM4EtKG96FmgJ5nlwbrXnrNN2yU M+4A== X-Gm-Message-State: AOAM531/VhQ3Iv9kiGVDBNl7jUTuE3uzRCINNkA45tWn9/fW0e9MVBV/ XtHPy5vz2iYGdBgVHw5IiKHMTK4oPC4= X-Google-Smtp-Source: ABdhPJxvwuCumsr8NNeeMw8ghCCwqo//WGAtcbT4Ag5BtmhFF217UgEdiv31yWOiYejoN+BwOKLF2w== X-Received: by 2002:a05:600c:3646:: with SMTP id y6mr14745336wmq.61.1633283893117; Sun, 03 Oct 2021 10:58:13 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id p6sm7508691wrj.95.2021.10.03.10.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:12 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa_i5() Date: Sun, 3 Oct 2021 19:57:41 +0200 Message-Id: <20211003175743.3738710-7-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" We already use sextract32(), use extract32() for completeness instead of open-coding it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c index e107cad57ee..3ef912da6b8 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -473,15 +473,12 @@ static void gen_msa_i8(DisasContext *ctx) static void gen_msa_i5(DisasContext *ctx) { #define MASK_MSA_I5(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) - uint8_t df = (ctx->opcode >> 21) & 0x3; int8_t s5 = (int8_t) sextract32(ctx->opcode, 16, 5); - uint8_t u5 = (ctx->opcode >> 16) & 0x1f; - uint8_t ws = (ctx->opcode >> 11) & 0x1f; - uint8_t wd = (ctx->opcode >> 6) & 0x1f; + uint8_t u5 = extract32(ctx->opcode, 16, 5); - TCGv_i32 tdf = tcg_const_i32(df); - TCGv_i32 twd = tcg_const_i32(wd); - TCGv_i32 tws = tcg_const_i32(ws); + TCGv_i32 tdf = tcg_const_i32(extract32(ctx->opcode, 21, 2)); + TCGv_i32 twd = tcg_const_i32(extract32(ctx->opcode, 11, 5)); + TCGv_i32 tws = tcg_const_i32(extract32(ctx->opcode, 6, 5)); TCGv_i32 timm = tcg_temp_new_i32(); tcg_gen_movi_i32(timm, u5); From patchwork Sun Oct 3 17:57:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535852 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=pPcfGcI0; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMsK7707pz9sX3 for ; Mon, 4 Oct 2021 05:08:11 +1100 (AEDT) Received: from localhost ([::1]:57292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5uD-0007b0-Hf for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 14:08:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5kj-0003JC-1r for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:21 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:39519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5kh-0003eG-Fl for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:20 -0400 Received: by mail-wr1-x436.google.com with SMTP id d26so26046473wrb.6 for ; Sun, 03 Oct 2021 10:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6XihHO8hR/2w0fkY9TAy59BcD7FH2rXSgl3e1w0F2cc=; b=pPcfGcI0CMfJK4Nio3gEDH/ajJlkGFl1mKbZRf58tfPzWJZUOvxThTfu8AMnVdUXx+ y9f7yLyVxx9R8Dtb42wk6DE7LVN668hzA4dOoYy4ych+fC8JVgKUvwdouos13maCUeG3 y4jC2/yoyy49API3+DP/J/ryvilLiTWpRW0kqi5S3zOkCmY3iz6IJaPVXcerADBrsDhu S+Fn89pBoqZJ/ezH8yCnE3Or5gVcbNi4cCc2FRkMQZ0PbbaMYHp+XjzXMsGnrrp8sV0d /wPFJzk5PUWCprice0b3Cy8SU8dcZDUs6wPzcSxJTH6Giufpd5NgQaVOFgsnmT7+h58s k2zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=6XihHO8hR/2w0fkY9TAy59BcD7FH2rXSgl3e1w0F2cc=; b=qk5w2+1FrGeE0uXU5NQhAkNslc87/xHxIsEHWdqtx1aXHEYIse79/U2/Q0b1SBxUXI 1jlMPmDmkWWd4mI9fIpfp/TqA7RLcZoMbCJGd+aRGstaLyEB4Z1Yd2YEBHkuS1AiTrga k3AGkFeQdbsaSJ5juButwuuyx9/014CJdoBFAg6acAI1430sryU2KomqROrKNZBS1ka7 pzKqqlW2vP2O4Gh6f3asVbBFY+7Sa6TrouCHUsLXVyz1rGgaNKwuFDlFngi2GVMvk2sB WPS5odXQf0i9c/I/1xPwlNGvj17yTudyPwwg6DIGJcYo/q65WbqdwPTWmZPCnarBbnGP ECaQ== X-Gm-Message-State: AOAM533erAY1CTJyvSYPA1HT6XUqFZrUOPWdIAPjVolAYKBAGneW0D46 Tz0GOrbxpJ+RreBgHivf+UApgTsvioo= X-Google-Smtp-Source: ABdhPJzgeuLoh7FsFtCvwTOsYvs5kfncYBjNQWhfTmPdGHzhXyviQFsXClgDCyALV4XepZm1Jbm8Mg== X-Received: by 2002:adf:a505:: with SMTP id i5mr8134053wrb.38.1633283897737; Sun, 03 Oct 2021 10:58:17 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id d16sm13728474wmb.2.2021.10.03.10.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:17 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 7/8] target/mips: Use tcg_constant_i32() in gen_msa_i5() Date: Sun, 3 Oct 2021 19:57:42 +0200 Message-Id: <20211003175743.3738710-8-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 40 ++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c index 3ef912da6b8..3ede2f643c0 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -473,14 +473,32 @@ static void gen_msa_i8(DisasContext *ctx) static void gen_msa_i5(DisasContext *ctx) { #define MASK_MSA_I5(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) - int8_t s5 = (int8_t) sextract32(ctx->opcode, 16, 5); - uint8_t u5 = extract32(ctx->opcode, 16, 5); - TCGv_i32 tdf = tcg_const_i32(extract32(ctx->opcode, 21, 2)); TCGv_i32 twd = tcg_const_i32(extract32(ctx->opcode, 11, 5)); TCGv_i32 tws = tcg_const_i32(extract32(ctx->opcode, 6, 5)); - TCGv_i32 timm = tcg_temp_new_i32(); - tcg_gen_movi_i32(timm, u5); + TCGv_i32 timm; + + switch (MASK_MSA_I5(ctx->opcode)) { + case OPC_ADDVI_df: + case OPC_MAXI_U_df: + case OPC_MINI_U_df: + case OPC_CLTI_U_df: + case OPC_CLEI_U_df: + timm = tcg_constant_i32(extract32(ctx->opcode, 16, 5)); + break; + case OPC_MAXI_S_df: + case OPC_MINI_S_df: + case OPC_CEQI_df: + case OPC_CLTI_S_df: + case OPC_CLEI_S_df: + timm = tcg_constant_i32(sextract32(ctx->opcode, 16, 5)); + break; + case OPC_LDI_df: + timm = tcg_constant_i32(sextract32(ctx->opcode, 11, 10)); + break; + default: + break; + } switch (MASK_MSA_I5(ctx->opcode)) { case OPC_ADDVI_df: @@ -490,43 +508,34 @@ static void gen_msa_i5(DisasContext *ctx) gen_helper_msa_subvi_df(cpu_env, tdf, twd, tws, timm); break; case OPC_MAXI_S_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_maxi_s_df(cpu_env, tdf, twd, tws, timm); break; case OPC_MAXI_U_df: gen_helper_msa_maxi_u_df(cpu_env, tdf, twd, tws, timm); break; case OPC_MINI_S_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_mini_s_df(cpu_env, tdf, twd, tws, timm); break; case OPC_MINI_U_df: gen_helper_msa_mini_u_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CEQI_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_ceqi_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CLTI_S_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_clti_s_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CLTI_U_df: gen_helper_msa_clti_u_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CLEI_S_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_clei_s_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CLEI_U_df: gen_helper_msa_clei_u_df(cpu_env, tdf, twd, tws, timm); break; case OPC_LDI_df: - { - int32_t s10 = sextract32(ctx->opcode, 11, 10); - tcg_gen_movi_i32(timm, s10); - gen_helper_msa_ldi_df(cpu_env, tdf, twd, timm); - } + gen_helper_msa_ldi_df(cpu_env, tdf, twd, timm); break; default: MIPS_INVAL("MSA instruction"); @@ -537,7 +546,6 @@ static void gen_msa_i5(DisasContext *ctx) tcg_temp_free_i32(tdf); tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(timm); } static void gen_msa_bit(DisasContext *ctx) From patchwork Sun Oct 3 17:57:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535853 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=UU0+JnFd; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMsMl1z4Dz9sX3 for ; Mon, 4 Oct 2021 05:10:25 +1100 (AEDT) Received: from localhost ([::1]:59596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5wM-0000sZ-7T for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 14:10:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5ko-0003Ub-6f for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:27 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:38677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5kl-0003ih-Rm for qemu-devel@nongnu.org; Sun, 03 Oct 2021 13:58:25 -0400 Received: by mail-wm1-x332.google.com with SMTP id g193-20020a1c20ca000000b0030d55f1d984so5814267wmg.3 for ; Sun, 03 Oct 2021 10:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aQLZEwzsOLFau3mXxxxHhtsLM0I/M/Yo3h72hp1JP8M=; b=UU0+JnFdSQjw8kvnUGaCnO6XR5oHf5mwkljQMjLrE3t3J4x0qHeX5LVour76s9qSBe NKTZQK5nkji3xhf/JP8VvgjxUzYac2WkUw2KNNympHy9nmP2oCNB/dmhrMAcXRsAQ4By iM8IZmhVlHmqf/FMMNKw9qRbi3yB22JownyjYax+cg7ZInmfh3NCZZ4msuww3EoRKXbr cf+xIEtnPUhG3YZWR83VGgpMLwV2/jVPV2/pu2KCXdrBWBp9cLxNczdJ3j/TZ3HKw6Ek tDsaouaH/r2Js/eEhENFajSvgoFN0s8HIuGk27z4ZNcRYCN550xT7ZPd0yui++2dfSzq 2cug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=aQLZEwzsOLFau3mXxxxHhtsLM0I/M/Yo3h72hp1JP8M=; b=BoBNfTlSAJFwGlPdqhzc6vEmYYINT6wUDCgyv2t7gxUPNBZwBun5fTTXfGtT3YaXoh q3Li/k/b1edX8h7qviIKjMHJwbQsf3KG0Tir9SPfMxkXFQWj7UlsWNcvQ5Bp2U8epMNW ma5Wmq/2uJ6+YRfsMEXJ+3pYIUEx5+UqG9GPN5jzYGyyKP65na9ZZmcz0O6uNZVS/yav eWoSVwd/SzMswTKuZcXBbGcCnCAJHa8HGmiNBGmCrl95zb6cs7XvSt4ziIirLwu2ZJZe EJurM21LV7SCpa+D5rP32KbxD34PQaE1PMB+dEXJ19cXRAvzhbHJz3dV5KehMPrtxBxS 30sw== X-Gm-Message-State: AOAM531Lt7NwR7GbBpq8jyQa3PgWHrN7ISTHlRB176ZoCoylBRJYA2ln dovm5qN9z4DOM2kjPn2FN0ZbZuDexZ0= X-Google-Smtp-Source: ABdhPJy2WQreFL1akAGlWFOtSFk/0pGIAqXpCZ4FHAbPuXz5luoVea4YZQHCqNUZs8zLlz9g3ES5CQ== X-Received: by 2002:a1c:2c3:: with SMTP id 186mr2477980wmc.183.1633283902349; Sun, 03 Oct 2021 10:58:22 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id k22sm12270084wrd.59.2021.10.03.10.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:21 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 8/8] target/mips: Use tcg_constant_tl() in gen_compute_compact_branch() Date: Sun, 3 Oct 2021 19:57:43 +0200 Message-Id: <20211003175743.3738710-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The offset is constant and read-only: move it to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 148afec9dc0..d4e0fbd35be 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -11866,13 +11866,11 @@ static void gen_compute_compact_branch(DisasContext *ctx, uint32_t opc, } else { /* OPC_JIC, OPC_JIALC */ TCGv tbase = tcg_temp_new(); - TCGv toffset = tcg_temp_new(); + TCGv toffset = tcg_constant_tl(offset); gen_load_gpr(tbase, rt); - tcg_gen_movi_tl(toffset, offset); gen_op_addr_add(ctx, btarget, tbase, toffset); tcg_temp_free(tbase); - tcg_temp_free(toffset); } break; default: