From patchwork Sun Oct 3 14:17:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535820 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=iFwXu2gc; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMmHB5nMcz9sR4 for ; Mon, 4 Oct 2021 01:21:10 +1100 (AEDT) Received: from localhost ([::1]:40812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX2MW-0005j8-Kp for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 10:21:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX2Is-00024Z-DZ; Sun, 03 Oct 2021 10:17:22 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:51744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX2Ir-0004E3-0C; Sun, 03 Oct 2021 10:17:22 -0400 Received: by mail-wm1-x332.google.com with SMTP id p21so1493904wmq.1; Sun, 03 Oct 2021 07:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TJk08MUEmq673dFPHh6OX1+k+QJfzBaOq3ycNKzF384=; b=iFwXu2gcBqwzEW5kDYAsG3hMXMaKzx4mU3snwOd1CdRFjMRQjdJiMxd1qVpFrmN3c4 bcMFFAV5PoyxPMHZxyQgi3cxb5W1QdFbHwLhX85fY0FZsDogCOtcrKRlJfgZ3XmPWRTw NCVaOZfm67X8G3UPpyc5TaHY7Yk39bk0Vt/cjVBoYpXEOfVqOfqGZQB0kB4QX0+3mLNh O0LowWN91rJ0ACTT1yNfj+pU+G73kH/YPxMWDlCfPk8do7mE+ogPyUVTmS7vsHvk8nLG cfQr/v/518+UWqzf1RrdF7+8lqW40mMN+mbi+19H+uds5pl9Sx5vATyM7gLcArtSG4Xq e65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TJk08MUEmq673dFPHh6OX1+k+QJfzBaOq3ycNKzF384=; b=3c95kxur98uPnMXbDcFRkFowjz3G1ocpYlpjkOnjK6i38n2eZYDRhHnmk1nHxmNhk3 uIO/vKcddRwI9+C5sOq9Vn26vtIm9NHT5rzHmbonOWEN7eJ7WHZmTGKJafqgAK3U7Dua dQuluXEKI3yNyqChj5N+eJOlqZC4F9HR5Aem41lsLei5s9/OefWPQ//WYEWzr+xuE8jQ pobm3msMwVhiyWb798iMGYWpHyXhnt8iqjgQIqyL+/eOLPCllFNw18yCEOAQaQgzfnoX 4Ua0sILH1+W5C6VhDz62mhCDR6nKFXUiC7N9dlYBk6zupV7IUvDvs//VfI1RkeqSOJmD T2lA== X-Gm-Message-State: AOAM532sY0Iz3wWTEORMok5a7CzLLxoRD75CzyrHb+mmEIx4CyaPUdW8 oLQOpgKeTU8VsTqSz3pn2QXdoF6NHo8= X-Google-Smtp-Source: ABdhPJxGueB97PN6cddgFEg/CjiE+oyavG+l03YHP2QAW3ndwyI1nL8TLCmLQA4uvczl8/y2U0PyKg== X-Received: by 2002:a1c:58:: with SMTP id 85mr7971222wma.29.1633270639048; Sun, 03 Oct 2021 07:17:19 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id x15sm2516494wrl.74.2021.10.03.07.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 07:17:18 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/2] target/ppc: Use tcg_constant_i32() in gen_setb() Date: Sun, 3 Oct 2021 16:17:10 +0200 Message-Id: <20211003141711.3673181-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003141711.3673181-1-f4bug@amsat.org> References: <20211003141711.3673181-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Greg Kurz , David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Avoid using TCG temporaries for the -1 and 8 constant values. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/ppc/translate.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index b985e9e55bc..193d8e89152 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -5074,19 +5074,15 @@ static void gen_mtspr(DisasContext *ctx) static void gen_setb(DisasContext *ctx) { TCGv_i32 t0 = tcg_temp_new_i32(); - TCGv_i32 t8 = tcg_temp_new_i32(); - TCGv_i32 tm1 = tcg_temp_new_i32(); + TCGv_i32 t8 = tcg_constant_i32(8); + TCGv_i32 tm1 = tcg_constant_i32(-1); int crf = crfS(ctx->opcode); tcg_gen_setcondi_i32(TCG_COND_GEU, t0, cpu_crf[crf], 4); - tcg_gen_movi_i32(t8, 8); - tcg_gen_movi_i32(tm1, -1); tcg_gen_movcond_i32(TCG_COND_GEU, t0, cpu_crf[crf], t8, tm1, t0); tcg_gen_ext_i32_tl(cpu_gpr[rD(ctx->opcode)], t0); tcg_temp_free_i32(t0); - tcg_temp_free_i32(t8); - tcg_temp_free_i32(tm1); } #endif From patchwork Sun Oct 3 14:17:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1535819 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Y33+THpA; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMmD765Ydz9sPB for ; Mon, 4 Oct 2021 01:18:31 +1100 (AEDT) Received: from localhost ([::1]:36058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX2Jx-0002GL-KO for incoming@patchwork.ozlabs.org; Sun, 03 Oct 2021 10:18:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX2J0-0002Cp-Fl; Sun, 03 Oct 2021 10:17:30 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:40621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX2Ix-0004Hv-5S; Sun, 03 Oct 2021 10:17:29 -0400 Received: by mail-wr1-x42d.google.com with SMTP id s21so25232773wra.7; Sun, 03 Oct 2021 07:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qKGw4q6/hJhz4VZmO0Noz/zkq42BzizY+4WFw06qiA=; b=Y33+THpA6JrmfQ5eu+QZQRJY2p/ixm2lu/bd+/54YkcBgFaULbvAhPlircLY+J8N2R Orfzo3tzizt8kiHECHCnnGKH73rd4T14lqRIzls31uptG09lDP4qlnrz0CfVjXNWchfp p3Jxxx2mFaXDboZqe5X3onQWiwkPIFY/2Xbt7QJKlC3hPF6QWr8Dz246cYfdhc5bw7Cx VO7BK4xHNl/uB/1w0i9mBMZ1sAa2fzMRCXDy+Py9TJYNyH4WoFKpqOo63gHN7qAfZiKU VG8T7a7wxmuxfyJbTLoyvtsXn/c0ShaVrYHl/8NKY+hHzcuzbHDPY8LHmIwvyF/tpYP3 0m6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+qKGw4q6/hJhz4VZmO0Noz/zkq42BzizY+4WFw06qiA=; b=yOe1N/EkBJY/XKXPExeKhU1WIpLlzfay29hPid+koOaNJWs75uUKkXY7AHOCuzPJn9 J8McPfnWzlfqZTXb7d3NvfdEOaLWMgfQnhD8XvJNAkobjlGBCsuxqntf586gk+Q8+BpC XTmQxyxl9WyOjCKvnQSdrtmtddHbn0lDaIIYRiMZEAah/iXs8FYUUVFgzEcesI3JIBsB FhGpKty2DU+zLJoCp1T+0r/HWbFANzB1dP6DgxGAOrb+JmO87Tsy0wIeoOvUOY9zB0V5 AvM2GYDKFoD5yKaZVGCQcpcPAhagbvwnxmiDqvDdzhLEcfZClqioLmLSQnnTiF4jdxwJ tOpw== X-Gm-Message-State: AOAM533+pB6y2kADkQr1k9TnDSU1q0NS8VBIfUVa4hbsbUcHUi2vBzNf r+LFvi7imued4elgisQdnqPoujBw4/Y= X-Google-Smtp-Source: ABdhPJyp7ENxVy4qWySDHl52JIz00BrBybLiuT2UcJ+h/F0ID8tryke3WJIf6MzQN55muBrx30zaKQ== X-Received: by 2002:adf:a4ca:: with SMTP id h10mr8921011wrb.28.1633270643809; Sun, 03 Oct 2021 07:17:23 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id l124sm13829201wml.8.2021.10.03.07.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 07:17:23 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/2] target/ppc: Use tcg_constant_i64() in gen_brh() Date: Sun, 3 Oct 2021 16:17:11 +0200 Message-Id: <20211003141711.3673181-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003141711.3673181-1-f4bug@amsat.org> References: <20211003141711.3673181-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Greg Kurz , David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The mask of the Byte-Reverse Halfword opcode is a read-only constant. We can avoid using a TCG temporary by moving the mask to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/ppc/translate.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 193d8e89152..30a60d60973 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7575,18 +7575,16 @@ static void gen_brw(DisasContext *ctx) /* brh */ static void gen_brh(DisasContext *ctx) { - TCGv_i64 t0 = tcg_temp_new_i64(); + TCGv_i64 mask = tcg_constant_i64(0x00ff00ff00ff00ffull); TCGv_i64 t1 = tcg_temp_new_i64(); TCGv_i64 t2 = tcg_temp_new_i64(); - tcg_gen_movi_i64(t0, 0x00ff00ff00ff00ffull); tcg_gen_shri_i64(t1, cpu_gpr[rS(ctx->opcode)], 8); - tcg_gen_and_i64(t2, t1, t0); - tcg_gen_and_i64(t1, cpu_gpr[rS(ctx->opcode)], t0); + tcg_gen_and_i64(t2, t1, mask); + tcg_gen_and_i64(t1, cpu_gpr[rS(ctx->opcode)], mask); tcg_gen_shli_i64(t1, t1, 8); tcg_gen_or_i64(cpu_gpr[rA(ctx->opcode)], t1, t2); - tcg_temp_free_i64(t0); tcg_temp_free_i64(t1); tcg_temp_free_i64(t2); }