From patchwork Wed Sep 22 10:53:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stijn Tintel X-Patchwork-Id: 1531188 X-Patchwork-Delegate: stijn@linux-ipv6.be Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0UMt/ADn; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux-ipv6.be header.i=@linux-ipv6.be header.a=rsa-sha256 header.s=502B7754-045F-11E5-BBC5-64595FD46BE8 header.b=mjfqMsEV; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HDwPJ3bkRz9sW4 for ; Wed, 22 Sep 2021 21:02:43 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7Nsk0CXTXXLkg8OWsvJjLBRjaGc59zHvqiTqk0NilDQ=; b=0UMt/ADn2guo5J LNCD5aFfp6GbyW+EMDsres+B1SddmnImsCZQ/+ueiFicqLsn6Kb5I73t5mOdCpkToT3g5ULt8ylT/ ruCUk2INvR5zUASLCFQwAUGpYONCI0sTAbwkHm/kjGbpz5QCShMq9PTAOZCSA9UeoBtY9zsPHHX7t Zu+b6nOtt9S5W3XclRrbNdmz0c/2NRSUEBjMwvVGtWlx5LhAHb/x2/2X71YfsABW91p9ovyoIdoP8 I+rSZw453hhdl4u+X6UcD1bUM090jRPypKki9oenj8UVtKGEOiBh/kaDh2AYLXuVYaWIV+/NEgreM cU/GqMkUxvdae2X4g7HQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSzxz-008Aqv-VD; Wed, 22 Sep 2021 10:59:09 +0000 Received: from mail.tintel.eu ([51.83.127.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSzsT-0088QC-6h for openwrt-devel@lists.openwrt.org; Wed, 22 Sep 2021 10:53:27 +0000 Received: from localhost (localhost [IPv6:::1]) by mail.tintel.eu (Postfix) with ESMTP id 50C9E4480CAB; Wed, 22 Sep 2021 12:53:16 +0200 (CEST) Received: from mail.tintel.eu ([IPv6:::1]) by localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id m64PAp3oWull; Wed, 22 Sep 2021 12:53:16 +0200 (CEST) Received: from localhost (localhost [IPv6:::1]) by mail.tintel.eu (Postfix) with ESMTP id E56B64480CAD; Wed, 22 Sep 2021 12:53:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.tintel.eu E56B64480CAD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-ipv6.be; s=502B7754-045F-11E5-BBC5-64595FD46BE8; t=1632307995; bh=GrYkxnMD4q7wfUHHpWBGG/KfAK8iE8joEKZYNu7gEaw=; h=From:To:Date:Message-Id:MIME-Version; b=mjfqMsEVwJnjuULZRjoJpdgkqMFjIBdSKd5NkiEGGXCWRaTq8o/6xYHTG4qxa21o8 DQWKfOheWo/lyL8O73aLeTgOBnXzGWZvp8DmM3NI7FWJ28bCrMsEoos0NC1ZrMaTBF FJ+rSP8b37LElVrJ75hQlA4bPjES00HdOdwFEFn0= X-Virus-Scanned: amavisd-new at mail.tintel.eu Received: from mail.tintel.eu ([IPv6:::1]) by localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id YvrIk1y-qe2X; Wed, 22 Sep 2021 12:53:15 +0200 (CEST) Received: from taz.sof.bg.adlevio.net (unknown [IPv6:2001:67c:21bc:20::10]) by mail.tintel.eu (Postfix) with SMTP id AB1B14480CAB; Wed, 22 Sep 2021 12:53:15 +0200 (CEST) Received: (nullmailer pid 1664266 invoked by uid 1000); Wed, 22 Sep 2021 10:53:13 -0000 From: Stijn Tintel To: openwrt-devel@lists.openwrt.org Cc: nbd@nbd.name Subject: [PATCH] strace: disable autoreconf Date: Wed, 22 Sep 2021 13:53:13 +0300 Message-Id: <20210922105313.1664189-1-stijn@linux-ipv6.be> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Rspamd-Pre-Result: action=no action; module=multimap; Matched map: IP_WHITELIST X-Rspamd-Queue-Id: AB1B14480CAB X-Rspamd-Pre-Result: action=no action; module=multimap; Matched map: IP_WHITELIST X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:200533, ipnet:2001:67c:21bc::/48, country:BG]; IP_WHITELIST(0.00)[2001:67c:21bc:20::10] X-Rspamd-Server: skulls X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_035325_593096_F6C0AF8C X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: With autoreconf enabled, building strace fails: Makefile:9303: *** missing separator. Stop. Contents of that line: @CODE_COVERAGE_RULES@ Disabling autoreconf fixes the problem. As the autoreconfig fixup was enabled in the initial commit of strace to the repo, it's hard to figure out why it was enabled. It was most likely required to bu [...] Content analysis details: (0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.1 DKIM_INVALID DKIM or DK signature exists, but is not valid X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org With autoreconf enabled, building strace fails: Makefile:9303: *** missing separator. Stop. Contents of that line: @CODE_COVERAGE_RULES@ Disabling autoreconf fixes the problem. As the autoreconfig fixup was enabled in the initial commit of strace to the repo, it's hard to figure out why it was enabled. It was most likely required to build at that time, but as it now builds fine without it, just remove the fixup. Signed-off-by: Stijn Tintel --- package/devel/strace/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/package/devel/strace/Makefile b/package/devel/strace/Makefile index a95d429311..adc619d34e 100644 --- a/package/devel/strace/Makefile +++ b/package/devel/strace/Makefile @@ -21,7 +21,6 @@ PKG_LICENSE:=LGPL-2.1-or-later PKG_LICENSE_FILES:=COPYING PKG_CPE_ID:=cpe:/a:paul_kranenburg:strace -PKG_FIXUP:=autoreconf PKG_INSTALL:=1 PKG_CONFIG_DEPENDS := \