From patchwork Wed Aug 11 08:56:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1515695 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=PnFlecbs; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gl3b947KHz9sCD; Wed, 11 Aug 2021 18:56:37 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mDk2L-000347-Po; Wed, 11 Aug 2021 08:56:33 +0000 Received: from mail-pj1-f49.google.com ([209.85.216.49]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mDk2D-00033I-4i for kernel-team@lists.ubuntu.com; Wed, 11 Aug 2021 08:56:25 +0000 Received: by mail-pj1-f49.google.com with SMTP id t7-20020a17090a5d87b029017807007f23so8487187pji.5 for ; Wed, 11 Aug 2021 01:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o8IcCpTr+4pQtgBE2Bd8GG34ng0zBIsHvD6nKEFi4Bo=; b=PnFlecbsBkSkQL9he8y+mY9oASgYLaUg3UDKiTmsUtfDHUTitnooUGBl+p2kSve7eF uab88zyQrcP9YjBP7Vm9IGWM64dzMYE893kRq8lDvToZCSpd/Xb0Yr/81j9UM/VIlTq4 Pu8b5lFpejty0hacLbRV8b2kb/b4CEgncmqBrgvtOi6iWG5qpnBG2qPDOj+OVRqshjiJ M3Hgn1NM0SCowfUgUDOEzgg69BgIxafmmK79mxxBbh+qjON0xWJshKtv/sksGVuli74N m22r5DOhRshY5uw5kJblJwZP024x1WZA/TyoX4UF1XOh6DZkxtQhhfu1bEZeKI35h7t1 J15A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=o8IcCpTr+4pQtgBE2Bd8GG34ng0zBIsHvD6nKEFi4Bo=; b=oDxDoUnVvS/Zg9Eg3qJgnyfpzwOkmmOMFv4LrcuP1B2tE4QKFiQ++TFa4aqGDxObP1 sNvqnTbmuoGhz3wHT6/U1++Qhar4B1qGSPjivnQrLDHsrLHnyZ6jVOlZ6IKxperF9olH bkrBAYs+NnBa7iK7T+4Rhy7p/FwEatKNTvUNMEaMlosRACIEX+7alkYUiwgvAoNryP3C Q/I9U4CxKngggtAJZDkdMS6WlM6/1VcwpraZSfEPXCwtrTN5GBzKvM7LYyl6b/dNHLVR qulQzN6JJNfmTo0mEr9P1JBQd5KPsUneLhufAEWApmxZvzRnVQ31i9Cuthm+IryeVdTa 2QrQ== X-Gm-Message-State: AOAM530kjfx+OgcXwnB+OU/1Y/0HUOlieb/ihxT8+oRunbk0MuBiGAX3 QICng+QtQj7NzMHXHk2myAJBEhrzThQ= X-Google-Smtp-Source: ABdhPJzeVwD6GE4dyJBD2wA06xQrHd1PmVvqn+sywd+9OGuQzbI/mxZlTbdKqV3LiwVUnTC7/O5slg== X-Received: by 2002:a63:fb16:: with SMTP id o22mr184328pgh.309.1628672182853; Wed, 11 Aug 2021 01:56:22 -0700 (PDT) Received: from localhost (61-220-137-34.HINET-IP.hinet.net. [61.220.137.34]) by smtp.gmail.com with ESMTPSA id b15sm32179580pgj.60.2021.08.11.01.56.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 01:56:22 -0700 (PDT) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][H][I] UBUNTU: ODM: mfd: Check AAEON BFPI version before adding device Date: Wed, 11 Aug 2021 16:56:17 +0800 Message-Id: <20210811085617.1389423-2-acelan.kao@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210811085617.1389423-1-acelan.kao@canonical.com> References: <20210811085617.1389423-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.49; envelope-from=acelan@gmail.com; helo=mail-pj1-f49.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Kunyang_Fan BugLink: https://bugs.launchpad.net/bugs/1937897 For the below: error log occurring in some devices: gpio gpiochip0: (gpio_aaeon): tried to insert a GPIO chip with zero lines gpiochip_add_data_with_key: GPIOs 0..-1 (gpio_aaeon) failed to register Add the BFPI version checking mechanism to prevent error log bumping. Signed-off-by: Kunyang_Fan Acked-by: Kai-Heng Feng Signed-off-by: Chia-Lin Kao (AceLan) --- drivers/mfd/mfd-aaeon.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/mfd/mfd-aaeon.c b/drivers/mfd/mfd-aaeon.c index 9d2efde53cad..74211d01ce65 100644 --- a/drivers/mfd/mfd-aaeon.c +++ b/drivers/mfd/mfd-aaeon.c @@ -16,12 +16,17 @@ #include #include #include +#include #include #include #include #define AAEON_WMI_MGMT_GUID "97845ED0-4E6D-11DE-8A39-0800200C9A66" +#define WMI_REPORT_CAPABILITY_METHOD 0x00000000 +#define MAX_BFPI_VERSION 255 +#define GET_REVISION_ID 0x00 + struct aaeon_wmi_priv { const struct mfd_cell *cells; size_t ncells; @@ -39,6 +44,21 @@ static const struct aaeon_wmi_priv aaeon_wmi_priv_data = { .ncells = ARRAY_SIZE(aaeon_mfd_cells), }; +static int aaeon_wmi_check_device(void) +{ + int err; + int retval; + + err = asus_wmi_evaluate_method(WMI_REPORT_CAPABILITY_METHOD, GET_REVISION_ID, 0, + &retval); + if (err) + return -ENODEV; + if (retval < 3 || retval > MAX_BFPI_VERSION) + return -ENODEV; + + return 0; +} + static int aaeon_wmi_probe(struct wmi_device *wdev, const void *context) { struct aaeon_wmi_priv *priv; @@ -48,6 +68,8 @@ static int aaeon_wmi_probe(struct wmi_device *wdev, const void *context) return -ENODEV; } + if (aaeon_wmi_check_device()) + return -ENODEV; priv = (struct aaeon_wmi_priv *)context; dev_set_drvdata(&wdev->dev, priv);