From patchwork Wed Jul 21 11:22:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chris Chiu X-Patchwork-Id: 1508138 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=CnZ2Qmkx; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GVCqT0nBTz9sWX; Wed, 21 Jul 2021 21:22:43 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1m6AJE-000224-FG; Wed, 21 Jul 2021 11:22:40 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1m6AJC-00021f-9w for kernel-team@lists.ubuntu.com; Wed, 21 Jul 2021 11:22:38 +0000 Received: from localhost.localdomain (111-240-123-48.dynamic-ip.hinet.net [111.240.123.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 320953F232 for ; Wed, 21 Jul 2021 11:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1626866558; bh=ps648ePHERCNc+w8T8yIY72io1MR04YWalni3DyesoQ=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=CnZ2QmkxT0JGadUBUFUGeWLR9Fhefx3b+MhfxENq9ArbHl6O5UtCpGwpajI1GR32r /tKpuFVLtAHV1/U8Dqn3Dc5NmEUtFrVuj/kF/O0V5yewCssBHxDCnGV4oi3wDRrH+c XR0WB3tYQWIuIdwWxugrF6vlHBqx36l1s56B4LAzBV1B3fJN/R76M/tdkbUKXbBV8D mRBvYZ82T5Qqi5kqbkig/oCzu+nij6kRVyCS4EoUiZIxWNPvhzW0VshuXC9axhvAGc CnxSO060INGIxJbI1VlJcg0eMxGY3rACEyUTk3pLEkEe4UoLra1cYSNwjkM2ruWXiD OohGFkVbuEW/g== From: chris.chiu@canonical.com To: kernel-team@lists.ubuntu.com Subject: [PATCH v3 1/1][SRU][H] drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0 Date: Wed, 21 Jul 2021 19:22:31 +0800 Message-Id: <20210721112231.29720-2-chris.chiu@canonical.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210721112231.29720-1-chris.chiu@canonical.com> References: <20210721112231.29720-1-chris.chiu@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Gwan-gyeong Mun BugLink: https://bugs.launchpad.net/bugs/1926579 TGL PSR2 hardware tracking shows momentary flicker and screen shift if TGL Display stepping is B1 from A0. It has been fixed from TGL Display stepping C0. HSDES: 18015970021 HSDES: 2209313811 BSpec: 55378 v2: Add checking of PSR2 manual tracking (Jose) Cc: José Roberto de Souza Signed-off-by: Gwan-gyeong Mun Reviewed-by: José Roberto de Souza Signed-off-by: José Roberto de Souza Link: https://patchwork.freedesktop.org/patch/msgid/20210422160544.2427123-1-gwan-gyeong.mun@intel.com (backported from commit 8804325861be242a420d68c0175127a5947ac35a) [Chris: use the old macro IS_TGL_DISP_REVID intead of backporting intrusive refactoring patches for new macro IS_TGL_DISPLAY_STEP] Signed-off-by: Chris Chiu --- drivers/gpu/drm/i915/display/intel_psr.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 5089dbd240f4..143485742452 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -803,6 +803,13 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp, } } + /* Wa_2209313811 */ + if (!crtc_state->enable_psr2_sel_fetch && + IS_TGL_DISP_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_B1)) { + drm_dbg_kms(&dev_priv->drm, "PSR2 HW tracking is not supported this Display stepping\n"); + return false; + } + if (!crtc_state->enable_psr2_sel_fetch && (crtc_hdisplay > psr_max_h || crtc_vdisplay > psr_max_v)) { drm_dbg_kms(&dev_priv->drm,