From patchwork Tue Jul 13 11:56:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1504574 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=ggSDhNNq; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GPJyq3v6Jz9sX5 for ; Tue, 13 Jul 2021 21:57:06 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 967633C8763 for ; Tue, 13 Jul 2021 13:57:02 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 236E13C5FD8 for ; Tue, 13 Jul 2021 13:56:59 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 1777D200AEA for ; Tue, 13 Jul 2021 13:56:58 +0200 (CEST) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id EB05140616 for ; Tue, 13 Jul 2021 11:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1626177416; bh=ErTOTWL+twlmvyY6cxq4i4nOojmHI8bmXv7VqBOJqJQ=; h=To:From:Subject:Message-ID:Date:MIME-Version:Content-Type; b=ggSDhNNqfAfcdC0XRM6uVP8b1E7Ax8GZ+DfP0fU5YxGl3drkw5HTTalEQzZGObgGn pvMJmXP+WOdnwz5dhbcF8BG0/7ew9DjyLo0TfTZydSkn0l4ubrMBdo58G8W0yk2izi YVXe7JZXiUXTkdDms+N++OyyMW2Jtw67NdFJnFbJslamh1qABCBJVLxxo8VfH68yws rbKSyoYIowfmqKxiHbQAvL9FkwB+/7sYicHr9ce6b/Ad/dtJzfGUhmDl5/YDfbhkUs 25RIEhLFnyQ/s3WQtgHr+Y4qlnpFOk3nhzO/OzyPhO1s4+BjWHpJ6RL6TygEEmmIix PobYqvhW2u+gA== Received: by mail-wm1-f70.google.com with SMTP id x6-20020a7bc2060000b0290218ad9a8d4aso432240wmi.1 for ; Tue, 13 Jul 2021 04:56:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=ErTOTWL+twlmvyY6cxq4i4nOojmHI8bmXv7VqBOJqJQ=; b=t3k8rV/zd96F3WCQPOr+NlNkHDY/QfvWUbtTo8QtdIeJdfcmSdTtUKgnBYb9L8SHk0 38Rb1wTIivd9+qWmYycDqzmWcjxydCd6E/3hYbyC8DBAmCWcbtTbjSHCIT3ZgN04qQfw 8mecFYkEDcmwUvMI5wRPjMTNRYgxXVu7/fQXcsV5ItLlL8uIGYSrMe9HUNyuHQyG+Few H6vuPKPQSlvjjZJoYnkJgYc9WzZTgc1R4UV6/2z55CuSCr4a5RUBtE+bZ62A+tlM0YOk IlSxQOMFcKyVV/x22EBXwtjIFZ+glF1jsN+L/OvWv8BiyesW+q1aJTGXf2mCXQRVdar8 qMFw== X-Gm-Message-State: AOAM532OYrr+6H3jv2pjtCb33PGQFfjwm0J/MAwE22y+5qkeGPcvD1dr 40jKVaUzjnPAIMJfNkY412S+IhH0ADGiV5/hZytxr8Eok3bjpZSCIt6f4ESSFG4l8EkV12ZH9Am aO1lLhBG1a0Gu5Mv8adKY0+2cBSRe X-Received: by 2002:adf:e2cf:: with SMTP id d15mr5113297wrj.359.1626177416327; Tue, 13 Jul 2021 04:56:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTC98PharxnWaUUgPvm2J8vSoqvQhh5wJR1k9kwYWkExoJp79s7kuEE2toe50trUclghdo8w== X-Received: by 2002:adf:e2cf:: with SMTP id d15mr5113287wrj.359.1626177416213; Tue, 13 Jul 2021 04:56:56 -0700 (PDT) Received: from [192.168.3.211] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id f26sm9041887wmc.29.2021.07.13.04.56.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 04:56:55 -0700 (PDT) To: "ltp@lists.linux.it" From: Krzysztof Kozlowski Message-ID: <9c05b592-e474-6a3e-2dc1-ec075a0bc558@canonical.com> Date: Tue, 13 Jul 2021 13:56:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 Content-Language: en-US X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on in-7.smtp.seeweb.it Subject: [LTP] Failing test on failing shell commands X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Hi all, I have a failing memcg_use_hierarchy_test (in testcases/kernel/controllers/memcg/functional/) which hits unexpected OOM on one of earlier commands, already in the test: 18 echo 1 > memory.use_hierarchy 19 echo $PAGESIZE > memory.limit_in_bytes 20 21 mkdir subgroup mkdir: cannot create directory ‘subgroup’: Cannot allocate memory /home/ubuntu/ltp-install/testcases/bin/memcg_use_hierarchy_test.sh: 22: cd: can't cd to subgroup The command did not fail, as there is no "set -e" and test fails later. However there could be a case where such failure does not trigger later issue and test is a false-positive. What is the practice for LTP shell tests to handle kind of preparation commands? Maybe this should be something like: -------- Best regards, Krzysztof diff --git a/testcases/kernel/controllers/memcg/functional/memcg_use_hierarchy_test.sh b/testcases/kernel/controllers/memcg/functional/memcg_use_hierarchy_test.sh index 8be342499ece..f8dd8946f80b 100755 --- a/testcases/kernel/controllers/memcg/functional/memcg_use_hierarchy_test.sh +++ b/testcases/kernel/controllers/memcg/functional/memcg_use_hierarchy_test.sh @@ -18,8 +18,8 @@ test1() echo 1 > memory.use_hierarchy echo $PAGESIZE > memory.limit_in_bytes - mkdir subgroup - cd subgroup + EXPECT_PASS mkdir subgroup + EXPECT_PASS cd subgroup test_proc_kill $((PAGESIZE * 3)) "--mmap-lock1" $((PAGESIZE * 2)) 0 cd ..