From patchwork Tue Jul 6 23:08:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 1501479 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=i/niOoV2; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GKJDN08clz9t0k for ; Wed, 7 Jul 2021 09:09:54 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 80EE9393BC16 for ; Tue, 6 Jul 2021 23:09:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80EE9393BC16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1625612991; bh=bpkH2X4PKPBvHvSz8YGT7ixPtW9HLJYodNG7Y2Fj+8o=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=i/niOoV2m0mG+0S6Fg7jxjZEJsRy58Pz00l1vgym/L147mWtOI8cJpjzryhis2JgB HadzuM/z8MWT1tCbX54eHg5pE/+RIw4s+WMyEQH4xlDTjWIT30vyJZ6TBi6I5ujAae agz2MDv3Fgx8bYizMTaBICJLAlZM4928tqKlFfVA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 86C77385741C for ; Tue, 6 Jul 2021 23:09:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 86C77385741C Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 166N69Y1026036 for ; Tue, 6 Jul 2021 23:09:05 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 39m3mhauvn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 06 Jul 2021 23:09:05 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 166N66Do051600 for ; Tue, 6 Jul 2021 23:09:04 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by userp3030.oracle.com with ESMTP id 39jd127n03-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 06 Jul 2021 23:09:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ePyf59Y+koIKcXI+ACoeU40mADjWca6+mI7AIcqaEJejC51g6mMDYo2rl72BcpPIn2tUPoeGESN1orF7/RUD7m+rqxix/ail5eGwat7Gs+SPlOkBioEnbUvP+7FrX88jrinu9xYSZihXZWP7VaVeDDRiWZ96V3mKG7dE/ZcpDY4zzclhwV6ntZhIDC5xSVxbJRiBKmd5+wKH0IdASxotP5jZjISp4oKZTVCHy5Tug2XsPU8BwOJO8sW9Ml9P2gbjMNlzvuATasIE7WiguDc963db4ZfbqpmrBwlZ3rnofe3TRqwDgIkmwvZT2sym8+kUcuKtBnQfc1n14gJD30PBEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bpkH2X4PKPBvHvSz8YGT7ixPtW9HLJYodNG7Y2Fj+8o=; b=dOsozUHFwRz7EUvSIvdP/27H+d27GMxEUiRRka2OB2mK56nW/zzYHYr5E5fUqFxYsMXZ43thuUUHKj0nPdODskC6LqTjWc9GaYTLo3bqRK5KNv0Rf3R+mLcaDkxxjvQNfXtoX0Dju3pK4V9cyHUUZuqEi/Io8X5/7VVrhsRt8XGEh8AX3VwlSfu5ZvobVLJ0+kBGhV0W4UYCBcNnXsC7kY4O1CO2Ts50dMJs5RHmRbu5OumNiFXrjqVmiuhf49zj4GTmpnVkrVePyHAGoelW4+ORc+uDnk/NJ9bb5ZTtXSN3MSz4EI/38/WVJS7a103mzKHimt4pRrMXIFSfBGk68g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by MWHPR10MB1566.namprd10.prod.outlook.com (2603:10b6:300:27::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Tue, 6 Jul 2021 23:09:02 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::1076:c9ce:4957:e3f3]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::1076:c9ce:4957:e3f3%5]) with mapi id 15.20.4195.029; Tue, 6 Jul 2021 23:09:02 +0000 To: gcc-patches@gcc.gnu.org Subject: [COMMITTED] CTF testsuite: Remove explicit check on ctv_typeidx Date: Tue, 6 Jul 2021 16:08:57 -0700 Message-Id: <1625612937-29043-1-git-send-email-indu.bhagat@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-ClientProxiedBy: MW4PR03CA0130.namprd03.prod.outlook.com (2603:10b6:303:8c::15) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ibhagatpc.hitronhub.home (24.80.24.133) by MW4PR03CA0130.namprd03.prod.outlook.com (2603:10b6:303:8c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Tue, 6 Jul 2021 23:09:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12a88257-ad7d-4d55-49f4-08d940d30ae4 X-MS-TrafficTypeDiagnostic: MWHPR10MB1566: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UKjiqAFiP1dwZkvbt4mT5fN9SFaBKGOWGkAa5Ltq+o5qHyQeN8jPSSqaaO0ZNa6GTTQQcTJTPqszC+ebaelO7QkMFO5EY9V7bsnTYPdgSOX7ciQKzNBGNj+fW8xg4qiDVnVl9x3Dso3fy6XIAi4Jv+MhyAEUGGAW3+9oosTTkGdUk+Bj4HBxSc2QC+5m/O6ENk9E4u7TGkaREGD93YTvrVtfKZPkKPNDqYxa71XhyctRxRVIqKbGMmkABzEoXr6kn9Q++bL6KLPaLJoEhJHOml3QfPsPox9fd7SbyHE/e+cQhaZpG/XSTcR+DlU3ULSeT7FUXTORr6GpEKR5qYR0LwQfIFqHFg+jUFF2kzGUnNZJr0BzPoDg8CHSRedu5HhWSDPGUXtFPPxYv2JtQMy6ljmZxRuUsVR32PdupHmazZwyAxEpgZm+TKZr4zWGIOa/cU9414le8ShC0Jhe3prciBvj8rXhwMhvbC+/XNLCbJKCaKxX2FhgDWil/K9d41MuSKH1GUOpsRTbkVg4azSjcCWD5eVwHdI2NvGA4ydQU2GOadi7Y1wV2/vAOLgWdVo+WfdACismaFXXLc9oM4h9tqnLTWwhqGFRtcYpvbRbBtozQQyAYaNXuDS5NLb17NDC+fazB8jSE/Z3khp9zj80pGcdNa/UrxVBNpBuJI0tWZ78N8qvW7P3OaZNCjmtRv0y5kgPXe8PAcETU6qRGillgnpXrJMV6Q0vXTPTTaWd5qbjDsiLvP5kfsx9MKraF+t/PMRksDGi4RwrtaTgVT2/EgK/20MDvmfxwfxM6wy/6rI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(346002)(396003)(376002)(136003)(366004)(8676002)(186003)(5660300002)(6506007)(6666004)(2906002)(86362001)(6916009)(36756003)(52116002)(316002)(66476007)(66556008)(2616005)(38350700002)(83380400001)(66946007)(6486002)(6512007)(38100700002)(8936002)(26005)(478600001)(956004)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EP77PpdyDkPdIyjfni4gaII8J7+jrx5kQDehcqEk2rrm96FxP9SsXXQrT0ALyugSCUmnwci2mSfp2nyy6Py7FFgkdEpzaLDkmvrV5Fc38CHYqMAjPR3vE8VjBjATosTZNnc5e9vfpCwgPwrJhdekTMZ0Q5ZmP0BNYwWI/OQqeARZEUnqXvO9XOTgIpKGS4QHUV9IOeCAqzp1FHgkWb/aXb06zeIookqEHG9JAs1jSRW5P2IEJUo8nBpurhNXaeslpBOwm1j0AtenJV2kGBVO4x3pGHtIKtx7b58Xdaz+fjH2Wdq28sS+Ze8zNFPjdK5uLotkZSCQ+LT2Gx11laAULslMnEOLOMmmsPy/24/i3+MaOhOCl3R69oIO2qS7PV4+p18fvr+rotMappiqAADut2re6E49fXhNU3yWiMDrhrQfpy6MNHAG77h2ieHIw5XXSh2pTc5ElTNyYnpS1CmsiizNj+mUAWwtjTxpsR77SVFeVQRN8zAUgS6SPMUreUa6l+kSuvPyi3I7hS75WFAPOZ96mZchOMuZwdAFWI8MjiGGD745719mCyd+jsbqH56L3LOzFw4G+dSUsNO4y84vP6aiw8RIy+RNdsIGlbkHWGitO7xTYShlwlY9uIs3TGGsxdKSH7TOKfDnqtVd2v4pON8ZpSaUnujRIP8jMmMyn/gt8hP2fUJajQqOO8ynSL4wAZJiKMlsHwYFi6Yz82vUnV+V44+xmMtH4tt03fydFGNwOuIreIXEpIKmWjTz0wFKmds7KlYs6EYDN71iP5QMTNl5Rfxt+0ud2IthoEmOUWoetiqhi/Q703PIi8cDyQ6IR5CSTZso9lB0e9D9kaBkrvcY8JafNN1X+IfmJk9T/r5+yZuaOmfucivZezIUTTO3/msxzbrxHKegMRL9VPbfKg/26NO5MK5xwYOxTjS8KzAUCMuMSfrU6TwlP+OFGq2Gpu0KIf36IUYQkCX56f0P/FRxq47VWVQYNFKQkM0GTgfut5v0dE9mMapqgfyollJEC6L2LJQ13es1RiNH1TfIFHsduUQWJcpbnvvISlKbdvXfv3SssjDIfjVXCgm6EyTUjQr6qGOD5QAL8usQjNtzDrcUlqFJXgIlXCzCmIryd2BkJLGBioey+GCQcFBgNEjeMRDmhoooKXG+Lj2bXDfz2TPZx2JpCbX4wSHuzk1iZ44gmyQNcRZV3tcqFQ3+72jyNBuHz70kaFHgz3U3t5QEPeKgTDgIteZghVpBhiZBCGdVZumOPqm54w1UQ7YJQejBGWofglFCrnE6bw0wvh3KXFT1SbNFwBXqFpBXWabYN5sAPCNXtiaXrsbaty8oYz8Q X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12a88257-ad7d-4d55-49f4-08d940d30ae4 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2021 23:09:01.6605 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HWzCFeYGdNAbk1tfB0yrqvUX4lzaW4Td06PlynAeqDXaFF3D4jqb+3y/tSCKXZQTRXWSTTf2V4UBzwr3YW/HYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1566 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10037 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107060109 X-Proofpoint-GUID: _QS1WypZcfyhpYQtyaFJfv4l88pgHKc0 X-Proofpoint-ORIG-GUID: _QS1WypZcfyhpYQtyaFJfv4l88pgHKc0 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Gcc-patches From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" [Committed as obvious.] The value of ctv_typeidx is the CTF type ID of the data type of the associated variable. The order in which the CTF types are added can change across platforms and also as the code evolves, hence changing the CTF type ID. As there is no direct and portable method of testing that the data type of a CTF variable is of a specific kind, remove the check on ctv_typeidx. This also fixes a subset of failures as seen on Darwin. 2021-07-06 Indu Bhagat gcc/testsuite/ChangeLog: PR debug/101283 * gcc.dg/debug/ctf/ctf-attr-mode-1.c: Remove the check for ctv_typeidx. --- gcc/testsuite/gcc.dg/debug/ctf/ctf-attr-mode-1.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.dg/debug/ctf/ctf-attr-mode-1.c b/gcc/testsuite/gcc.dg/debug/ctf/ctf-attr-mode-1.c index fc3af03..c4801a7 100644 --- a/gcc/testsuite/gcc.dg/debug/ctf/ctf-attr-mode-1.c +++ b/gcc/testsuite/gcc.dg/debug/ctf/ctf-attr-mode-1.c @@ -1,7 +1,10 @@ /* Test CTF generation works well with ((mode)) attribute. In this testcase, CTF should report type of bqi to be an enum and - not an int. */ + not an int. Also, CTF for typedef of enum should exist. However, there + are no direct and portable methods of checking that a CTF type / CTF + variable refers to a specific CTF type, so this testcase merely asserts + for existence of individual CTF records. */ /* { dg-do compile ) */ /* { dg-options "-O0 -gctf -dA" } */ @@ -16,7 +19,5 @@ /* { dg-final { scan-assembler-times "\[\t \]0x22000003\[\t \]+\[^\n\]*ctt_info" 1 } } */ /* { dg-final { scan-assembler-times "\[\t \]0x2a000000\[\t \]+\[^\n\]*ctt_info" 1 } } */ -/* { dg-final { scan-assembler-times "\[\t \]0x3\[\t \]+\[^\n\]*ctv_typeidx" 1} } */ - typedef enum { B1 = 1, B2 = 2, B3 = 3 } B; B __attribute__ ((mode (QI))) bqi;