From patchwork Mon Jun 21 13:51:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Donahoe X-Patchwork-Id: 1495133 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::138; helo=mail-lf1-x138.google.com; envelope-from=swupdate+bncbaabb6vsykdamgqe7h7qbja@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=iAopD5iP; dkim-atps=neutral Received: from mail-lf1-x138.google.com (mail-lf1-x138.google.com [IPv6:2a00:1450:4864:20::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G7rYZ0gyVz9sXL for ; Mon, 21 Jun 2021 23:52:00 +1000 (AEST) Received: by mail-lf1-x138.google.com with SMTP id z1-20020a195e410000b0290229c07c3305sf6358340lfi.11 for ; Mon, 21 Jun 2021 06:52:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1624283515; cv=pass; d=google.com; s=arc-20160816; b=ZN/M+Njm8g2ljTI2RQIe1JhgwFnBnORYT4WlE6nMloaEEz9ugapWC6IVedB94/BDnz 86p8tH3TSx31/y6uc0MK/JJ1ptQ6/EGJqNhFiW5AOOVxqS1qUB4QALFdq3F/Xilv5XGD s6OkFim/Xy11y57QrfFo+RLlvl+6AqxQE+JvVKLuQr5/A4RVImNHZd/36Wxb3o/+BysN tqReWkRgnAwiJGrPzol8wYP9tVJhV0TMmbP46BB9jasftpNpoiU3ukdwxjruRcJHPQfe Vri6ulShqkMWcqv0ku8OpT6dDKj2kmwTvV2ErYaTBTp+CXk32vDNa97k+DdqaVHZXthu Xi0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:to:from:sender:dkim-signature; bh=5BWcCG0iS6y4rtO4PVWtz6D9UTKyRjCufIbnuuwu7dU=; b=pqwIK2AZmP5E/MKPbv7YIHc12XBZJbCKfFbE9zX4uX6XGABdKb8hxpYevJrKVKT+5z Ev++ouYdkxfzIG1GZW1TOWBln144yhBwELsv8wxuSOmxfyjMcSPfsoza5IIOhaMWLuX/ V+wALhHo7zQmOajbbAcL8DjQPVY+G156DXdkZhkuUmQflDdcXFOS7ycNlCDvLLYGN/xd lVsbEkR6wDDtcCywjjeawUdB7qC0VYnXYZ5taK6tQcDRHFKSPX5uQlDAvStEklL32APg dYhjiv/NXeUmVLYgleqIqBnVMGduu/z5k7xu0HAxZSalz4XZOCBSZQj3B0tLAd+YigLa Ahhg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=policy (weak key) header.i=@baseforsale.com header.s=default header.b=piT+wY9i; spf=neutral (google.com: 192.185.51.228 is neither permitted nor denied by domain of mike@baseforsale.com) smtp.mailfrom=mike@baseforsale.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=5BWcCG0iS6y4rtO4PVWtz6D9UTKyRjCufIbnuuwu7dU=; b=iAopD5iPNUfBcv0EnZdksbpUlzLOpT0ooM4jeP/KvslkutBm/cwEOQfaeXobu89dzg J6R4XE5Avzqd3utenf6VMgbJUUE3dJ7NCZkv0EgEZma+mdYwathNYUh6yfWO7JREIJbh wnA7zxlT9yyJNOBbcO7OvedYN43N99ZSQeWfcgXOTz004G2HVlpGYKJqhCTVm/J/TMTH wy1fDNfaTsCz33+pRNV+dHjE6/hP+PQingvcgMNaiScMlBbjdLHQhSvbCrGsUoyVMBZA WsIHYiCw61eNR94siFCZAfy+3wSPvOYPd+A9VzULzEaeMrRjR6aDaNj9zIA9qQwKJs0W 0kVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=5BWcCG0iS6y4rtO4PVWtz6D9UTKyRjCufIbnuuwu7dU=; b=WinpX+fZwjvRS8nYkAuHjNFyiz5o6tMbNWyQet/DrzekKJsTb7l3qIR6SJr2HIjes+ 4WpzF0QKlUFmQMzhA7SoK9oJt3+zrMaizq1PyIQuSq5PaR6G3ri1N1MWtirSt31vBNVZ 1HFxelOYnRl46VUkdKSGSw8hOIg//KQ2fLm+0RQLUSVJWYFvcF5AHr6QeJQxThL8ABMQ CR6OiOarkOs6VsEAjlTPz7MTTFDwOqZjgYv3MezQUKKW7qPW72fvnRd31Bakvx6VE4Kg kL+TqqzhTZdEPZveJ2Wvjw70JhHL/JwJO/XHqWS7ZTjw3HjqtpgUV58A8dFU6J+Wp07r XdNg== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM530RA5VwyMC7dnKoAXxEeGT08Cmea/OIpi88a+4E0X7jcj/rhRzo 7fi3JKAAmKRl1GqxR6Q3MPo= X-Google-Smtp-Source: ABdhPJxV/00WpF3MFX19MRsjc8ILNTmvx8N3U4HmZWHIPxyHpZ+rrhRpQIMcHm8ybQhpKJ5AX30Ncw== X-Received: by 2002:a05:6512:2148:: with SMTP id s8mr14687233lfr.117.1624283514951; Mon, 21 Jun 2021 06:51:54 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a2e:bc1c:: with SMTP id b28ls329119ljf.4.gmail; Mon, 21 Jun 2021 06:51:54 -0700 (PDT) X-Received: by 2002:a2e:3508:: with SMTP id z8mr21585308ljz.385.1624283514196; Mon, 21 Jun 2021 06:51:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624283514; cv=none; d=google.com; s=arc-20160816; b=q5LAL+bBA+nYpoef8GcKT27UqOr+q4XFTqroxg6GGfV/IkNiZQ7rlIY/QNCQ9uFde0 7SYzXGGfCahysnwki8MFvDBX3ZKmUPw/SwroeEppnvi8S4GTNL+jA9dSb30T8ptP0rOq fmMDXzRw6khJD6VOsl+fPjylX/pkf10bBa8Y9NEaXm7LkEMhjcg6edDK2WKX9D2g3azx YMogqrI05p2HP5cXJ/kx8EOT3bmDLuTIWrsvvsgdtj0HY8KoBRe1GgPdJMEk1Km5sKXw 9NdGgHZ4/MXDuRwS7Fpe5QpcEq6/Cfzd472rzK7CO/Stp2Zz020BUSvfY3MyjpV9M/wJ rOxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:dkim-signature; bh=rrkN1Lk5KVVfWM9drFgaykMHoOv69TzOYbyS7QXWr6Y=; b=q2y9FtDO4Fh7ptoyrX1AiKwVzf77GIeZX3rvv0phdQifW/rwbIMNYCECPHv2IW6Qsp pi+El/+3ALGAkIY5Y4W0MwEXSxlm/7wBg+MuT4bO3d8KAL/0TkeOUfWl3D1gEVZU6zna 6wHYZMb+Rrvev0CS5KCJeNHsMK0jBGq6Fuq6exJ8Fk+q7ZSSSyRUQN2t7UFU8hVfj9ls e3YY+l+XeQaoZgWRpgpXtmZ0Ldy7mzcMUE+vUy3VP6LVBmlpFrJY8HR5h3wEo9QRK1wY hXi+6hITfDfDoScq09gTSn6JFRHs1x2tBzc7oavIRGfL180WtesQlXQCKH9ak6ONsSBK IZHg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=policy (weak key) header.i=@baseforsale.com header.s=default header.b=piT+wY9i; spf=neutral (google.com: 192.185.51.228 is neither permitted nor denied by domain of mike@baseforsale.com) smtp.mailfrom=mike@baseforsale.com Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com. [192.185.51.228]) by gmr-mx.google.com with ESMTPS id f17si879623lfl.4.2021.06.21.06.51.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jun 2021 06:51:54 -0700 (PDT) Received-SPF: neutral (google.com: 192.185.51.228 is neither permitted nor denied by domain of mike@baseforsale.com) client-ip=192.185.51.228; Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id B73372264 for ; Mon, 21 Jun 2021 08:51:50 -0500 (CDT) Received: from host2027.hostmonster.com ([67.20.76.187]) by cmsmtp with SMTP id vKL8lFYneAzLJvKL8luY24; Mon, 21 Jun 2021 08:51:50 -0500 X-Authority-Reason: nr=8 Received: from [75.36.177.129] (port=36596 helo=mike-ThinkPad-P15-Gen-1.digitalcpt.local) by host2027.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lvKL8-000gYb-3r for swupdate@googlegroups.com; Mon, 21 Jun 2021 07:51:50 -0600 From: Michael Donahoe To: swupdate@googlegroups.com Subject: [swupdate] [PATCH v2] correct missing goto in swuforward_handler causing curl failure to be overwritten as successful Date: Mon, 21 Jun 2021 08:51:48 -0500 Message-Id: <20210621135148.12333-1-mike@baseforsale.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2027.hostmonster.com X-AntiAbuse: Original Domain - googlegroups.com X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - baseforsale.com X-BWhitelist: no X-Source-IP: 75.36.177.129 X-Source-L: No X-Exim-ID: 1lvKL8-000gYb-3r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (mike-ThinkPad-P15-Gen-1.digitalcpt.local) [75.36.177.129]:36596 X-Source-Auth: mike@baseforsale.com X-Email-Count: 3 X-Source-Cap: ZWllbHNvbmY7ZWllbHNvbmY7aG9zdDIwMjcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-Original-Sender: mike@baseforsale.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=policy (weak key) header.i=@baseforsale.com header.s=default header.b=piT+wY9i; spf=neutral (google.com: 192.185.51.228 is neither permitted nor denied by domain of mike@baseforsale.com) smtp.mailfrom=mike@baseforsale.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Signed-off-by: Michael Donahoe Acked-by: Stefano Babic --- handlers/swuforward_handler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/handlers/swuforward_handler.c b/handlers/swuforward_handler.c index c9df541..3135afc 100644 --- a/handlers/swuforward_handler.c +++ b/handlers/swuforward_handler.c @@ -211,6 +211,7 @@ static void *curl_transfer_thread(void *p) ERROR("SWU transfer to %s failed (%d) : '%s'", conn->url, curlrc, curl_easy_strerror(curlrc)); conn->exitval = FAILURE; + goto curl_thread_exit; } conn->exitval = SUCCESS;