From patchwork Mon Jun 14 12:34:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 1491653 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G3WBh0qc3z9sRN for ; Mon, 14 Jun 2021 22:35:38 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A4A6384001B for ; Mon, 14 Jun 2021 12:35:35 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 303813857027; Mon, 14 Jun 2021 12:35:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 303813857027 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: ofok3ClwDpdXFP4mB31rx7z4PTonx8JjbsUPi5jNi07du+0hBPEcrkk5b05aO3ql22sNLdu2xM 1vYZEqtAXOp01zwQpLdVgHBHopVIl3h0JN6zo5X3gHzmyrdTekwxsCYhNM/dPmes2KLdmH225e tpKEgT8PZ824kmEX4slq3eW6kpeu/l8jSUBxl9dQOvHOWlHKtV8y0NiTLEVFtErgpMAiRP6ONG Xtf/SMQ4nSoKZmWCJNwbXXIzaCkZT6CESb0OtGgYYLhgLmVdltLnj+aBlMcHnjFJ76LnKpq3iz Lwc= X-IronPort-AV: E=Sophos;i="5.83,273,1616486400"; d="diff'?scan'208";a="64782061" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 14 Jun 2021 04:34:59 -0800 IronPort-SDR: IkytUQlTplbn1rsWP/exBNi81dh7DAgnXAAIO3Qle34NYYRgkkc+i97toG7VpECorsZaprl826 GyRsoWgHPnOBk98IJfeOCu2em3Eau51ouYUMKLU/D8mWgr1/A76Bd/+QmJhEy9JjQ9u7kMvrN8 X1iv+xxLI2xViDhJAuyS+HCsMcWIr8/Ymcpd/1BqFOtRnUOSSoAW8SSg56XtGEpg3x/n13kOhv OuyUI/2ojmvJ+Hp0pJ+pkq6GQHxJpkHGxt3eJBwvjgKewIgtda78s8zXbwguHOAMpFC6A4dEh0 Dtc= To: gcc-patches , fortran , Jakub Jelinek From: Tobias Burnus Subject: [Patch] C/C++: Fix unused set var warning with omp_clause_affinity [PR100913] Message-ID: Date: Mon, 14 Jun 2021 14:34:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Rather obvious fix for a warning found by David via cppcheck. OK? Tobias ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf C/C++: Fix unused set var warning with omp_clause_affinity [PR100913] PR c/100913 gcc/c/ChangeLog: * c-parser.c (c_parser_omp_clause_affinity): No need to set iterator var in the error case. gcc/cp/ChangeLog: * parser.c (cp_parser_omp_clause_affinity): No need to set iterator var in the error case. diff --git a/gcc/c/c-parser.c b/gcc/c/c-parser.c index add33532a60..b90710cba2f 100644 --- a/gcc/c/c-parser.c +++ b/gcc/c/c-parser.c @@ -15590,21 +15590,19 @@ c_parser_omp_clause_affinity (c_parser *parser, tree list) return list; } } } nl = c_parser_omp_variable_list (parser, clause_loc, OMP_CLAUSE_AFFINITY, list); if (iterators) { tree block = pop_scope (); - if (iterators == error_mark_node) - iterators = NULL_TREE; - else + if (iterators != error_mark_node) { TREE_VEC_ELT (iterators, 5) = block; for (tree c = nl; c != list; c = OMP_CLAUSE_CHAIN (c)) OMP_CLAUSE_DECL (c) = build_tree_list (iterators, OMP_CLAUSE_DECL (c)); } } parens.skip_until_found_close (parser); diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index b5af3877e48..d57ddc4560d 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -37922,21 +37922,19 @@ cp_parser_omp_clause_affinity (cp_parser *parser, tree list) return list; } } } nlist = cp_parser_omp_var_list_no_open (parser, OMP_CLAUSE_AFFINITY, list, NULL); if (iterators) { tree block = poplevel (1, 1, 0); - if (iterators == error_mark_node) - iterators = NULL_TREE; - else + if (iterators != error_mark_node) { TREE_VEC_ELT (iterators, 5) = block; for (c = nlist; c != list; c = OMP_CLAUSE_CHAIN (c)) OMP_CLAUSE_DECL (c) = build_tree_list (iterators, OMP_CLAUSE_DECL (c)); } } return nlist; }